From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E2D8E435BA for ; Wed, 17 Aug 2022 22:05:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CBEB468B8AD; Thu, 18 Aug 2022 01:05:54 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2055.outbound.protection.outlook.com [40.92.91.55]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3A52D68B320 for ; Thu, 18 Aug 2022 01:05:48 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LQTA/z0o0Glb5WjPmGnkLwrKn5lshPgVGZCCEH0qHUP3m6FGdLEeyDPdOZJPSQ6Uv3Hd6QvYsfn6urjYQIY/fBflW1rFk8dDYoGlaufzOWFCkGMh0PaLbrMm9Vk8ESRMvhZ5TxBF5F1tpGGY7iVY9qdfgoZcuKeFOQ4gHXO0bFf18a5MnIMFveYPAEXvuMJC2Qo6iPHISnV6viZUpjxaDS9ssIixgwk+ZjwseMxis2XEDnhQpi2jo81fLZwYv10neQCJP1YeanpY1AgaMegeIundxpCNzAAAh+sIwqKjUkGMbBV/uj5O/25YbPYaNyE5IsirdXK2dOi5cLPU16a08g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xI59/BIHPG4N3BXkTBlUSyeP5QPXVFl5lg8G12W6bEA=; b=mevryN3YMCOMZqtEhMt3nivFd8vIDzeroALu9wGVgOzFAZ5INEYoV1HdUWyMp/bmGDaMCEAC3UjFmCNnxW2JEoY1otDt1q2uiqOKNO/0rQQF6wArJo1RhdqAGLqnD3hd4hGvwkIL5ONyxptllwFt2iwthGaJMYnKiUJr6Z0RVbAbDBrQ8PgyefyJ3JGUN5lYJtrfnCLOgGPjDa5EoyvUJKIyJdr5HYVPAP/Zu+sq3BeIiZiQWoqAviN8W+LCPa5xDW5u3vNL793wNdJbC8BIL9AaD6kQfM+AwoXuNgiopgwCxJNRxxduuzmnt8lytMZtkj6wb2h21s+ng3KcigJdYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xI59/BIHPG4N3BXkTBlUSyeP5QPXVFl5lg8G12W6bEA=; b=mxvRfTPp3HtuluIPwmkre2AKe6bvEZwVLxuxwjRKgHQ30RLGuKNq0GViBd/z3eZP7IW1FWml9zU4RZS3PhNIL0t5bJaBjdN6wT1soVQRU/zn3Gerv5tm5H09gzwkZ5Y+Q+FwfQAPD7LK7oxjn8hKHz2RiWtwXAvsOBlQHnGuqACyN1WQf5QpyDEn3g6G5fvPtUd5s5vdUdn8sg+aL5B7cmX5qHCtvUJsSildGCaoVy/wKL11TkcnxLKoXADRYJkWbq1Xb+VF3ZFA1ABsvJ5uvbEdIGvMqOoMpL8KFp1yLcS8LEGB2xvWbDRdGveV7Od0Qem0qSf3hPtzJb2ME7oaDQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DU2PR01MB8733.eurprd01.prod.exchangelabs.com (2603:10a6:10:2f9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Wed, 17 Aug 2022 22:05:46 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5504.028; Wed, 17 Aug 2022 22:05:46 +0000 Message-ID: Date: Thu, 18 Aug 2022 00:05:44 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220815222150.GW2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220815222150.GW2088045@pb2> X-TMN: [ZbJp0BnVdG++P3rq1SoZ7QTnQSnGK7X3] X-ClientProxiedBy: ZRAP278CA0001.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::11) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <292e2faa-d2d8-e973-d7dd-40f9409ee6ec@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dddf56d-8cb1-4e0a-2f86-08da809ca2e6 X-MS-TrafficTypeDiagnostic: DU2PR01MB8733:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NPbjYQ6uqHlFbOJrds7MNBx4eRpKiU7x1iINEVeF5H3rLJN4391UhyK1+ugpk9HVV9RpvfYcD/XIuhJtE0Y3xeeVjncUPmjM0BXWCKnJwjt6HWjwbRxgK1rYt8qKwOIHXhue8X1vPZxKAkCwqJHnxswKerg/jH9DVS/ANAQpWZLmajyYmgLd5G8HrkOhl02lInp8hRDj9FGmWjpaiJ4Trb3V6B8Cn+vJwTDgpVYYrkrOtZEUn0u02+nXzC7t5+V6Qe9Q7d5kUBmVwY3x4H761fshI9iL4nRXkUHNp/2nbVs1yFnI04IQ8b7eivGxJe3LlTcX7Bc+LOMD65V6S7OxTXXcblD535R/jY3cBznNxHs2LoYXRP87PFMsJk1Inhwg9L/BEN70mygd44seKvMoeJoXLmWn6V3EWf7W1sI3OwJHzcKkq9rMZbeceiu3Dvf2r24A730xMF7J4prO8YmvYQOWed8xMxknD/OuhZJhKXi9EPkrNv6uwGO7fOEPiXPF8e9Q11qNBL+N40EnbRLdUcW9gox1cXFO4Huz9WdhS9Z9pWdMKZlSqjw2Ly4P0Y00wMLlCL0rPI8IOwSPKEDE98F3RKWqZffg0j2ZHz6bAGliv2RVmRJautDiCFBjwcJN59mjCjg8ylAgSG+WMUwmCK2DNHFJGrAaCiMgp2nz59r9v9VMh4sn6KmT5xa95Qxx X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjNZUWNYaFdNREVOeFZkMWhYK3NmTDMrVDU2S3Y3WFJqcjhmVCtXalV5czJq?= =?utf-8?B?bE1NbTFZT1Q4NmppWHFtQ0E0L2dCc2NxVFNJR21KRXJrUC8vZ0FkVS9pcEtK?= =?utf-8?B?OW1XMnRkUEc0dHBmR2E5SEp3SHhkeXNxMFZabG5qMEc4bm1oQlUzQU1kYkx5?= =?utf-8?B?UENSNE1Welc5bnl2NytCdFVFWWZBTjdvWlBoT0NJdjBwMXQ1UjhjOE1FQVJk?= =?utf-8?B?aG9lZlJDUFNIREFsZ3dvTllheXZPQzBEUmpkSnhtNzRyS0hIam5GWGtGZGg3?= =?utf-8?B?VHl1ZTdIOG9xaFdRMVpEVW1NWkFNUmNFOTFDSDFwMzd1V09NK2NPYVZCcGk0?= =?utf-8?B?WVNZSWY0VkxLdmVwNkY1anRGd1RyVm1aaUR0M0VxdU9KUUdpejRsR0FhUGRq?= =?utf-8?B?TEFmTWFFaXo1S3ZYNEczUSt6VnpmYUlVdG44aWlTRE0vMjRNMXdGWHZIOG5i?= =?utf-8?B?dUlCMlJDU2o4QmJESGsxZnNaZkZMSVQ5T1hscHVwM1E5YkFLSW5seFRaRm04?= =?utf-8?B?aTMzMlJCU0hWK2NEaXQvRGhzYWx2QzJwUDNQNHNwM1VPZEtaMk56Y3E4Q2U1?= =?utf-8?B?S3BpZVJHUi8vSHhROTJGSzJRWG5sOVc4QldhVWpYNXl1TzRCYVJjVkVrZmF2?= =?utf-8?B?T2x0am51QXdJVEt5NjJsbWRMTDV1SW8xeHpwZTBsaWtINUVrN0dkQlhsRndZ?= =?utf-8?B?eDA3eGpIWFpCQjR2UjZZUHdxb2YxeXp1eDg5UW43Z2w2RlIzQTg5SmpwYUdw?= =?utf-8?B?SkxZM2JoNFVvV09sR1ZIRHFwQW9ZZUJiSUlGM3Zrckc3Q1lvcldJTTFxRTV4?= =?utf-8?B?bzEydG1na0hMTVZBNHRmcjRtcGNsWi9XcldMT3BscFJ2KzlBMTV0RkxkaHg3?= =?utf-8?B?S3lRYUNwTkR0UXRwME9rbzVSSjBaWXFwYTFqc2xLTlhhZTRGMkViWlBPSDNX?= =?utf-8?B?YTB4aDUrd1lHNGh3MklBYVR5MU1ncTN6WVkrc1Y1aHUrYTMzSm9DSjY2K250?= =?utf-8?B?cGk4RlVsbW9JcUp2eDR5Si82ckRzZHIrWDQrWkRIakxBZE9ZTmFMQUJjcDBz?= =?utf-8?B?U3JqUkV0azR5NWpDUDg0czhHZ2RKSDNtZGtXMThDYWNKWFFIRnI3eXFhdzRN?= =?utf-8?B?R2ZwM0w5SmdOaDZyM0hHZzBQVEZHakIyYVZ2NVV4bGlSVWpJRVBqdllaS2c5?= =?utf-8?B?ZCtHQ1FKbVZxczkzaGhLdHJHc0UreTB1OFk0RTV4MlJZQ1ZFUDRRZTdJM09U?= =?utf-8?B?WFlTUkdxSStLNzJtMmR6Si9vOWpsUjBYTFdrbVNpenZtRUplSGtwVWVMY0pm?= =?utf-8?B?LytXbm9ISnRUSGVGMmJQa0RJM3ZIZ0duR0RwUUhMb2F3UjFpenNWWnlYYklj?= =?utf-8?B?L2VqK3Vzbzh1VEpvSTZLT0R3bER5dUR3WEZ0OGpvK2QvK3g4N01vTTF5U2ZY?= =?utf-8?B?emVPQXd6emZxWFV0Y0crOHVOZkdEZGdOcGQxeVVXeWRXSnhRSzlGNWpSUTVB?= =?utf-8?B?NjFob21aOGFZR3VhcjVpOU0xQWNMOHJZdmpxRko1bnhKZjZqQzcxY3NxME9W?= =?utf-8?B?WDVISWpkRk52T1kzQXQrVEJFc2hPTXBxaGthK216czh3NmRBTjlVTHJYajZZ?= =?utf-8?B?c2tLb1VFVEpVcW93UnpTNzZsQm1KUTlTWkxxTXplMmpobnM2cGR6UVB6TzFh?= =?utf-8?B?YVR0MEhtQWFrRW1KR2dOVjgwZzh1aUZpdk1uYzkvMlhWY3NMdGFicGhJV3d0?= =?utf-8?Q?TK/9eNhIiVI5JZ2mz0=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dddf56d-8cb1-4e0a-2f86-08da809ca2e6 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 22:05:46.6656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR01MB8733 Subject: Re: [FFmpeg-devel] [PATCH 1/7] avcodec/h263dec: Remove redundant code to set cur_pic_ptr X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Mon, Aug 15, 2022 at 01:49:24PM +0200, Andreas Rheinhardt wrote: >> It is done later in ff_mpv_frame_start() (and nobody uses >> current_picture_ptr between setting it in ff_mpv_frame_start()). >> >> (The reason the vsynth*-h263-obmc code changes is because >> the call to ff_find_unused_picture() now happens after the older >> pictures have been unreferenced in ff_mpv_frame_start(), >> so that their slots in the picture array can be immediately >> reused; the obmc code is somehow buggy and changes its output >> depending on the earlier contents of the motion_val buffer.) >> >> Signed-off-by: Andreas Rheinhardt >> --- > >> I'd like to take this opportunity to once again ask anyone familiar >> with H.263 to take a look at this OBMC issue. > > Iam too busy ATM :( i might look at some point but its not very high > on my todo as it works :) security & release is more important > If you (and no one else) don't object, I'll apply this tomorrow. > but i can say this breaks fate as it is: > > --- ./tests/ref/vsynth/vsynth1-h263-obmc 2022-08-16 00:19:00.345967181 +0200 > +++ tests/data/fate/vsynth1-h263-obmc 2022-08-16 00:19:05.262017999 +0200 > @@ -1,4 +1,4 @@ > 7dec64380f375e5118b66f3baaaa1e24 *tests/data/fate/vsynth1-h263-obmc.avi > 657320 tests/data/fate/vsynth1-h263-obmc.avi > -f5048b5f0c98833a1d11f8034fb1827f *tests/data/fate/vsynth1-h263-obmc.out.rawvideo > -stddev: 8.12 PSNR: 29.93 MAXDIFF: 113 bytes: 7603200/ 7603200 > +2a69f6b37378aa34418dfd04ec98c1c8 *tests/data/fate/vsynth1-h263-obmc.out.rawvideo > +stddev: 8.38 PSNR: 29.66 MAXDIFF: 116 bytes: 7603200/ 7603200 > Test vsynth1-h263-obmc failed. Look at tests/data/fate/vsynth1-h263-obmc.err for details. > tests/Makefile:304: recipe for target 'fate-vsynth1-h263-obmc' failed > make: *** [fate-vsynth1-h263-obmc] Error 1 > > [...] > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".