From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A3AE843A1C for ; Thu, 4 Aug 2022 22:22:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86DEF68B9E7; Fri, 5 Aug 2022 01:22:14 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073097.outbound.protection.outlook.com [40.92.73.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CAE1068B1F1 for ; Fri, 5 Aug 2022 01:22:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kBdnNJWyUCjxBnEeZb7rfDC6zCi6UphBfApWu/sgRvY+oiiWrpfMJJ3j36fVQ3WMmjqiMgAjwmWGOLcYPZxRClzoXzoQA4oN74Xobb12ZjX0zgzWj58WNNQkYtvGTK1fwYFOoZi2HIqRj3re0AMRid2bSLFKixFtL94X577vg6Wrk7n8WgIbhVtFfVQfm8cqV5/qmt9kXDjT8Y9w1yk98lZoCA1PLXgCdCYjN9fjubctdHW7bEz/AAHThQyU8YKTjQnldXea8EKJEuXsPN+xhbXwzQNneK5x8PUn2dSuuEKSXlTQ1RUYn7i1JHurk6NzTUbIudDyseudQQyJTS7qXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/dGNwayanctmGy16VHoYFAfmC6JsOooVBFozyDhdcg=; b=cR497QlPsFF+mv0OL9jUyjQeOmYGJWILI6DpdtEPOtxJv5WJXqEzdfBlsiZpY7kiBoRw1bXhZHpkzrC2xd3zgoctgE4YlvQSYnDbMBBZ1WMgXSKAIX+qcNfvnhft8msyf5HRt4mxyL2E2TE+EH2H6cncFWLLMKFKQZtjOVApREXNOwPCeuLvMHPrS2jvNPe+nDkAKKlasKDxREtoz+lqlcCy2Jel8kDvGP7ichiDwBWwp/8BuLIqntTvQ0Owa0G4l9/4mfoSN6XUnyLwGrPM/kMdOaUmdzn8Ndc166W2V80yPJEx3gIUKevXgkNyNoCr9rj/bnWqgyDtv8JkSDg3rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/dGNwayanctmGy16VHoYFAfmC6JsOooVBFozyDhdcg=; b=jFRGiMnsdKTz2SdKnod4BzVwTFPE0P93fKFSDMX17fm/R0mAgktOqlbLuOari1iVGV+G8zt23boWm3+YOUkzx4+PprS2YYj7r74/Ej4K318j/BmgmC6LJE9R0SRJBwQnmAYLsHN7U6ZJm1HFo3FiqKJnyhoRWRNh9Hdlwt27o75SlPSMDyXMVYZBY8QrXUjXVm9ZeNo0VIvvcdqN/hyNN7e/fPrHQfpZX5/lUCu/3lyEGr+FNpfJyogR5XCGM4LLtIP+LyDNlQM5+eZtt3sDokSulIFch4eu+XEAnXIbsesDFOYAihb0ZK/NtVqN2gtsCeMxdexZgdLRB7apDhiAZg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by HE1PR0102MB2746.eurprd01.prod.exchangelabs.com (2603:10a6:7:18::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.15; Thu, 4 Aug 2022 22:22:05 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5482.016; Thu, 4 Aug 2022 22:22:05 +0000 Message-ID: Date: Fri, 5 Aug 2022 00:22:04 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220731215157.22022-1-pal@sandflow.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [+pDlnECmmOWlcfnYC0T2hpOxWHGUy37h] X-ClientProxiedBy: ZR0P278CA0089.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::22) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <22546db0-1726-23eb-5b38-52667cd7f7da@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 453ae142-3fd4-4937-279d-08da7667c2b8 X-MS-TrafficTypeDiagnostic: HE1PR0102MB2746:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9Kbvb5k5q5Tx0kIioDYJnNyWyGGE84SNKFVEPidqfeMKFnTG2RG5QV3eDVsXpCGimhA/R9Wb2pztuz1UPBmoIfuUcB7qqr11lGMK3JsV0uMh3zk++k5CuChtmifoSVaA+OlabQtQIcKQr0A/cx5Ha9lblnWmrOzdnwEm/ERXSXH1WpkYbW0v4T5TKUvnPNE0ozagWggYEHGel9kuSTM/cjvcOi6oFCjNJbq4MqxE7ed00o/vFzwPbNi96j3jgDXGnelO9+X8sJ1CehDm4l3yPYxV+HZr6nBk6X5jFkadrw2VJ0VqkvhHuMs7aU/u8dIifJPfUZ04joiPoWlMnRUN7hiqR139PQtSiX5eVDll66GgHv2tQWjvvs4lWq7PbARZDVicwNqV3QIZyt6qDxVleVzmHsyxCu4GntCHUwcrb4RzXB/HvuHJZYpmIDB4AOSbnp7og/wZhfQJztlPriPtxkwmE9zJACOr2Ckr7ds8OfrnabqMraCYIDmQrHCAh9o2kmQ2kUEum5ZZffN+QiD+gUuS1+5Gqa3Q7wTd+CoUhsA8G+htoJtF+nipRUz+AURzZG2o1cJpOF0Mo3QRu/Da/ShsiTwy374yzvX9k7qjKSgqPAVj8WlLNEL1hDLaFiXVPCaxl3T/gWmaikoEGTyQlPcqdH1xQT09ymD40GSF9CYeDc7LMcnNsLYUhKfXFr9Z8N4AwtOmiVN/NVk+pfj/Y3VmTnUqssqG/GBBcAP41IE= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2dTZHBvMXQ4MWVBbFE4d3RVRkxYNG1Fb21tZzBPVnlYSXVNa0ZDc2QrSDhT?= =?utf-8?B?d1lNUG5LeGRZMjZQei9ndW85aGpDMlc4ZVREN0FHd1FwZ3ZFZVpKNDYzWnBt?= =?utf-8?B?RzI0R1JXVUh4YXlFUUVwZXRUa1orcGNkanFKd1oyODk3dG5lWHpwZWNKT005?= =?utf-8?B?aUpKV0RDbVdLL2dPS3ZNNGdraFd0NDRDbXoxWWhtWHp2S2dtWnVHN2xWbnVz?= =?utf-8?B?bFRONkpWbnA4TXdDUGp0eHBpTVZaRms3K1RDM0QwenJPdU8rY2kvLzZOeDhZ?= =?utf-8?B?RFJIdGRWbkI5bjZPL3J2VkJLSFhHL3BudWhUMlROMENzdjl5SFY1TzJTMWxI?= =?utf-8?B?L2NEb0hMQzErVFNub3V5YjlQbHV6enc2SG1DRjJhZjY0c1FFR3JzSTF6RVN0?= =?utf-8?B?SjZ3L3JmaXBhampGOWFyYnFuVlRRV1ZaNEN2VjVhYzgvd2J6R1FySHJYZWVZ?= =?utf-8?B?Vnl5YVhWRFVoZHhDZUx5NHI3bHRxV2R6eWF1RWN3Z3RVUFlKTHpTTEV0ckI0?= =?utf-8?B?WFE0OEJnR1BVZkFaOThtTkpLN1dwcTJMcnZySXJROC8vM2x6am41MWdZZkx6?= =?utf-8?B?WVRvYnVsUGVjMjJocHZYeW1rQ05TczJLMklLYWJmUnFwN3FXN1kvelRZanJI?= =?utf-8?B?UERraExZbVRtd2Z3NkpQWVFsUVFoWmg4SVFCZzVKK2V1ckdKSjVDMHJrUEVG?= =?utf-8?B?TmF4MHVNRjYxUDlNYkVOblRXQkVtdTZ6N2FXazE0Q2VqQUYvQTA0M2xHVUVO?= =?utf-8?B?Umo4ZlFVS1hlVTlkczVva0FRZUNKTmpTSUZtSzN2bGVtSnl0aVpDcXpiMVR3?= =?utf-8?B?ejI2NWY0N0ErbVl3SU5qYWJIZFF2TS9sS2dWdjZaK2tiWDVDZHlzbVZCbmZl?= =?utf-8?B?a2hVejVyQzk4TDgyVHRxbTJhWDJJUjB6bklJaWpGejExcHcwbVp3RHM5eVVB?= =?utf-8?B?S0pWY1ZuU0k4RkMzNkdhOWxJeStxWElLMWJnZjZXaGh6Sks1L2hWalZTck1h?= =?utf-8?B?eDF2T0Z6L09LRlBZaWwraVA4dHhyU0NYTEJtWFExaWtNTEVTek9sVE1Fb1NS?= =?utf-8?B?WnJpalVNMUUxRFlCNE9sR2dIU0FZclNTSnpQYkxNQmVCMk5jeVVPb3JNOENX?= =?utf-8?B?VURGNGdTTUh2YWJkWnFTTURGdDdWK0dZL1dBMVpaZGYwanNiQWxZZ0xzVVpH?= =?utf-8?B?aUJRdy9zQVdxcG1yUHphdTdYNXo3TGhqQXNGTEdRSUQrZTFvd0tpSWV1MEJu?= =?utf-8?B?dFJTSXowUW9TRUlQL1RITTl6czV0bjFFT280UlpnbjNtdmgyOHgrZlYzejVJ?= =?utf-8?B?U0VlSnBEcFRvT3hCTU9qNkZkOUJOQW5CTE9pWXI4QUZTMFA3cW5jVGtEWWRo?= =?utf-8?B?SmhnMWlpMXFiWHhxbXZwLzlXNVVwdmZ1VXhjVzBUQ2M2eEx3TGg0V0RFcFpw?= =?utf-8?B?MVJaeEQ3VHBUdUdTWUpVSjM3YmxqQk03akRYSnpiKzFsZVV1empIWGVqRDha?= =?utf-8?B?MHRzVW1JczVBSkdack9MM2xOTWRTTUVpdTl5UjVGRk5vL1Rua0Z4ZFBHQ01s?= =?utf-8?B?cGhqdzk5dE9zOS92UmpSdWVxR1EzaUJFeisrVnZFMmhZNUtSR3o0K1Q3S0hu?= =?utf-8?B?NklqM29oMnBnbW9OZ1VZemVCOUVrUElidVZYYm9BMWNKUHhLWldoSHJmbVg4?= =?utf-8?B?V2NvZVFjUzRCdk0rdllLWXRzMjZ0aTVCZW9DamtnK1V0RTBCRU1kemRUc2My?= =?utf-8?Q?je4SvxR0SDFZ5vzQ+w=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 453ae142-3fd4-4937-279d-08da7667c2b8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 22:22:05.0497 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0102MB2746 Subject: Re: [FFmpeg-devel] [PATCH v5 1/2] avformat: refactor ff_stream_encode_params_copy() to ff_stream_params_copy() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Pierre-Anthony Lemieux: > On Thu, Aug 4, 2022 at 10:15 AM Andreas Rheinhardt > wrote: >> >> Pierre-Anthony Lemieux: >>> On Thu, Aug 4, 2022 at 9:53 AM Andreas Rheinhardt >>> wrote: >>>> >>>> pal@sandflow.com: >>>>> From: Pierre-Anthony Lemieux >>>>> >>>>> As discussed at https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298491.html. >>>>> Note that ff_stream_params_copy() does not copy: >>>>> * the index field >>>>> * the attached_pic if its size is 0 >>>>> >>>>> Addresses http://ffmpeg.org/pipermail/ffmpeg-devel/2022-August/299514.html >>>>> >>>>> --- >>>>> libavformat/avformat.c | 40 ++++++++++++++++++++++++++++++++++++++++ >>>>> libavformat/fifo.c | 2 +- >>>>> libavformat/internal.h | 12 ++++++++++++ >>>>> libavformat/mux.h | 9 --------- >>>>> libavformat/mux_utils.c | 28 ---------------------------- >>>>> libavformat/segment.c | 2 +- >>>>> libavformat/tee.c | 2 +- >>>>> libavformat/webm_chunk.c | 2 +- >>>>> 8 files changed, 56 insertions(+), 41 deletions(-) >>>>> >>>>> diff --git a/libavformat/avformat.c b/libavformat/avformat.c >>>>> index 30d6ea6a49..242187c359 100644 >>>>> --- a/libavformat/avformat.c >>>>> +++ b/libavformat/avformat.c >>>>> @@ -235,6 +235,46 @@ int ff_stream_side_data_copy(AVStream *dst, const AVStream *src) >>>>> return 0; >>>>> } >>>>> >>>>> +int ff_stream_params_copy(AVStream *dst, const AVStream *src) >>>>> +{ >>>>> + int ret; >>>>> + >>>>> + dst->id = src->id; >>>>> + dst->time_base = src->time_base; >>>>> + dst->start_time = src->start_time; >>>>> + dst->duration = src->duration; >>>>> + dst->nb_frames = src->nb_frames; >>>>> + dst->disposition = src->disposition; >>>>> + dst->discard = src->discard; >>>>> + dst->sample_aspect_ratio = src->sample_aspect_ratio; >>>>> + dst->avg_frame_rate = src->avg_frame_rate; >>>>> + dst->event_flags = src->event_flags; >>>>> + dst->r_frame_rate = src->r_frame_rate; >>>>> + dst->pts_wrap_bits = src->pts_wrap_bits; >>>>> + >>>>> + av_dict_free(&dst->metadata); >>>>> + ret = av_dict_copy(&dst->metadata, src->metadata, 0); >>>>> + if (ret < 0) >>>>> + return ret; >>>>> + >>>>> + ret = avcodec_parameters_copy(dst->codecpar, src->codecpar); >>>>> + if (ret < 0) >>>>> + return ret; >>>>> + >>>>> + ret = ff_stream_side_data_copy(dst, src); >>>>> + if (ret < 0) >>>>> + return ret; >>>>> + >>>>> + av_packet_unref(&dst->attached_pic); >>>>> + if (src->attached_pic.size > 0) { >>>>> + ret = av_packet_ref(&dst->attached_pic, &src->attached_pic); >>>>> + if (ret < 0) >>>>> + return ret; >>>>> + } >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> AVProgram *av_new_program(AVFormatContext *ac, int id) >>>>> { >>>>> AVProgram *program = NULL; >>>>> diff --git a/libavformat/fifo.c b/libavformat/fifo.c >>>>> index ead2bdc5cf..fef116d040 100644 >>>>> --- a/libavformat/fifo.c >>>>> +++ b/libavformat/fifo.c >>>>> @@ -509,7 +509,7 @@ static int fifo_mux_init(AVFormatContext *avf, const AVOutputFormat *oformat, >>>>> if (!st) >>>>> return AVERROR(ENOMEM); >>>>> >>>>> - ret = ff_stream_encode_params_copy(st, avf->streams[i]); >>>>> + ret = ff_stream_params_copy(st, avf->streams[i]); >>>>> if (ret < 0) >>>>> return ret; >>>>> } >>>>> diff --git a/libavformat/internal.h b/libavformat/internal.h >>>>> index b6b8fbf56f..87a00bbae3 100644 >>>>> --- a/libavformat/internal.h >>>>> +++ b/libavformat/internal.h >>>>> @@ -625,6 +625,18 @@ enum AVCodecID ff_get_pcm_codec_id(int bps, int flt, int be, int sflags); >>>>> */ >>>>> int ff_stream_side_data_copy(AVStream *dst, const AVStream *src); >>>>> >>>>> +/** >>>>> + * Copy all stream parameters from source to destination stream, with the >>>>> + * exception of: >>>>> + * * the index field, which is usually set by avformat_new_stream() >>>>> + * * the attached_pic field, if attached_pic.size is 0 or less >>>>> + * >>>>> + * @param dst pointer to destination AVStream >>>>> + * @param src pointer to source AVStream >>>>> + * @return >=0 on success, AVERROR code on error >>>>> + */ >>>>> +int ff_stream_params_copy(AVStream *dst, const AVStream *src); >>>>> + >>>>> /** >>>>> * Wrap ffurl_move() and log if error happens. >>>>> * >>>>> diff --git a/libavformat/mux.h b/libavformat/mux.h >>>>> index c01da82194..1bfcaf795f 100644 >>>>> --- a/libavformat/mux.h >>>>> +++ b/libavformat/mux.h >>>>> @@ -113,15 +113,6 @@ int ff_format_shift_data(AVFormatContext *s, int64_t read_start, int shift_size) >>>>> */ >>>>> int ff_format_output_open(AVFormatContext *s, const char *url, AVDictionary **options); >>>>> >>>>> -/** >>>>> - * Copy encoding parameters from source to destination stream >>>>> - * >>>>> - * @param dst pointer to destination AVStream >>>>> - * @param src pointer to source AVStream >>>>> - * @return >=0 on success, AVERROR code on error >>>>> - */ >>>>> -int ff_stream_encode_params_copy(AVStream *dst, const AVStream *src); >>>>> - >>>>> /** >>>>> * Parse creation_time in AVFormatContext metadata if exists and warn if the >>>>> * parsing fails. >>>>> diff --git a/libavformat/mux_utils.c b/libavformat/mux_utils.c >>>>> index eb8ea3d560..2fa2ab5b0f 100644 >>>>> --- a/libavformat/mux_utils.c >>>>> +++ b/libavformat/mux_utils.c >>>>> @@ -121,34 +121,6 @@ int ff_format_output_open(AVFormatContext *s, const char *url, AVDictionary **op >>>>> return 0; >>>>> } >>>>> >>>>> -int ff_stream_encode_params_copy(AVStream *dst, const AVStream *src) >>>>> -{ >>>>> - int ret; >>>>> - >>>>> - dst->id = src->id; >>>>> - dst->time_base = src->time_base; >>>>> - dst->nb_frames = src->nb_frames; >>>>> - dst->disposition = src->disposition; >>>>> - dst->sample_aspect_ratio = src->sample_aspect_ratio; >>>>> - dst->avg_frame_rate = src->avg_frame_rate; >>>>> - dst->r_frame_rate = src->r_frame_rate; >>>>> - >>>>> - av_dict_free(&dst->metadata); >>>>> - ret = av_dict_copy(&dst->metadata, src->metadata, 0); >>>>> - if (ret < 0) >>>>> - return ret; >>>>> - >>>>> - ret = avcodec_parameters_copy(dst->codecpar, src->codecpar); >>>>> - if (ret < 0) >>>>> - return ret; >>>>> - >>>>> - ret = ff_stream_side_data_copy(dst, src); >>>>> - if (ret < 0) >>>>> - return ret; >>>>> - >>>>> - return 0; >>>>> -} >>>>> - >>>>> int ff_parse_creation_time_metadata(AVFormatContext *s, int64_t *timestamp, int return_seconds) >>>>> { >>>>> AVDictionaryEntry *entry; >>>>> diff --git a/libavformat/segment.c b/libavformat/segment.c >>>>> index fa435d9f32..a8f3e94714 100644 >>>>> --- a/libavformat/segment.c >>>>> +++ b/libavformat/segment.c >>>>> @@ -169,7 +169,7 @@ static int segment_mux_init(AVFormatContext *s) >>>>> >>>>> if (!(st = avformat_new_stream(oc, NULL))) >>>>> return AVERROR(ENOMEM); >>>>> - ret = ff_stream_encode_params_copy(st, ist); >>>>> + ret = ff_stream_params_copy(st, ist); >>>>> if (ret < 0) >>>>> return ret; >>>>> opar = st->codecpar; >>>>> diff --git a/libavformat/tee.c b/libavformat/tee.c >>>>> index f1f2a9d2a5..dbfad604d0 100644 >>>>> --- a/libavformat/tee.c >>>>> +++ b/libavformat/tee.c >>>>> @@ -289,7 +289,7 @@ static int open_slave(AVFormatContext *avf, char *slave, TeeSlave *tee_slave) >>>>> goto end; >>>>> } >>>>> >>>>> - ret = ff_stream_encode_params_copy(st2, st); >>>>> + ret = ff_stream_params_copy(st2, st); >>>>> if (ret < 0) >>>>> goto end; >>>>> } >>>>> diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c >>>>> index d69db3a004..39f21fce7a 100644 >>>>> --- a/libavformat/webm_chunk.c >>>>> +++ b/libavformat/webm_chunk.c >>>>> @@ -94,7 +94,7 @@ static int webm_chunk_init(AVFormatContext *s) >>>>> if (!(st = avformat_new_stream(oc, NULL))) >>>>> return AVERROR(ENOMEM); >>>>> >>>>> - if ((ret = ff_stream_encode_params_copy(st, ost)) < 0) >>>>> + if ((ret = ff_stream_params_copy(st, ost)) < 0) >>>>> return ret; >>>>> >>>>> if (wc->http_method) >>>> >>>> Looking at these callers shows that they all have one thing in common: >>>> They create a stream and immediately afterwards copy stream parameters. >>>> The caller that you intend to add in #2 does the same. How about we make >>>> a function that is equivalent to >>>> avformat_new_stream+ff_stream_params_copy above and use that? (But >>>> please leave ff_stream_params_copy as it is in the form of a static >>>> function.) >>> >>> avformat_clone_stream()? >>> >> >> I was not thinking about a public function. But clone_stream sounds good. > > Something like this? > > int ff_stream_clone(AVFormatContext *s, AVStream **dst, const AVStream *src) > { > AVStream *st; > int ret; > > st = avformat_new_stream(s, NULL); > if (!st) > return AVERROR(ENOMEM); > > ret = stream_params_copy(st, src); > if (ret < 0) > return ret; > > *dst = st; > > return 0; > } > I'd use AVStream *ff_stream_clone(AVFormatContext *dst_ctx, const AVStream *src); - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".