From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B58EF4025A for ; Wed, 20 Jul 2022 22:00:17 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D2BD768B5AC; Thu, 21 Jul 2022 01:00:14 +0300 (EEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067067.outbound.protection.outlook.com [40.92.67.67]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3ACE468B312 for ; Thu, 21 Jul 2022 01:00:09 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UBN5ZE5+b6Tirz95EvIRIJeWGUqIMwFjprN7vT9ylVjbXxYGM+KTCWGCUEzRV7gygdNI3h2Ff0t0VmLsI4zPs4mbVyxvg/9u3cw96bobDcieh+19LXBg+tdGIbxZ4AJ1ZCJtw9Cao/LQ27+U7uFOPrU/RLqQ/vCy2Ljy9lDMWVC7/VnyWa3cNz3erbRJHTsF3buFGYxSMr3XsHUGEdcrgpW1D4AHgRYqsyJLxZ9az64pfwUAJ4GZObdo2sMavzVGSYdJIU6F+YwmHvLvVsvEwpoGiXj7zgGisIFSSdmSzqTUXd9akehqQWm3XDU1fS5+IEaaj5lwsJSb1yBlekKlCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SApRBiaJ3HvAorJTyCfl0qjGY/r5PLTaLljZC6RkHBY=; b=NpJ5eu5oY7nT4dA26UwJ7SvFfJas38lwXYbgJdShVC4jN33dl5f5ZR/dUFE4U7mmtNrX8er9amSQ/nD2cGCOFCtiDXd1GJTwB57sINnYYHE3+BEd4dZ/4fKVi0EaC9voCZDD9qSblTxV2E5RZql7oGQpNArsaJngiyxMnaivRrP9txxrpO4gGaT5WuVkU+aznynm+xqh4CF67/fKDzqXNNSVFiAEwg2CkjBYbgQQksYPD/y3RuJ9QOwRg55sdAQY6W8NP/WnsoCEiB0O9/MBN0XF2jjE/owG7k8YqrPsGwIDiveEKrdCcjvnF35A1bE+mTpA7msopckcgznW+yME6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SApRBiaJ3HvAorJTyCfl0qjGY/r5PLTaLljZC6RkHBY=; b=St+EoDI9E2lWHZ4FZVkfag9+nzioNEW+hoHjzNBOybgoCvWNNB4WNbz/LDjRjCgtjnuOG8oz1vHWuXkiqqP3QxhPdRNOG7pOZlOOeR1H6si2oNg3HX7zvTNyml3qtwMwW6BL3UEMANP9/2yoXwQabW/mjViDITaO/9stEkBKvWDNdB4Q8L7SeaEHxsEfMjcogoZkY7dcIsGT5nyH8+owLEtOFFPPpGwZP+qx90h8LJUWtGn228VLuNe1udGLjPA/9tfpqcqSrWkboUTr7Inqw4uroxNtQduFdM1yeDHuocdwDL+M3QzPbAKd08gMoL8V2LebvxbvXcdfrSr7lFM1nA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DB7PR01MB4837.eurprd01.prod.exchangelabs.com (2603:10a6:10:2b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Wed, 20 Jul 2022 22:00:07 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 22:00:07 +0000 Message-ID: Date: Thu, 21 Jul 2022 00:00:05 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220720144937.93133-1-zane@zanevaniperen.com> <20220720144937.93133-4-zane@zanevaniperen.com> From: Andreas Rheinhardt In-Reply-To: <20220720144937.93133-4-zane@zanevaniperen.com> X-TMN: [wRVGULYFGTqYNbbxqELvEvIES6eozLcB] X-ClientProxiedBy: ZR0P278CA0077.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::10) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <36484072-d1b1-5db7-df5c-59842a2d972e@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 90409aa1-5384-49ee-afe7-08da6a9b3538 X-MS-TrafficTypeDiagnostic: DB7PR01MB4837:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JoGchNFCeJA4mjN5eilukZ+z7v0jhrktSCfoSfvN9iwlEn0tpve0k8piJ34wzga8v6UiWr0rv7lZpW9ruEGBXIBxzqsJgUjwMXxngY3PRsmeKxN1oSqKv2iV4tvu5qarCfoRk/BpsKOXQDZPooKkIFxCj+UFM1IDo9pbsblEkxHH+8tTLTl1DE0Rr0m0GkZKdrt7gDcTqUqEUQPUNgGz0GbGpVngAHQGNkHLLNcjTuRrcRb80e/acV29ZakmRRWIvdvSK3UUEDH1iFeB+UsqCO+2jrTLfaP6ET8V2FOdDPQoyZ0BMW2hKw9fMc/mWl/vidHV5C6EiNB+eUJufUR4PkRKQxbeNoyLMBpj2OgCWJjeoehVQc3sHK0Ov+ulxpBd+mfwIXnPfP0lGOjIp/UuEaGBa0MHCraXvLJluMY+ycgZBJkHbicbJIM+tHaSlqBzUnXE8E7ZyACPllhVYuicVy7rYpZwRrQ9nsSC9c3dBjnn4Oc5cjSXNLJq8VK3sG1zBNd/GtXRXediLSsA2myFYHIHnMH2BCx5KFJKWI1+M2K0dcy9VbLMYVmN6MpDroC1glp2vOAkM/1MFWBnbj12ZraluQg/N1ykXCV8rvp4EuVHe5v3Qd4M5xHyaZj5U9vuTJvKSrQSNP1y5jUWsxvhRY5x1LKdC5yfMOpF36d34m5K6yV+eQDFrvewgsSyObze X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anQyRGI0Mm9PT1MybnAvM0l2em9KZ1VrNjZvbWJsUjgzZ1Jla2lmUHN6S013?= =?utf-8?B?VXdpSzJTNGNBOXRKZDV6RXA0czlIVFNTaGl6N3hqY2pTdTlNMjY2QlZuOVVY?= =?utf-8?B?ZFMxQ2lNOXBzbWJYVE9tVllyd0JBYTNFeEJuQjJjSmRTOW9QTEhVR2V1cTNv?= =?utf-8?B?bk5IQUErL0Z0dXRxakllN1I5R29wVVlYOU94RGFzOHpHcEptbERBQ1MxUHNm?= =?utf-8?B?bnNFZlk3UlB2c1lQQmZxbWtHQUlpaUw3SGJXVytJekZSdGJsWndoVnJ0U3d1?= =?utf-8?B?UFgvV2hHdyt4NzE2U2pUVFkxSERCUXFTR0FVK2JWaWZOemxRSkROUWtNZG1E?= =?utf-8?B?YzkwSHJGclZENHF5bko1R0FUSmNnejFwR1RjYkFocWQ2SU1wTTZDVmNvcEc5?= =?utf-8?B?TThHLzRzdGZEbTZqb3N3NG5ieSs4YUs1QmZRd0JLdVIwdGxkb3dqTXhYVXJS?= =?utf-8?B?TUpzcGxueFZoSHZrTk5XZ1l0cEJ3REM4RTVNcjVOUXV4dXp4a1YrUHBKSFhO?= =?utf-8?B?TlFOZDN2NGdFYnhlV0ZhRGFyZG5SM3JmcFByUGhjM3pudG9LY0hXWDYwaWJ4?= =?utf-8?B?YVEzS3ZnMGs3N2lUVStzakFMd2V4UkJQNWJhUndFMTFuZGxpR3lhb0xJUGhL?= =?utf-8?B?S0xrYW5rU2I2RkQ3ZUJxMUp2SkwrQS80bU1ZdmJ1NVBNM2xWMERNVU5Kd1VX?= =?utf-8?B?NmJvK2hyeXR1eUpwUm1qcVdMU2tLd0ZEQllWWlpDd1RzQlA4UWlhVWlyS3or?= =?utf-8?B?ZEZPanhlVzFkRkRJdm9nc2ZFVFU1TnF2d2VHUC9wY3d4OWF3Zk91SFI1TnIz?= =?utf-8?B?T3ovWkZLRXdTSVFOR1ZFeGIzZHRKQVZyYjVkUThTWDRhekRUdXRZdFIxdnVP?= =?utf-8?B?bWUxdG5xRjJkUXdzNDd1QjROZ2lwYUc5dEhMTm9sZmVPOEZQT1ZmckIwMDNM?= =?utf-8?B?ZmM2Y1BaZVRMeWE1dnRPYVlRelFXajFzNWlveERGUWN6QjhrM0xTOUx4ZzBK?= =?utf-8?B?NzdjV3h3eE5UTEltQmt0N05Oazlvajd3MUt1Y3VvR1BvTkllT3pBNnZvUDhF?= =?utf-8?B?dUhvdU4rRGcxZlJUTnk2bmhTSi93WGY5TUxxUkVveHNpMVJDV1RZWkRDbTBM?= =?utf-8?B?VVI0emhKTnRGTXMxTTJwMWFCTnh6aXdCT1V2d1lIcmpoY3k4cldLUDRRZlpN?= =?utf-8?B?b0xXRGlWZ0N2WEFkRFYzQnZaTUpFTXRCTW90MEI3WW1tT1NpekZJR0V6UWg1?= =?utf-8?B?TnNlNW1ISE5oYUVCcVlLaGRMYnp1N0gySFN5TnlydjZ0OFdMNk1JZ1dKaGo0?= =?utf-8?B?S3dIR0VNTllFcWRHQWZhaUNNRVZ2VUsyUDUxQUswZFRyTE1xaVpPUUkwVlBw?= =?utf-8?B?Y3JSNHh5cW4rVEdONWlZSHVPQmtkOHNtZy80UmNhTGs1VTc4aGlPdDBRaWpx?= =?utf-8?B?YTBlcEU4NUtIbHZTRWxWM2FzS1drY0dRR3hYNThnaS93ak9OZExuWG84ZFFr?= =?utf-8?B?cXpuMG00Sy9UcFpxMmpKTHU0SG9YS1FMVGNraTk5RlVKOUxiNW04Q1JsVEw0?= =?utf-8?B?NlpodWRkUGpWRkhVNTBRV294amhaeC9JSlhFeWlKY1R6N2JPc1lBdCtkMnFW?= =?utf-8?B?RzUyWWFtc1k5NDQ0SUhkVlczRVU1SHdkM25YL2l2VkJIc3J1L2dDczlHWnNu?= =?utf-8?B?Nlp2eFc5Z0FsUW95dVR5OXhOYlRiaVF6N0VYK2JrZkFYQ1dKTjBteEplTzJz?= =?utf-8?Q?Fd5wRIzcVkY/qP+5gw=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90409aa1-5384-49ee-afe7-08da6a9b3538 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 22:00:07.5947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR01MB4837 Subject: Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/argo_cvg: expose loop/reverb/checksum via metadata X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > libavformat/argo_cvg.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/libavformat/argo_cvg.c b/libavformat/argo_cvg.c > index 12465dcbcc..3d4abb4758 100644 > --- a/libavformat/argo_cvg.c > +++ b/libavformat/argo_cvg.c > @@ -162,6 +162,15 @@ static int argo_cvg_read_header(AVFormatContext *s) > if ((ret = argo_cvg_read_checksum(s->pb, &ctx->header, &ctx->checksum)) < 0) > return ret; > > + if (av_dict_set_int(&st->metadata, "loop", ctx->header.loop, 0) < 0) > + return AVERROR(ENOMEM); > + > + if (av_dict_set_int(&st->metadata, "reverb", ctx->header.reverb, 0) < 0) > + return AVERROR(ENOMEM); > + > + if (av_dict_set_int(&st->metadata, "checksum", ctx->checksum, 0) < 0) > + return AVERROR(ENOMEM); > + > par = st->codecpar; > par->codec_type = AVMEDIA_TYPE_AUDIO; > par->codec_id = AV_CODEC_ID_ADPCM_PSX; Don't second-guess error codes (unless you have a good reason to). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".