Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Paul B Mahol:
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
>  configure               |    1 +
>  libavcodec/Makefile     |    1 +
>  libavcodec/allcodecs.c  |    1 +
>  libavcodec/bink2.c      |  479 +++++++++++++
>  libavcodec/bink2f.c     | 1234 ++++++++++++++++++++++++++++++++
>  libavcodec/bink2g.c     | 1479 +++++++++++++++++++++++++++++++++++++++

The latter two files are not standalone files, but are included in
bink2.c. That means that bink2.d will contain bink2f.c and bink2g.c as
prerequisites for bink2.c. Yet if the code were to be changed so that
these files would no longer exist, then the build would fail if you have
an old bink2.d with bink2[fg]].c prerequisites, because make would not
know how to create these prerequisites.
To fix this, rename these files so that they are either templates or
headers.

>  libavcodec/codec_desc.c |    7 +
>  libavcodec/codec_id.h   |    1 +
>  libavformat/bink.c      |    7 +-
>  9 files changed, 3206 insertions(+), 4 deletions(-)
>  create mode 100644 libavcodec/bink2.c
>  create mode 100644 libavcodec/bink2f.c
>  create mode 100644 libavcodec/bink2g.c
> 
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".