From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E46D943287 for ; Sat, 25 Jun 2022 13:01:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id ADA2A68B7D4; Sat, 25 Jun 2022 16:00:57 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073099.outbound.protection.outlook.com [40.92.73.99]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5919C68B756 for ; Sat, 25 Jun 2022 16:00:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ep+R8hMrcgPDbpRRYbEg9XWTNEfsHQB23gGHhpnDgfFU3mpiDjEGjGc2poDa7ozT7KcZ0Vo73f/wg9uBVVBwvVSqzYdjOHNdU4nHoifs/PobxP2Ld9pGx6Py+/Ip9PbMU/dwRPMt4dNP1EgoivH2rLMVSq7Kblbk6AyyuwLiFxJK1wVbmDtr9Tt79fI2fSdOo2yX3OCuRNhsrZ9158gczgxEui0xUeJPrD06LEHzF3agkReRb0DltuInGsL3kX3FozvvZgt5K2qbqyOi32RrHOym3zlk7tGqpdkfK+duUmzVi++6JTTO6+934HwL/EM8fIAk8qFITGngfSgBfMkYHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZL4hulp/4XMzb2D3qaKkVmH8GAKoVeLBsU4Qm1M+RI=; b=aR09Cl43KEw1kTBjkvokVIwAB39k7cNJJ7J4aXQsJMm+beLOi32wC4ui2SPr0IMp7rRm4Xi5/TJRIX/iOQPFv3hNGpgCR90DHdILD0eGX+Nc11DgKnxEMETRc7RYWOBDu469ZnL7TqBntO8P/ZpuEBlTFi7y4ifphGJx2fCd4TZeX7HPJeW0kyXixoEM+haPYJir8krqb9VkrjpvuPUETKXvkGn0cMNoSgHha9BRwT+6WMNZ31crqH1NbAiOP10f9MFsuosxPxJFCv8K67SC+C0V7sKW5DJu8XbIau0xQDrVS8q/wRM5OJ/2RD1E/Yl2W0WGpuAFy3+wpjNms0yGyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MZL4hulp/4XMzb2D3qaKkVmH8GAKoVeLBsU4Qm1M+RI=; b=pV6sEuJpPNypu/mSlXM1K2q3v5EzczO95Oz3oM7su0haOdKeDBZIEUdoELrlpUQAK7zmFg4n5l58q7hT5l7DJkdwZCq5IIJ/eQOa1C2KtU0Z22IRAxqgLpXFV1uSsCQc+M7TVKHfSUwtndBhRZ6JDxElAyfDOZEE0agwrrsqDH92Fr1+XcANdrqPT9qLV3CGK6UklPBbqqBEMnErh0YmDEbbT6H23tKxH0fJLnH/G4SjP1oW3aFF+CkD/+vIWaFfXSYs9byFkUdZi/GjVqQgtbfnt8j0nXXjUKRCFHdB0AuMWj8K9451UrKdSW2AbDkw/TA38UikcwHs06P+xCQdpw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS4PR01MB10203.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4fa::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Sat, 25 Jun 2022 13:00:49 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.024; Sat, 25 Jun 2022 13:00:43 +0000 Message-ID: Date: Sat, 25 Jun 2022 15:00:41 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <2645a1a8426d406de339813d97a69aed1d205967.1656151077.git.ffmpegagent@gmail.com> <20220625113452.GR396728@pb2> From: Andreas Rheinhardt In-Reply-To: X-TMN: [vbaP1yS0eLrTk3ZW56/iDwxznLcbbZFn] X-ClientProxiedBy: ZR0P278CA0177.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::11) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0efc377-f7d0-4d3a-45d3-08da56aab638 X-MS-TrafficTypeDiagnostic: AS4PR01MB10203:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jzt50RB7sW07w0jaCCKyQUhBwFUkjb4Y9tMnxQsMkpZAasctJLpNptxi93EjYu0mZ3VOW7B3n7kT0ueppoKIueHz/w3XDnUWtzPPRsFfou9kd5FefFmxjX9f6XFJXlHCVokSBfNOMzKbx2YXoVMZC0ley/nyGKRLBH53F0tDjCwFw/bg6zAX28uR+vBFNZZ4Yb/+0YKf6CDvRt98Wx21lIsuMtnzTC12OswmH3O0yU62rhLxKP9ZfVT4uGM68eGCRaHJkP72PtW7OWtg43U1NMZkDu/uVmn47bqUJgClTT/oqO135DPwpt5a/B2/NH5kA4IaX8ERm/hLSDzQTF08wrTTLWr3SYFUO2BJ/qCuRwHK4eguhhP9xWe5ghtEyhB6INK14j+E6od8x33Hb6qbBbjgxIex/nhd9NQ65DemjXT7WYQGG37C12/Mw+qxbhaxj806+JT8oK3vn7rlJ0Ys+2UiQxIACy+DpRW5+vq9HBzSsszTkSucq56miwDavOGnE/ye0dN2dZvX8S+YuPPWLANLrAekIs0NdUCZzN4LXTNLdGZBxyaEjI52SXGeUMjMwgRlZtVpYvceqj7BpSiHdswxhWHHi/AUsNoa1z1NSm+u+HdwNMcRnrq4O5il5Z1HQClKuaEo5p6S2tNdvGhYQA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHB4dmJ2MWpCYUFCQUt4bHZhYUIrdWJBYktvNXJwWDdCVkc0M3hSYU1PWTY0?= =?utf-8?B?eENwM3VLbGY3ZWk5L1NJbWZIZTFoVUNtMXhqOE56d0p2NlU2WVd2T3llaUJx?= =?utf-8?B?dzJXbHdidFg2TVoyY3NkTjdQTmdNSlVxNWxPTjF0cFBBZmlWL0FkaWVpenVK?= =?utf-8?B?QWNzUTFpS1RMZzU1QzcxenprYkd5WDN2UVhQVzhVMTYwTTJEQjJySFhnVzhC?= =?utf-8?B?SmJPL1M0OUJyUnFIemNTN0UzNDBUTXVQR2ZFMFBNSC9nZmFybEIrOVNUcm1j?= =?utf-8?B?KzZjWWkvN1ZSTTFmSlZEYnVITXRMOG5BUFQ2aHFqU1diVHdRMHpnNWlKY0ds?= =?utf-8?B?cExIWlVYaWF4UkZjWTRIYlJCc09xS2VNWUlkcTlpMGlkOFEyT2NoUUxKUTdG?= =?utf-8?B?eCtwNVFHRE42T1plUFpFMGlMRjhVVnhJOStpWlJxd3NqZ0J0VWhveUZQOVNL?= =?utf-8?B?VjhScDMvSDdCdjNEY043V2lxemllNXBZR2xiUXY4NkZzRjlRUGNsMmQvRVVx?= =?utf-8?B?ZWNjWGowNHNyMmZEZ2lKZmdtM1NvdVVFNHNGLzRzYUcvaXByb0JVTlJWYVlZ?= =?utf-8?B?MGVQYkdKeVRNa3ZERWhiU1ArWDhubjlSRjlEbkJwVjZTTVZQV29LN0ZPUjNJ?= =?utf-8?B?ZGpLeVFXdjB5TkFOQnhqTFJreDl6dmMwU003K2NjK1cvUUR1endDaTR3Q21p?= =?utf-8?B?VFMrRDhvZUhaekgwVGN6V0xtM2xpRnNNMUk1WE5xNGJyQWFjOTZlUy8yaTRY?= =?utf-8?B?WCs1bjFPeXQ5ejN3Uk5nTTY5YVlEcWhyeldhSGZ3L09BZmFpa0RScnRLZ2xu?= =?utf-8?B?N2pjWmhETDR2V1c3UGFyNFNEaksrcjB5RW1CUUxyQ2pxS2xZdnlIMHdZR2do?= =?utf-8?B?VTRTUkthMFI0RVFZK005Qmp3MDByT2dvQk05UmV0bTZKaDJEU3RRK2RETENF?= =?utf-8?B?K2RXSHk3eFQ2N09ZRFhhRkU3WFFvMUhvUzAxSWpDaldYTjd5Q1c2NjNwWG5N?= =?utf-8?B?bTNldUNHelVnQzI2WU1VMFVvVTV5NGxBUzM1Rm9IVnl0VllnU1E1MFJnNGQv?= =?utf-8?B?KzlpcnJkN2pia2xRSlNXSzNwTVVma1NjRGtFSGh6U3dLVlNJZzdneVN0MkZG?= =?utf-8?B?WVI3WEFRUlVNZlFFaGV3amQ1am8zeFdQS3JLSVVFNlQrNFYyMEpQVHJWdlN2?= =?utf-8?B?ZjE1Y0NZM2w3azM1T21DR3NtR3JYdkRrNDhyYkM2elJGS0g4bGZiUVVGZG1F?= =?utf-8?B?TDMvSzYzeXNsYmh1UVdvWDJwRjQ2Tm9JT01NeTYvNjBGM0g5TXYyN245c0hN?= =?utf-8?B?UURhdkhDNnFGcXh6NFZKSGxrNllwb3ltSkdoQkRiaDQzZ3JNMFhCWFNZWXZK?= =?utf-8?B?ZWQwa3R4Tm5VNXNvV011TkJCMFhzbVVCME0rZ1pITnVIclN0OU9CODgxQ0F5?= =?utf-8?B?RUhSTWhyRWpJMWhqUVdnbjhGQzB6SmtPNG1kOWZVazVWbTZRTzdoYldHY1Vi?= =?utf-8?B?S3VtbzdFN0NLWWxiRlE4V3prcHRpNHhvdi81OGpSK3QxRTVGYkFUK1Z0T1ZV?= =?utf-8?B?S1ZxT2FhRzFBRnVzYW9XOGZ4N241RVBobUU5eXVqWFdwZVM4emlGSVluN01F?= =?utf-8?B?SWlmV0E0YXdSNE8rSkttM2lGZkxOeVJVZHRpZm9zNjYrTEJ3NHdjR3d3T055?= =?utf-8?B?OUZoQzZwT2R3NTlJUndhVmFoMkFVdkxidWpYWk1hcC9RckFBdjFFR0Q0TlVW?= =?utf-8?Q?13taDqol60KLvqutzE=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0efc377-f7d0-4d3a-45d3-08da56aab638 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2022 13:00:43.2447 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR01MB10203 Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Soft Works: > > > ________________________________________ > From: ffmpeg-devel on behalf of Andreas Rheinhardt > Sent: Saturday, June 25, 2022 1:42 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding > > Michael Niedermayer: >> On Sat, Jun 25, 2022 at 09:57:56AM +0000, softworkz wrote: >>> From: softworkz >>> >>> This commit actually enables subtitle filtering in ffmpeg by >>> sending and receiving subtitle frames to and from a filtergraph. >>> >>> The heartbeat functionality from the previous sub2video implementation >>> is removed and now provided by the 'subfeed' filter. >>> The other part of sub2video functionality is retained by >>> auto-insertion of the new graphicsub2video filter. >>> >>> Justification for changed test refs: >>> >>> - sub2video >>> The previous results were incorrect. The command line for this test >>> specifies -r 5 (5 frames per second), which is now fulfilled by the >>> additional frames in the reference output. >>> Example: The first subtitle time is 499000, the second is 15355000, >>> which means 0.5s and 15.35s with a difference of 14.85s. >>> 15s * 5fps = 75 frames and that's now the exact number of video >>> frames between these two subtitle events. >>> >>> - sub2video_basic >>> The previous results had some incorrect output because multiple >>> frames had the same dts >>> The non-empty content frames are visually identical, the different >>> CRC is due to the different blending algorithm that is being used. >>> >>> - sub2video_time_limited >>> Subtitle frames are emitted to the filter graphs at a 5 fps rate >>> by default. The time limit for this test is 15s * 5fps = 75 frames >>> which matches the count in the new ref. >>> >>> - sub-dvb >>> Running ffprobe -show_frames on the source file shows that there >>> are 7 subtitle frames with 0 rects in the source at the start >>> and 2 at the end. This translates to the 14 and 4 additional >>> entries in the new test results. >>> >>> - filter-overlay-dvdsub-2397 >>> Overlay results have slightly different CRCs due to different >>> blending implementation >>> >>> - sub-scc >>> The first entry is no longer in the output because it is before >>> the actual start time and the strim filter removes such entries >>> now (like for video and audio) >>> >>> Signed-off-by: softworkz >>> --- >>> fftools/ffmpeg.c | 613 +++++----- >>> fftools/ffmpeg.h | 17 +- >>> fftools/ffmpeg_filter.c | 270 +++-- >>> fftools/ffmpeg_hw.c | 2 +- >>> fftools/ffmpeg_opt.c | 28 +- >>> tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- >>> tests/ref/fate/sub-dvb | 162 +-- >>> tests/ref/fate/sub-scc | 1 - >>> tests/ref/fate/sub2video | 1091 +++++++++++++++++- >>> tests/ref/fate/sub2video_basic | 1238 +++++++++++++++++++-- >>> tests/ref/fate/sub2video_time_limited | 78 +- >>> 11 files changed, 3010 insertions(+), 672 deletions(-) >> >> seems to break fate >> >> Input #0, ass, from 'fate-suite//sub/1ededcbd7b.ass': >> Duration: N/A, bitrate: N/A >> Stream #0:0: Subtitle: ass >> Codec AVOption threads (set the number of threads) specified for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. >> Codec AVOption thread_type (select multithreading type) specified for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. >> Stream mapping: >> Stream #0:0 -> #0:0 (ass (ssa) -> ass (ssa)) >> cur_dts is invalid st:0 (0) [init:0 i_done:0 finish:0] (this is harmless if it occurs once at the start per stream) >> subtitle input filter: decoding size 1280x720 >> [out_0_0 @ 0x557cab64bbc0] Subtitle format change from 1 to 3 >> Assertion c > 0 failed at libavutil/mathematics.c:61 > > That's an av_assert2-assert. softworkz probably didn't test these. > > > Yup. To be honest, I wasn't even aware that I'm supposed to. It seems patchwork doesn't do either? > > Do I need a different configure or make fate? > The supported way to set it is to pass --assert-level=2 to configure. (You can also modify config.h by adding "#define ASSERT_LEVEL 2"; if you have not used assert-level during configure, you should have no ASSERT_LEVEL in config.h, but better check this.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".