From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A508143966 for ; Sun, 3 Jul 2022 19:15:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE0DC68B97D; Sun, 3 Jul 2022 22:15:47 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073040.outbound.protection.outlook.com [40.92.73.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E484B68B918 for ; Sun, 3 Jul 2022 22:15:40 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kSXcVwd/TYRdCQq9arbzQup8NypVeUDhTJ+KVk+q2rYZotu9da6tWN+NIa0RnDhhtb9nSTn6Uy7liHfdKrzCwRN1fb+91rqiOTXcGhXwlil0wb0+yaONmUKFT2rt60msmoT2S13ipI6z+C/N7jwitg/zNpVNG/QgKGX22rSgaX500Eo75EvWc9ZFwxprNI1jyhOKaPbfQ4eWyM8HJnMERvZ8KhJKtlKf5PJRnTAKpUGgwkXkBzxBVfwgRKJKgOGnTPJNgaCVWfhR0UXUjRFiSS2zTGc84/2q729PyzomvWj+1ZpyHvLcft7VKVEttQhCXu7bqzLRVLNn6zemwy0H9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U0R6hU9KMiCSWC0EM2veIgi+YjgBSGjyoFySm+1UIy4=; b=m7syCep9QBMqH377VFMygJLnXaz2/jyR0/Ozh4EjdyjIz87Gi/dTxaYgNb5C/NEOXbO3RtRm6rMVWzBpTey1iRwRQVjAwAqgjEm/d2YjPglIhmRz1OFqvLalRzr7xlTPiyojRBSKMgHMwxmioFVgS4ZYDIwqzJmnfXyMQcjTN3poAFR9V06JsNLkUZyOyT83s6R3v6ldB1YOPdzColea5CTdkSfLuCjhNU2nZ9dFtjXK9IjDZ6NSCJ4NEdBXt5VnoR4jCfEdPoRDdImi37UJPExjmc2U/yJHide3BhhBpxUOmwF2YvS/LR92YtHtBq5APhFCXyA6bVFxeTcGUBIn2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U0R6hU9KMiCSWC0EM2veIgi+YjgBSGjyoFySm+1UIy4=; b=ln2muKzUOEmKsoH1bm3pVHAwzDBSGij6ZGbCnOiO4jBpn9RJFgcNpfpXlkIW0WUast8eyurJCHMHpMb2V1Hl/Q+mxEIhKHtmF4ajP81gQRcmOr4cbnRkmKpxG91ZHVVBA36ZSVSygVNyWlV2SWyVXvyiRq240OPKhmjQwqDOIE5MOt+YlaVzbQZGWJx/oyzTBerKOvEbmBOdvwpuAJvsyLnX/s0/GwUyHw9c3N24CXcOMM8pWTuuldyHCnwjdIgVzJN63agE9EyVcU52aG3k1zyQLv01q+A5TZMT2tH/jzGk042cXFbwMhoXQCHV4C9OQYbIf9Qoc0huZjkwNdDH3Q== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR0101MB2143.eurprd01.prod.exchangelabs.com (2603:10a6:800:22::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Sun, 3 Jul 2022 19:15:39 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5395.020; Sun, 3 Jul 2022 19:15:32 +0000 Message-ID: Date: Sun, 3 Jul 2022 21:15:31 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220703181525.6488-1-pal@sandflow.com> From: Andreas Rheinhardt In-Reply-To: X-TMN: [bQePjLEZ20gCzymoBH9vbNnjN46gsUVA] X-ClientProxiedBy: AS9PR06CA0779.eurprd06.prod.outlook.com (2603:10a6:20b:484::34) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <71914c36-2271-7c6d-a4e7-38dc14279451@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c906c2b1-3620-453d-72ee-08da5d28663a X-MS-TrafficTypeDiagnostic: VI1PR0101MB2143:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K9z/1BbKrjlBJQ7ybnUKscER+tkPazn5O0vZQKLwFxzi+50SWl25EbVid8tYnLCEg9wq4P/AthUtppz2etJ6NcPhTvqfzmwwYYcsK+Rtvzd3eOO/leDF//Vb/6wn1KPJSPQsuXSbqspuHxioEqzgzmjLyZ94mpVqNGH+kg5w/Q7ELib1dAsTP6excIEp1v6kH32x4A5XaLmvvoO7DAsCxka3D/LI77d5VHQv2Dxp/GszNxiHOXbBaGz/B7W1bDdYH3hWWq6JjMyyk82hFAAmcc+w8dqGNuXLox1HzTrR6z95n4bQ8rXgrItopBI2q8HIAqvjAHfZOnXPe2rrg3RwDJEeWjMTVaCRQEd2zkTM8NJZ6s97DJuccOmOzvjw1ZXd1DJ+U9JrLRXnxaMexrvnZBxLJHWAFYZfIgJH3uxnYFR5xAAc8AkOZprO3D7rzl3gkC+IRMb72hqRREJqQYRGJSLNPqVfzDVCmOycG3MjVwnwfUQ89PwrQNobK4wwkRoEdy7ZLamuv8Ki+YbVeZwd2VPfCyzQgsiVeuQSNDGPjHWpXLqGvI49sRotJfqr67AzGVm/lDS9Fs4CCRE0GiBte+8V+kJFxzpAhcWh3O4FUE99+au2ea73jSRMF+3wNIRP/zOqCwsOLh4DbJHhbRM47Q== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDlZaE5jVFVONXVqMmZWdlhrci92SWNjZGxrMnFVcmo3b3VvRHRZaVY1QjBE?= =?utf-8?B?NHU3ekZiRy9JZjF6VVlPZ3NjN25KV0kyQWh5VUluZ3p3Vm92bHZncmpiMXh0?= =?utf-8?B?bStxaE1IbnVLeWVwUVZYRUJyY3h6anJBTEplZCtZSmY0OGJXU3kwQ2RxbGFj?= =?utf-8?B?REVPYnlTVlZOaGhlb3o3ekxrdk1iTTcvVVo4SjFNT2tiN21nZTE0ZlFobEtz?= =?utf-8?B?cXo5S3p4d1lvVUErbmNBTHp1NTNBdnpkUnQrclQ1M1FrQWJFcGtBblB1T1RY?= =?utf-8?B?Zjlna0RTYkx1aEFYbmhvQzd4L3BoeEZYT3Rhajd2NldleER1UXdXNXIzNSs4?= =?utf-8?B?dDlLWUp5bjNVOWxHaDEwMjlHL3ZWV1BMYjZ3MkRSbG1EeGd5bFhCcE9ybCts?= =?utf-8?B?U2trVjBzK0t2VmVndndNZFZXcUU0QVRDeVBBZ3JXTlZGR0M5TzRROUVpZTUy?= =?utf-8?B?aUYvQU90ZDdnb1NxWFJzNGo2ODl1SEMwdEc5cnRQL0tXbmVDK1VhZFNxbUlr?= =?utf-8?B?NUdldHpmN0dMZ1FkY0MwTS9pS2J2VWh4eW9DNGluaHBOeHEzSVZDWkZua2Ur?= =?utf-8?B?dmErR1BocnVhNWVBYlZPNGRYZGJWQ2lydVJveldDK3hoUzQ4NldzTFZnbFgv?= =?utf-8?B?WHdBQVJTcmtRako1SnlzWjVhWFN2cDlKdGp1Tkt2YllCdnl3b3NhK3YrcWI1?= =?utf-8?B?RXBnU1Zqa1lEdVZYTlUydkVFNFhWeDBpNWNONFNhanFiTy9iSWRhOWtNZlJw?= =?utf-8?B?ek5zRmNqanhnN0hzTkZaS3VxbmNxQ202UGdrblY5RmliOTZoZ1Bzcm95MmdY?= =?utf-8?B?ZU1CRlZuTnpWeXBWSzB5cWVzOVJCVUNYRFJKMHFNb1ZFZzVVZzFrZFRkTVB4?= =?utf-8?B?K1N5QTdROTU2OGVibnZKaVE3Y0RaVUF2V2V5Q0hXbm9mblk4N1RVaTB0d0Fh?= =?utf-8?B?MVEwb08yczFYTnpIWDlyN3VYMGxjbXB0T0t1OXZBTlFRekRteE01dzVQeW5y?= =?utf-8?B?QkxZeGtWd0tSVGUzSjU3K3E5bWlqK0ZUOGY0eFJkSnpWeGRJaUtlSVRjN1RZ?= =?utf-8?B?Tks3U0haQkNhK1ZkQi9SeDdPRkVCVjR3c0ZySU1wcTAwa2NROTh4Z2Q4WWgx?= =?utf-8?B?dEF6UWVwZHNnR0MwZXNjL1hWMk03VzQ5YTFTV0ZRREJDRTlMaTBxR25vc1pZ?= =?utf-8?B?eUdVb1NIUU5zeDNDNjR5NnQwNnBWdWdVWVRVby90Z2pyM3ZhZW44c3RET3VM?= =?utf-8?B?TTRHZGFZUmhQNUdhOWxnR1RWTE9TYkJLSDJQNVJsZWVqMjlVT2U5T2s2bUVN?= =?utf-8?B?SGw0Zkh0TGhXRllqV21YUnpPMmF3OGpLR0N1cHozNFREeVFySHhDSjBFUFdD?= =?utf-8?B?eEVxMFYzRjVvNVRFbzJwRmxOOHBuZE1YRnpIQk4vUExxaEhwOWV3VE9ad2dp?= =?utf-8?B?U3RmSHNrRSttSWgvY2h5RmFhUWxVK2hBeFNDUTZ0SlQ1VFg2cWJBUGwzbHdz?= =?utf-8?B?SzI4MEttc3BKTmV2U3V6aTNDNDNTSGpwOURzMXk1WDBtemxXMHEyeXpzZXFL?= =?utf-8?B?dDdwdW82aTRidFl0dUE1S2pQYjdWT2wzOHkwMFQwSDNZbzhON3JUZFc5b09l?= =?utf-8?B?MWczQmwxb0pMaUxvaFYrTWkzY1FMWUpTeUtycFdreDFUeDZPSnVWMC9GaGJU?= =?utf-8?B?Y1pTaGNlN2JCYmhpb1VjS2pTSU1IVkRBZkR1TTZ6d3c0S1B2N29SOTRXK1ZN?= =?utf-8?Q?8mES4h9jk4h6l7FvbM=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c906c2b1-3620-453d-72ee-08da5d28663a X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2022 19:15:32.4511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0101MB2143 Subject: Re: [FFmpeg-devel] [PATCH v1] avformat/imfdec: preserve stream information X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Pierre-Anthony Lemieux: > On Sun, Jul 3, 2022 at 11:28 AM Andreas Rheinhardt > wrote: >> >> pal@sandflow.com: >>> From: Pierre-Anthony Lemieux >>> >>> As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does not >>> currently preserve stream information such as language in the case of audio >>> streams. This patch is modeled on copy_stream_props() at avformat/concatdec.c. >>> >>> --- >>> libavformat/imfdec.c | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c >>> index 71dfb26958..7aa66a06bf 100644 >>> --- a/libavformat/imfdec.c >>> +++ b/libavformat/imfdec.c >>> @@ -580,11 +580,16 @@ static int set_context_streams_from_tracks(AVFormatContext *s) >>> return AVERROR(ENOMEM); >>> } >>> asset_stream->id = i; >>> + asset_stream->r_frame_rate = first_resource_stream->r_frame_rate; >>> + asset_stream->avg_frame_rate = first_resource_stream->avg_frame_rate; >>> + asset_stream->sample_aspect_ratio = first_resource_stream->sample_aspect_ratio; >>> ret = avcodec_parameters_copy(asset_stream->codecpar, first_resource_stream->codecpar); >>> if (ret < 0) { >>> av_log(s, AV_LOG_ERROR, "Could not copy stream parameters\n"); >>> return ret; >>> } >>> + av_dict_copy(&asset_stream->metadata, first_resource_stream->metadata, 0); >>> + ff_stream_side_data_copy(asset_stream, first_resource_stream); >>> avpriv_set_pts_info(asset_stream, >>> first_resource_stream->pts_wrap_bits, >>> first_resource_stream->time_base.num, >> >> Seems to me like one should use ff_stream_encode_params_copy here. Of >> course, it would have to be renamed and moved if used in a demuxer. > > Would copy_stream_props() in concatdec.c need to be refactored as well? > I often wondered about this. The problem with copy_stream_props is that it is not only called during read_header, but lateron as well, but e.g. the documentation of AVStream.side_data says that it is populated when the stream is created and not later. This issue does of course not exist in your case. > Note that, in the case of avformat/imfdec.c, AVStream::id is not > copied across, so ff_stream_encode_params_copy() would need to be > followed by asset_stream->id = i; > Yeah, I know. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".