From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2540640F60 for ; Fri, 13 May 2022 13:32:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5823768B3D8; Fri, 13 May 2022 16:32:43 +0300 (EEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-oln040092072032.outbound.protection.outlook.com [40.92.72.32]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D27D68B292 for ; Fri, 13 May 2022 16:32:37 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JbpnDS9shQzu5bhPJLbOuWnxzax5mhOpnMY0iafDvIwP4Z/DzbCq4LvCdVRrhw5A+JURcWSFe0YdQNI5RHWCJho553PisdZ8mFxor2Oxgl/G1jDNPO0M3SqYtp7Mhm/15rIM4aeH3ySrMXI3Dfqem1Mj0Nih2TaexG62jCMoPyW3mdfcqAQUiACtcljSJqiI4HRkH+Sy9vIjMcKzA56J/D9SGmhoRHl0zBieZgA2YRKg2tvaunMsWEEq1O6yL4lMrFMphCNNt4zVO1CyFp6YONUHtgdZ5zea43yoLUe47pVC22K0zXeiijP1SO5MBL6IKFs7pAba0K0eEgfpKvMaWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aGc4sy4Cp3iFX0glKgpcENMpY96DhzKG5daPlgxUsQI=; b=gvRH6Llptvd2F6S6c/zcStw5iY9dwgHGcB9JDmvVvEsBDDmeJWoTYQHvhsAyxBXEj53D423MN/U3w2sZNJwxg+0T30+zldY8Oqr6LDROka4Hjbjb+D/krUYKOSkZXyu3fuZqmImxRJao9YCKzR2sB3A4PP703tdryNwIj1h74wIo7M4EiZc/C0ZvnbWRGYF44Ar7OOE1uZi1I4c4tRQoFaH4YJNmxqcdHMpyCAz4p/B+eTvlI0Y9eVtvHTPc8QhHQI9EuXM8HT2WEWJ0ZfklzN1xZSQNRDDG6BE9KsLrsJQNJAqpb2uUuPmpRSS3RJ9uaaPXOiDv4eWoEEAyPqVrcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aGc4sy4Cp3iFX0glKgpcENMpY96DhzKG5daPlgxUsQI=; b=P31M2l4VU35/CpZlNyYtKCeR3APPnHPByl3loPC8k6yYIhDCMU2Hdlat/a/DQOTMMBlVaRr4Pf+E6MCk0rZJT3I6FdWFtMQYwFUo5XR32/U3r3OOEslaoxFJKYhzkZrp8wOJmYRBP4ELHSrUipOIxVywG+xoM2phh9qrIYtgCJ4V2zxZW5L9pCfXNE52blz464rGCHVIGrI8/OuudoHRlTvQey6ExH9HQzOq1b8hJW9Q7tlQTDijQDjcyyHjyLKnC/cY+t3/LvZ/oBT7pNaMtan7F76eLyvBGvaH1rrSBGAI6z5dsYcX3fDILxsaLtEuDx0qwDcQcNynWFAJe80AIA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by HE1PR01MB3866.eurprd01.prod.exchangelabs.com (2603:10a6:7:98::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.22; Fri, 13 May 2022 13:32:35 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%9]) with mapi id 15.20.5227.023; Fri, 13 May 2022 13:32:35 +0000 Message-ID: Date: Fri, 13 May 2022 15:32:32 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [d3QN6f4fsE4vTdvSEzMhuL3py9tM4Ra5] X-ClientProxiedBy: ZR0P278CA0180.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::7) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <55eb6a42-9efb-da8f-3296-9e7c08cea991@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97e2b356-53d3-4acf-d6bd-08da34e509ac X-MS-TrafficTypeDiagnostic: HE1PR01MB3866:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MChfN8Sng2L1aw1rvQoHYQzgdXzSHzTPP0gxCsCSXvqLguTaozRmiHgGHtGVH+7UCRA4ZWRCti+eI+q6hrw/vwkcN4MyclhlEZjTNz1DkroUgJWABabOgE9jJmBkhgW+GHrLft8/FBME7VFd9HH10cW4EvCY5mgVjQZ+v+nutQGFCnfUV+IVMc4fFtN80pgUPV7T4HlruLRA9/AtoX/5XxDdHh89qBLi/mIQkibdSbL/1REskACkFDCJ7i7oPGWJa6MDYfJRAImlefFt4EEir6r8z8ma/lBTqbepbX+GrxFbQx6EOYFFw2Ibn6IQXh+6XUyLGeObuK3BhbWM0ZtDslo3/EoY+AUsV7dIsBW0INo23hdH3JWvej6JxkrilSawO94Nvc0x6fQojn3i9nwUASIsaruKLT7OmcKGab2wGijyNTsghyId0cgCy9P90pscuTRKaApeIVA6Atp3dExkesf7oQdVSKv9MLI+UPJGRzD1R44BOmZA7ql5+Y5ZmInIRSvnyNQrIQ4Qhx5iPBFoHoY8N/ZScoOdbG6aQEAHTLmg8snAGAzD+is7CjUpwEoLqnkReOg3E+DG9p/IclvcUPJxPqvCzHO91yUBtyXPsi8cstY4eedVW8NOeGRtO8r0okpGkHpx1k4sNDzGFFg4mn5Y4DCYq3DQhfrBog/TE58= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NitLMWxtMXV2YjRWeFY1Mlcxako0ay9ZWTlubzN0Z3VpQnBOTk1HcmVwTVIz?= =?utf-8?B?VjM0Mk5MaFJFNEtFQm5GVkg3bkMxU0NJQjZVUTlORmZnYTdyc3NiSGdRMFNJ?= =?utf-8?B?YWo1WVNIckFrTmJuZHdmb0R5ZHEvenFucDJWUVJtVTdpcUUzREcvRUVYNXgw?= =?utf-8?B?QmV2UlpCUEcvM1lYNmlmM0pUYjVJSFpyTnRuQ1RPR05Ba2hFTXR1QnhHMlJD?= =?utf-8?B?VnBYSElkYkUyazd0NGZ0MGtGVXlxeUJDRE9nanJUcXhtNEVoU1RYV1I5V29t?= =?utf-8?B?L3JHVVpxdFg0RzZQOWFRbHJNVUt5RFNHdU8ycm85NDRPZmdicDhDcmJzUVRv?= =?utf-8?B?clVGM3ZyT2RsYnJHUEJNWEd6b215YUwycHk1dUNuZWFxcis3cjJLR3FPcGFW?= =?utf-8?B?aCtzZTVuc24yTldoZFVtYXBkRlZRYWFzTUVPZnYyUFc2KzZsdk5ERFowTVhB?= =?utf-8?B?UlR2R0dGU2craFFrSkRWYzJrTmgzRXJFM3czNCtrdzg1eVkzRVllVHNTNUtN?= =?utf-8?B?eHZBMnllc1dKNWFNNW5iNXl6TTVIS2R2SU1YWkxmUmZ2UTR0azN3ZGdsTTlM?= =?utf-8?B?RGhyUnJiOFpEcTUwRWQxMFRjNFBBekZrVkFmOSt0NHVueXV0V2J0T3p5VG83?= =?utf-8?B?bDcxVzBaU2ZOdStwNURvVkZoZnA4QmhMRE8xMlQvNVRkbnRaODRsdnNtL1Nm?= =?utf-8?B?NTk2LzRJQUpSK2dXU1F4UXEwTVF4Ylg4eFBabU9ZTzFIRWlSVEt6OFFYUzJO?= =?utf-8?B?cmR1c1NMV0ZFN1dXbWZ2cStmank2MUY0RmtHcTREa1N1clA3VzV6SzNhQzYz?= =?utf-8?B?V3NoRmVOUzZrTmZEVE5ma09HUHNIRW9zU1UreVdxTnpBcDBTUFcyQlRYMHho?= =?utf-8?B?VmxSNWVWQmZxT1pLZjNFaSs3OWorSVBnK0ViU08zYmRwbDdISGgrMGNrd1hz?= =?utf-8?B?V25VSVB6ZW90cytWRmRtRGhseC9VNmI2M0NaT1pnbm9Ia2pXZUwzU3FZRVJN?= =?utf-8?B?YkIrbGUrYzBRUzQwSkJKVEQ5bUZRQ2lqaUlkQ3dwMEpBQ0xnMGpXcHgyZmsz?= =?utf-8?B?cnpvWjFvSUZITUFvM1Z2NkFHbGx1NXRzV25tTC96TzRuSDE1d21ZLzkyU1Qx?= =?utf-8?B?TFNWcTFRYVlUdVlycDlZMHd5T2hwREN6UHVJbkdtVkRwTmtyb2JQTXlGdm5T?= =?utf-8?B?emRTa2xLMm9XaE00dVZYU09QempnNmxEQ2s2OGFwajBTYVcvVHh3cE5WV1p5?= =?utf-8?B?aktNVGFLbTVTdktzek5ORldnWUJyUmdUclMrUDdpY3orVDhqYWhSZnMxeTNr?= =?utf-8?B?VVNnRy82YXlVenJHSkV1R2dZSkJWeU1TM3lFM1M2NHcxRU1rQUJHT3BWMUpX?= =?utf-8?B?Q2tNOXc4Y0VVT2V2ZU91c29Ld1NzaGt3RmFXdVdpUTQ5Uno5VnkvVHlxU0FO?= =?utf-8?B?enRSWFlBTHJTTTdnb0NPMVFIZWZJb1BPaFRqQTY1SllnL2paOWxRclkwMlRL?= =?utf-8?B?dmpGVytnM00rOVphVEZSYWdqaTRwbkt2SHZ2Tm81TklJbEFHRTVScGQvY3p3?= =?utf-8?B?UHFkU3BJQVh0Mk0wTU91Wmx6Y3Z5K2ErUDhORzhhVDRLSXc1ZTV2YjJlRVcz?= =?utf-8?B?MjVaaUpoaE5vZW9Xd2h6aGtOM3B4dExaUWNqQmhWL2tHYlRWVWplbkFDYWJH?= =?utf-8?B?a2svd25VdUdiOGoyRUp4YXF1SUQxdUI5S3pKM0Zub0RCSHhQTFlQeHJZcHRP?= =?utf-8?B?Wk1rV0QwcFhjQzNjK1hYQkFPcTVXT21aTUM4QmtMNDFjVFZyczdHNi9Wc2Iz?= =?utf-8?B?ckdRUFUrSXRqWUVKVGJEZWZjTjd0TWx4MHI0SnRTNGx4VWFPeVd6azFwSkdB?= =?utf-8?B?YWlkMmI3QnE0ZERhZHZMcGt3ZlRFWnJRd1BtNnBEVUxUMCs5QlNWVGpUUm8z?= =?utf-8?B?SkF2dFFSbXhQRlcrQi9VekJLZWQvbFRES3JrcFpIMHUwK2FtUGt4MzJVVGl3?= =?utf-8?B?TTdEdEEzYmV3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97e2b356-53d3-4acf-d6bd-08da34e509ac X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 13:32:34.9885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR01MB3866 Subject: Re: [FFmpeg-devel] [PATCH] fftools/opt_common: add missing include of avf/version.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: softworkz: > From: softworkz > > required for PRINT_LIB_INFO(avfilter... > > Signed-off-by: softworkz > --- > fftools/opt_common: add missing include of avf/version.h > > MSVC compiler complains without this include > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-27%2Fsoftworkz%2Fsubmit_version_include-v1 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-27/softworkz/submit_version_include-v1 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/27 > > fftools/opt_common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > index c303db4d09..5a5e35bd7f 100644 > --- a/fftools/opt_common.c > +++ b/fftools/opt_common.c > @@ -51,6 +51,8 @@ > #include "libavdevice/avdevice.h" > #include "libavdevice/version.h" > > +#include "libavfilter/version.h" > + > #include "libswscale/swscale.h" > #include "libswscale/version.h" > > > base-commit: d2d8b9b972ba2df6b2a2ebe29f5307cbb7a69c33 What does "complain" here mean? Compilation failure? It should already be included via opt_common.h->cmdutils.h->avfilter.h->lavfi/version.h. The latter inclusion relies on HAVE_AV_CONFIG_H to not be defined. It should only be defined for the libraries, not fftools, so if it is defined for you for this file your setup is wrong. That being said it is nevertheless good to include this and avfilter.h directly. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".