From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 45587436DC for ; Wed, 22 Jun 2022 08:27:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 36F3D68B6C3; Wed, 22 Jun 2022 11:27:41 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073025.outbound.protection.outlook.com [40.92.73.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5F75668B308 for ; Wed, 22 Jun 2022 11:27:34 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4h+ycb01g+ro/DRkbcSd0NHnlNdBqXLhdxoCzkd3S4bKUao1+VsEnJOyuG5IPMsyW8h//LzDClSOR5rDxHv8rVfwRAPoF7noUfVzhY4LItLfyfjZtolDlBPPOAsTnYmq6IPdATeVOWFRrKwEPMyAiA3UoUEMv4ZCFDubYX/PGPqvhHDfnZ6YSOizCupAT30+n2nexxPz0QG7tkvldNMpCaJbO2URX3vRxxgTRCoGs2zKK1buRoVcUp9SHBeKaf2rml/EH/Af/SscuBojSF2cvhs2+XwYUUm1LU+g35NcQcmbgcLChUGqybFRS/u7IOzGvrNdInAREM51fvwx8xhGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NtGBno6mVMoPxF7E+c0pzJXuJ298mfSpDLOr1+c+LWs=; b=ZH4pGBkhUQm+fEpqi7MHGMfGhKUDIZzBQNv9cr+/ox/OxIBhvZH+zs+r9SHVDh1M4CmvSYHo3E1b7Bx3FWzH0UUKvM3uFAC8+zpI3Cr+sUlnBNBjBI1r83kEZQWf166l5EmVDItK9X2si0mM+SDi3PmvgpQpn28FDXGJ7l9kRJMCEpqYvLpXMlpMGgLDYG4/m5oRoyYUo28eK+ZFTTv4LYKapqHDjJz0vgUmtfpHGjJDVRVFOx0MoAfXNwS1gEiOffkY/t2jYOeZ08C1IQBvEBkJIqFKFYvYgY8e05Jy6KSaNqt68fsF0gWODjwGZHoiXI8U85Q6tQedXlhCPSpawQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NtGBno6mVMoPxF7E+c0pzJXuJ298mfSpDLOr1+c+LWs=; b=R4hC/6jDKplXOYBd11owHnTuFUKgxtQPdsxtUund+Ql2AyPCkFdIurlz7bmGgfrRfIz331814azm6abC5/44x9jiA/seeu8dxiz6XTxXlUtgrAGkunaPR6LO3T+yx9M7y3KcA5C8VuAQ4Ro9SjwldfXUYyxyR9ApmZId8VAInphFGnGbY1jQdxd2+niy7Bhdaw1xSA+NaXn/G/3acpPPWacB1YaDRmLwXP4x3mV0mzbkK3PAx5mPXEV2t4jJkFWkd0ISbwI6I5Nc3BtIvrBzj4B/Ut2KSD4F15aCI3C4qPe/fG4KkFqqR1PY1O2cxLMpO24z3H0Gc4AlGdDh9V7ZDw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR01MB5799.eurprd01.prod.exchangelabs.com (2603:10a6:20b:ff::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Wed, 22 Jun 2022 08:27:32 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.022; Wed, 22 Jun 2022 08:27:32 +0000 Message-ID: Date: Wed, 22 Jun 2022 10:27:30 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220616195534.5278-1-anton@khirnov.net> <20220616195534.5278-24-anton@khirnov.net> <165546277831.13099.11304958668330237723@lain> From: Andreas Rheinhardt In-Reply-To: <165546277831.13099.11304958668330237723@lain> X-TMN: [rWUVtYGhZ+rzDzogNiH++egAxh+NG3Z6] X-ClientProxiedBy: AS8P250CA0001.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::6) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <098c61b9-d8c2-333b-72ce-12aa60e9bddc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6671fbc6-f1b8-4d62-6b43-08da54290d40 X-MS-TrafficTypeDiagnostic: AM6PR01MB5799:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aWjnuVDRIhyq9ASHyL+7H0f25gWiuajA1sVQBiqlP5H0+N8TPMSzowgexW0OERORhyc/mxWvxpcIapXpfpVHny/ExmciDZNYQ38XO5FSWhyehsmS8bFijOaKJ21ISL+4OWn6Ots6f7eGfHhH7EEavKXZ3vjSBFeg+qsnuLYL37b6pYkEpgrGW5+sYbAMC6oVReEta7P2UPiA86fJ9CIXVsbgLkaLlrsuurBfZRKf3oNONHWsKnwcFxv1fAtFdfH/6tkmXmEgnJp8CcCwZDjgK6KD+Isa0YP2zyV9wHtVRSMJ0o7/ITT92D3+nY8DccSf9IAIxns+SUZoZ2+EjpF5VKXb9ihkebVTQS49xEuwZX87ftC3hRWgIxXdYI8r2zYmMbPQ1kmTCkawNlIhtVPdfO0JxWjBsmoNTA4iL+Fam3245q5RT45bKRSN8yIYzjppCK3Gmz2FfTLd8T/0Mfpvqlq+xZxZypINsTQJdY3nAzp/iDbh1jGHe2s+wkX2BzsfhY0+3z7BBnNd5oNpvtUYzzy5pCeSN1b7zIH6QUjznlREyejuwFiVQM19I9np+5ulySPJ88LaLxLaEG52+NRr2w1GPoCvJlvii3Iw44FfpYfF0yZndUA0gdgA6PDawQ6Phj/x/i1BaS2ETuOSVCmLvw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0Y3TFFNeW1CL0xoSllGOXJuaHZmQnZRZ2NzOHo2TkRYd1dDcGxtQ0NycXRo?= =?utf-8?B?V0FUeHlUUVFwVVpxbm9LZXN0NWdxZEFvQnlHY09JNzduaDAvTnlaZkhOVVpW?= =?utf-8?B?REJMbDF1NXQ4am5PcW5Rd1ZXWHZSZ2l4b25QbWRaNUtpdnFVWUsrWDBOUXl6?= =?utf-8?B?bzdIa2MyQzlhRmdvSjV6VnJFNnpWY3p0U0dIOGt0SGFKSENTQXArdkxQZE1j?= =?utf-8?B?YUxSSW01UmVEcUtlNnpYRk9TUXBmRXVyYUMxWkNraURuM1RYZHFmZTJSMGhL?= =?utf-8?B?cEhiUTlxTTFpenFSdUFBYnhrTGdMTnZ4bzFwUjl6Vk5QNEdJWkNWTDlUeFJW?= =?utf-8?B?d0k5d2tzdVd2Rm4vMElpTTFpcVlycE9lcEZYb3VKRTNmZ1lzSlZ6bHZnbDFi?= =?utf-8?B?MUN1OWlpWVI5TmdlbFVxUVBvL1NLemhKc212ZDhBRERMWDZhZ0w4NUVLenVj?= =?utf-8?B?dzFad0pQaEFobVRpVyswcHNVMUxrcUp4c3FTOW50N0JoQ2Fsd2VGVU50THpa?= =?utf-8?B?VVRYSWsrN2JxamI2WTY0MW1hbWJmNVpOcUROdGtJSE9mUStScFNkSGl3NVQ4?= =?utf-8?B?eDNoWCtEZ3VsQlRRZFhlS05OWkd2cENKMElMblArT1pZUVpHODJxTlJBWVRV?= =?utf-8?B?UGpHczQraDdSaTNCUHZyOC8wYnpqNVBGbVdFV0VrUHdwcGtUU3huTGRjdmhM?= =?utf-8?B?SjlUc0FoOVhWWjM1bTFhaVBUSEJ4eERmcVNRVFJObVAzdUErdDk3eEswNG9s?= =?utf-8?B?WlNkdWs3QWVEOWMzVSt1UmhZQW1iT0JwVkxXUk40ckFkcEhnNXcvQXl6VTdF?= =?utf-8?B?RW5WZGJ2SlRhKzByazJwZ1E4S2tEcGJUSTcxTUpIb0xFQU1xdy9yWDdCTGgv?= =?utf-8?B?TnBxdWRpZmZwYVgyUzRCOGd5cUdHN1huV0Vjd0ZuWmV6VkJtb0wrR293NFpo?= =?utf-8?B?cnRqazBsVUsxUUxMd0tKMVg0Q0ZtWDQ5Ukt3NjVEZGk3ZThQb2o4UnA1SFM2?= =?utf-8?B?cG5jVXJQZHRSUHpZMUFYMlQvT0U1ZEZOQ2d0SmpXaU1IVm1kOTE0aExQL3hP?= =?utf-8?B?ZThBbXlEYXNyUlZNQ29Nc0lXczd6TVRPNkxZMnU4VkdFR1hZaEVCYVZ4clJF?= =?utf-8?B?cjVFbWYvVnAxVVNuVDVGc3FaMzlSUXp0KzJWbCtLbmFSeFgwTmt1bzhyMFAv?= =?utf-8?B?TnFyWGN1RFk5ajhDaTRKeTZEOC9wUmFNeXM1N1h1cm81YmNTVnNIZDRvVzhU?= =?utf-8?B?K1NQQjQrMmhDVExlMlN2OXlQa0toUmtBbnpzYkVFY3NMd1pZa0RTeDhIOEpB?= =?utf-8?B?SEdZbFJ1dG1udzgydnZhVXJYV2w2QjkrRHBxaWh5VjY1ZmViL2tIdFFMQzA4?= =?utf-8?B?Wm5RTS9HMGRYcUFNRVJEOUdGdjdlaUVpa3hGYjJtU25KQW5lQ0V4UWUzVEZp?= =?utf-8?B?d0h5RWtFL2haYnRPZHFaOWtyQXlkWEFMMTNaeGhvNkpMZlBsMG1FS2dYZG5R?= =?utf-8?B?d1NldVg2aEhmMDYwWE5RZ0cyWjFUeFYvS2E2NjJIcTM2OUJhT05zZy9rZGxB?= =?utf-8?B?R094N2FhY2hhdGhseFU0RkY2UjJjWWVwazc5N3B4MDNQMDd1ZDR6VUlpaDY2?= =?utf-8?B?cWlOeVlwVWZXZUVtUUNOOXhFekNLV3NzMzFBM3BKNjhtUGs4eStLZVBWWk9X?= =?utf-8?B?WjFMU2wyUzFYVkxyZlNYOEJWV1NvU0FqeEl4U1hZUnIwV3lKV0xWUGJPSHk3?= =?utf-8?B?Sk9UQnYvdExLMUFEaHZxVk1GRVVBblNZTW91QVpjN29BSjlYVnBjOERmbVRs?= =?utf-8?B?YkVkcmlkV0JuYnplTHJvQktoUi90dVJKVjdNOVVCUDREcWl4aXRJOUdmZEZD?= =?utf-8?B?aUNVdXpqQkUzOEI3em9oekZoYlkxelBLSXFkUXJZVXZ4VjFpNVJhRXIrS25X?= =?utf-8?B?K3RlMldWU29OKzJodnBZYW00dDJDYUhna2llTXZIZk9ReXAzNDhaWXlkRUJl?= =?utf-8?B?L01WS0NQdzJ3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6671fbc6-f1b8-4d62-6b43-08da54290d40 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2022 08:27:32.3439 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB5799 Subject: Re: [FFmpeg-devel] [PATCH 24/35] fftools/ffmpeg: use the sync queues to handle -frames X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2022-06-16 22:33:46) >> Anton Khirnov: >>> Same issues apply to it as to -shortest. >>> >>> Changes the results of the following tests: >>> - matroska-flac-extradata-update >>> The test reencodes two input FLAC streams into three output FLAC >>> streams. The last output stream is limited to 8 frames. The current >>> code results in the first two output streams having 12 frames, after >>> this commit all three streams have 8 frames and are the same length. >>> This new result is better, since it is predictable. >> >> The point of the test was that only one stream is limited so that one >> can see the extradata update directly in the test result: The unlimited >> streams have a different extradata than the limited stream (because said >> extradata contains an md5 of the decoded data). So it is expected that >> the extradata hashes of the first two streams coincide and differ from >> the hash of the last stream. > > Right, but my point is that the amount of data that ends up in those > unlimited streams is largely an accident of how the code happens to > work currently and is not guaranteed by anything. > The documentation of frames reads: "-frames[:stream_specifier] framecount (output,per-stream) Stop writing to the stream after framecount frames." It does not say that the other streams end after one stream has reached its framecount. So it is guaranteed by the documentation that the other streams don't end prematurely. (Why do you think that this is an accident?) > Are you suggesting any specific changes to the test or the patch? E.g. > the atrim filter could be used to replicate previous behaviour if you'd > like to keep it. > >> (The current test results btw show an imperfection: The extradata of the >> last stream is not updated, as the encoder is not flushed (or the flush >> packet does not arrive at the muxer). Fixing this (as seems to be the >> case) is good.) > > Correct - frame-limiting is now done before sending frames to the > encoder, so all packets, including the one from flushing the encoder, > get to the muxer. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".