From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 156724364F for ; Mon, 20 Jun 2022 11:17:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A998168B5C6; Mon, 20 Jun 2022 14:17:05 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073094.outbound.protection.outlook.com [40.92.73.94]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4564868B44E for ; Mon, 20 Jun 2022 14:16:59 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWkB5rKt+ms+fLA+2NHcOFaqoqVEc5Bbb/02N4mwcAF/Snpeno1VQOw1VZaVdsIf9bx+UFrhcmCXj/BcS6x0MbC+xnBQzT+4qRfoM2yZGHKDzOvO7ZA0ONdle4QcgkexmOqAgOl2hiT26pK1E9KExrUpf66AMsn4x0QSkHUUwM0Dydk1TpvZ+Gf8k0ZGaIuYHqftVBRsX/TFrcSMl9LSKKA2LWLib5P+LAxPgLHGgRP2D7o+B9kSf6vYTVyJkSbrvuKQtxOlFGBsgx51xR5oTTFJGtOlNW65D4VFds5bFz+NfHnyVtmaHZncTOrIenNKo5uiv4wkSya1oKYvv3UWsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hgiKg2qicoA7dCummrD4UJUL0jM2zoNoTQC2w8R41oA=; b=UT4fmHccHkI3BgbXsuZkefXHElQUiSiH/h+i3SSVeaZAdw+eMi6oF6fPLzwqnKagrGyCPatM4rEFJT8m9PGzKVMBzEuW8I8PraSQmwug4GIx+E44Hlygosop6pYNkZlrE2Axjiyb7VNBLanjUshE1ZD7qrzJ6b5ycZE0ScD7F/tsJ4ezWIVZ+jukdRk6BIhP0ktrB4CXnWYzbuCLGf3+qtW3Dl1NkH7QdD4xqTGAWIKUkaWYEWkN3kqtUb4BrzU561ayzLfqd0Tup7UCXx2rJfIT4ld02x2UP6Zs/sh0H66FQMpV8JOsczkaQfo5MepTTdn6fosop++F992K2dJCIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hgiKg2qicoA7dCummrD4UJUL0jM2zoNoTQC2w8R41oA=; b=EzGtSW8TBf6PwZ1wNNctZb4iTSak7Aq98Rs78OSXC5Guj8jsKZURAyz727jcJ65kqeUfcEDq1Ld46OMQeKAmH7igQqs+mhnfC2bLwivqHJLwfJUu+VUaTOmJ/9UNpqZqAt/skeMh2LBpBi7DkZRoKprUJUL4HgSqaNEhoEkWb/xaQnATWkPi0FMqMVve5jNBTRVl7vwzICMrd63557T4+pWanQFezT9UUDytQ2RZneEMExaZdY4cSIit1gpJeoh3KwOnPisbcTps12NaRgSJ0WIbgqo0F4X9qXcflKXoJnGcCxLWNNyzGpNA9zByauhonFhZd0/hrCKuAoK7kWwoVA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM0PR01MB5602.eurprd01.prod.exchangelabs.com (2603:10a6:208:177::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.13; Mon, 20 Jun 2022 11:16:56 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.021; Mon, 20 Jun 2022 11:16:56 +0000 Message-ID: Date: Mon, 20 Jun 2022 13:16:54 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [LYmfgz1mpSQWNGGTB+BRpzWco5TNKKaK] X-ClientProxiedBy: AM6PR0502CA0056.eurprd05.prod.outlook.com (2603:10a6:20b:56::33) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <7a339cd9-b563-e2fb-e2fa-a530b7e2b77c@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28787a2e-2229-44f1-b927-08da52ae6292 X-MS-TrafficTypeDiagnostic: AM0PR01MB5602:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3RJXkxmEn8DD0GTsaMPvVYcXAyWyyPQEcQCycW8iysLvZn68KTUoAy24tBpO9D0q7UAAVkM94Zd7KTUCwMoeCS1Mg36w5NZjVXffarM0PH2odJNQMywRWv+WoQXbT9oLmmW8qaA/Ux+voP0FhbMTNHlO6KO61rYgqUBNZX5jnz03H7CaFObt+1G+v8YjJKhiahYpHDtAd6Fra3NyCf74ZV2TvdkVX9SRbB6vJvAwRXYgYSkCLlmf0A7JIGXAsIYfeMtISugUs05UA690zL+y7MbX5IFzs0SFz9zAttLkMtB17Db2sK9D0FbO4MWsi2SXcJ2HAYt+isir38PWtZAL+cmboNnJ+bY3Y/gAAFCaN7qzLl9m3D5d5Wn0q6kHXq1d5UjkzaiZUTcSwg36ryexa3zkP4NmdXN41vC9ugzLO+s4i++DstMNkoEB+M1cC93J3oqM4j2tWadSWvhQdDWDVjJoRTRWkFZr71cj+81VK+orNUrHGrEI7aRZCtdJDLZSzcl7eH7NbCjYQsJ8JIx/FHrMQbVKI0jsIz28Fwz+IdzBILGTyXiyDfSStq6S2BR244dHb+GUGHaIW+92qWoy63HxGcK1V9bxj1fkqrISzQrrwYIHemAULqT/gDRpJgkhFebK3l8yxcWfbsZVIlCwgUISBXH/LFEh0/zd9z8X6VY= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGJhUDdFUUZQT1pmb2JNb0RGL2JzM3BvbklLZ1V5NXNrdzFETEUrY0NrdmE4?= =?utf-8?B?SFpPSnJGQU1hYS9qdWZNRVpSL0ZqOHlqK3BWa1B5YkJpcTd0M003aUZrQTlj?= =?utf-8?B?QkQzR2FYOURnN0JRcUcvS3NHSFg2cXMweU43VG1Ec2h2WXpUTURLOThFMk0z?= =?utf-8?B?M3FQMFQrNm5YWUhTWWtObmR4TUpINDM1ekxHY0w1WVNicytEQkhMc0hmelcz?= =?utf-8?B?dHIrUHoxTk1SVm1GNkJSU3VVcnN2aldTMXlBMGdjb0gycG9xMXJNNE05N3ps?= =?utf-8?B?eFc2SkNSWXpsMGZ5eGtOcElodTlKR1B4K0plMythVkZNcHJYS29TZ2lpQ2Vs?= =?utf-8?B?d0RTay9QamNjMG16R01JaDdLQ0Q1UFFKLzBGSUNyOTN4V29LakZnbFkvQWJR?= =?utf-8?B?TnBFY0JRZFNUQ29OWDVwY1hvK1N3OEZKNVNlTU9odmtJZVNoVG9UZjFxeDFl?= =?utf-8?B?bFBOUVRoWVFwYU5Zc2pyR21UM1dTdUVxMU9VOEZCUGo0dm1hSU1VcXExeXFy?= =?utf-8?B?azF5b1VhUHlhYmwwU0Q4MjdORFEvOGFDUTh6R0lHNWFkWXVJYnlhRVIvN3Y5?= =?utf-8?B?Mjllc3ErOGNaTmdyVm9LK3g4ZjRnZCtGazhJMGgwS2tOa3gyaktqMG93YzA4?= =?utf-8?B?cE5pUFNVOFl6UE5FajV2V3dPd2JTTlZpU3grSlliSFVuNkp5TFBWUWdHOWdo?= =?utf-8?B?TFpZSDJhQlZ6cm4zeDRNRTk0NGdmcWF3cDI2UDBsVjI4VTZmaWFtUlFwYm9X?= =?utf-8?B?YStoTi9lL0RKTGxxVy9KZno1RTVnS0xaWXl2MXVCbEFNa0IzVi9sUWs4MlFR?= =?utf-8?B?V01mWGFYUHpnSHBuSHZpNVErWHdxVHZWY05HcFJiSG5HUVNtcjZBamlXcUpo?= =?utf-8?B?WFJGbjFUcFJFSk1WWVhIZ1ZLZEZiNmIvamtDczdzazNvSE9ZT1dBK0tvV3RW?= =?utf-8?B?clp1K0RRQkxFbzkxRmtmTDZNL3kveUpGbWlHUUY3K0loclVTSVZjcjM4YmZU?= =?utf-8?B?UE9ldDZKdWFYVDN5SFpSWitiZ0d1c2xjNUpKWC81U2FablVVblRxRkJFbTYy?= =?utf-8?B?ZFF3TG5YdEFtYnQzWS9HT3VZRjV3QkpyQ2lMNzREd001RHhNRkVTUFRjU1N4?= =?utf-8?B?T0VxL2M2QTdzVWs2Ni9xQzI1WlRxQi95anc0UHBHZHZmRTFPSkZrTlVucjZy?= =?utf-8?B?dTJ4c0FIZk9SK2hzMVpKYjNvSjR3cnVRRVdIOTExMjBIUDd0VGpHOFRqSVdE?= =?utf-8?B?dFVFZkJ3RGZyWjh4MThMbjdiUmxuc3h5V3plOFJQYjF3SFUwclU0Y2txcDFt?= =?utf-8?B?MzhYVWE0U2lrVFczVS9TSlB5bW90bEtHN1lNa09JL1ZGZXY1Z1k0Ny9ocjlz?= =?utf-8?B?Q0VPQ1B4RjJWWDJnK3JqZzEvcUVIL1hnZ1RNVlp1N2xMYTd4MXZsRFNYdDk3?= =?utf-8?B?em5PNWRscmsycFA5cVd6RnUvUTNGWXREcXhTUlZ4UGRRYUtncmJyL2R3Q0VR?= =?utf-8?B?YjBNWmdRMnJ0cEZRVEhqeFNJM2gzK053cmUvU2laRlB6blo3Y2JDRzZPSHpQ?= =?utf-8?B?NXhrMGV5MG94MDRCV0k5UnkwWWNYU1hkenZZS215QkRjMlh5M2RTbTVBMml4?= =?utf-8?B?QlpFSXdiSXc0cXN1WFhXMXorcjdKVUpFelA0czJSYkFvVlllckEwdUJVTjFQ?= =?utf-8?B?eDRUWDJDWjJQbmI5VzZMQ2dEdGJFLzVrZW01cThnYjBsVnNxRFlCaWFLWU1X?= =?utf-8?B?WmtKR1NsTm5xdExqUWFnL1YrQTl6RjdSSWxseW1meTZvUVN0N2lDZTgyZmdt?= =?utf-8?B?OEpjbkFLY1FTQWFKOVBHZGxQSmtQZmdKdHFpQkxtaVdBclVEYlJkQmk2NlRy?= =?utf-8?B?R0l1dlZvb0JSWSswTVZ3RzU5dUkxQTREZ2tDNk4vNXNrUnBPZ3pCK2NJRDBR?= =?utf-8?B?cnd5N00wU3NMYi9KZ0lpbUw0cjNxbW5rR25DNXdObzR1b0REZjUzeCtmd0xs?= =?utf-8?B?T1FHQUQ5dTN3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28787a2e-2229-44f1-b927-08da52ae6292 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 11:16:56.1822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR01MB5602 Subject: Re: [FFmpeg-devel] [PATCH 00/41] Stop including superseded functions for x64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Andreas Rheinhardt: >> x64 requires MMX, MMXEXT, SSE and SSE2; yet there is no shortage >> of code like the following: >> >> if (EXTERNAL_MMX(cpu_flags)) { >> c->ssd_int8_vs_int16 = ff_ssd_int8_vs_int16_mmx; >> } >> if (EXTERNAL_SSE2(cpu_flags)) { >> c->ssd_int8_vs_int16 = ff_ssd_int8_vs_int16_sse2; >> } >> >> Given that SSE2 is always present on x64, the only way >> for the mmx version to be chosen in the above example >> is if SSE2 has been disabled either at compile-time >> or at runtime, i.e. it is never used unless one shoots >> oneself in the foot. >> This patchset therefore disables such functions for x64 >> by #if'ing them away; x86 has not been affected. This >> saves about 140KB. >> >> (Another way to handle this would be to remove every function >> that would be overridden if one had a processor capable of >> MMX, MMXEXT, SSE and SSE2. x86 processors not fulfilling >> this requirement (which are truely ancient nowadays) >> would still work, but would be slower, i.e. they would be treated >> as second-class citizens. This would have the advantage of >> avoiding #ifs and would lighten x86 binaries of code that is >> not used at all by the overwhelming majority of users. >> I'll update this patchset if it is preferred to do it that way.) >> > > I have now implemented this other way mentioned above (i.e. removing > stuff that is overridden if SSE2 is available altogether also for > x86-32); the result can be seen here: > https://github.com/mkver/FFmpeg/commits/mmx2 > I prefer this to the old version because of the reduced complexity which > dwarfs the potential to slow down some ancient systems a bit (if these > ancient systems use an up-to-date FFmpeg which is quite unlikely). > Furthermore, some of the MMX scale functions that are removed are > buggy/not bixexact. See > https://github.com/mkver/FFmpeg/commit/c5513ad962100040601b5eba0042692a740ac50a > (or shall I post these patches?) > Is anyone against this removal? > Given that no one was against removing these old functions, but several people (on IRC) supported the idea I will go ahead and do it. I will apply https://github.com/mkver/FFmpeg/commits/mmx3 (an updated and extended version of the branch linked to above) in two days unless there are objections. (I can also send this to the mailing list if desired.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".