From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 733D7437A1 for ; Tue, 28 Jun 2022 11:49:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D0C7468B93B; Tue, 28 Jun 2022 14:49:21 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073015.outbound.protection.outlook.com [40.92.73.15]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B8F968B814 for ; Tue, 28 Jun 2022 14:49:15 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6Bu9ZzyBqsXsu2ao79JzsFkyU5Uve5SN25TMG040p0Ny7oCXeWFjEcdRKvxZR3SBlGihrlmfscnogauXnn6P68wGKPWtQCKQUVoBKKgTc0mXAuDu5mTqGaUBwe912sgydk7f5xKLjxRJWy9ofjg3xrDnVK1lqCIHmsgnME5QtIVLZrN6ZF1tXpiAWXNYsslNJT6txUrKhj3041Kd8n4xLsABl7atlsxpGgqikGU+tgr0NWYgt62ALeLOvLI+C+m9p9vH6iVFr3Yo3O8KCG598dqjONZ9luqIvvX4wwg8jJKfsIqdc7IadUpOUOcUSJTUR9l8cd46N3v7lMxU0je8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkQHVy8GcJ24i0lYwGM8zN2cist8VasCSVigeN84lgo=; b=mAQiXGvBHNISj4Nfu1r69y1agmNBpFyaYRKbkxo1d+vcw0Ty4pkLYVFbAE59IT8ZU5ewkh6ZVN5vNU9oV1QtJnB4uSPhwkO8LK7CzcpuJqTKSkticGdEBOLXjniVIaGvnJQ9OfJKH8tPu/OaiNVQMuqSRRpoGKytxrSHqOC7n2dGgAWqqSpfiPZuw+B5Iw8d8KScmOactiAX6R1mQ5mXUTlctIugygdv3QvOzUG8355LK6U9vJ2ygy3wYlNRSHWvU2z6/+1wzd5nxjU2wBNqXFefowRfRG9ZkJ2AW/1mPuGXuAazqlDpCd6bkmTo8g/bYEBh/JmVJtFgsNxjCuEI/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GkQHVy8GcJ24i0lYwGM8zN2cist8VasCSVigeN84lgo=; b=pT57sBnONHRQ3k1mrzcHOXwON+IkRLDeJjYkeJXAmIScL22baEJamefveidtwioV9PfVpy5fdCULg5RKsHtqDL4PlvC9YOZPEl7aeDW1eFb+PBvQV9SKF8W7f7OzWhilcUuCwTQQ53NYOR1A+g13q5vcq6WsIi+fYEXvVqQwh8JA20DVREE7yXhvSoqdfL4soI2NF4FJACI+Y4/kckF3ehwvjmLdOOElqgKGoaNOQDN2w9F+rqrhjFAlghzd6ysOZxZc7QI83tNo+6KypIy6QFvz6ge4Zvw+ZB5Jbihv5vZRxtLTr1fWiJs3BnmMCQztYvo8DvMkLl0XBC6vEjuwGw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR0102MB3541.eurprd01.prod.exchangelabs.com (2603:10a6:209:19::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Tue, 28 Jun 2022 11:49:13 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 11:49:13 +0000 Message-ID: Date: Tue, 28 Jun 2022 13:49:12 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220628114432.52656-1-lq@chinaffmpeg.org> From: Andreas Rheinhardt In-Reply-To: <20220628114432.52656-1-lq@chinaffmpeg.org> X-TMN: [XElXiU9sNeyG+y37/DEAGYQsHAaKf6tr] X-ClientProxiedBy: AS9PR04CA0142.eurprd04.prod.outlook.com (2603:10a6:20b:48a::16) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <0f4cbe9d-b890-c687-c0ee-53e408f72f98@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eb0551fa-f778-4593-15d3-08da58fc38b4 X-MS-TrafficTypeDiagnostic: AM6PR0102MB3541:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rPaplLQ7Wosq67JAUZMKbGWDqczRxzl/84PkbNP3uTChJPoWtm46ycZtT/3dB7G45YaJANCu16DEiQKn3fmwfHwlGth+DUZkDahE037vV0Rp2W30pci75jmybT1OdV45cEjCg0/uQtMDiQsagn/lOYFG85dFyy+8fy08Iu2u5mxgxA0nfYvYtRCUaDvzoXKC/kFVxogUnxo+xOzdtFPcDXUxJVrTZX8SrtUkKZ43GUqzRs1Zw4Yv8fWOuRRlKV++nfZcAw5ooWDgjNeurdiwWyP+boKqCG2CVkADqRerA4DCmj6wJgeohK0xjm/6dQmscUOeGQ69yTmRcDOgBegYMl+5/hizuKJN2PyXRecHwKqcja2q2AHHtbfEyuyNDg4oOD/VyK9ISOxoznCJqF2WBB2if3ft2U8ef774aV9YY13fGQnlsf2hZIm/hpWpN6bQMkWRdUnZilULg9IROTmB8do0Ma51k7xhgYJmVGG/4oXtUh9jPXzsYurcEwOhzuN/fXVPcfN8ZG8eRoUYWiGw6E0+pi8+ooYXthvk1P5P80BUEmGkmBZPPYI2ti1dXM6T8NWqXajhxpYP9gy1YQi2PThS0gV11DSI0/VyytfR03u586p/D8Abs//cceabsG1OiuMzfXPF7atbLzAKuhHzYA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnhBMEN3RDNVUGJhMmlhNkRXTGNjbWRvSmJqNHcwN1pydGlJSEV3Vnlndmhr?= =?utf-8?B?SkJuVjJ1YnFDSnNtVVpkalJ1NGpHNXdLNUJ6Y2pLVkRkUXYwOEp3MUZnY1dX?= =?utf-8?B?VVhlcGF3NzJHbEQ5N3RzU0RDSGNUUGsxOXBHUms2Z25mRThLL0FBWFl3b05G?= =?utf-8?B?NjNlTFMrUkJsZ3g2ai85SjlKZEw2S0UzcEhtb0lrdlFoQWt6VlM4b1hxdmtu?= =?utf-8?B?TkJxZ3hXQWNsR3Qzd1VwSXpZbnVIMGVWSUkvbk5oWGs2ZTdmRTkrbU5uRG1y?= =?utf-8?B?bWRyUkc5ZUpjeWlhWXIxckVWYitkZGgxK3ZRYy81Nzd4eEtWMkxBcjRycmVu?= =?utf-8?B?cFlMSjJIVVQrQUNVWmc4TENDQkdwbDN5SzVnVUlwMWFnQmlTaTFyYkhOZnpp?= =?utf-8?B?K1B6QXlPL01wRXpiS1F4bXdZUEVzb1cya3lRWjAwa25BbCtLOWNkNFZpaUxT?= =?utf-8?B?bk5GNHAzZkhjVUJWYUVsWDRBL2JXRXc5c0ltR3Fza3dNZHV1eEtnWUsxRFZp?= =?utf-8?B?SXdVMng0Mm9DbmhFQzFoQ1BhejMxd0cyYk56SmY5cDNGNkhjdlNhTjdhSlhz?= =?utf-8?B?R2o3dDhaR2U3T0JKbENuS3pKVXdmc0V6NG9pWkRxV282bEhCQUlOWWFjYXdK?= =?utf-8?B?aWt3YjJuQklXQXhyWkdnRU9FN3NwNEdlbzAwQ2hFclI4WjVGR2g1K29BUmpK?= =?utf-8?B?U0s3VjRSN0htUHlOeS8ycFdxaUUyYjhZV0Y3OXJkbUwzci9IL0NrQnNyenRZ?= =?utf-8?B?bkFhL0Jib0VjWUdKMWZJWmM3cHhRRGhYcTBXbnJGMnlWdjkxK1g3WHRnRi9X?= =?utf-8?B?ZDFaN3FwdWgrWGw4ckZhQWw3M1djZmcvRUUrc216SUFoUzBZblB5R1dhMFRv?= =?utf-8?B?TjBuTndhR2FtSlgrQTdySnl4M3ROVWhxbjlENmRuSDA4UmdXVUR0ZGxsSzNo?= =?utf-8?B?ekpXZnRobjVRR0VRSnJBelJ3aExaTW5CVDdrcnNKR1QwWldTR0kwNU9BL211?= =?utf-8?B?OXFOaHVScmlVZjEvNEdONkM3ZWlHTmVPYm91YnJWVlN0ZVFCS29NZUY4MEVC?= =?utf-8?B?L3UrYmF4emdjc0hmSE1JQTZSUU1ERVhwMS9XdjZiOWplU1h5NVczTGk4blkw?= =?utf-8?B?UmpYLzZ5Ynk0Q1FmZEllV2IxRDFGRjlrWDgvMXFFRWtEYTgxZCtlK0RBQkU1?= =?utf-8?B?ZjdpVml6Qk84dDdwME5veUhDRTlZMzZiWVVZaldESHNNZXRhTENlOG5zOTBG?= =?utf-8?B?RDJHOWMxTktFV01QTWE4cGdkR3VQcjd6UUx6dnJSNnp5SEhIR2xzZVhUQnMv?= =?utf-8?B?VnJKZndacXNpcTdVdDdzVlFIU2hSdG1OODU2SW9hQUlSSEdFa2RYL09obWpH?= =?utf-8?B?dHZvWTl4VHFkUm8yUFJ2QTFra1dycTY5dXVlZDE2UjlxQ0h1Nkp2Y3NMMHAw?= =?utf-8?B?Q09iaFU5UXlKWllRL2VqZlZaU0QvRk4xbnZiTk9yNUhmdHc1SitqYlQrMk8z?= =?utf-8?B?U2lKU3N2TndIQVBNVW5ObTE4RWZjQWlSOUE5dmpsc0VPdzhVRjFPZjZwZ2ZW?= =?utf-8?B?V0xWVXNqS2dneHlPWkQ5Q2hQOVpRdDEzRHcydHR3RkN1ZDVUMkY4eGgzRm01?= =?utf-8?B?V2t4Rm9lUTdBNGx6SFRIbWhSOElNb3d6ZmxabTZVb1UzTTAvaDRwV01JV3dT?= =?utf-8?B?QU5PUENSU1ZhM1hiUXdCdmdzQStPblhlU2JQRnNqODNrYXByYUJKdTV3RjBS?= =?utf-8?Q?5ZWdI45hAhQ2ZZpwLw=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb0551fa-f778-4593-15d3-08da58fc38b4 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 11:49:13.5644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0102MB3541 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/encode: remove the = from assert0(ret <= 0) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Steven Liu: > Because the codec->cb.encode return 0 is successed, > so should only check negative error code. > > Signed-off-by: Steven Liu > --- > libavcodec/encode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index b68bf1e184..5cd9615da0 100644 > --- a/libavcodec/encode.c > +++ b/libavcodec/encode.c > @@ -217,7 +217,7 @@ static int encode_simple_internal(AVCodecContext *avctx, AVPacket *avpkt) > avpkt->pts = avpkt->dts = frame->pts; > } > > - av_assert0(ret <= 0); > + av_assert0(ret < 0); > > emms_c(); > I presume you didn't test this, did you? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".