From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Fix compilation
Date: Thu, 25 Aug 2022 21:38:18 +0200
Message-ID: <DB6PR0101MB221473DBC5D1F6E75F0859FB8F729@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <DB6PR0101MB221472C2FF31B8A832D9C70C8F729@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
Andreas Rheinhardt:
> The struct aom_codec_ctx for the encoder is part of the
> AOMEncoderContext, it is not separately allocated.
> Therefore 5bab794e4aaed55d3146723974ffb5ad792617ab broke compilation.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/libaomenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
> index a82b933c18..1e89b7e3a8 100644
> --- a/libavcodec/libaomenc.c
> +++ b/libavcodec/libaomenc.c
> @@ -400,7 +400,7 @@ static av_cold int aom_free(AVCodecContext *avctx)
> #if defined(AOM_CTRL_AV1E_GET_NUM_OPERATING_POINTS) && \
> defined(AOM_CTRL_AV1E_GET_SEQ_LEVEL_IDX) && \
> defined(AOM_CTRL_AV1E_GET_TARGET_SEQ_LEVEL_IDX)
> - if (ctx->encoder->iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) {
> + if (ctx->encoder.iface && !(avctx->flags & AV_CODEC_FLAG_PASS1)) {
> int num_operating_points;
> int levels[32];
> int target_levels[32];
Seems like I am too late to the party and this has already been fixed.
(I got a new version of libaom because I presumed that
5bab794e4aaed55d3146723974ffb5ad792617ab would cause a crash in case
init fails before ctx->encoder can be set, but before I could test this
it turned out that it doesn't even compile.)
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-25 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 19:35 Andreas Rheinhardt
2022-08-25 19:38 ` Andreas Rheinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB6PR0101MB221473DBC5D1F6E75F0859FB8F729@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com \
--to=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git