From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 60FB043910 for ; Sun, 3 Jul 2022 06:38:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EBAEA68B866; Sun, 3 Jul 2022 09:38:28 +0300 (EEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-oln040092075093.outbound.protection.outlook.com [40.92.75.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EE87F68B710 for ; Sun, 3 Jul 2022 09:38:21 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEv7a23Ble0ESYj/MGJcAteSU315m4FhutMmKZaruMqMOTBzfxa8foppFGpuhuU40W/KsMsZQs1e0zk3N3nYaPWZwDlOI1ZhyNxtVB6a1oj5No2Xdt4v++Qyu88n4yOfG8L6vbQlp7pSJuj1p0bmAvZ6J5FHUeIsPfasXz/eutCyE7Tl/xhTqvxSE8OU5EavQhrJFcJ4URGH0Qs9XGTwTwFFWMSr7LpuhjQhLCQUe/Y05HIrUAoh7QO5nwihYWCkcYRPVhio1xSak57JSXnDzqRRcqtjDrb1u9d7jru+PDMHLFsMkLsXzcCfEeJu2HjvElvjZBEgEO5Td/tURrfvgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4RYLW0e/EAbQnkS6aiL4/sFsiMeNUALO973EO2x/uE=; b=n8SFxNPBX0h4+lPDThsu2q7n8Oj40zcDcPYnZukuHRPtXhzmvVtvh7cEMLDnBrgm3Nw/8+iTZ0GV5i2kVzNpfgWswvl/EFCMreUolwMXAsPx/YomWmGb2xF2FLjU/FlMr0DxOwygpkgIxtAaVtaZHQx2yqYglGxdslGh+0jN8lG9M45SQsH5AI8M5gSqwCW0KgvkPpeIZTIDyLFXUVLRImpw98OCLIXMTkTsQ4WtBVKEPK4A2NfJH9ECn/iF0dXbLeQGXeVlLTTfLzWVHWr/J4PF8XeRRarAP5Qs4j/QvbhXtTq6gM89cGDb1V/YxbU/Ml61roPBUogGyyFB0sH2BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4RYLW0e/EAbQnkS6aiL4/sFsiMeNUALO973EO2x/uE=; b=U9gMd0k1ibFJ0IxCJOvblQYAJQBoXwrFLFcSUgWP1H2oCXmarJkf9xqrS2ajPa+Lsh7K8Cj2Jhsgirk3E2orpiNrHOwBGoXkD6MYQRA35ieuSWy3Muwzhjf/crpkbHSQrwQjgbo+yWwj8ejxjCTg34XX84c1OOfMFVMaSnvxe+fnM8SEm+m0SleYzhVty1u/ULpB8O8DoWwMeUs3TCah49I2xv7qX94vDuZyAilt3LUAX+mGrbM9gyfJocPSWVydpCWJv70rfR7kq03gBPln438YnlrD2J5uaSYvKxmyGm8tT4iIUwj+lyXvXCNkHv/0XmpzZHVMzMfRL6Gt17gIgQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM8PR01MB7811.eurprd01.prod.exchangelabs.com (2603:10a6:20b:248::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Sun, 3 Jul 2022 06:38:19 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5395.018; Sun, 3 Jul 2022 06:38:18 +0000 Message-ID: Date: Sun, 3 Jul 2022 08:38:15 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220703003152.17850-1-michael@niedermayer.cc> From: Andreas Rheinhardt In-Reply-To: <20220703003152.17850-1-michael@niedermayer.cc> X-TMN: [KRJGMhmSi5nGHsRR0/t/FUaHsjW41BOE] X-ClientProxiedBy: FR3P281CA0045.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::16) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab35c903-3c2a-44cd-0cc8-08da5cbe9d37 X-MS-TrafficTypeDiagnostic: AM8PR01MB7811:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K514I0EmBxu1VDPRhDrIje7bCC0aOTrItA+5qptMzdKIr8SoXTPblQlJeUS7bFjAqCoy333shuRAy6Tl0t7LFHOQ018U28iXX2HQA7tniJ5mZiQa/WMo9gfTmTmf4uaRMt3YbAvAmKhFQnaHRz3KdXNpW/pT7zsZamsbcJfS732+c6eUdjvdk2CNvNLuVpbJigK8bJYUg7ViyldZqKw75Vm3ri7cip5HLVlLFW8ezL3KG1gKrnGffkBzcvkqZzb2u7MzHKm33waFElELpyjwVwdFKt2yj4BrAriX8SzZejniGTsb+wXfrBoWLe4io94BGOdkG91+2NlHPAllJDpO1wRuNbGjdnSNRG7ksofG3yEF8vpnmULAS95R7f1K11EzfTq641/Q4i0ZDuu1CfyvsHC4Adkv363iph4VFysGgRmsWsQXGXJJ1GCTINFl34LXkIpgQuQXH5V7NrCsBaC0HjUW+60LtwrcQ5qUDpfpqadNKnLBDC2v73Vsp//hpAZGgLgnTZj0yGpHJnbqSKGLNXX3Ghohw8pCDxTqhpSIw8n5hphrFROH67WFysB4DtRIGfDzqGG7elXL0x2saOhyr3y/8vR+8BU/QK9vzzeL1KZf+3vtp0s0H5YpWzB/T9bJdiM5TUuiHnAdb5Og42Hp4w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkg4WkpGME95TGFNQVpEMEZBaEppYUxObklvRTJKbjlNbExOZ0lpdXo4UnA5?= =?utf-8?B?R3JaWlVOdjYrTiswY1lhQWtSSnVqM0xxUGk2R1I5Q2NIb0pmcDNHd1NJeHZs?= =?utf-8?B?WjlvZ1pjOHllZmtOdzhjd29ObXB4ekJubmxOMUJ2TlU3U1RpenlzdHBPRkZI?= =?utf-8?B?V1NCNFVIRFdJWlR2WHRRZ2xqWWtVaVlNLytTR05MN3J3eVgxMHVJS2xpY2Y5?= =?utf-8?B?STV3WkdNcUdoazR3bVBvRUd0T256cktLRGVicWIvYjlUWjFXOFZJRW1kWUdu?= =?utf-8?B?S25ZbjREUkJPRkZENytCcVVSZzlMK1Y1bDNMSnZMczE0T1M2QmpueDNndnBK?= =?utf-8?B?bXpFaHRraEJQVkpLbTZhcTRMVjVZdzkvUGI3L25pVjAzOGVDY01ZWTBGdnZi?= =?utf-8?B?Zm90OWlEMWFsQzVaKy9OTERxUGllZmNxSXo4MEp4K0JVZWtkcTUvQ1BORUhk?= =?utf-8?B?T3ZNMm44TzE1NnhienFncFR6NTBjM2gya3UzSVpQMHJRRW16cU9IRVNORW5Q?= =?utf-8?B?RE9WczFBMTZIcmhpSSs5S0VLbndwTkNNby8vU3NkQklYNTE2OVRWWEwxMGhp?= =?utf-8?B?SG5PSkEwZXkranN5R0tzVlBNSTI1QThyYXR3aCtjcEUyT041aEp6SDJPdDR4?= =?utf-8?B?YUYzZkxFaTBIcnNpRDM0aVJUVDBsUENzS1Q0ZENxZ0NVeTdnd2QvL0VPdE9o?= =?utf-8?B?Qm0yOXFBa1NORXRJU2hYNHBaZG1LV0o3c0prWE9XbXRjcXliYkFYMGxoNm5N?= =?utf-8?B?SGZmVjRrSHh3RFNFaE1IYTZNd252UDVONWRyR2l6WXJQeFFlTVI0c1dFeWV5?= =?utf-8?B?Y3ZJZ2VKcjB4emgyYSs2SzhQMGFzc0djaG02ZzlVQlBjWDFDNFdTZ2F5OGwx?= =?utf-8?B?TWpuKzRMSjhCc2tHT0RiSXhEdVdrQjd1NEc1dkNhTHBVQXRxbGZQcDVyTVVj?= =?utf-8?B?NDRIQ2M4Rmp0OFJrUytZbXZzMkRVdmxWQTl6NHpwc2hPdmkxVHFUS3FBdDZz?= =?utf-8?B?bXhkVTBLZE5JdFZRWHNScWE5U3BFQXhZdG4ybVJ6TnFiTGRmYStkenVyYjVC?= =?utf-8?B?NVdPSk12QW9uL0F5TytOaHRVay9WU2o1V1FISExHMFdqWXI2eWI2NFpuSnJp?= =?utf-8?B?SmJOaVRhTnZqbmw3djlwbTJXcTdhTHNyNDB4TnM2ZTlPSmRjRGxZNDlsR2N4?= =?utf-8?B?QmhJV2tpaVJEcHp3RGxtR0djYm14emFvZjJLOWw4ZG1GRHZtT1NxdDEvdUZr?= =?utf-8?B?OThRWm54dXRlZnNwNWVDOVFUSTE5WU0wQ1ZwQXRoTjgrVU5Bb1dqS3Nhc29i?= =?utf-8?B?c2tKTjhZNU8wZUpHaUlvSHQ0U3gyMkg2NTg4NVB5WGVYb3VtY2VYUDB1amJ4?= =?utf-8?B?ZnI1K3ZEZUlZZ211ZHNMeWdlTHVpOWpFS25pNDdPWWwwTDBHRDNjOTB4enBY?= =?utf-8?B?ZnpObXF1WExKdGhsS29pdm95MVRkMENhb1RrRFl1MWJGTDBINDdnL2oxYVVB?= =?utf-8?B?Mm9kVzlFWElEZnVzM0s4c2JQZlBzNlZibUx3ejBhMDNTZlRQTFlzUUZydnkw?= =?utf-8?B?M1c4WFZybU1nVXdSUzI5U2QxS1NHR0JkbXBLSHd5WmptNGR5SDNuQ1VOeUVp?= =?utf-8?B?MmV0THZQV1hwMWxpa3RERnI4MnNkVmVQSTlqZXZWbGVkN2o1ZUQ3Z2piWEVF?= =?utf-8?B?bzhFTmMySmdUYVlFZTlPRENnSC8wVU9qYW5CbnkxRE8vZzlTdlpaT1dQVW9I?= =?utf-8?Q?BYhEktHj+i4KObSKHk=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab35c903-3c2a-44cd-0cc8-08da5cbe9d37 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2022 06:38:18.0967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR01MB7811 Subject: Re: [FFmpeg-devel] [PATCH 1/6] avcodec/wnv1: Check for width =1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > The decoder only outputs pixels for width >1 images, fail early > > Fixes: Timeout > Fixes: 48298/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WNV1_fuzzer-6198626319204352 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wnv1.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/wnv1.c b/libavcodec/wnv1.c > index 0cf2181a48..f1223493fe 100644 > --- a/libavcodec/wnv1.c > +++ b/libavcodec/wnv1.c > @@ -129,6 +129,9 @@ static av_cold int decode_init(AVCodecContext *avctx) > > ff_thread_once(&init_static_once, wnv1_init_static); > > + if (avctx->width <= 1) > + return AVERROR_INVALIDDATA; > + > return 0; > } > If you want to fail early, then why don't you do so before initializing the static data? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".