Re: [FFmpeg-devel] [PATCH 1/6] avcodec/wnv1: Check for width =1

From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/6] avcodec/wnv1: Check for width =1
Date: Sun, 3 Jul 2022 08:38:15 +0200
Message-ID: <DB6PR0101MB22146C63130A3F1B96F7EBAC8FBF9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <20220703003152.17850-1-michael@niedermayer.cc>

Michael Niedermayer:
> The decoder only outputs pixels for width >1 images, fail early
> 
> Fixes: Timeout
> Fixes: 48298/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WNV1_fuzzer-6198626319204352
> 
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/wnv1.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/wnv1.c b/libavcodec/wnv1.c
> index 0cf2181a48..f1223493fe 100644
> --- a/libavcodec/wnv1.c
> +++ b/libavcodec/wnv1.c
> @@ -129,6 +129,9 @@ static av_cold int decode_init(AVCodecContext *avctx)
>  
>      ff_thread_once(&init_static_once, wnv1_init_static);
>  
> +    if (avctx->width <= 1)
> +        return AVERROR_INVALIDDATA;
> +
>      return 0;
>  }
>  

If you want to fail early, then why don't you do so before initializing
the static data?

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".