From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6076543960 for ; Sun, 3 Jul 2022 18:28:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3886168B93E; Sun, 3 Jul 2022 21:28:08 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073104.outbound.protection.outlook.com [40.92.73.104]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id ADADD68B93E for ; Sun, 3 Jul 2022 21:28:01 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZqhZ5DYZHzhCeEjUV4axr1RJJk/02XQERKsfBh6/SCOcpewesuhCXAIllKPNWQSxtQdZEnJVCJaDKwvtGqfZjj+ASM+Gv4x6M+vaDz/HK7LAibmsPmuPaY/TZC6YQj4LYYZ+7QLIw1K/Z3mD79ETZsLtey3YPcez60J7+j1M+38OEa+AoVTtMbkzjsiN2jjQUEY6tZppY+HDriv/TD6DoakBxsDcMCMjduAARmmwiDD1XooRtrg30He6b05qJKZvapbzWeTO6tZj0JMZuOtcsylOdmtMPugY9QpafQsI4Np9MWh3ymONNH/s6mPq4IO1KUOcSOnTnk9/UlihAbcheQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ADTgJ/4TeUuuHOT6kotr6/9NPEZzh7fppjRkIsd2WtI=; b=JLwFrDY4pPNXLsyc7Y+0cFl86cyALwhVLhI1e4lLv89sYB06W/7GM632F/QghWhWdtCZguzRMVveYB/NpsoX9WOI86vgqjpz5v8mYyHTeAMsZKkiFUvB5afeSz7JX2GlnknIwsDMYBB5PTE4ne9wIw/V+wh8QlZXsg2JeIV55BotWpM9O3iJBzgdexwpc3j5xBGsjiZL2sKKyKRFrEJ8nXuvZ0K9bQaOkWPYIuebFEO3wi4+NUPtKAWGb27yn5trWnxBZL+qD8xCsU0Pkkm1wXYo+HbSWeRGGSb4453TPs64wj6UdJIeq2tif/rPtNJ8FGrRkX7WN8lcLhogmxiFzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ADTgJ/4TeUuuHOT6kotr6/9NPEZzh7fppjRkIsd2WtI=; b=VYY46FgIfD0nTuY4PcKmMqC77DvZJdNL5Ah/0HBmATcv7sdJKtw70fA37eWei/CibsVB+8fxt+16oMTMpDuo69KtMdein4sPMGGfAmuJbbkgAU75/mrENuPt0ZGUAwemAwRzQg//ECmoHCpLbNsdKWyeDIZw+F/qGPdAlVeHp6EpBA1nnQKIYLA/sLtksx30Uaz6dls2QFzYKM5G/Ybgp9U1Xb/LG4Kxujk3V+h4bBpqQO2WquRe39IGIkQyWAcxOoZ9w5rEj7HyaJkhyxXwsOT+0fPq3bUg5f0xfw20fDVsKEiulP+aKvrDSBc9pZFWmOC+7og1DPGuCz12Y9t3Cg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VE1PR01MB5805.eurprd01.prod.exchangelabs.com (2603:10a6:803:120::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Sun, 3 Jul 2022 18:27:59 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5395.020; Sun, 3 Jul 2022 18:27:52 +0000 Message-ID: Date: Sun, 3 Jul 2022 20:27:50 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220703181525.6488-1-pal@sandflow.com> From: Andreas Rheinhardt In-Reply-To: <20220703181525.6488-1-pal@sandflow.com> X-TMN: [S45W/Gz+IwNuOTDaWeQ+wkbZHqo3Rojn] X-ClientProxiedBy: AM6P193CA0143.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::48) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <0fe08e7e-911c-f621-bf8c-cfa99e3565a6@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad02c879-f5fd-4784-6843-08da5d21bcf8 X-MS-TrafficTypeDiagnostic: VE1PR01MB5805:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RuJ1ekw0gqWSjffBxexlblBeULgIc5RSEp7mkJMCpoypLpoZh13DnVbljKRzCpXot/CET2B9cDBrH4+0osyrg0x6OrulyC7dPri5bX3vpd3mx6GE/P7FDx6ilc5xsSeaLrUTI4jjBa6xI2phY16QPHQ6N75RXxdEOqvyg1p6rhrSOaNaOFe7MwCfRVJaRdUnnvj2L5tXq/q44Ql38f61/WlEXdaiRY7/63mElW43OMx0Iy47LCdqPLsS8fApR6AQQBrM7IHVJ11xPesw4I9jnw1fI6SuiqPmuRTifJngc3gD/lC4+1In9iGQe92niXfZPL3IGtcvMomxhnsrtF328+gYWX5LrPIoZd9BbtaOQkoVC8UNWafZBhLHKx/WDXQb48cN7DdVz05Dc9Pt12URC7cF3TN0Dhz48REro8WdE8DSnEBV1x2c++iwTH3BJlVij+Ha4sItN7D4FJzc4Mpnv/y0WcsZ2TE6QX7sUU7jdJRHfv7vbsdaoZkcc9qlOFzV6EVuaJkSSC5SUDW2OjLtjyy6rFq84rMDpvkNQjcvAtIEzLPx9p0eA2SgnrBZGJutdGn7lTpS6fltwyGTLKptZ6IZI7zEakAG3o79sfI+o1lQ8dA08U0bq1oeikrNqXItzkYhDD/aOubRfm3iLLayaw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVRab0hPZk11VmdNc1dEcjkvOXd1eGdqUTgvQkZTWmVwRDZLSXMzakI5di9j?= =?utf-8?B?QzhqME9LeWhEN1VtNEFMNitlaHdvVDFXRFlQb0tmYlExQ0RqZndwZHo0NHZF?= =?utf-8?B?cXB6bk0zU3EwaEpra2lTZytBVFNVdEg0Ny9PdXlXZEc2QkpsQWFBaXY4THhN?= =?utf-8?B?R3dsbEJBVkdRQ1VyektBdFdvMFIwMmZPS3BCWkEvK0tYanhyb1hxaDE3WjZz?= =?utf-8?B?VFcwdXp2dmhXTGYrR2lCNHVXM3NHU0Q5cUd3MnpaWnJCejYyMG5tYzBjQ0tN?= =?utf-8?B?YWwvVGw2S3FJQUwvSHNwTGtSNXF1ZjJTcHRvNCtWUzhHWTBBQWhnRDJHUGlq?= =?utf-8?B?QmtxdG4xb251elRha2hpbEUyRHhIV3Job1JhaUVoNVErQkh6QWdjZXNtbUdU?= =?utf-8?B?YzhTdWd4NGg0d0VsaEdQN05SUXFaSE5zS01NenIrWXhQK3lZeDJvWXdYa0R5?= =?utf-8?B?Z2ZzQ0hSSjhGM25PUjRUYUVsSFA3MmlJWjZ6ODZKamExNXJ2THZ5SklVbmNX?= =?utf-8?B?T2kxVGlaT21mSERDL0pzWG54VzN4d1pCYXY4b0tGZ1Q1RVRNYlNxVzhyUEE2?= =?utf-8?B?WFB1TW9FVU1wMzZ3K2xMMFUzUkI5cW8zOFZLWlZEMUlPa3p0MlFvOFR0b1d0?= =?utf-8?B?OHFmOFZ3cmwxeU5lQlk4RFlESUQwTmM0OGhmQmdDSDUva1R0ckxLbnhGSk9n?= =?utf-8?B?dkxQQmtVZUZqNll5OGxZVllkdXBobkdZUjRzYk50K3JJd2ttQkQzWmNRaGF5?= =?utf-8?B?Y2JIZFVEU2tIVWdVY1BsSlBUc05hTk42Wng1SDBHSWJJdDlWdWlScEtGRnJV?= =?utf-8?B?SmRVS0UzVS9VOENtaHQ0OWpZbC9BNVJhamhMK283N0w2Y3dzek9NRHV1TlJm?= =?utf-8?B?Ynp3TVJaTUlVQXFWVnRGNzFmWWxKTXA0OVNvNThhVjlqTm01Y2VDdWdLUzht?= =?utf-8?B?TWFLaFAyUDNkUUVlSExaV2JwblFZNjZTUDAvbVR5TGFtcDlZT3F6SXFYdUpy?= =?utf-8?B?c0JuWjhnanBhZE1FM2MvMkxlUUpaOWRuZWdVU3BzcnRCR0JCMUVMT0tkWTZL?= =?utf-8?B?T05pbnRNN3M5Y0hreTZEV2hjcnE1ekQ4ek1FY1Y5S3ZRWFg0NEpJeS80ZlZJ?= =?utf-8?B?dGFGZ0RIenFCOWs4TkkvL0tBenlwMG9XeDhiOHRuaUVEZml5MVUzVFV3V1E4?= =?utf-8?B?NlJJY1R1QWNTUjU4TXppc3MyaGZLWmh1SkpHRHQwWXVUVVlvdjZDOE1LeDdo?= =?utf-8?B?ODdEaUY0ai90bzhXWStSZUhCT2ZDeDdVTTRJRktVbDZMaVNkU2w5RHo5Zkox?= =?utf-8?B?MW02WHZhKzNnS2c0Q2JiS1RoRE5OeWpQc2F1ZXZkdldqakRaeTlLTkE4SjA2?= =?utf-8?B?bmFpMnBkcko5eWdoSDNobFlXK1FEd2M0SE1tUmdCZkJMRTRMaUZkc3FHMWJG?= =?utf-8?B?ZDVPOFI3M2NQL0IvOFl0VkE3cUowRUoyNkMzekxMbnhJYURheXJJajd0VHlY?= =?utf-8?B?aU5NemJiSGh5a2pzTW82amFBNEdNVW4raGlLSlRpOEZ2Wk0wTE9PNGEzbkY4?= =?utf-8?B?WEpnZHF5V1V5TXExbGN1TDExMkFMeWdBSDNnUGdTUms5aHF4NDQxUmN2WjZa?= =?utf-8?B?WE9oVWVwVjNpR013VWtIenN3OVNvUFRMY2lxN0gwc1B1dHQrbXA4elp3Y0Zk?= =?utf-8?B?STNJK2JUTHEwaXoxTzZBSDJpUDZuVk5hKzRIcDdZdldKN1czcUExV1BHN1ZV?= =?utf-8?Q?E66bG8JQ4za6/I2KgU=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad02c879-f5fd-4784-6843-08da5d21bcf8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2022 18:27:52.7714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR01MB5805 Subject: Re: [FFmpeg-devel] [PATCH v1] avformat/imfdec: preserve stream information X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: pal@sandflow.com: > From: Pierre-Anthony Lemieux > > As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does not > currently preserve stream information such as language in the case of audio > streams. This patch is modeled on copy_stream_props() at avformat/concatdec.c. > > --- > libavformat/imfdec.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c > index 71dfb26958..7aa66a06bf 100644 > --- a/libavformat/imfdec.c > +++ b/libavformat/imfdec.c > @@ -580,11 +580,16 @@ static int set_context_streams_from_tracks(AVFormatContext *s) > return AVERROR(ENOMEM); > } > asset_stream->id = i; > + asset_stream->r_frame_rate = first_resource_stream->r_frame_rate; > + asset_stream->avg_frame_rate = first_resource_stream->avg_frame_rate; > + asset_stream->sample_aspect_ratio = first_resource_stream->sample_aspect_ratio; > ret = avcodec_parameters_copy(asset_stream->codecpar, first_resource_stream->codecpar); > if (ret < 0) { > av_log(s, AV_LOG_ERROR, "Could not copy stream parameters\n"); > return ret; > } > + av_dict_copy(&asset_stream->metadata, first_resource_stream->metadata, 0); > + ff_stream_side_data_copy(asset_stream, first_resource_stream); > avpriv_set_pts_info(asset_stream, > first_resource_stream->pts_wrap_bits, > first_resource_stream->time_base.num, Seems to me like one should use ff_stream_encode_params_copy here. Of course, it would have to be renamed and moved if used in a demuxer. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".