From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 49CE843ACE for ; Thu, 11 Aug 2022 20:50:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E44F368B93D; Thu, 11 Aug 2022 23:50:23 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2034.outbound.protection.outlook.com [40.92.91.34]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5161A68B92B for ; Thu, 11 Aug 2022 23:50:17 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RMTiHNLziqGTr9hOWVaIGl95+FQ/QaH86U6k6ll8VwHTwrJtgyFzVzYbGPEp+ZU6qtDq44wKYOZ3XAPHKf9imjBhdDvlGvFtsRvAkJkO77eT3AmofdUjWeN9sy0QZngK6TLl08cVUVMfzt+yQcKDSX1/qT1rGI6YX1sRS/3QiEwZXZg84vCP/42BlyYxIq78WHncG4RNogc8s225OHsR7VSndpe88NqtXW8gv1qcz7jtwR3/WE4Q8598X4PUTeiu6W8rWrBRrOy4S9DUV+Wh+/x3XVmJwIEn9TEkVALogWGvouap6KLguMbUGheQCba/lWS7rsVKa0hEPqTEO5BeQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oC8enuc66/TTqO/8Wnrskgqpn5U7oxCyyzLFKq/BDEQ=; b=AHMtodtceGGyzIAhRH0cxq0WWlXfPGTOl1Sftws8mZN52bce84KdNjRC7u35GCgKnE6UZDy2bl/ESgwyDdumMhlhq2gEHo5XWpmqgUGhoyYJ+g1W81F9P0y/tU3sn3uzSnFiRbfTP2KgoMe5vWOev7FHq1Fo6NJlpTyjayzJnagBAJvmElVlkRmuw0ugSKV6EqQVcVj2+kvL49XQab1wmcsw99fnCWFDsjVtzpdEeKyrbWPcyGkAOu1UGUux4SasV9rQqBR7FjEvqRVDxXZSQhGWl/glCHqzKdcE5ecQjgWmhJDS2YeaOE5609WqJNS6HMFxqGjw4Ovqqd5pJnQ11A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oC8enuc66/TTqO/8Wnrskgqpn5U7oxCyyzLFKq/BDEQ=; b=d9/xukeSH/0UgDAZCcc6FXwTxOa64STaYT2AQPV6cCAHrErYLj2E5OHz9VHMaNJ9cKebv8uuo14L5PQyfrmGiQWG+nXDfvvJegYqw5I9JWFY+PU2ZFVNddhlIlF26Xr2ckgniIPk+zCAysHLy6cIX3+Ju2KpNxVFDJvSIl6nw6tFsYERAQnfNlmpG2pmiEQrOsPMiFlA+qY0AD+TQ/cirklUM9x8tBhX2HbnKvGOfQQz+TJjqozxruwFzOmQudcqYGJcejeJ9H+1ASRiuib34Axd5pFwfN6keHw96iezRLNhBtOvaMY4fLgqM6OV1kzNvdeu2r3EbAA3HTh7fZyNlA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DB6PR0102MB2821.eurprd01.prod.exchangelabs.com (2603:10a6:6:4::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Thu, 11 Aug 2022 20:50:15 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5504.020; Thu, 11 Aug 2022 20:50:14 +0000 Message-ID: Date: Thu, 11 Aug 2022 22:50:10 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220810204712.3123-1-timo@rothenpieler.org> <20220810204712.3123-8-timo@rothenpieler.org> <20220811204616.GF2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220811204616.GF2088045@pb2> X-TMN: [Pkf4qJQtTn0vGUcVTOSGJ67Nv2OOlSvF] X-ClientProxiedBy: ZR0P278CA0197.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::8) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <4deb20c7-e07e-413a-685d-bca21ce9e9ac@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3d79563-2141-4150-0832-08da7bdb1721 X-MS-TrafficTypeDiagnostic: DB6PR0102MB2821:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xCRiWTTVEyv72ABJ984W74VYW54O5H7SNJglWqLDgl5brbKDO9zsHUCWAz9cz8WpcjMOh2Q+MWAWie6dbJ3wr7Pn7pdQFKEWXkIIPCKPJi6vEuh9ggxw8J7J8pYLd7XgvUHypke8z+esXeSmXhck8FTj/H3SltJqi7r2h18UAu+surE0srlILQv29my2rThwAqpehBY0HcWIZd9azJKF4FVJtw+hFbuxeyUhTGKSCnv3acsW7UHIRlxFI5eVapMFnkikAeg68itaaXFO1d+InO2AzWp5uJdpyhAWBEyiRKEU5hf8CBk2zoomUPGjky3GmRF302aMlrKyT2eyto6CvAryPhLbW2iTNPfmvH2Xz9C8HpxwMkDsP3fYTvjrk4oV+9t/EEUm47DZ0pNdfU/54JnuSMREGHj1TZC5gQyLXHy0YY/NhJsVe+cYi3TBt9CVFH6i7f7b27fkwdECtdKKLXJdDuf6EZgLlbcuDvS2cdW5uFzy2y2voGFp0CQ2A5ZoCSSdkMORObHFAywdu9TgUr+IzL54TkElVAOet4bduJ80U+/p89VRReLmDrCraFBADfn175mWXC5NvpK/POmlLDJ98vAUCTBvcq7kf2WMu95PSzfWuPrVPg34PE/3VQOKA1i2kmjHtdd7Qhl8uvQ2QfG8MiONncZrld3GuVZndxVLvea9nnNDfJGTtN5hy1Et X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEFKVHVnSmxBcDk2K2xTTy9CWUVlRHluL1NWN2tIWlVFbGVtbmthWStxOXF5?= =?utf-8?B?c3cvcWhNczc5L1pXbDdyTndoTGc2S2twa0tGckRsTDc2UG1GbklsMU9MdXZE?= =?utf-8?B?alZRa291RVNvbFdJRnFMUnRRZ0R0UXo4bUE4SjdoZ21uNUhnY1UzOS8zWWRH?= =?utf-8?B?YWpGd0d1dk16VFZTcjhRL2V6WWNWVjN4dU9aZTMxWG9HeEZ6S2phYk1wWm5m?= =?utf-8?B?Y0szZXNTdTk3N3A2YzFwNkx0NkhtaUFOY3l0T1NKanFTRnhaYmFvdk9iR1RW?= =?utf-8?B?S09xWWpYTEZ4OSs1cE9VdFlqTTJweDRTMkZXdkV4N096RGREUXYrK3Azb1JU?= =?utf-8?B?UXNXUDZrYnI0N2ZwNmIvd1BaSk5Ua1ZoMTE4YXY2OVlmcE9aeDAxbTViaGQr?= =?utf-8?B?dkxKVUtqcDN1eTVGZDFXWUp3UkQ4WXBPMmZ0QjZVcGVvZnVNNkJSaG5Gd044?= =?utf-8?B?L0pMaUJQV2Q5TEVsWSs3ZkFYdW12SUZVOTB0SjRhYXcwZTFjSG53elJRclZN?= =?utf-8?B?NWw1aUNTcUl0a3MxdVhRWi90NkxOem5sMkdXS2F1VHA4ZTdmcDRINDQ4S1U4?= =?utf-8?B?OWc0Rm5WMkFkOHozWW5HZmpjTlhGZmJDdW10cHlwcDhjSHBBZkF5WmFqRXJ6?= =?utf-8?B?eFNaU05hVFRnakJxTTFJUktzRElyalZJMEI0Y3IvdmZRbUdTL3pnUDBBS3FU?= =?utf-8?B?L1lSYzdLYWVvK3FQQTNJeVRGKzcyT1FHRXZ5ckdHa0NNV0JZZGJIQ296UGp6?= =?utf-8?B?bGpBVm5aWnA1RjBWWnIxcHZnNUlmZHpSVHczSjZoUTlWcnNEaU9seUpNVENV?= =?utf-8?B?dytDUTcwVS80RW9mbnVxQS81WVBzZ2xlZkN2aG1VQmNlUFYyMkFLbm5YZXFB?= =?utf-8?B?WWpPRkppeDlsWGY5alFNRngzQyt3ZE50dlZMTU1mV1ZCMWhWTGxhbitnaEJ0?= =?utf-8?B?Z3BQOE1PblpsYmx1dlg2TWlwTDJFMGpNM2JqNWtyMm5VZFZENXJvdlNvMnZo?= =?utf-8?B?UDExNG9IZk9XUWN1Z2ZJaDlOclFWbUYzTk1xL2haQVQrcEVRWTRhSklwbjd0?= =?utf-8?B?RmlTKzIwMG9YcGVNZk54aEhzdFNPVHRTcFJKekxLZFBwcCtEd1BaQ2V4UlRE?= =?utf-8?B?TUVodE5lamNtRkFWcGt6QlZGYnRtYTZtamdFekdOeWJlcE5vLzJzOTVROG42?= =?utf-8?B?andydU00RElLYVZ0K2R1TjJ3ditTb2FWSjdQREw4STkwODZ4K2xHRzd3Q2kr?= =?utf-8?B?NmZWNUx2aE5vWTlYVHBzMCs2ZGN3WWo5ZmViay93WXhCNWh0dWtOK3VROUtJ?= =?utf-8?B?ZmJvVWI0RURHR0oxQ2VsODZvZEFVNitNQ0RZSnhWWDl5dk8xRFEyL1RleTAr?= =?utf-8?B?YmVCbTJvUkdaRFFYL1ZrcC9GSWVoRkMyM2c5TUZ5ckpOK3dNUnN1dkdxTlQ1?= =?utf-8?B?SXQ4cGZzeDcramYrL0Rnc3NJbUFsM1YzTFllaXpmYVR0RnpXbHA0eXZCWkla?= =?utf-8?B?VURQalFvbmNmM2wva3hLKzRsR0hwbVNhd0M4VHNIS2tHWXdONVd0MjQ0NVdP?= =?utf-8?B?NkE4MHdtemozUHNndlR3Q3ZmdWRHdU5hUHRyS29qdDBtUEZtT2RlRXYveVNE?= =?utf-8?B?cEl2WEtzV3U0bEROaXlJY3U2anhDYTROOHplaWpKcm4wMmg0aVFvYklRUktR?= =?utf-8?B?OVkwbWNRaUNtamVITlBTY2ZQTENGRVpDTGVVeHRKb0l6Tm5kSnhMRnBoSm90?= =?utf-8?Q?hsy9ghz8iRrbA0M0I4=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3d79563-2141-4150-0832-08da7bdb1721 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2022 20:50:14.6503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0102MB2821 Subject: Re: [FFmpeg-devel] [PATCH 08/11] avutil/half2float: move non-inline init code out of header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Aug 10, 2022 at 10:47:09PM +0200, Timo Rothenpieler wrote: >> --- >> libavcodec/Makefile | 8 +++--- >> libavcodec/exr.c | 2 +- >> libavcodec/exrenc.c | 2 +- >> libavcodec/float2half.c | 19 +++++++++++++ >> libavcodec/half2float.c | 19 +++++++++++++ >> libavcodec/pnmdec.c | 2 +- >> libavcodec/pnmenc.c | 2 +- >> libavutil/float2half.c | 53 ++++++++++++++++++++++++++++++++++ >> libavutil/float2half.h | 36 ++--------------------- >> libavutil/half2float.c | 63 +++++++++++++++++++++++++++++++++++++++++ >> libavutil/half2float.h | 46 ++---------------------------- >> 11 files changed, 166 insertions(+), 86 deletions(-) >> create mode 100644 libavcodec/float2half.c >> create mode 100644 libavcodec/half2float.c >> create mode 100644 libavutil/float2half.c >> create mode 100644 libavutil/half2float.c >> >> diff --git a/libavcodec/Makefile b/libavcodec/Makefile >> index 029f1bad3d..cb80f73d99 100644 >> --- a/libavcodec/Makefile >> +++ b/libavcodec/Makefile >> @@ -337,8 +337,8 @@ OBJS-$(CONFIG_EIGHTSVX_FIB_DECODER) += 8svx.o >> OBJS-$(CONFIG_ESCAPE124_DECODER) += escape124.o >> OBJS-$(CONFIG_ESCAPE130_DECODER) += escape130.o >> OBJS-$(CONFIG_EVRC_DECODER) += evrcdec.o acelp_vectors.o lsp.o >> -OBJS-$(CONFIG_EXR_DECODER) += exr.o exrdsp.o >> -OBJS-$(CONFIG_EXR_ENCODER) += exrenc.o >> +OBJS-$(CONFIG_EXR_DECODER) += exr.o exrdsp.o half2float.o >> +OBJS-$(CONFIG_EXR_ENCODER) += exrenc.o float2half.o >> OBJS-$(CONFIG_FASTAUDIO_DECODER) += fastaudio.o >> OBJS-$(CONFIG_FFV1_DECODER) += ffv1dec.o ffv1.o >> OBJS-$(CONFIG_FFV1_ENCODER) += ffv1enc.o ffv1.o >> @@ -570,8 +570,8 @@ OBJS-$(CONFIG_PGMYUV_DECODER) += pnmdec.o pnm.o >> OBJS-$(CONFIG_PGMYUV_ENCODER) += pnmenc.o >> OBJS-$(CONFIG_PGSSUB_DECODER) += pgssubdec.o >> OBJS-$(CONFIG_PGX_DECODER) += pgxdec.o >> -OBJS-$(CONFIG_PHM_DECODER) += pnmdec.o pnm.o >> -OBJS-$(CONFIG_PHM_ENCODER) += pnmenc.o >> +OBJS-$(CONFIG_PHM_DECODER) += pnmdec.o pnm.o half2float.o >> +OBJS-$(CONFIG_PHM_ENCODER) += pnmenc.o float2half.o >> OBJS-$(CONFIG_PHOTOCD_DECODER) += photocd.o >> OBJS-$(CONFIG_PICTOR_DECODER) += pictordec.o cga_data.o >> OBJS-$(CONFIG_PIXLET_DECODER) += pixlet.o >> diff --git a/libavcodec/exr.c b/libavcodec/exr.c >> index 825354873d..a3582bfdd6 100644 >> --- a/libavcodec/exr.c >> +++ b/libavcodec/exr.c >> @@ -2208,7 +2208,7 @@ static av_cold int decode_init(AVCodecContext *avctx) >> float one_gamma = 1.0f / s->gamma; >> avpriv_trc_function trc_func = NULL; >> >> - init_half2float_tables(&s->h2f_tables); >> + ff_init_half2float_tables(&s->h2f_tables); > [...] >> diff --git a/libavutil/float2half.c b/libavutil/float2half.c >> new file mode 100644 >> index 0000000000..dba14cef5d >> --- /dev/null >> +++ b/libavutil/float2half.c > [...] >> +void ff_init_float2half_tables(float2half_tables *t) > > this will need avpriv or break linking with shared libs > No, because this code is duplicated into all libraries that need it. (In case of static linking, only one of the variants will be used (namely the first one encountered in the link.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".