From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68E1D43C9D for ; Thu, 4 Aug 2022 12:54:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2756E68B9CA; Thu, 4 Aug 2022 15:54:51 +0300 (EEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067072.outbound.protection.outlook.com [40.92.67.72]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1682068B7CA for ; Thu, 4 Aug 2022 15:54:44 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FWmTq6NrfB49+st6kqEI/134GrR5e27CYRE95nD2FmSEfJwsVPAe68OJJE3wVARjJgUM16gCzG0yD7HF63KmXHVgRNa9BKHjsUucdJLPn5oHXHS2Fux2Gko1lX5YYL49MO7HroEBZrEVD/aDfXIpd8PaZV9fNkvAM/h6LhqZ9omAhRm9UPCu3wQPaQ1remnHxp9Fy0UKjeM44OxN7EeLQ7SayXwqmM4EchunDVnzh8mSJM12cYdNT0ewIuGzhtmr+oNVaoBHkvABcfpt0IZPLZ897o8xa1qBgP899+fIR208R2O5UCUZ0rkV0FHtQSiPlOh2tDoJ6fNmJ2AYUFIhAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GkefOLGgrjCTwGKkB86IhIEreBBknVOO21BkIdKFZF4=; b=GGPhBXteQD8HRNdZ7M2vLDAKhjmxnQN0/i3mzQkiSLmTPbDVbdFmN3YBQzD9b0wB/ygLouHhKKqjHyWtvVHDAW+mwF329Qquwg8Czgsf2M/AoEuHR6ENev++d2uKoM9DFrJL7udG/5oD8r8KZTXPohqhOLQMESMU6STDMfxF8ZWbbxUPlmHUnE+QmPztth9na11/YGSwwUNiB2EqC+VXqkJFXcjRp1bLsgb+u2YTXKZuTOEn/rP+4yDa/DFjF1oIIlnDf7OrYZiHseEHyWscJyLo3lhfMIS/koTCZMzTXuhRhMGKniCdm7AdyAa4Yg48vY1Z+ZNGLoGaigogquIAiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GkefOLGgrjCTwGKkB86IhIEreBBknVOO21BkIdKFZF4=; b=Xx/9hFk/gDySbAUme7zux3rA/Cnq7ZHQ1hhRKMEwLFklZtBhVYDhcpxqsaBbKaGtwy+1eE3LEeajc7GAi9Klk+X3lDYNNsfj+rN1H/9+O+FO/A+QMa8fUBfVdiUYFKg045vYCj39nFvyXy37nAnt5ngFq/S5NNf5jozgMYUo++5E/w5NuNF2ZzgPy8WVt+Tr8wcLrefkmAMNAXFJcwHw3zSLyaAFjFlm2lusZR9a8T5M72o8YCM9GyYLs/s1Ei4fBy+e//3hVmKS/VDo+S/DDKawa6LYIWV+SusK0zjDsqmBS3p4pC95VwubxtMcC6J69MY3xsj7z6nkNOWfJcqxVQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS8PR01MB7398.eurprd01.prod.exchangelabs.com (2603:10a6:20b:25c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.15; Thu, 4 Aug 2022 12:54:42 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5482.016; Thu, 4 Aug 2022 12:54:42 +0000 Message-ID: Date: Thu, 4 Aug 2022 14:54:41 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220803135844.16662-1-anton@khirnov.net> <20220803135844.16662-7-anton@khirnov.net> <20220804124009.GI2088045@pb2> From: Andreas Rheinhardt In-Reply-To: <20220804124009.GI2088045@pb2> X-TMN: [xHvu5434wJtkOVwvhHWporK68cfiWawF] X-ClientProxiedBy: ZR0P278CA0019.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::6) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <591d9807-12c7-4c41-822c-4cf78c882bae@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b8abca6-421a-4cce-748d-08da76188004 X-MS-TrafficTypeDiagnostic: AS8PR01MB7398:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OQBYgBT1YvCdvS2sZeJvwa5lQSZYAqBofhgtRw/KUpVrzK3JRjs/Hx0wiM2sWJEY6Oyw3hp+iqEMz5QC4Rr6ZA30ItsRzTelJIgH4+bAe1pziMUabG4CdZbq1VtO3wrdbFvScbbJBEUaqKeaDw41GWZ6mQRvfEnJnWYcCJQQl2LzYJsx/1vVJaoobj8rEuo2sddMopqOgYUyMQaLGvf4QlUQbAnvfH5IYXJP3LvVsLyVUdA4ocgxmOEWiXthXfbeqxaeAfyFd4IF3s/ifPpUTVGFGY1DsO2m5jka9q92VxZQ4r/VFGTFAWxnPrgiXNTuxbDXNsnt5F9t9fWWlJJpWv1A3Pc8Js2XDAilmfUvr7OwXuHQhcAXZSoin/Le9EUJdr0LvbZMmp454c24jcaid31R+CoxICh7DIwLHUQebA2Pvvi+Tm1j1RfXwwKRff6N/FsPk3Xl5Y6dBL85grOmDucM0iAZbRq5iUgCAJvHWcAMZM1Fuc/BYG6n69/7sIMhOYlNkfrUL2PzLkVxgneZF/xwl9OW7WJ/gU3VV7o9Y0UeZor0ZnfYIzCHTgn8wjvj5QNnUCohMnDid18yteNvW2n44TEI2SxgwZIba+z0Z/S7n+XJooUUN+4wqF62dvib/u6WNSI+1faLjwC/KN5zGnf+GPhBXcBJGSlvXaAemB7vUEM6+9nNUSLufkk1ug2Y X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MStiZWN4YnM3USs3cGU1UW11azNleklBSHdyVHhScDZEdGhKQ1VvSTVXTjdF?= =?utf-8?B?TWZPUVRZSU4wZkV3VGxQTmdhbW5PR2o4N1Z4MnFkcUQwOEIrSDdwNURjcmx4?= =?utf-8?B?MjhTZTZhb1QvMWliT1gvQVdQcWFaNlZjQjJjYVNzS3FaeFBSY0J3MXBvdG1U?= =?utf-8?B?Qk01dnFqblVlZ0lFWnBuTjFnOW04UTRRc1ZTbFpKd05XRHl6UGhlTUFaZ2lr?= =?utf-8?B?YXpKRFJSVjBLU3hlVllOc09tdi9vMkU3SEJiTzUrbi9wbFkwVVFMS0owWnZG?= =?utf-8?B?QzMwb1hUbHdqVlFyZUQweTVGUUhPWWRqWmZMcVBGN2g5bHVEd01rdlFmczlT?= =?utf-8?B?NkhzWEtBUWw5RlVrT1NHVUtlME82bFdwQTNHcm85U2JMdzZxMXl6OUM2MGQ5?= =?utf-8?B?RnZTNUZ6M0NqVkk0ODdFOHpLZTlSN2J2Ujh1eVN0M3lrOEw4amx2ZmMyR0tn?= =?utf-8?B?MXRDdDZHcWN3MTNvSXhTY3pMZkpvNk5idUlMamhuS0E0cGg3bkF2OFZvS3Vk?= =?utf-8?B?bmlaZWxJUndwYXM4WmhvMzhBSlBGWXNSS0MwOXFURU9GQXl3Z2s0a3NMOU9J?= =?utf-8?B?TTBGcFQ4Wlk4N0d0QUZRbnVtWFh4UGRkR014ME0zSkhWMFN0U1p3V21RaFRJ?= =?utf-8?B?d1Zqem5QM2JaN3JxYnVteXpNU3V0UXNBNE5WTmpjQ3NBa2lEU2hINS9Sc0lr?= =?utf-8?B?TW1tamFyWlVnOXA2QThydDF5a2s4SUJUdk1mcUxBaFQ0QUkwYzVoMlI4OWxl?= =?utf-8?B?UFhXVTVLTEk2WHFyZHZ5R01rRitwVmpnTzdxekVydjNSdXczUVhweGtxdUYy?= =?utf-8?B?WndVMjV3Vm9PSDZBckhLcU1sdTNrektSLzlXT3loa3BMMm9yVDFLSURKVUow?= =?utf-8?B?bXQ1MFV2a3NFWXpVaUtSenNXdndGeDVmMC9mbVZ6UCs0Y3M5MWVjbHNVNzFR?= =?utf-8?B?N0M1azUxTFFmZFpYd0hVWXFDMFlXQ2pPclRqeFZIaVRxQkR1QktuTTBqMSsy?= =?utf-8?B?a3EwYys2SXZ5S0ZBREZwOGZjbTg4UnBQWUllUE5lVk1IWmRPcjlKRnl2aXZt?= =?utf-8?B?SUVwOHFRMld1SU9tTEVxTnYzS3BJTTY0TEg1MUdOeWJEVzdOR21qV0tWOUFn?= =?utf-8?B?d2ozZ3FOS2ZBMm9Cdy9XMlNRSWZBTXVuZFVNcmNDQ3Zsa2ZIa2psdElpQk1U?= =?utf-8?B?ekNRYm1SNjR3MG5KREZjdFZsR3B1eVV3RWwzcEFtdmx1NS80cXNRY0t2RjNM?= =?utf-8?B?cnAwUytnMWQ0OEQwcllFVXIxQ1ZIUUU1NlplRTk4dmZOM0c1VHlERW9rWDlN?= =?utf-8?B?bDkzMGpScmN1QTRYcG1hVU1hcWgwNDMrZnRWMy9xYndpWkVQdlhnZlNkdGlS?= =?utf-8?B?Qnk1eVkyNnp1elJVa0k1d0VyWmQ0QmViWTR1VVh5djl3T0svYzNpTVkwSDFu?= =?utf-8?B?dCtsQUl0YjJwdkRmMll4MXZFdVE0Z1haUENxV2h0UVlFSUYvYys0bDhGTm9y?= =?utf-8?B?Ykl2cVZXTnM5UWVQZDdaWGRPR2dWdGU0ZlA2blhZMS9JNmdXYzNWSW82UURl?= =?utf-8?B?cG1TWjVkTVQ2Zm41WmE0VU1QN0RsNmgvL0J3bDRXYWFFMmRjSmVpdjRGeTE3?= =?utf-8?B?Y2tGZXNNQkIrZitjZGw3bVlrTkpoeDdlRm1aakdzU1YyekRhTGQvODdseUxT?= =?utf-8?B?VVV1cFNuRklDb25XdTlFb3VwYkRoL2Nab3Avd2hhaFBMWThQbnNuWDM3N0N2?= =?utf-8?Q?n2khMzISRW+NUz3wwk=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8abca6-421a-4cce-748d-08da76188004 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 12:54:42.7602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB7398 Subject: Re: [FFmpeg-devel] [PATCH 07/25] fftools/ffmpeg: remove OutputStream.stream_copy X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Wed, Aug 03, 2022 at 03:58:26PM +0200, Anton Khirnov wrote: >> There are currently three possible modes for an output stream: >> 1) The stream is produced by encoding output from some filtergraph. This >> is true when ost->enc_ctx != NULL, or equivalently when >> ost->encoding_needed != 0. >> 2) The stream is produced by copying some input stream's packets. This >> is true when ost->enc_ctx == NULL && ost->source_index >= 0. >> 3) The stream is produced by attaching some file directly. This is true >> when ost->enc_ctx == NULL && ost->source_index < 0. >> >> OutputStream.stream_copy is currently used to identify case 2), and >> sometimes to confusingly (or even incorrectly) identify case 1). Remove >> it, replacing its usage with checking enc_ctx/source_index values. >> --- >> fftools/ffmpeg.c | 23 +++++++++-------------- >> fftools/ffmpeg.h | 1 - >> fftools/ffmpeg_opt.c | 33 ++++++++++++--------------------- >> 3 files changed, 21 insertions(+), 36 deletions(-) > > seems to break build with shared libs: > > CC fftools/ffmpeg.o > src/fftools/ffmpeg.c:405:32: warning: suggest braces around initialization of subobject [-Wmissing-braces] > struct sigaction action = {0}; > ^ > {} > src/fftools/ffmpeg.c:1612:37: error: address argument to atomic operation must be a pointer to non-const _Atomic type ('const atomic_uint_least64_t *' (aka 'const _Atomic(uint_least64_t) *') invalid) > uint64_t frame_number = atomic_load(&ost->packets_written); > ^ ~~~~~~~~~~~~~~~~~~~~~ > /usr/lib/llvm-6.0/lib/clang/6.0.0/include/stdatomic.h:134:29: note: expanded from macro 'atomic_load' > #define atomic_load(object) __c11_atomic_load(object, __ATOMIC_SEQ_CST) > ^ ~~~~~~ > 1 warning and 1 error generated. > src/ffbuild/common.mak:81: recipe for target 'fftools/ffmpeg.o' failed > make: *** [fftools/ffmpeg.o] Error 1 > > [...] > This has nothing to do with shared libs. It is just that C11 defines atomic_load in such a way that it does not allow a pointer to const atomic; presumably because atomic types might be emulated via mutexes in which case even a read involves a write. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".