From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3099943BD4 for ; Fri, 22 Jul 2022 14:56:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3045268B701; Fri, 22 Jul 2022 17:56:26 +0300 (EEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-oln040092070033.outbound.protection.outlook.com [40.92.70.33]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 25DEC68AF5D for ; Fri, 22 Jul 2022 17:56:19 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fNoUSedPS8r/N0Urc+CP0X9tGMI6gHYqwxiqlYb5GPn3FUFUJSzzUMyo1rKWCEBz22T9NMMusOW9J+Elu2UZb2XXoBlYXt343Qv7vd21lph1/K9LJrVEnhq6cKAq2Po/2oiq+Qbjx6uotUkm8KYcAz61XMwwOtE772KPD/iDcqES3Z6RBngmbivp+/44UYHCiDRXkskAlIaeMxa13TGebjwmG7siIjLFwh9+3yXp+/+KTaIPxe5A5fUL+t5LcHa/04YcoYKXJR0/tNcjht3LjWvQwgvlpXKycqYqxLI125UUTsjbcz7VC9O6ItBEXBEgvoQ5bVDRuOfGFpWKfbEjYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IP/NeJv4de+g+1/qhhF4P3NxES6c8orsxJ+geOqgb1k=; b=MSiAvPewe7+cQ/5l8w641W6FE85yXzsOgwEG0QIKmm0RfgwpF6zJHLd9AgGqeNaN+Iumhb+ICGJy6TI8EhZOgQgF10ew5d1Jkcn0zwhrDtX3O5kqUM/keHmvfYW7zd8Sw3hALc+UsiORbdhP1ts6FoCZ1lSpAGympuCQd2JW7Un8yLptpXmuZfALwCcP+0YQLxUJl5ovLrUp1oDl4gSCmQo8lMG42aRiHYd43v+UZO9BODs7FR5CmCsrCZ84+sBjCWj/an9yZ3lYUFo1GPECkG9rgMs4yal8gXKr91bKZrCn3GCNwq7mK0MiQFcqiWUOfkze3UBzmJR3EvZS1K8Fyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IP/NeJv4de+g+1/qhhF4P3NxES6c8orsxJ+geOqgb1k=; b=ShKc7DWZIvPaL3bcZYxUM7+WvyG2QB+QSnESjPzz/APQa/nwiTEY/tGZc/mn3uq4M2FMkHDYT8K4hCVNIsCaNYRQHPdm7K5Gvosl1M8K5qc2eo9exgiO+j1wh8gtBFbDMIgRcpsQ02wYo7fryCpo3tyPjtrcu3iDU/hvzBC7xsR9haS/1EQO+5ih+B6mArfaoksssnC3/D5+Pfh5W7BmhPDg63WO/9jDkdujdzzOFSoWWtWg4q7+2DA5fPbahRgiWZXXF17gtsNc5ePbyeVP11VUJbimzBXp6jeQZWhl2IBCPMVDjm4nxQwL7o46wwyZHcwPYnxT2jmh7CzzlN2fTg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS8PR01MB7429.eurprd01.prod.exchangelabs.com (2603:10a6:20b:259::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Fri, 22 Jul 2022 14:56:17 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5438.023; Fri, 22 Jul 2022 14:56:17 +0000 Message-ID: Date: Fri, 22 Jul 2022 16:56:15 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220713175948.1955-1-jamrial@gmail.com> <8b484a4e-ba96-d54e-a4b5-84e1ee5e53f9@gmail.com> <3dfc3a5b-6b08-e36c-44e7-40cdf062cb3c@gmail.com> From: Andreas Rheinhardt In-Reply-To: <3dfc3a5b-6b08-e36c-44e7-40cdf062cb3c@gmail.com> X-TMN: [evZra7Yqd+htO1ZXtncIyb8wzMOCeVLQ] X-ClientProxiedBy: ZR0P278CA0144.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::23) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7a181efe-712e-4871-b246-08da6bf2547e X-MS-TrafficTypeDiagnostic: AS8PR01MB7429:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xeFJHay1bSeIeZre2of8j/IZlo8nCJRLUqUhy2CVPnUniDSf8zpM/Q6WLWsbTro/hAZcA4ITZErwZBRZTOdf3bmxi/m6PIwoph8L2cN8yBIcstDRXzyiihWymXhOi2ldtBNe4sgrR/Fd7zxR9C7VlHv2yqeUI7amTV7f6Y2wXuFnHtDs6blVVebuTIiskOhE0auyTkjpCiCxFBuc7F0J26GBsyZSzCwqoJhuuY14LIlwl82gTEcEPSPSURC3/51qOvi5L6+RlKivjR9nhh/0GVBm0zMhOUEz3SAZZ5tYqYu9EDvDN2+Ht1hRLpxOeJ55geeSp8mmGR7zT4Po/CpS430QElwUF2nDmU7zc9aUwhEIRTTfxBdwr7KO8ps93wrFPfnkeTVSMghKFhb2L9KO3LyGbfXm9+lxBc1e1FNzZ/MCM1V2gJc5f6yib9gFc5M+8T1HC0ZOfR3izvWmx2pY0XxGGawzYTAHQmc/j+x/paF7sEF7yVa4+ScNaYyzODGcFMTGAmy/UEn9s5m/RCR8u6xKCIkrhLHstns1rR4ST7YyNTV5/BOJ1zTlOy+T63JKylSyps7EhecXsyFiXdsZBG16hhqCFSH6Xlyndl/UwnCy3LDji9Ezh/7W9FZzAyJu02owl1MyyuIQResbe8UD5E8FToNcqFjHgAUpFGjFuBlaxeX7kncE4r7/WBCAbhub X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkU3T2trVGh1a1AxTTNxOGJUcExOUm9WWGJrWHRtK1h5RXErQklDTUNaRkdp?= =?utf-8?B?U3FyTnJEUVpJZXJMZno3QUlTQ0RtbzArQUE4Z2V4b2FWN0lMYkJIRTV0ZzEw?= =?utf-8?B?UDhndWZocVVWell2MktyRGQ5TmVvWkpLZ0xqZ0lwZVo0UzRyR3hNRDNqMEFS?= =?utf-8?B?TnZqbUlRSk4wVTVjRllndkp0bHc5NVdiQkFZVUdveDZFQ0dZL2hRSTcxb1hr?= =?utf-8?B?MG50a3hFWW1NY3BlaWVTdEpsTFVwa3hyS1BjeVd3SGRMLzh4NXNJbVZjRUdE?= =?utf-8?B?VXhBWWU1VHhzVFVWSGhwR0taSWw5anhGeWJQZHA2SWwyQmtjTUFJZHN3RTNi?= =?utf-8?B?RW81V1hyd24wYU5YTTg1c0V6dDI3T25leWRRdFM4K0t4VGx2dUVjYUdyY1oy?= =?utf-8?B?K1hFbUFITkx2bnkwdFdlMkJ5bEhHbUdaTFBwTWZpTktGZ2VBOERkdFFlcE1M?= =?utf-8?B?VllLT2FuVE5hWCtBYk90L1F1NGEvRUlQOXJOWTlFT3orekVDRVRRODNDVk1p?= =?utf-8?B?emJobHoyNUJSdFduNWJubjVjQWE5OHZ0NXZDWVd5WDV5SjMxdHdtR0dmdWth?= =?utf-8?B?Tjd2VUVzWURwaW1yKzNtSnZsdFloNU5NYmFkc1NLaFN5ZVVaTUVKWlNSdWoy?= =?utf-8?B?V29LSWU4WldxK0pDVTRQTTZpejZwYUJBamZ0K0NhRllyamNRdkJKd29GZkdL?= =?utf-8?B?UnEzMXhjTnIrY3ltWHo2dXhmeWowRzd2M3FQQzB3VGhNSFAwUzVYbnM5R1gw?= =?utf-8?B?NkpTUnZPdTRyRnFnYkE4RnlmaW40TldZN3BubERkUXpQN285c01WWWhiTVFS?= =?utf-8?B?NUFseHhIczBjakN6cDBKUEgyaXl4d2U4MEdSMHhYVzdxdU9ZSytHYWlRVVBS?= =?utf-8?B?RXNhd3QxL2dUNnNoSU4yQ2hHamlZZ0pQQlBIaUNOSkppL21yVUFLUVVuWUsy?= =?utf-8?B?eW9tVGNsaVhkVDNsOG50MVcvQllxb0pWVlMreTZPaUJFK29XTWw0QWtic3A3?= =?utf-8?B?cy9YOWJReWFoVnA1Z1N2aDYrc3ZsVlJtVjFNbXlzcG9GQ2R3YTVxd3FFZ3JF?= =?utf-8?B?Smlza3lDVmdMSTFBQ0hXVFg5bVU1clJzZEFDNG9WNzg2Uy9aWlBjZlU3WjBv?= =?utf-8?B?SW9Ob2YxY2ExYWV3dHhGRzNSL0xFOFVlNzBpL2lkdUhFM24vaHdCM2t5ZXM5?= =?utf-8?B?TGYralhYaFdKMms0VmxVZ2wzWXJVQVJTdWlad09rOVRwVzd1TXFnOEZyUWU4?= =?utf-8?B?dkFHWVByR1d2R1MyWHd1OWZyL2NoREYxSzJ1WWZKekFBVCtDai8vYVd4eTV4?= =?utf-8?B?MnVrNmkybzdKQStSa3hsc1NnSkhsRFBSU002N2Vpb3A2YjlMc0FDaW9YeWY0?= =?utf-8?B?a2ovZHAxOFdTWW1BQ1ozcFR5bGhqL3B0L1IxdGowRTFRM1cyd0Vxa3BKcnYw?= =?utf-8?B?WmFvZlQ3aTRWVnRNRStlK2xhbXJMRVRWbVEwa3hvNkk5ckhmR2pIMnoxSkZp?= =?utf-8?B?WCtDbkZyVzdXbkNkSW5Ybm1oZ0pPdWl5UjJFb2QvZVByWGh5Ymkwd1piL2FO?= =?utf-8?B?U3JieVV4MDVzc0M1eUd1VDhLQnlhdjZZZ2NSTURNWHM3cFR4REwzS0FwbVlE?= =?utf-8?B?Rlp0eDBqL3B4WHcwLzZSdzc1djh4STlSV011V0RnUUJwMTNwZUk2TFRMOWo4?= =?utf-8?B?QXppWFFrZWpWNDhYWTBCL1Bxc0laaWR6d0ppNXZJSEwwR20yZkhNRnZjRVZM?= =?utf-8?Q?pdVetRkE+AgFOFJ25o=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a181efe-712e-4871-b246-08da6bf2547e X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 14:56:17.2537 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB7429 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: don't force HE-AACv2 profile if no PS info is present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > On 7/22/2022 11:23 AM, Andreas Rheinhardt wrote: >> James Almer: >>> On 7/18/2022 10:57 AM, Andreas Rheinhardt wrote: >>>> James Almer: >>>>> On 7/14/2022 9:10 AM, Andreas Rheinhardt wrote: >>>>>> James Almer: >>>>>>> Should fix ticket #3361 >>>>>>> >>>>>>> Signed-off-by: James Almer >>>>>>> --- >>>>>>> This also needs an update to some fate ref samples i'll upload >>>>>>> before >>>>>>> pushing >>>>>>> (fate-aac-al_sbr_ps_04_ur and fate-aac-al_sbr_ps_06_ur which are now >>>>>>> decoded >>>>>>> properly as he_aac mono, so the .s16 files need to be replaced). >>>>>>> >>>>>> >>>>>> We have both a fixed-point AAC as well as a floating point AAC >>>>>> decoder. >>>>>> Is there actually a test that tests that the output they produce is >>>>>> reasonably close? If not, could we make the test so that the same >>>>>> file >>>>>> is decoded once with the fixed-point and once with the floating-point >>>>>> decoder and then compared? >>>>> >>>>> That wouldn't help much, i think. Almost all changes to *_template.c >>>>> files are going to affect both decoders, so a breakage would not be >>>>> detected if you compare their output with each other as they would >>>>> both >>>>> exhibit it. >>>>> >>>> >>>> I actually thought that the aac_fixed tests used checksums instead of >>>> ref files; then changes and breakages would be visible by changes to >>>> these files. Apparently I was wrong about that and the ref files are >>>> used for both aac and aac_fixed. But a test like the one outlined above >>>> would nevertheless obviate the need for a new ref file. >>> >>> Judging by >>> https://git.videolan.org/?p=ffmpeg.git;a=blob;f=tests/fate/aac.mak;h=1743428f544fad8946dba11dd4ecec0630eb70a6;hb=HEAD#l117 >>> >>> it seems at least for these samples the fixed decoder does not generate >>> a decoded stream comparable to the float one, so I'll just upload a new >>> raw pcm file. >> >> When I decode both of these streams with git master, the left channel is >> pretty much identical, yet the right channel of the fixed-point decoder >> is silent and the right channel of the floating point decoder is not. >> With this patch applied, the result are two mono streams that are pretty >> much identical: The test sample created by the floating-point decoder >> works with the fixed-point decoder test (if one uncomments and modifies >> the latter). So the issue with aac-al_sbr_ps_06_ur is not a reason to >> upload new samples. > > Ok, can you suggest how to add a test that decodes with the fixed point > decoder then compares that with the output of the float decoder? Is > there a helper in fate.sh already for this? > There is currently no helper in fate-run.sh for this. >> >> - Andreas >> >> PS: libfdk-aac produces a file that looks pretty much like the floating >> point decoder from git master. Are you sure your patch is correct? > > Yes, they duplicate the single channel in the stream and output it as > stereo, something that should be done by a filter if that's what the > user wants. Decoding a mono sample should generate a mono stream. Not really. The channels are different. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".