From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DFC96435DF for ; Sat, 18 Jun 2022 06:49:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCD2568B586; Sat, 18 Jun 2022 09:49:47 +0300 (EEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2047.outbound.protection.outlook.com [40.92.91.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 16E9B68B56A for ; Sat, 18 Jun 2022 09:49:42 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jqziXOI1hD0I/UR+lXSKZLePTUOE7FIyTnkaW0t3++eBPgGaykECcVDKXIC5QKK9d5ahvhm0N70veH0FY6pw58Z/kKx4+q8f9pRB9jb48DlMzXsXJutE53R0QRpUu9WTl2iqGdjDUkndWd1M/fVp8rioJGyrPbhOvNSzSyE4UK8G0CShWtp3ycTSk2kDXUnVzlU/IYXFIvt1rqB1dJtOhuL01QG/iMLQBQdz2YDXabWHIFsggnFcTn4CV6reW5Es5Rys2C/F1dBEfkl3E7+z95xTB37JJRyp1XHQ9dluZf0FWv7UJJlA3uS/JB+5m6tdAZ+tfn5EjHutK7WQBczRgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J86L06gijhFNH4u1QT3DaCcrIfeSCpsi5uoqWHcs2Qg=; b=XqM+AL+GzJvxNwFIcPfZLgBBeg1sgmvUkXd+XvzGC8x0iVmSLbUnw8J2TC5xexeANVdioYKjiL5WHhnScb39CzYzJccbIziNqBLeLSgfbDOw845p3cZ6UH8/Nhs35cbeaKd0vV1MU2CFvWRIoSXZiXvIOsTT4fZdw7DdXFFDqFoqGU93g4uemuolbr2LnVEG8487kpotxVqAeQldhIqgoF1AIYcct9vVcXORQNhCB8kERIBTMY9ZjVG5IYEwrj8u2QcPUHVo4BPtPDhRerxueV551KwrC1k56+lwrGHqmOiTFzihA1M5tVsNSU5HxTRjWH+gjTvE9GYJJFTyuATsAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J86L06gijhFNH4u1QT3DaCcrIfeSCpsi5uoqWHcs2Qg=; b=hmlO/5fOt43VNIhorst/8GioaSuJ7ztpKrcR6iOn/BDHHsWWpaeUkCw9Hg/YYYu3Wf3jZa/tJerhEzqzUcpnE5X+KkRcCv+3SmREdkwCuGdT61lZAyI65CqgOTr/Bsa6GNYE5IdaS09NFz6gNSIyBi4J18lnn6qKQTn6amgWtrlt6+SabsQKiU3EEk9RtLRnaZevxaMnLtq5h47JUVWjEyZUc14joNkKgAzOEtQkWC9pq2PQNdGz7YC0DBTxXb5g493Kt2ouNKOueIZRY90BpMpE4XIFp2D5HtPYH4My8agmMcluP7d2g8Mc1XmF4CSboFcuTDzEdzKGe4IvkHT2/w== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR01MB4503.eurprd01.prod.exchangelabs.com (2603:10a6:20b:6c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15; Sat, 18 Jun 2022 06:49:39 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.016; Sat, 18 Jun 2022 06:49:39 +0000 Message-ID: Date: Sat, 18 Jun 2022 08:49:37 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220617054451.6127-1-ffmpeg@gyani.pro> From: Andreas Rheinhardt In-Reply-To: <20220617054451.6127-1-ffmpeg@gyani.pro> X-TMN: [FLiPKfTD+xn3//8uBDTAE+5ElkLMsuBI] X-ClientProxiedBy: ZR0P278CA0093.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::8) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <93122df5-36ba-8984-76b3-c415fb3c8977@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93da9beb-8ad9-41de-a258-08da50f6b741 X-MS-TrafficTypeDiagnostic: AM6PR01MB4503:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XWJ5pyyjaJQwl615xZujU4+64i433RTCE6CF9NFx3Z0GuBYkgeuLbmTgLXbvLQOO16OR+O8n5HXX622v1J45KaK83B6LtkxauONp0mlx4DqlwovM45DSeaauXlLlMq5Wgmbq5dV7JLiTI+d91zmGCFRw2IvMNSiL3QAdRESZ5wOmusL98bCgzdrpoKSwwBa1rvVpiosYPm+5M4HmDXNxfpp8sPHiZ/8HB+xQr1uA2XnxdDrjyYFKSyiG5yywS9HYakxSrxeQS6VJJJidp/4mS0RNr18tqqdQC/k0CRW+yaP+kBst1DRUx3eyxE24Bt7xrzgstCDMiS4I1sFDGfgZfaTHIZsbHMZ9gp82vjTN+mDwSG1jvwdkR+5VyK/E+rebYcJuIE8Ay4o/SU1+oTV5PzArsCsqEdsGNKc2LNbj2JAvI6o9fLhexYmzanJX+noqlrNhE6gHw20vNl0aan3sa7D1qc8NFia+WngxJqXG5auOO9gXX+t0Wdne+0ajKMnnRiBgEvCoYZD6EFCktR1zznszUI6haJ5m3/QOWsDkzq03P9rmN5JRsKWsHzpgjFJK+26Epl01lGeboA10sk2JAg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZE5wZUtQKzlOMi93Nll0SGZ5dXltK3IvL1dRYnFVamZFRFcyVjlORGhDUjRi?= =?utf-8?B?QXhkY1pudHEyaW9GcC9JUWREbzQ1ZWhDUGQrdUFBSmxjM1RhQnpjWThHcGRX?= =?utf-8?B?b0UzdWpxdUFqYm9FMUR5d1E1SEovdElJZXE5cDY1amprdUU3RExLWHBXZHhn?= =?utf-8?B?bEdIZ0lBT2hvdDdqWmJXN3lZdHNwMjZCZmYxS0FXNUd1TlVyUHhTVmUxMjEr?= =?utf-8?B?MElsaXFBdWZYNFF1cXhVN29aV1lWNDlOcTY1bmJSVHFtM1l1a0Rsd2pZTTFF?= =?utf-8?B?U1RISXprY2lFL2ZFcEZjR2E4YTQyN3lVNGExVElNQWJ2aHFWbzBobVBsazZm?= =?utf-8?B?bDlQa3Q1dVg4alExVS9QSjh4NTRsem5CQUNBWkkvSy9HMjMzTzVqc0tUN2JH?= =?utf-8?B?amlyODlCNFl3cFArT2Q1N05yb3ZRWXh6WE1JQUNFcm41U2tUb0lneVBleDUv?= =?utf-8?B?YWNIYVpQZHFqMWszSi9KdFN4U1FwbW03dUE2WnVoTWtEcDlNUjloMERqWStr?= =?utf-8?B?dnZzaXRnSWhWZlVOVUphWW1zVUZ2REQrN0JLanhCREEyK0xYeDJENU9vVnZF?= =?utf-8?B?dU13bFFuY1dZOUFFUVE0K3IvNUxtWkV3NTRUSXpscHNBeThTMFJ1WkdqRDRM?= =?utf-8?B?Tkhsa2R6OUVMTzdiOHNRZDgvT0Q5c3JUSnBFT3RyU2Fhei8wSkR4ZFlmY2ZR?= =?utf-8?B?MEYzWnJtdkZEaTlHeFQ0MVJGVjRDYW94Sm9XRyt3YjZEZlZ4UDlHWHJ4VVYw?= =?utf-8?B?T1dRRFpFMmpGa1F1L09UV1EvakpNUUhFOTBiNGNTR1U3NWVSTXhlRnRkejNp?= =?utf-8?B?aW5lVG5Ka05xcTRYWHZNaVdZcDJOS2lpaGwyVTJ5cHBzRStOTFlNUWQ3NWJS?= =?utf-8?B?cytUUVFHTjU1K3lSK0ExYmIwc1l2VXpCTFl3RlpJaVhybzBHdnE1UDNYNkwy?= =?utf-8?B?eHpTeEJuMDdiVWxzTGJrV0ZiSkptRThZSkZJTGlJMyt5Vld5YVBPaTNSTEVM?= =?utf-8?B?dUFRTnowZ2tIMjY5Y0VSaW1LSEdOdm4rb3k0Y2w2Nm5nanVRMk02ZGg4MWsz?= =?utf-8?B?WHorQnp4SW16enVFa2thM2RpNlhxeXBUd04xZHF5UE5MUFFwUmtMVjI3YXZs?= =?utf-8?B?TGRsQjc2S2F6TlJFUnBTK1h6Q2lIU0R1akYrTVlWVERQQ1BtNllBZWliMExt?= =?utf-8?B?UnZxZzBmZHR3bjFTQ1BobFM3U1c1d1d3MGNVTDV3QWJ3QTVTV3RJOXpvUUlD?= =?utf-8?B?QzlsSlI4WEFXT1lhaklMMk1iUFFUTlBHS2lycTUrM05kYzNuWmNSbVV0MHEr?= =?utf-8?B?cVl2SkRoNm1LVkY0ZjM3Yzc5UjdIWnh4cms4RUtJa3d6U1lXeWFJOG95RXB5?= =?utf-8?B?c2gvY0J1Z3EzSGdIZkhMMDV4TGNrQ3RueHhNNkxveTJvTldCM042Ym5qbkxt?= =?utf-8?B?SzRSSHZFUzFpeHRyNnkwZDdjc09UdHVuSDVCdEFxVlV3WGtvMzR6Mkl1Y3ZN?= =?utf-8?B?cE1ZRHRkcExkeElGbDNTWFpzL1FxT0dFR3lKMkFwUEFWU0Rxam5GNEZsanlT?= =?utf-8?B?QlIyY0l6TGE2U3NVOTl1aHNHYlFYclhnbUVFTml3cGtFd1NhNjRTK091Z3hz?= =?utf-8?B?ckRUL0o0bERQQnJMY1B4RjFIbnN3dW51UHhxazM4dUlwSjJqRjRPY0xnNFBx?= =?utf-8?B?REs1djl2bXJFdkthUXJiU0U5eGVJVmlpQTlIZ2NoT3FJQnZEWTYxb2R1WHIw?= =?utf-8?B?MGlOZHg0YVRWa3JJMHdCNFNmOCt6THBsdWttUGs5ZmYreTZCYm1EMHJKc0t4?= =?utf-8?B?WjMvS3RZbWZVTHVxM3pvdjRyVkRESkdOaXhtREVCWmlqQTNYL05velR4VVhD?= =?utf-8?B?anU3TnhYTm9QVnhsSjNoSUJobElMN1N1bkllM0RxVU96cHRNU2RvNmFLd21O?= =?utf-8?B?OGpMZC83R0I1Z2tsb3VBU0JZWUJpY1YzRFZvbnMyNzkySktiY1NNSUhqS282?= =?utf-8?B?d3oyV0tPbTFBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 93da9beb-8ad9-41de-a258-08da50f6b741 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2022 06:49:39.5711 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB4503 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Gyan Doshi: > Default avctx->frame_size is 0 which leads to init failure for > audio MediaFoundation encoders. > --- > libavcodec/mfenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c > index 13ed7b3e11..ff9ffe4827 100644 > --- a/libavcodec/mfenc.c > +++ b/libavcodec/mfenc.c > @@ -1066,6 +1066,9 @@ static int mf_init_encoder(AVCodecContext *avctx) > > c->main_subtype = *subtype; > > + if (c->is_audio && !avctx->frame_size) > + avctx->frame_size = 1024; > + > if ((ret = mf_create(avctx, &c->functions, &c->mft, avctx->codec, use_hw)) < 0) > return ret; > 1. You forgot to mention the ticket that this is supposed to fix; you should also add that this a regression and the commit (827d6fe73d2f5472c1c2128eb14fab6a4db29032) that supposedly introduced the regression (if this is indeed true). 2. Where does this number come from (apart from the user-provided error message)? How did it work before said commit? (It seems that frame_size was unset before this commit, but did it somehow just not matter?) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".