From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8E63E42685 for ; Sat, 25 Jun 2022 02:06:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 21D3568B757; Sat, 25 Jun 2022 05:06:50 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064074.outbound.protection.outlook.com [40.92.64.74]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 55D1168B456 for ; Sat, 25 Jun 2022 05:06:43 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VNSGDBik7+bMq72LUJJ/GLW9MnTQQWSXTa/fPKDRI8pxUykKUCL4h+4Y/fnc7HKTzH4BtJhxvoyUYBcqJUUBGwLc7CObBfGwtjAopr9RcEKw8xFCOWsB2bdoElcCM0G3aerp6M0I6v7lWtaec+ZK1NruUhs6mCthHLAyl1tfcS9B5A6XmeCoicfbKHjasi1ziDOeAdR5/XoWKDt84IbPMaxKQgybpioQ2rp1IRweZUWc9F/4c0fNDt4VQ1M0o1c2VJ2BlcUEiWZ26oHta1TkHZenf5RmHMs0hysMNJ2BpTp03UGAe6dAlhU2dBisDDZHS2fs7FVlb3bsuV3+KY6T+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+0e2wPMVLq22HHzitJJNYkRNKjAfxoH4jIQXOjWnBHo=; b=WaKEsnJGe2HiKZ6WfRFdMjHQ4qr/TYXrTkfjC488jm7nRZ5I6T2eW9r7Xm8olIKlcKqMb7K6xuzH9xJh2lPk3Z1/M56zNvxtctlGTlOBtIMJwALxwZs5wvVbMKJHdPzbkpZMpLmRN8r4UZE7qJsOpThEaEzeC9bQWhUEhg9SXpcSBbdOEWgZV7rmsWoqoHcMiM1QZ0kQwzXLJP6IBCMoqu2Cpn+GUDFrEz/TG2IFLNm0lxSxOIfGBXjIIivMq7+yuski9CrHnNSnzVQf43BplbL9hzkZ1OBqcCKN+oaKdkc+R6MTZ7C2iWyR2zyMPM9OkTyi95mLPEgSR7HwOWzvOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0e2wPMVLq22HHzitJJNYkRNKjAfxoH4jIQXOjWnBHo=; b=K1LLq+EyGnJ+OSaHVkyl7OJtZx0nbdQx+FnZz8RUapC9GoTpYlLAxUYCLs3+X4e5cYAQO+IZQt7eqYxR9n6mo1SI9kEUTypueVJd2zFpebAyMFP785vDV9JUbugs8AiuU9akawcdS16FuAJ0GMXTQ5G5kCO6nhOgExDipZlFyQ4/gyXRbiHtMFP1fcjj5RCYpJc4a08e6Dd0ExLOEFuSMIkKjUkgm8W5dvKrFuwvEpPPe0g7bP0GdOgsL/RTw82S2Kohc5g2iyGOhEqjlu/rx8pOdEGe58scAh2+90Ng/O2aQ/kUltcc8/K0Zbtwc+H7bO4LSPin/ypO1c/E/NgByw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DB6PR0101MB2552.eurprd01.prod.exchangelabs.com (2603:10a6:4:32::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Sat, 25 Jun 2022 02:06:41 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.024; Sat, 25 Jun 2022 02:06:40 +0000 Message-ID: Date: Sat, 25 Jun 2022 04:06:37 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220625020323.16181-1-jamrial@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220625020323.16181-1-jamrial@gmail.com> X-TMN: [1DF7RrMtHZGFNPyMrQbSUor9ESS/l4S3] X-ClientProxiedBy: ZR0P278CA0005.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::15) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 74cb715e-b394-4307-cd10-08da564f573c X-MS-TrafficTypeDiagnostic: DB6PR0101MB2552:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3kl8Ir3mbmlK7Q6aGbi0OoT1LEBHTuB+dAVTATdZSNc7g9TAZnipGyrMeFcd6oRdypV8rxdvg5DSsj8TaN1y/VmWrNexiGz9cH9MpM6GV14O7i2IpcFFaoUIk8wprHnmvLiJjGHh5egWucDG5Z3i14JcXAuJwaUlNRh20fpKXOtd0hbAyhPH6c7tKCrq1M27BThWYjmwp28RDvFJQbRdMP9vRyVFCq0rvyhsZf2QGUDhP5x2nvrgf6VILn3hFVYQU6pED+PUi0L5Os/rCs3y2nog38+FI2MfIbUt7Ovj53JcajQ1TVi6GtD+M7522t1mQvggxtwLetUhuTSEpTzyEKcvpEa7GcR44hXjQZQEwXKfb+EPNqAHtD47B1/kE3h8DyEUS84K55d6fCaZslauCoG3nIDiKEUGa4doCoRGppsLE8Yfks3p3H0vF+OmLDDrlvFufT1UWVnYUber1G8JANFchgp7LgEYGA0rfQ3IUADhE7zIPu4L869G1OnN7m9Y+aE3loywE/PaDerrNXWlJaPaxHAgVrP4kzxnYJ3XIqCrpvbBOlaJlHZXzaaxpAA27UicyvmJi5ipg/6XXN9zwnZLFYlx/2F42CzM42/xkLUBcCXBIilReUU6sBSFS0e3ycbaH0ik04H6VuDnEgLjHg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnRjclBwSUU1OUw3dG5taStSUjdJUlJTL0RtNEExbU9mVUp2ZkV3QS92VDFx?= =?utf-8?B?dEVxeXJXc1ZPMGxzUlAxWkU3ak5KbHYyRExTSTVZUUQ5cXgzT0VqRy9tUlZP?= =?utf-8?B?bk9OcFg0Mjk4UmFiMDN3ZEN3ZGh5bFBxTnFBVDBzbTlVaDBrd2JhUXE4Y0RT?= =?utf-8?B?bHZTekQwYmFYclQ0VU5jTVNESElvSE83OUtnSnB0UGMzbDFCMWI2Y2NRYXRo?= =?utf-8?B?L1FRNFNHSVZEbFZnVXdsUnNsaUNYSVZQKzFwQnhlakNkVEpOUytLWG1UZ1F6?= =?utf-8?B?ekhEY1RRSVFZRHlpNEVEdVF0Q2FVbGQxU1M1eUsvL05EeEVXUzlyNHV1SUJ1?= =?utf-8?B?QnJEaUtwWEYzTzZVTnV6WFJWa3A3NGRFVEpKRTh1L0NZRUpNcHZPTFloSjJ2?= =?utf-8?B?UGxVY1l6R0I2SFZzYTJhQ1NYdWZkVjlFQ1ZEV0liL2VKRHFLaHRqbmJOMVhi?= =?utf-8?B?Uko0NHJyeVdUNWp5VXAvd3JLcHJZemhudWo0cmNGQnRWcWFEeXYxdm1vOFp1?= =?utf-8?B?MjI1MlAxNXdyRVNuRlVGNXR6SVFVYWVHUUdUVTZtbDRpUXZ3Y3cvSk85UCtE?= =?utf-8?B?MC9BbkowYVEvbEQxSi8yT1FlUWJuWExJc2JtZnRqT1RhbGNnNGJoZ0J4bWRE?= =?utf-8?B?OVpmZkFXR3d4UGIwbjIwSDFpdjhrZlM3TFI1OGdLUXFlbFlmdmhSSnlaelFo?= =?utf-8?B?cC9mRFE0c2UvcVdUTWhEVE11dU0yNVNRZDNEeUNCZ2doSGdsMk9NbUlkZTZ5?= =?utf-8?B?WE80ZXc3VnRRQXVsNUFZOVMwaEJwYyttempyNVpCTXdYdFM5V3l4cVduMUtX?= =?utf-8?B?a29hOHZHSWxFRi9MU2NBM2lUS2JmVlUyMFd4d1ZvZyt3MUkxaG4wZkNsNjZh?= =?utf-8?B?VlRLbGFsV0hkTnNXZFVjOXdlSm5tKy85UnVGMDJveFB4aGo3NDR0RXBUd1J6?= =?utf-8?B?QUlhK3BoVW5Kc1poMlZZNFJrVHd1WncyUTZLRW40UWZBVTRZNHMwNnZDWHM5?= =?utf-8?B?ckRKYk8wdUZFOWtqNGx5SEJNVzZwbDFPZVAvbDJUYm5IZXl5RnhteTFMbUtP?= =?utf-8?B?SlNMN2ZTMHBWTkNTZERNWWdtc0dubit0YkJDVnp6Q1dGSmpZbmtBYVM4c1lo?= =?utf-8?B?RTRVak50TDhZbVBFbWV3b1BMdDhyTlN0VzlzRjhFYTdHem9vK0JVM1VLZFpp?= =?utf-8?B?YTlmbUtYS2VuaUJBKzdORFhTSlVuRnJNVlNSR2cvSi82ZWRhRnRXUnkzenhJ?= =?utf-8?B?U1U5bDlxNjA3T3kvYmVyVkJVYWJIZGRUblBGOW1Ea0ZHWlZtRzl3Sm40VFFD?= =?utf-8?B?dlN0d2k1NUh3bER4c0dlUnRNQ3UxNTVQV3YrVEVjMlM0ZEEvRWpiT3J3Z1Zo?= =?utf-8?B?TE1OMmhVU1BsSTZZMGxXcE05MUxTNzNnbmJsMkJwS2xVOXIrV0ZWcE1BbmVr?= =?utf-8?B?djNmeFpKUS8ySVV5Zlo1MzFVTTc0NXZzY1pRa2wrb1JkYTFoMFhzeWM1NHBC?= =?utf-8?B?NWVyRnBCcGthTlNjcDFFNFY0VjVwb1Q4NFFEblFkUFhiR2U3ZGhvYllBRzNY?= =?utf-8?B?ZmRnYTMwTzhjcnYrZEJNckp5N2ZldEtXTDcxSDVvaGE2enM0WTVIVUlkakUr?= =?utf-8?B?VFRGVGZmazlQaW02ZXFpcitpT1lFQ2dIQWNJNVZlRk5MbzkwU1puckZXam1i?= =?utf-8?B?ejF1NmhXaWFZNVI1NFUrSmEvdmc3WUpMMVZWK2s1Ryt6d2QrcXc4QVlGZ2Jo?= =?utf-8?Q?SM5pDPz+oreFsr6XDA=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74cb715e-b394-4307-cd10-08da564f573c X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2022 02:06:40.7665 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0101MB2552 Subject: Re: [FFmpeg-devel] [PATCH] avformat/http: include version.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > This is needed to get LIBAVFORMAT_VERSION, used as part of the user agent. > Fixes a recent regression. > > Signed-off-by: James Almer > --- > I dislike the fact AV_STRINGIFY() silenced the warning that should have been > printed about LIBAVFORMAT_VERSION being undefined. > > Before: > ./ffmpeg -h protocol=http > -user_agent .D......... override User-Agent header (default "Lavf/LIBAVFORMAT_VERSION") > > After: > ./ffmpeg -h protocol=http > -user_agent .D......... override User-Agent header (default "Lavf/59.25.100") > > I suppose this is a regression since the recent work to split the library > version defines into separate headers. > > libavformat/http.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index f80ea7bf35..c5c48c7900 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c > @@ -41,6 +41,7 @@ > #include "network.h" > #include "os_support.h" > #include "url.h" > +#include "version.h" > > /* XXX: POST protocol is not completely implemented because ffmpeg uses > * only a subset of it. */ LGTM. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".