From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 617124384D for ; Thu, 30 Jun 2022 22:39:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8453D68B6E6; Fri, 1 Jul 2022 01:39:01 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073105.outbound.protection.outlook.com [40.92.73.105]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5686D68B452 for ; Fri, 1 Jul 2022 01:38:55 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/gz38Q5SHy39SoLI4+jIQQWtGwweAt6W3AsQKVXJJgTbgI+G+QjxCv1DDaU15Boj3EcLwD+E+Qo0/LowXPYUVLFboi/Bs/QROgJGA0Ljm5vVdbnIZsLK1sBBI8rp2HxCzuGMjRqCJjVcvEeaWxUVYPEzd2nWS2pGaDNPWnb6oMnCS6h/LVDT4jrGIYHISEBDnurGaKCTGmLTUR89yXijlskee3ouG1apPkev8KzF1aLkaMxXhspowmtWWefZbJ8ETYAUITb/8hV47JZdqvQqIvTFUokeV0UjJ0Vgu59/WOhDwpQBULJAfCIKtejUwWNbWKy0g6OyN7YorJwGc+8Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G7QobA2fkks2HXRUZJFzUatK22jd2JUehUY7CS4gsMI=; b=NSET7hKkg87Hj+z3d64SZheoBPOJUMH2yJQOvv/NOBF/sc1CfhwLHIyw179JMtiZNGJoy79ETDJ94FT7gDV6lTeUAUVR0oLpSJpxPL+nnZMzsl7pprrRxe2bAQDHs+gFgPpId13HRsTKi3Rp/0uSa2O0oxGzzU7RXn57a5a/buJRDdtm23dnBsOR+b/7KbvSm+Ds+N160ubRJkiTuWaWqHxu/NuGkGe+WuOW+4O/yURaxABWaDFZwjNawmph6Vl+6oBuJMAQQCPQTmSnSTIcvavmBBKaUQtYxzTOjIa7rbDi+XC0Egh+ftaakuQ/9H5rRQqRM4WxeTdkUm+jSnI42A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G7QobA2fkks2HXRUZJFzUatK22jd2JUehUY7CS4gsMI=; b=rOFEUYDRP0EZR6L00T0yytwClU3ke96cn2UP1xCEkwaOJVF3HH6UvGzzF9/B+G0zg7aHM0EkV9QzLesPi5T6xcVcK/73xpQQhCrO6Nla0epAHHGHChzLJKkHQ/SZ17Hb2bXbAEuCU2ZK5WmcpdAwdD28rOMp/p+0NDqfkOfMKOop9No0uxeoFiKDYi9Ni1Hs3NnEMlG/6+KcMjGjLwiiEpLR675RTqMb/3jNYnPXzmHiQpNuvrzhM9HEDvKjL4swPZAUR1/0tIwApGYuQMfHw8LB+kdrYt3N6mNLyNGYUebEO12p109Wwfdkc2ZvHl8rKtZ8ZHaO2YpDHNSLrpEW+Q== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR01MB5751.eurprd01.prod.exchangelabs.com (2603:10a6:20b:f5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 30 Jun 2022 22:38:53 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5373.018; Thu, 30 Jun 2022 22:38:53 +0000 Message-ID: Date: Fri, 1 Jul 2022 00:38:51 +0200 Content-Language: en-US To: Paul B Mahol , FFmpeg development discussions and patches References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [23o/x+GFjW+XlKPUQo8UITV+BcUK4Yuj] X-ClientProxiedBy: FR0P281CA0097.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::10) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 298eef54-d721-4d3e-6a4c-08da5ae94f82 X-MS-TrafficTypeDiagnostic: AM6PR01MB5751:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F6I06A2Vy/y40fT9BNU0QNLuA3MHnGiTtwACqnRBjpUk5ARB81rp90UX96qBtSFagciPE277LNQOdjtGTI1fm4y6HV6rtqtmft8XyF+wKY7oSnuTReZoDRsA3LJz7WB7rMaQ6oV6isx6z/hUKP4FNB+gao6F6u8YjIekqKaprnJcX7RSjVkviMYtkfZMPTgwxbNA7L+yxrY8N1I+M1pLlutCncl26GKBJ+HbeO0LLho5r2wcg3en0/UigHO2V6N6CmcRBxfKTez+vCWuE2KwCsleYP5uWp6m8lep3szudG6B7xIbA+cBA5GnmJyrYg6qQG1l/NSGLCxmZF0pf7oK60v4pjTa615HFYzS4gMXGJyS2NREqa6HsjuvdJeW+X/SzubkALTOqgXRsoHNQvkUl63uTNlnY4m79H9JkZpDzaRM8kjfWaKobzVCjqDYDuZjpth/NYxIHGVWdXsi42fRB4lDyxCjCctxjZBVu/87gq29dv3cdaAG/aURFqciZzD3lb2DjynCLR379bYTyXuStAYrZmp8amjBgnL/0WF56gLzKJ9txq7LLfEAbMFIIk0L9p49SIYhcok0Y7KwWEHk/De1DIOFHUM9XWyq9FcDgBz2+gea6em+Q0vannMTW37YUok6yrcd9oiI2bMoH/1As4L1kDXRzbT9YweG6Qytusp+tdapAZySZTSU5pBAaN8VjxE1gC/K2IUPzxazThRYTg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVNUTDg3cms3bWY1RUVNejl5TGNtcVdrdTY4dzNSQ1JDQXlGd2pJRUVZazlt?= =?utf-8?B?VHZGOFVlRlRESzRveDNZdGZtdFJ1WHJzUmZaRlVUbmRLTll1Y2RaR0N3RVVk?= =?utf-8?B?VWdDRnNmWXI3dHgwUjdzQ3hxZnR2dkh6N3JZYlRpVnpTOXpiOWNzQkZ6SnR2?= =?utf-8?B?V3RLVDR5VTFyV1hSOWJGZDRyQXRPbUVpRXdtVC96Q202NDRPWjNtclF5djRs?= =?utf-8?B?RFZGWVhhK25ld3FQSVM1SEFFL1ZCam9pWXk2eXhVUkNEVWFuZjRUWGpoR2tM?= =?utf-8?B?M3RackRNMzFhLytnSkZKNjNueGd1MDFpSUdPRjFjLzJUVSt5MS9KS0EreWUy?= =?utf-8?B?TkYvQlgzbStveFoySlJrZXQzNmtsUmExRDN4a3dIdUJlSGpiTFhoTTIzTWM5?= =?utf-8?B?U3FBVms1NU5XY2R4VkFLc3lHMW0xWFFDREhRa3JRWjdNaWlFZ1c1T3B3NXIr?= =?utf-8?B?UnNBVmxFS2k0SVNxY0ptZ0FoMklXN2puWkM1MExtU2ptNm5mRURvWmRTRUFw?= =?utf-8?B?UjAvVk5lZVJ3SDV0WlNkN2V0aHFDOVhjVnYwUE5rMlJ1U3NLWVJ0cFpGNzFK?= =?utf-8?B?cXl3ZWZRM2I4emEzQmxjbFBKaHFQbGtFSHYvUEJoRUNYU3AyNkxWYVRLWE1X?= =?utf-8?B?VHM1M1A0RDY1eUlnUnNtQjBnZWFkUi8vN290bGNIbW5BeUJ3aU00bjJYMzJ3?= =?utf-8?B?OEh3NEZQS0Y0b1NzL0ttT04xMnZLcXdoV0tUQTVSQXorR0NNZGMvRE1tYUZq?= =?utf-8?B?UGx0cGlZNlJKUTBSWkZucHl5ZndKRzV2dDFEb1lhV0hLcVV0Sk8zc1U3R1NF?= =?utf-8?B?Kzlid3ZmeGE3RjRtYklrUTVWZ21mOXhTWGlwcW5rR0U5dTk0RFlCVEtxSFhl?= =?utf-8?B?OUNaTTBRME9vaG9EQXJuQXFTakxQMERGbTdLclhVODN3Z1lLbkpVNjE2dy8y?= =?utf-8?B?MmFQMnl0NVNTbFIzZHllZ0F0Z3JSSGIxbDFBa0tBeUdObXpySmsrWS9xbzdr?= =?utf-8?B?NG5hYnhCZThwZ1BFNEZPNDVSZUExSGlGNDVIL05Bc01IUnZPRFZwTWRxcnNq?= =?utf-8?B?ejF3Mlc4QnlZWno1V3pHa2I3d0Fna2FLQ2JKcjY4UGlnYTFyTmgxWTg3L0RR?= =?utf-8?B?Yi9PbDl4TlVRNW5GdThhdWppRU9WTWVwejR4RjBoWE9vY0xSelN4cGN5QkFL?= =?utf-8?B?VzZuTHk1SGdCa2lyK2M4MUdLUUNNWENzY0RLZTJJSHF4MTVHZDNSQ3BsM0Ro?= =?utf-8?B?TmQxTjJJc1ZVOUxEckI0VHFYRWdreHFabXo4SVNRaU9RWFFxblZvTFhkdnJP?= =?utf-8?B?c1FWYWZqMTdwSDZEUmFpUTN5UmxhMEgxSytaand2eGt1Nk1lQWNyUUVnUkxF?= =?utf-8?B?ZWtueTZRb3dvWEdrRmRIMVdsVnJaRVEzdUlZczZSTjJpMmVvZmlWdExWN1Vr?= =?utf-8?B?M1YvYVZYdUx5MkY5Nm80UGk5dmtCZldtSndiTEVZeHdJT0syODFHQ3ZycHAw?= =?utf-8?B?Ui8rdHlQaEYwUUREcDZsdjdTeDF0b3RDQTJONko5bGJYSmJSVjV3KzlDRTVj?= =?utf-8?B?YTN1dVlFMGtMQlh2UkZKVVJ1QktOUWozakoyeEpBK3YzdFZMOFMyK1NIUkdK?= =?utf-8?B?MUIxL1l0UFFLaU1YOFNRM2JIbnN3YkZvVE45UG1UZllPZURuSkVnVHBQYStZ?= =?utf-8?B?cFdWcGlIVHpxT2dVeFI4eE1xOXRvL3hvMCsvQmRFYkpxOEF1VCtzb2xmOFpj?= =?utf-8?Q?JGA9zQ6DQhTjiE1U0o=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 298eef54-d721-4d3e-6a4c-08da5ae94f82 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2022 22:38:53.7610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB5751 Subject: Re: [FFmpeg-devel] [PATCH 1/8] avformat/bintext: Remove set-but-unused variable X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Paul B Mahol: > On Tue, Jun 28, 2022 at 1:27 PM Andreas Rheinhardt < > andreas.rheinhardt@outlook.com> wrote: > >> Signed-off-by: Andreas Rheinhardt >> --- >> Maybe this was meant to be used somehow? >> > > probably some not implemented logic to set probe depending on amount of > invisible chars. > Yeah, probably. Anyway, no one bothered to implement it, so I will remove it tomorrow when I apply this patchset. - Andreas >> >> libavformat/bintext.c | 8 -------- >> 1 file changed, 8 deletions(-) >> >> diff --git a/libavformat/bintext.c b/libavformat/bintext.c >> index 0465b86f4b..b6f14a03e5 100644 >> --- a/libavformat/bintext.c >> +++ b/libavformat/bintext.c >> @@ -132,8 +132,6 @@ static int bin_probe(const AVProbeData *p) >> { >> const uint8_t *d = p->buf; >> int magic = 0, sauce = 0; >> - int invisible = 0; >> - int i; >> >> if (p->buf_size > 256) >> magic = !memcmp(d + p->buf_size - 256, next_magic, >> sizeof(next_magic)); >> @@ -157,12 +155,6 @@ static int bin_probe(const AVProbeData *p) >> if (par.height <= 0) >> return 0; >> >> - for (i = 0; i < p->buf_size - 256; i+=2) { >> - if ((d[i+1] & 15) == (d[i+1] >> 4) && d[i] && d[i] != 0xFF && >> d[i] != ' ') { >> - invisible ++; >> - } >> - } >> - >> if (par.width * par.height * 2 / (8*16) == p->buf_size) >> return AVPROBE_SCORE_MAX / 2; >> return 0; >> -- >> 2.34.1 >> _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".