From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E6ECC42EBA for ; Thu, 12 May 2022 15:30:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D6E4568B452; Thu, 12 May 2022 18:30:51 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064097.outbound.protection.outlook.com [40.92.64.97]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3ACD768B3A7 for ; Thu, 12 May 2022 18:30:45 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aDJgBpeXc87nfIOFc0CIn2JEt99H7ZSPoHNz+Bb5/l5bvJk8SzeqHLTQcOZzR7cvu0+fga+vRjua9NWvKj89L4SyQF8FCPS1qzKkiRnTceYgG+wtmfU/RTKObIKl2Xl2M0WkpaZf/tdvrBBp+4zl/319EyR+d2kA21qszjgbDCJpqyGSMOl4xncH7WDchIX0V0wNgfZNotoo7Eb1wnPmCHKH1MH9eeTS3h3mYgKhWrAqrGigjSXLRI09BE0H4xErQ/306TyFbSVFF4TCW7fcRgJYtRmATOi22d95JDo4aZiqw3XOrTYGVjHdGlNvJjIgHfUu/GOnDwNYgW5G6NFl7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1vxZTZOgkI36GKcTgpiv5/HWshIILAEFUsPeyR1rnQ=; b=kxxZwZa0PLTaDB1hC6h7Nu4wKa78+BEwcB73ggwWchmBAkqvHxPT0Kw6nOYeF+F8cNJ4ozzcNWz5IuTx4nFxTTiBFl3QCntKR/foo5be2XDcuN0Z2zKqWI3nFOWJ48nZSOkxoc2K+y8ckgQlf+Ts3i2S2TpsS3whkd5dCWZac7cyxHlP5dgswqMMxxx72rOJU8vSwhhgZ1XpKZJo1voYYs7WfuNq3V46tKqYNDSFqxgBDyet2sNtsDeCIxy2imC1FxEcoarlrQnunxGvh8w45WOMkHL3Ut/ztdPgAa0fi0eCRGQVBOworjhj1pn6uqFGzWVZimC4uNbJj77kj7jsrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H1vxZTZOgkI36GKcTgpiv5/HWshIILAEFUsPeyR1rnQ=; b=H3CLwuUN9Og9tleM6WsgYBC/D4aS5XGGrdvc9edZOX7N7FZst2iv/mOFTQEaQhDUv3iPsZ5IvdJlfdaB8gsA8084jsRgDpWIJUVTQTP27Ppi0CgwNW0WCS6jA/1arIJ0dM/Zau8T/NgOxWGbwOVV+Bs6Lg9ry/tD3j6w/rIsUE42UgbB2z1u3F+B6TL6fnizthmzv4X6PYENFoT1mEQ7GojHopO7QC7ecuCHpn1nlFEdmKsePXebbLjj0PvfL9KmB2x3I/1WWsJIPWWOMAawIqqSw3JXiuYx0mNy6UIn78/LgB0jiAdak7Fz4V2kRufcypvWSrrPLdaYn+FFQHRB1Q== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR01MB6864.eurprd01.prod.exchangelabs.com (2603:10a6:800:19d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Thu, 12 May 2022 15:30:43 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%9]) with mapi id 15.20.5227.023; Thu, 12 May 2022 15:30:40 +0000 Message-ID: Date: Thu, 12 May 2022 17:30:37 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <1652280498-10408-1-git-send-email-lance.lmwang@gmail.com> <1652280498-10408-2-git-send-email-lance.lmwang@gmail.com> <20220511233840.GA15884@gmail.com> <20220512151713.GA8500@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220512151713.GA8500@gmail.com> X-TMN: [/XO726gJPes+5bDWHf5S8aqnWra8A2LT] X-ClientProxiedBy: ZR0P278CA0178.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::22) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1e4ea737-e6e2-4e11-9eb2-08da342c5eb6 X-MS-TrafficTypeDiagnostic: VI1PR01MB6864:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F7Ov0w1nNZS/K3MoiALoa3LKJNCCSkW4FuAVe5oMImVuMAe05y9SDyq6cHSLySV+++UWCHmC8NDsMbXZHQc3psdJLIZzmNqmVpnd8Hnw3WOltw4YrPgmGgrUtGncGcf04s1veE0P4gQAn11g2wmVDMLefvFD65nb4LSKIQrzTWFT7V078FpI841o4JOjtR30YVNxfYwWNymbFIhBuyQ3TX6wzzaLLLqN3jIpBOl12XzrEy81FxUFR4LNnVW0lNsU+4k0tlpYWGAY3WQGUreNS8jXhr/MDLJtSMf4uixyddj0EgNCvEbTCpI6+ENVkF/85RZboYt03IBX0GQcILvhtJaY4NF/kevGp27u9e/CVrnMUrBKDZwqW0qiEhZTDWjihJu1U6ZCJeJ2qYlJASgFjct5AkDRa6CjRRisg6zC6aoQl3zZW/tFosPh+Fv5MDQcE4SUwm8Xwpr9uIeUTPEuG6F8KdG3MlvrWA8YhlbDzfBP/qyvDuDvqocwUDZN+dORBkXMbf4Z+dDZpANl5bPuOeKlC1LCZiVrtarpza852vbMD44sHilKqQhxjGxTeSU0K08XrpvAb76MXjzco9vetfG+ZEH746g+fMuf16uzAuIo6c0QBJuyJ5tnswqBkjP1 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WThCK0VLeURGam5PVUhjODIvWVVOM2NaRzM5VG0xakMwUFh5SStiUTBlSVlZ?= =?utf-8?B?YUpPZlJOMmxXRlQ2MmVNZ0c0YU1IWFhMc2pjNEpLODgvYjl5SGtFaHliV1FJ?= =?utf-8?B?b0hhTHQxZEFnNjBpeG13YWErSFJ4blVWNjZOTlp4QTZ6U2Z5VTB5bkFpYS94?= =?utf-8?B?ckdZSjNUeWVnazV6S0d6UDJuMVRpVWJ5aUxuSEZXM2tmQ3dQUkZRMzNlNXRi?= =?utf-8?B?VGd1UDlRWFR4ek1CQ2laQXQ5a3R5VDBaUVY4Y1VXQm04OWZvRzlSNzJETGth?= =?utf-8?B?VVgrd2NzSHF6RmNPdTA1eW1PSzc2d0pIN3hsSE1ZM3hnRitnMnl5MzJBMHhJ?= =?utf-8?B?d3RWNm1FNW9tTUxGenVKOVI1SFd3RFZFcnJQUUIwN012dHdWVlBKVzVCdUw3?= =?utf-8?B?ZngzRnNkbkZrand6cDNkVWx3azJPenFSbHlXYmxHd2ltYllMZHZoNnhIMmox?= =?utf-8?B?Mkt2L2FXbmw2ZzZZazdQOFV1NXBmZEIxaDZTL3U5cllGdWJTdFVMUGVwdnBh?= =?utf-8?B?RnVTckhta2lBSlFZL1R5NTN1Vm5hSjBUQjFlWm1BTE1taFVuSzJtdU1tUlMy?= =?utf-8?B?RDk4SGRsbVVrSUJqZVRGZDVMK1BLenRpNWdwWjVmREdZK2NQQXNIUHlhWHJ3?= =?utf-8?B?Yk9Cb3hRd2d3Z3hPcytJOGJCL0xCK2RjWGRDQnBCMDlxZmx5SnZmZDNEN0Fq?= =?utf-8?B?QUdaVE5PaGROckkyZDM3YmpqN1pBakxhWXc4M3JoMGZMd1ZyZWRTRENoeVhH?= =?utf-8?B?OXRLSlNlc1pzWGpTQlVNaVZ4TWNBS0tCQW9OazN2YVZ6a0tMYWdXcnR5d0tS?= =?utf-8?B?V2Vna01TWG5Wak9pRy9Ca1pCNjFibkE1dTY0a3U5Yjc0RS9IU0cxOE80bGQ4?= =?utf-8?B?UTFUWWRlNXBRWG9tc051WlRoUXlpdHlwZnBYWjRoVHd5QkN2R0ZuZXhvYTZJ?= =?utf-8?B?T25CS2dFRmNoRVA2ZWYyMmZYNDFyc3lIaUVvVVJQZloxQnpCaVJCK0NVa0Rl?= =?utf-8?B?YlFOcFJXQXNGakdlQzVYU1M5UnlZY0lRdmQ5Nlo1aUpOWndtOTdmSE9Nem5Z?= =?utf-8?B?R3FXUGQ1RDVNaGtHTXU1K0pqRXMvUjlPTEtMVmRJNmVtamNrYnY3Zk0vN29Y?= =?utf-8?B?ZFYzTnJSMVhBUWhBVDlmVTdYcTZZRHhOTE5FS2dTM01LUWpEdlBNNWVCMTVa?= =?utf-8?B?enlzTW9pYTlicFFzNXlBODVYZFkzc2U2YlYzVHFDVTZ2Tk8rQStaYzVMYTd6?= =?utf-8?B?VVVtaStST2hJZG52UUwwVGptTkljeTRzV3lyK2YrSFkwazNibk9nazgxWmln?= =?utf-8?B?RFRUeVIwUmRtdFJMREtSMmpNN2w0MENmZ0RVOHdXZGRPTWQzVDNJNnYyRVl4?= =?utf-8?B?cnV5R0JqYUZ6dVhNOVNTR1NMUDZtc1o2RHFnd3ExbjNuZHU3cXZEVERaVGxD?= =?utf-8?B?SVhQcW1xMFlSYit0anpkSGU1dVliRmd1bEZCV3dtZWtVU3JzcDZBVHNmd0d3?= =?utf-8?B?WHNzRlhlWEJjRDNUTEx3ajFkWWlWUEJYN3Z4YUpMaXVFYWNTcmFNRVJ2MWhT?= =?utf-8?B?WHMveGdTT1BWUUxvV1UxRVJKV3NGSXk3aHozRXh3MVg1ZXdqcUpjS0F3Rm1P?= =?utf-8?B?QVRnY2NXYVlVTXVhOVVuZ1dBLzlua2Nta1VzRXduaENBWVZwaUNHejc2NTdH?= =?utf-8?B?Qko1N1hLSVM0MTN2K0lvVjFKYWk2Y1ZIOWF0Zko1djUycWpBVkhSRXVabEd6?= =?utf-8?B?UW1LRWFwWmhZV1lZRHdjcjFMTFdmNm5PTkZ4WkxPTHEramVWVmd2T3dQZkFu?= =?utf-8?B?TERIZVEvU1E5YTN3TmVkWHdrK1B2SU9WamMyNzkyb0hYYW1nZmFSeTdaUDNw?= =?utf-8?B?NSt5Sm83OUhldFp1TThaQUptUWZncHhmaTc5VnZwamhtLzBjVEE1eXdiRmx2?= =?utf-8?B?dWV1NVdRYUgyNEMxcUR1ZE5mV2FQMnF3L3JjZDB5dDVtMnZzQ3Rjb2s5NTdU?= =?utf-8?B?OGdIaUZDWmpBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e4ea737-e6e2-4e11-9eb2-08da342c5eb6 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 May 2022 15:30:40.1703 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB6864 Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/ccaption_dec: check the length of packet and return used length X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: lance.lmwang@gmail.com: > On Thu, May 12, 2022 at 08:25:29AM +0200, Paul B Mahol wrote: >> On Thu, May 12, 2022 at 1:39 AM wrote: >> >>> On Wed, May 11, 2022 at 09:47:52PM +0200, Paul B Mahol wrote: >>>> why? >>> >>> assuming the len is 1, the following code will access the next 3 >>> array anymore, I think it's better to check the i with len -2. >>> >>> for (i = 0; i < len; i += 3) { >>> to >>> for (i = 0; i < len - 2; i += 3) { >>> >>> for the return, I think it's correct to return the used length, >>> if it's error, have return already. right? >> >> >> I doubt so. > > maybe I'm misunderstand it, but from the comments, the API claims that: > libavcodec/codec_internal.h > 175 * @return amount of bytes read from the packet on success, > 176 * negative error code on failure > 177 */ > 178 int (*decode)(struct AVCodecContext *avctx, struct AVFrame *frame, > 179 int *got_frame_ptr, struct AVPacket *avpkt); > 180 /** > 181 * Decode subtitle data to an AVSubtitle. > 182 * cb is in this state if cb_type is FF_CODEC_CB_TYPE_DECODE_SUB. > 183 * > 184 * Apart from that this is like the decode callback. > 185 */ > 186 int (*decode_sub)(struct AVCodecContext *avctx, struct AVSubtitle *sub, > 187 int *got_frame_ptr, const struct AVPacket *avpkt); > This is correct. It is not only the internal API which claims that, but the public API, too. And this just not honoured, in particular not in case of subtitle recoding. See https://github.com/mkver/FFmpeg/commit/ba1564c532654888015d67b70bf73d117c2d9f75 - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".