From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 993E040F4F for ; Fri, 13 May 2022 08:27:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1A94868B42A; Fri, 13 May 2022 11:27:37 +0300 (EEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-oln040092064082.outbound.protection.outlook.com [40.92.64.82]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9E0EF68B231 for ; Fri, 13 May 2022 11:27:30 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OmjZXjPB2VCbG0csHeOvz7EEtH2CONV2/C1Bu24vuOyhIdlUPsGwgMJ1+hAkJ0pFJRPdNS5vsDqlwvRfeGEaBTECbs7DUHL/iaoj2bXnttpkTC8oua84l8dVGt0vdWIoF+WnVtw2IjZSmWM9o4NHyREmjNkoNx40kI3vkwotntn8Kd7dpgKk1Jzp3hOH3w0rmNuY9RiN22loxf+aVFvTlUaZgXjhlNqsL366l+AoqPFjbZgpJddp9jG3STiqp4eM1eVDZRUMuAKKbXE3ek0elNT8+uivSstdbi4mwMzIjCZi4q7LJeaKwzRqqKYfLPLrNL943P/yMUr3/9ibMd+02g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZXXrBQSXCNNWgpvbG99eTLUtBBW/1OsUx/vJRabXr14=; b=AyrnPedtOQPsjZRTbghw6XuD7lNFBY+j8nuFbt9djSIabqr4iQE6RnXlhAv9zBnToMTTn5ZdbMkGeSOlA/TtJdVdCEbs4H3Syati/OALkj0owacL9ku0nJ3xJS/f+r+/9HMA3QaXuzVrKc889W903dRzTpYGRF+K5F2g5GJ2G88f4+5Z0S1/niKrowRanLXnwhoth88fqOfoiCyFwlmpPZvR0i0a393YLp92R58Z+BU5OO/1mEjNx4gZnJQJzLDXff+/GgBRevBvBaVbDgXXvYFlfMLHueeVCYioYgJNoclsfRJxh2oGe/mIGvh8bpiz4DLpHbqJVf8NMmHue2GzxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXXrBQSXCNNWgpvbG99eTLUtBBW/1OsUx/vJRabXr14=; b=l070tTWhKTj60/tOoh9wYnE7iWV90hT6eFMdO/AwSxIzzLNzxtoeZGUwYvY8IyrQBrvIhuBS+6n5apqOeRgLOD+Fs3jTh8P1vTkvq5UMC9RI70mIm0U7YRf9h7fE0LPjNUN05Dx/z4EVjqu6vhe/0Rtt88oA1gnsSQEI9SJJvzrU+nVKApc3N6M5+w66IgKZ5cCt9v3fI4RVZphBr16r4ckoCEpyblsirT4VFrdnDQ+PbszRz9P33GNL2jGrnmJvvLnhOIuPy2R2E/xUcmBCHQYQPHBf/EV5mHX8w+dwCdwiWKr5XC0EFHsSbuVuqPbDTHfeEkl+YOsEEYp1U6xcVA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS1PR01MB10246.eurprd01.prod.exchangelabs.com (2603:10a6:20b:47d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 08:27:28 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%9]) with mapi id 15.20.5227.023; Fri, 13 May 2022 08:27:28 +0000 Message-ID: Date: Fri, 13 May 2022 10:27:25 +0200 Content-Language: en-US To: Soft Works , FFmpeg development discussions and patches References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [A0w+YD0kopCqBmyS/hwxL+vStH4Yp2JK] X-ClientProxiedBy: ZR0P278CA0114.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::11) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ee28c57-b17c-430b-4d51-08da34ba6a88 X-MS-Exchange-SLBlob-MailProps: +LiGfBxqLEvHkesRcKowAYSe9YT5HwiwFkrNsUILNuwRSxeY5T5tk6gpZ4s+X/BJeQ9wK5a/fVifzCPwkSzM/4SRCCRaI+3n3f4KVUbaV4VNGDlV5QbDgSYzrdXQH3JGr4B9tGdL8pMTanOtE/QufZQWRnkN8UOjAmODJQbU6vTWKOE8ebDpj7epM7O1NkWMRmVvADdmEx7rMAHkRZ1ZgbGldmhaZ6GtxBUm94CUjHmHNSlNNISXs9bBvrQku62L9yjHn4hOR9dFrUvBBQzgZBRBK7NBNag5PI9hIw2dZWBZOlfq/nQ8p71ZcVZkC/mjrJTLt4tV2uOcP95RAvg6h3E/t5/MGGySK2H/bmm2SYpSm4AbgQ6ClyGoq8nXGgGUwaOdW68ZapSFpHfO9TyJnFKZRc1Gwq064R5f45WLyhUKZ0nPjPrn+wPkBtqx4JyMxZqlOZPYfQNR6OrgfhIj1tXWPXkJ39pOlssPYXGoFFX85A8OihUL5F991EovZgXy1Q1OjiL3pEx6V8Q84cmGGImMkMLNDLEy9Xf0JcJC8jaNgBezDjoerlbRpQCu2ES++CHFnxxeWTwDDuD38g6qp1yfBFeOtU9P9K9I3KdLSP+vdGScheOdUNPHKwncdUSUbnhpi6r49g7oP9XaIHNLXrHdPi908QViPGQbMwwJBSPjJ2hVIc7d87PvO8z9GRCD47+SOP5DtJA2UK7y1BHmvrcNsUcbi2RtnlrzscBVacnpUsUeyAd4DGz2hQVSwmmC9+FYXZE+aFfB7lBSEN1MhGuuwettb3ir X-MS-TrafficTypeDiagnostic: AS1PR01MB10246:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h7QDstnIdDLp2hkoFjpMFEKtV1ryTDFip8nfbkT2LXQ3SYTiWXWp6vEkt5hRj+M+IHl8ZABVbC8zqBEDsGsZMU5HjPQ0jzIFJKC66QqOOTk9o5+0+zivWuJeDqS54uWSPg3SNm8D4hQoYlanKaJ6I4kLbaAeScjODGQwkt0CKkhycCE8IbQB1bnrO8f5Gi+7Cw2hqpyqwaIZqQSbN9Oi9FWQbRQecw6J6xXrKQeiDIiRHlBx1zdKRxtv4QlEYI7Bu8Te78oZzJtwJnOoyWsR2oTQVniCq2hBMaKqFYxsgehFBltc8zf4SWdE8znXwuK2lWMB21ErQ+o4aamZfU5DPf+RWMeTCl5QzXx5e+LT8pVS2GiKviB4NwaP6y8ByRF3WUHUts4J3+3hk+SDO4JeOixT0LNfZ/541yBdj1jbL9M2LbQOeuZ0J9/X8vYtEG85EFRRKflQzUrKEVE6JEZ2jNzNZkNUCs87lxR2Idt59B0padWL7Ii2rx0YFIkE3YBiSw3hY1V9HYVeJHrulQHtlNeylET4duz/6fGxIV1dz1U1oEHD1/9TnbpwkiiDEMPnxhPmzRTWVx7CBDY75SAhkA== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RkV2NUNMOFIwTWtQa245bkQ1UkhMTHFPSmxWZGJ0dE5vSjZ2QmFQaDJaN3Ba?= =?utf-8?B?d0JEdFNRWWIzSkdaRVlLQVE2c3NLSXkyVUJ1RVNaVnNGK3pBQktiWkRZcjZW?= =?utf-8?B?NFZkZFA3Mk9iaGhMek1pN0c5YXlCSGhnSlROQysrU25uOFhMNkJnY1J2VEdU?= =?utf-8?B?YlplUHVnMFpyMGlOZUVOUS9zUSs3RVpNYzVGV3YwSlJ2cm01b0JjR0xHaWYr?= =?utf-8?B?alJlc2RaVStITHl0aVVUazBYNzc5Y2FxM2lJRHBWZ3l3bkxoTCt3aFljOUVL?= =?utf-8?B?V3pxSUNWTitHbk9XMjQ5cS95WW42TW1WRVFWRmtZeDZrSVRnSElOcTkvSnZI?= =?utf-8?B?MzFCWkhFNDhJcW9TL0NURmMzdlJpMklmOGM0Q0sxZzRhb25BQjU0OGF2UUJW?= =?utf-8?B?Z1FVQ3o0YkZWdlpkT2NzNHBZSlp3Tk4zbFJHRGNBOFBLWk9iaVpBQ2VZRGM4?= =?utf-8?B?M3ZqZHVOT0thMGg4SEQ0b1BZR3djVjdiOFZDaEw1c1Y4MG1jcHdYOEwrV0tu?= =?utf-8?B?SnlsQlo2YWpIUXM0dUh0dXJWdm0xWVhYMjB4b1NSL3lKdWs4Y2NlQmlROVQw?= =?utf-8?B?UkRoRmcwMllWeGlTV1BsbE5sMVg2K2ViNG1WSHo0ajVEY21WcUQzOEhDRU45?= =?utf-8?B?QUNyeXVBNU01aUNpY3lya1EzV2pSRmluSVVpTXZCbWdnZ3N5RVRkMDlRa0Fa?= =?utf-8?B?TTVpUVd2a1IrNFBTeitJYkJKS0NXVWNhNC9WclplNTI1Z3FPeFJ0Q04zRHJ4?= =?utf-8?B?T2twMDhaQXFNRHpGRFVXdE1yMXBBalVGZ1NYVURFaHh4NVMydUhvZkI1Z3dQ?= =?utf-8?B?elBEN3pxQTl4cGUwTjUzRFo1TkJPZWxpQVRFb043T1RxazJXWGJMeFRZRExq?= =?utf-8?B?MVlmbkhSWWx5V0praGRpU25VVXNqTDNrMDg4TXp1dlAxUGpPZmhYMVliS3lT?= =?utf-8?B?b09ldjZuQllxcHI5Tk5KazAzcUlIaG1pb2hDakdYdXN0amRmakVXZE5FUThH?= =?utf-8?B?SFBZcHlaSjViOFNwMDkrR3lpZGJMa1VKMHNZTTM2alVnTTdveGIwUTBpMVAr?= =?utf-8?B?UHgrQWJkRVFxSGVxa0pHaGZ3VUVoeTdxOWZOckJXcWRNY0ZLOEVaM2dWdWVI?= =?utf-8?B?d0czR3ZmV216c0FMSzVVQkFUMy9ubU5BUDhoWDY5bTNhcDk3cmdJbVRVd3dj?= =?utf-8?B?VkNTbnJaSjlpd1RSVndETGZTYUExZ2FTaWlYRGptSUpxM3A2ZGMzaXFLUDFn?= =?utf-8?B?cWg1bURyTEdScTZZUzNLZnBKanJEeFJadnpHdHBoNnhLODduZnBuTXJrWmhh?= =?utf-8?B?K2dxc21RNVlYRTJXazZXRXIwR3p5TVhRSHFBTEJxY1QxMGJlU1RHRWRITWNJ?= =?utf-8?B?MENGNEN6TUtKUkdpRFdGZWR2UlhPVHY0N1JxQ0w3YWxzeE40aHVJaW5seEcv?= =?utf-8?B?bGdXUm10S3BtRmFuV0JrOUx3NmVia1VrVFlCUnBUZE5GTGtqMzJqdXZXSzNF?= =?utf-8?B?WjdqcjhOOG9wc09lcnVWT01PSVVjL1VjYkpJS1hXcHpqUDBMMldyVG9zSk5h?= =?utf-8?B?L1JlRjEyRURIZHJLUEp0aGZjcFlMd1ozV1k3aHp3bGhyVDdUdE5oRW9DODFr?= =?utf-8?B?aUorK2FxK0FpQlhKZGF2OUVkRjg2UklVL0hDTzdldnFiVXZFYkJSMjgzN055?= =?utf-8?B?S0o1MU5BSDEreXdNMmZ6akQvSkg4K0YrWUI4QXlweStUNjRSVzRqQ0oxcDNE?= =?utf-8?B?ZHdXR1RRMFRxaXdYWG1vYXlWTUljOFlPZG5uUVV4Mjhib25NWStqSjJDMWN3?= =?utf-8?B?ajlHeCt4NHdMT2FDMktYck4rRzZ5Wjc4UHVMN3lBSjJBVmlsNExxdEhkNk9x?= =?utf-8?B?T0FTRytIY0NHem5hOXRJemw4ZjdsalRVQnNYcHRzRU12YWJZSjBtVW5pUmRJ?= =?utf-8?B?dC9qMWZLaWVpaVFPR2o2OUVTNEVjT3VKcDNBU3daZ0c2ZGMvOXV6SnczWG5E?= =?utf-8?B?VDMwQk11S1RBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ee28c57-b17c-430b-4d51-08da34ba6a88 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 08:27:28.7381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR01MB10246 Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Soft Works: > > >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Tuesday, May 3, 2022 8:38 AM >> To: ffmpeg-devel@ffmpeg.org >> Cc: Andreas Rheinhardt >> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move >> ff_nlmeans_init into a header >> >> This removes a dependency of checkasm on lavfi/vf_nlmeans.o >> and also allows to inline ff_nlmeans_init() irrespectively of >> interposing. >> >> Signed-off-by: Andreas Rheinhardt >> --- > > [..] > >> + >> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) >> +{ >> + dsp->compute_safe_ssd_integral_image = >> compute_safe_ssd_integral_image_c; >> + dsp->compute_weights_line = compute_weights_line_c; >> + >> + if (ARCH_AARCH64) >> + ff_nlmeans_init_aarch64(dsp); > > Hi Andreas, > > the above breaks compilation for me: > > 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: unresolved external symbol ff_nlmeans_init_aarch64 referenced in function ff_nlmeans_init > > The reason is that I'm (obviously) not compiling stuff from the > libavfilter\aarch64 subfolder. > > It might need an #ifdef ? > > I haven't taken a deeper look at it, though. > > Thanks, > softworkz > > That surprises me: The earlier code did exactly the same; in fact, using if (ARCH_*) is our typical check for arches in dsp-init code. Is this the only place where this happens? #ifdef is certainly wrong: All ARCH_* are always defined; they are just 0 or 1. Anyway, will send a patch with #if. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".