From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6B2D842AEC for ; Fri, 13 May 2022 09:25:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1926868B46E; Fri, 13 May 2022 12:25:57 +0300 (EEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-oln040092067045.outbound.protection.outlook.com [40.92.67.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DC5668B3A8 for ; Fri, 13 May 2022 12:25:49 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R8Dg2zhZJypm1ULQunHtAeIBwwYlUfPyST8dsAVd4xY/Jkc64J6K5bzydi/qLB91DHUOCgDE1J3SjPqgmOM6T56A1ae9cP/Q1+cPT7WXTJsxZR0OLouRLaYFKdOw9DPYaKdkPdcbYJaUZfTmVFQhAD/0ljT4J8LhfFUbVuhhTBpfp1n2eyFawISLmSxXjZMVPWBdMg6I8jQjPizVNVFEHYP+UBbaiJYNTIEaN01QKjhn0c5ColebkZAEst3KWDwmTLiVfT1zeZb/RkO3RVZxd1j7DyB6l6L5CE/bl9Gfp0kXps9G9jypLjU9t2vTKic19AZPo4Fr3aCtob9iGkXx5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zlRRni4PzyC3ZjsV4mE+2kT4hCYMpPgpjueYqDd6CHU=; b=Ks27IxO516rctetKaFfrpP504QfZJcjPIo3ffIwRE16vbl/vEXXQVyRN5j4Y4unOUwuj2LuhkZC8XAId+QUqLLyPP6mlY81H7eG06na0XNhy0fylJn+jVkI2aY56YxCvsIufLAfXURNMU9LoYRfa3OFSVzOlFdJD46oya1yi8sw8pJO9iSaPbW+NyvU8mqrD5EN0rWP50nkZMP2kEnxmax+qqwOnnyOvSwV1aJDvbR6l6iJBSd56tmBsEcK19D6H8j9IRZ/561AAHezvgLwM1fHzj2BcSlPUFkjGyBfxKSkp3tJscd8VNoswdeAt5lBw1hskmyELzwkQqV4KG/e7yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zlRRni4PzyC3ZjsV4mE+2kT4hCYMpPgpjueYqDd6CHU=; b=etNPyShiaI0oSUavDihueAr2RF/dOkbI0oSjD12JsrR66enUsyutkf0nb9QucIxuNaQzCctiavbqIQh1ZjDw5XzlFNDA5GVgkz26z5B89qEV0YwWYU9i+149qLgFpredKt3Zj6KsXjCdrGd8fCD9ghJFIPPsr1aeuME2AbIv+h95GLeW5orWlFpseqINa8Fv5OJ4rbVNn8Y9aaiyFV8Z/mt7hAp56vzRJu1qL2hU2SSC2C5005zDCZg6W4zeHGF8jDlAry0XT7FEOw+JKK6KdPzzdDlx7metH67kNtxmoDqnzSDbddYbK5Fq2GnFDKu5Py/1vn5ybnjL8ivXZn09fQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR01MB6960.eurprd01.prod.exchangelabs.com (2603:10a6:800:192::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5250.13; Fri, 13 May 2022 09:25:48 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%9]) with mapi id 15.20.5227.023; Fri, 13 May 2022 09:25:48 +0000 Message-ID: Date: Fri, 13 May 2022 11:25:46 +0200 Content-Language: en-US To: Soft Works , FFmpeg development discussions and patches References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [DfF+7ld+7oVOchnKRamyWNlBu31Zp/RX] X-ClientProxiedBy: AM6P195CA0079.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::20) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91960052-6b85-489f-b786-08da34c29098 X-MS-Exchange-SLBlob-MailProps: sTyj/kSftosB9bRjlmNyMBZIG2LeY0LGlGL92yH4YN1Q/64UBEBLXmvWwY30VZ8QQB5Hc6UiO7NX5QJr3sXUwhBkdY48AjBXM5dVX2qqyTUafurbhiDXUOPwo5g1N6ypB8JpIo75z1Y37KX1wynEmgKEH7EotiEmd+3OU9d6grsQwm+VctF27LJQRAWmGjDd1JiciZlZwgKP81Skxjv4JPwlN+zZJuRiHTEFuSM+eE0N7EYE7MR+jF5HTOPEfAutZOAv4I5FFHrvhfnaJq4PaOWNdWIIl9+awODuZ4+XpuzpZi3fAnhY7LIex8ursRgIs6B1Dyt87fLRia0YCYrBj7idXWbhYlXx39rarfisfzKB7DrrspiyZkoKPTnvsN3GX7azo/fJHM9IhJ+syoSUAD338wCEr3TUDM39eBGw8FcLr/Oc2Hm2wBYMvNxjEOfX9XL7hPUhHT4w1vD7UZE1zXyfw14RT/WzCqWubHGZlsKi8ZEfzYB7dTAuMroTale4nRWDrQuQGDvjA3k82bRi/8+kLFL3sX6YtqF63H62V+6os0ieNlzgI23GC0v063hk1qNyYtfoI57DLZAEQLoJxC0Q56VWR7/laoKPErBgFXgDnCLBDO8dmdPbotq3KxDRQTtCtggCqO8mB5mgyuRMiy9C2T+bxOua5f+DaQ3S62So73+Yj+EStOeiJ33aD97u/8l/MV7KWKTaBvU7MVwCCRsI5RtfvihoTa737TS4k1CqP0xr8D23MZ2kg7RIGxbWDCkX0HbdZl9eTyW7O0p1tiegP2SMf0p7VgecXdTNeshv+/pKJjua8M//VxKmB8GUVpIqpIyyvosGnvDNeBZezw== X-MS-TrafficTypeDiagnostic: VI1PR01MB6960:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ifikECEgBbMaghaQRryvOzNc0+mSeb/hOLXL1nTLWbBbUUXK4vssdc3hVgg+GBf0axYs9yAgJTb5i2Xyj9/Sh89ckNCz0P8dvUdzEHshpK0vgAKu37QMGnB384dTYu/yNZ1U5Up4hjRsyyc1XBu5OQuxbHvbcavle5L3RVt4DINL3Si91covAvanCGIOe48X0ptdejkoY11RkBGKCR6kVEQSV8+9zBiw80WYWE9B9xmg0DNCMSlrf9ma7SqYuHlFoRJ5VNMNmHQTMBRXuNQGsmisiNBEPZcZXUfqBIfo/mM0wVPc3EMSwzTlHv/OLUQY553B4hdGmu7Gtwdhb2N0+mV7uFGnyWffVx97YxQqpWTo2epj+nGM37xkWS09g/Z3UaAf/vjPnNfDP2++EQ5j8BN0zxRi6FnaVJ+iQ+XDiv6kAhfEWT0AtJ+1b6slEF63O6tyPe/ZDYeBXnNYS+g2LFbg0GnkrEhliyNJgCTqjOge4BfYzPn8wqK5krAouKsd7MuGgGl5Gnxg3BgDkigiP2VN1sMKzCPS6AcCS2DU2E3qHkqiO9K+GCL8FCAJOTqbCO3UsfdncEX9FUA+jh3bcC5Q2NHJIsa0MWY8kol7BXTasGddBhVp7K8HG1M9+I86 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K2pETWwwM3AzOTR0bnV5SnFwMkI0UGNLSHRBV2haVGgrZVhNVUZDMnJLNzZk?= =?utf-8?B?V2w5dmx2RSs5Qzc3bFh6dy9EeFZmV3pFWTdvbnpwbWN6U3B4a3RxSmV4Q2RO?= =?utf-8?B?dFd2cWNpZ1NIODhxeTd0QnBtVkowSDBBTFBkcE13Um9haXZwbi94amo0MTl0?= =?utf-8?B?bGJaYWJ3S25meFZEVUc5YUpFWGk3UDdFQmRuRldhSDFFekxDM2tPNHMxR1ZW?= =?utf-8?B?U3BXd1FQZ0pPMXZwa2ovVXZpSm1wTFlVWE42TW5xdnpxenF6RXZ4Ly9maU5X?= =?utf-8?B?TFRWVEVjZnRvSWhkbEp3Z1FhY00wbDNxd0hDMDREWHVaMi9yek5talhyVXZx?= =?utf-8?B?RlFUOVpsQXhRQ2FyQjBGc0Nvd2JBRVNPbmNaNGg5WHZKNlc1NVVkTkdUNjEy?= =?utf-8?B?elZxQ2pBclJXTmVZQkdYYXgwZjg2SnpmWEtyUXdqdFk4TDhDcnZpOGJ1dEFG?= =?utf-8?B?UXQyM1R0dTU3bUJSSzBzSmlHK3ViYmFYMG1HdzBFK09Zd2dvS1pFOTdqUm5T?= =?utf-8?B?WFMxUk82MkIzMUNCYnlaWUV1blFLakNJL2J1MkozTi9YeWR2OG1Sc0RtbEU3?= =?utf-8?B?NkJTMlVuTWVZeGd6ZTZXTVVzNWhYZExoMjdRWjFXMDRQU0Q0U0ZhWEZZb3Fv?= =?utf-8?B?SFZnMjVRbnRGMEphNTd0QVZFOWQ3aVJwN2E1Q3pEVXVoaTJZRzVuelNvS1Fp?= =?utf-8?B?bmxDK3BGUkpabGE4TDlOOC9XZTNqNHc2ZkZoMi9hNnRmODh5cENDeUpqeHlK?= =?utf-8?B?Y1ZPa3BDMHpUa2N6MEZydHpWV2FmWEtIaGZVeHdzOG90MDhCM1lsc2NKWm54?= =?utf-8?B?ZGp2L1o5ckZpV0xCTzJicjFkM1pGVG82MDYydk9DaUwzY0FZRWNHd3hLa1JR?= =?utf-8?B?ZmJ0cGtYb0ljS3JYU0N6WGJpY2ptNHByTEFpeTZhZTdVcDhPVk1CcXdFQXIy?= =?utf-8?B?TE5OVzJYelBtSFh6bW5xSlMwZXBqVTFqNDdOOERxQ0RSSmg5bU8xdU9jRjBH?= =?utf-8?B?YmtNZ3NpV0FPeUNvQTVrbnl1OHhFeWR1RDk4ekcrU21tWWNtUzZCV1NWRXJl?= =?utf-8?B?STljQkNuVGVoYmU3M05oV1NCMm5SYTZ2VjFPSGVmdCtpb1ptalFudmpCTkM2?= =?utf-8?B?Y0pOdzVBUUlIRUpRME5RWWR6QncvQmVHUnZsMWJoT1JIalBXeU11UE5xQ0lQ?= =?utf-8?B?SWRURWl2YU56eE9QT1NLZG12OEJ2dGV5SnNCK24xd2lOdy9IRHNoM0NVaThY?= =?utf-8?B?Yy8zUWNwYUNXOVNyK3Q5R0xqQnAwQzJiMVpmYzdwVWhucHAxMEt1REZMbW8v?= =?utf-8?B?NE1CbDVuQ0gzRmpzODlFQ3IzaGNMa0xtWW5sa0c3UjZFdkc0c2Q3aVhFZEFa?= =?utf-8?B?eWcvdDR1cWdRRmJuOVd3WTNTb1VHSk4xZjVIOWRVYndXN0wzV2lYYlR3a2h4?= =?utf-8?B?aUVZdXRqaDk5YkM4TFpUV3U2dS9lUTh5Z0lSTjNrRFdHNzdwVW90aEUrUGhL?= =?utf-8?B?RVJrVi9lVTdrZDlvZlVzb2xXTU1BUFZWVG0rN0NIVUVJSmltOENXNm1JS2RL?= =?utf-8?B?OUpoNll6QTU1a0laek5qaEw4ZEpnTDdRY01kVW1yT1lWaGY5SGFGYmh5WmJG?= =?utf-8?B?MGRjMFlZejJsV21hUHRIM3grN0o0azI5ZVUxRTJXQkpFMFQrcEtTWlBkT2Rn?= =?utf-8?B?MlVPNHgxOTh1MnVEWm96TjJ1VWdNMEpYQ0F6V3k2YkljMyttNjBTRzhXWTlo?= =?utf-8?B?TWttWXZuUnFueXIwbkllbGlBQWdRR1B6eEtTQ0p1R0JqUFAwQTZvZnZVcVdN?= =?utf-8?B?TEFlTVM1czNCbmV1aitMQ2VkSjJPR004UkpJVS9lZGhjbmF6VU41dFhpbHI4?= =?utf-8?B?cTEyQW1pcFZzZlMyQ3FvNVFyb2RtaWZGcEltbWhFdWxnUjhmbkxub1ptL3pG?= =?utf-8?B?UmJYL2ZmMXd0VmpEZnV6b1dDRXdvZk1hVnVNOHh2aEZIM05OZ05GZ25YMXNM?= =?utf-8?B?VUZMMy9HTGpBPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91960052-6b85-489f-b786-08da34c29098 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 May 2022 09:25:48.2761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB6960 Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move ff_nlmeans_init into a header X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Soft Works: > > >> -----Original Message----- >> From: Andreas Rheinhardt >> Sent: Friday, May 13, 2022 10:27 AM >> To: Soft Works ; FFmpeg development discussions >> and patches >> Subject: Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move >> ff_nlmeans_init into a header >> >> Soft Works: >>> >>> >>>> -----Original Message----- >>>> From: ffmpeg-devel On Behalf Of >>>> Andreas Rheinhardt >>>> Sent: Tuesday, May 3, 2022 8:38 AM >>>> To: ffmpeg-devel@ffmpeg.org >>>> Cc: Andreas Rheinhardt >>>> Subject: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_nlmeans: Move >>>> ff_nlmeans_init into a header >>>> >>>> This removes a dependency of checkasm on lavfi/vf_nlmeans.o >>>> and also allows to inline ff_nlmeans_init() irrespectively of >>>> interposing. >>>> >>>> Signed-off-by: Andreas Rheinhardt >>>> --- >>> >>> [..] >>> >>>> + >>>> +static av_unused void ff_nlmeans_init(NLMeansDSPContext *dsp) >>>> +{ >>>> + dsp->compute_safe_ssd_integral_image = >>>> compute_safe_ssd_integral_image_c; >>>> + dsp->compute_weights_line = compute_weights_line_c; >>>> + >>>> + if (ARCH_AARCH64) >>>> + ff_nlmeans_init_aarch64(dsp); >>> >>> Hi Andreas, >>> >>> the above breaks compilation for me: >>> >>> 1>libavfilterd.lib(libavfilter_vf_nlmeans.obj) : error LNK2019: >> unresolved external symbol ff_nlmeans_init_aarch64 referenced in >> function ff_nlmeans_init >>> >>> The reason is that I'm (obviously) not compiling stuff from the >>> libavfilter\aarch64 subfolder. >>> >>> It might need an #ifdef ? >>> >>> I haven't taken a deeper look at it, though. >>> >>> Thanks, >>> softworkz >>> >>> >> >> That surprises me: The earlier code did exactly the same; in fact, >> using >> if (ARCH_*) is our typical check for arches in dsp-init code. > > I looked at this a bit further. It seems that the VS project > generation tool that I'm using is creating dummy definitions > for such cases. In the previous workspace it had generated > > void ff_nlmeans_init_aarch64(NLMeansDSPContext *dsp) {return;} > > in a separate code file for being able to work with the ffmpeg > code in VS without modifying any of the code. > > Now that you have moved that code to a header file, this logic > doesn't work anymore. > Why does your compiler not just eliminate dead code like all the others? Is this MSVC -O0 behaviour? I just sent the patch https://ffmpeg.org/pipermail/ffmpeg-devel/2022-May/296380.html, but now that I read this I have to agree with Hendrik: Why not update your tool instead? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".