From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8B05E43A0B for ; Tue, 5 Jul 2022 17:16:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 34E4268BA1F; Tue, 5 Jul 2022 20:16:53 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2030.outbound.protection.outlook.com [40.92.89.30]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6D57768B9CD for ; Tue, 5 Jul 2022 20:16:47 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PbtKW/2zN7tzi4XZtVyn32ebIhMadT5pksbIuYgrEwGutN9IkgiWqi4dDHgJhNbQFXsFaWVRaveOOnSGh4hrfUcjjaCLTQejpo7lVQlKKOooCar1ByQWt9IS8+TBBtyNRXSXKZ6+6CCrrVFskpihCp5PD8p7CCyZAGiWaZs2vv9QIy3JVeErQ+ImzzwTmsxV4gZwE0avnnzk5p1EFJsG62whlMgMlhiJxJEiRpxMY/SYOVOw9na6RWPGFWUv80d0uj++Sw5I3ZOS0eX1CMqcwdRssCUWpco5Qv41GZFKmYN7EtBfCSRHTibXo4uV8zy2xNeJj+3nF8dPO6j6sOIrLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=asLly9vKkFoTD795by6WOT76EkYAEhHL0zUGHKYqpj4=; b=cuPYWY6AIh7yGaGue3fommFkuPVlk8r/0AUg57vij6suJFDs276U+fw3Wwoabudvxof2gOOuPjdzHbLrqHMR+bC05KdUCDlb7Dk25P3M+S+W1aXFjYy5iE+2LewvkZur0mpssnabdhVEIcUo52k5+0fLNUtKFjhR+gXU+LPG84AD28u7daCmHhjSIIbg5VJMyVFt5lj52EgT9G2Itliaxyx0efv7F8fIbZEk5JAm3HVg89pLDTrgBkYDnDstpWjRZQImueYwfXoOF65KmMHpk5hxEfHkL6RR08ktDX9Me+ke0hc3Yte4MUIUi3XjOPZ1LMggXi0KKJIkBQUNBWGLog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=asLly9vKkFoTD795by6WOT76EkYAEhHL0zUGHKYqpj4=; b=cK8Mp5JnxY6UmMu52DJkGjaha6Hjo1jSABv3oqXnjWxW2nkWzMd2n3PhvWIiDPS1k4YAMXq2eRzvhzXvRT8gjWRrPsr0gLMDKoc35rBtQy4NoT+smoFdAmplNxQud4YnYUpsfeG/pU8YGxt6jFO/kfyuS0pxT1mQMsBNYZIxkP58An2dtuVy6if/fw/ZJGpaysH251Fs6fBgXwG8qDkS7WEuilGZhWAgQdMRICsxJtVNgw5f5B1ffNFpUwtyScUpITZWkkc7dNfzFKXmAhs/vWTWcXrkfFQjRbXrqTekO2YQmrNXpBAl214L0Gkn3/vkkgYmFa2cujB2UIx1ozjOHA== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM7PR01MB6785.eurprd01.prod.exchangelabs.com (2603:10a6:20b:1a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 17:16:46 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 17:16:45 +0000 Message-ID: Date: Tue, 5 Jul 2022 19:16:44 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220705001101.111869-1-ffmpeg@haasn.xyz> <20220705170512.GL396728@pb2> From: Andreas Rheinhardt In-Reply-To: <20220705170512.GL396728@pb2> X-TMN: [6/prk5vkT9xUasUzi1Srq1aiUmKGSPSa] X-ClientProxiedBy: FR0P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::19) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <519988b0-d78f-0d91-8cb4-8b7eef59a3a7@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee3e1f21-59d9-4de8-79d5-08da5eaa232c X-MS-TrafficTypeDiagnostic: AM7PR01MB6785:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2mBHn2ELPe+LF4z7IT5efOfXpnV6Zvgaf4H+dgk05QHi9xQ2UXr2XmFLS/2KFp8dkLWRqSSUEGPrYKV4Xbht+hRPlgMZeTbCqshAa7l1jCul+PQW6hYmSGHDkPf0VHXJoYclwFsKK3FSzrb9ecFSLnLfWKn8Q0roLd/JgmmvH+ywGoQJJ7OmUzS7btNF92AdKujbvXX/b8WwxKPx/6BXxHzGF0QTFPBtnOhT8nWPKlTQDz1LbQMW6XdYWa//cNWtrEY0wWRe9/+m3oLWjTz8XSup6edOWzv8bVAu5B/K/LcRyeWHNXmJDBwQBcLZyx/eC27HliL1tqu13XFEJHhoakDnKD/5k99daU29jEFwAQuezJUVlLOnRGEfLTKh6nPeTWsumZQU8aDdlwG8kGAJ5g8P8wJ1oJbJY+0Jz6qVcfCJbCfEjapVghZgQ+0RyxAdSnMiIpPS4vl6ZtOSNvAIyHiOb2Vi4/DguKaiSrrZRI97FZAi56jYGPwRCl01YzHosE/Z+gyJMIrxFntB1ZSlpLz/UQ3PNMWqawGNelOzZG0Uvlxsg999A3WFZQVPvx2UQM0YLt9WnsVTt7XKjsVYaia5GliPiUTtPJat77PDZnA7iMhq9MQylrsaFpg/F3igdIv1+CfpEIyvE9UWZO+5pQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmNVOU4xYzVudHpoZmZob3dzVUJXNm1qeS9ROTdITUVXMFV6S3pRTlhOK2tG?= =?utf-8?B?SGJ0SWpvdXFkS2dkSjF4RUV1WGYvbFhQZkZ2MkRxa01XU2JYSy82WWdoc1F6?= =?utf-8?B?RjdWelh1UW55YlQyY1lOOHN6SHJVNC9lbWZUamlqVERkSDFmeVZ3VU9WUnpD?= =?utf-8?B?NUtWR3NrVFZBd1ZkcUp0bkZsZzI3azVUWkN0R2kxQ0pQS2tLcHdOMW9RZ0pX?= =?utf-8?B?Z2E3Tlk5dTF0SE4zNDl4cHM3L0VWOFVIY1EzUDBWSXBFam1la3lQYnBMN281?= =?utf-8?B?N1RxbXM5L05RVnRUTU9HOUovR3lCeHo3MWduUFZ4dVpUR0FMWU5SeFF1Ti9t?= =?utf-8?B?MC85U0dwYnpJaGNwaE1PNTFSYmtQSDFOdElRTWp5bHdjaC9lWEM2dDY3SnNC?= =?utf-8?B?QUpWUnJGSGR0eXYxMk1hSm9TUHBFK2hLM2dHMVFFZXBua09mSklKSUkwQjFH?= =?utf-8?B?dGg5bDB2TGQ5NFdtd21Cb1A0c3hYa2dTSURQZjNrT3ZMQk5ZcTRTZFg0V2V4?= =?utf-8?B?M2hvZ1RqTlBaS2JEUW1EcmhJY0JFaHAxRXZQVU9aMmhCelYybUZGVkdYU2ZQ?= =?utf-8?B?RThzVmU3Z1UxbmE5MFFlcTV1NzBibUwrNVp0RmtZNEJ3a1RYRkpFM2xBM3k2?= =?utf-8?B?eHlzc3F4YU53ckczSGF4dVo1NnBid2Y5UXMvZEFydStFY2lhMmxpT2RudGZU?= =?utf-8?B?a2I0eEVlNGdKSSt5WG96VEFENEtqRVZLQ1ZLL082blhNQ1ZZMCsvaDN0WTFO?= =?utf-8?B?WlA2RWNMZkJMTSs5OTFMWER1cVNSZlg5UllONndobDZaemU4V0JTdDcweVBJ?= =?utf-8?B?R0ZCeTh4UUxoaGozWWdhV0graFYzdExvcFRLNHJxK3lOUmxCRmNYOUZJQjhR?= =?utf-8?B?cFBvR3UzNExmZnVKNE5GWE14ODlUYlI0cEVnTFdSamZUd0NxQVFUaUIweTlh?= =?utf-8?B?bklvYTdXbGwva3BpQXBmT0VCczhpL0ZQZGo2bDhQd2RGOWhIM0I2QXMyNEFC?= =?utf-8?B?N0QwOUlTQVpTY0tXRVRnRnlMTVJhMXcrbUxqUEFsM1BqbWszZE5ueDFWN3E4?= =?utf-8?B?TWdLaVF0YUYvMnc1MVB4Qjh1eXNmcEFadkMzM1gvVDJhSmQ5S3dJcWw4THRm?= =?utf-8?B?TU9Wenp5YzN6Y0pmOUFOUExvT1pMR01MV1dJT0t0UkdtTS9wYVg1V2FkWVA5?= =?utf-8?B?S3dYUjBjams3dTZySkQxcUJFQnF1Q0htSjVhZHdSSjRuZGFsMWF4b2ZDMGRQ?= =?utf-8?B?Y0FqS0dUSmZoK2J4ekI0ZE9Ebzg1Smg0MUw0RmtuajFkUlovMHlGMXE3dnAy?= =?utf-8?B?eFFVeTh1aStFWVNCUzJhcHdHNFlLa1NxbHd0YnhHb1RqMTJrSDdobHdSK1VD?= =?utf-8?B?NjFFem9sZGRwdjBLM1dQYUYxU2YzQTlIWmRtZEs5Z2hoNnJsYkhqVmxtZ0RH?= =?utf-8?B?VFBsN0pRU0FubFRaQU9ncDErOFphMWExVDErWldnQkdBcTNRbDdqaE1QRWRI?= =?utf-8?B?V3dObXExSTh2ejFUNnk0ajRhZnkwWFlSb3Y4R2o0YVRCc09IOURSTTIxdG1W?= =?utf-8?B?ZDQ2OGVoSjhLRHFPNDBLSUZKZG9walBlOFNRdkEzZG5PVk94ZnltcWZ2QU9L?= =?utf-8?B?UkpGVmZ4cUg0OHVlVHpLUWc2aUZCQ1J5Um14VEpBcmd0VnRnL3p6Vy9NQ2hK?= =?utf-8?B?elpHSnNEdmxMSDdDb0l4OVNjak5HVDVkUHpBL2NjQnFzeTdiTjZDdHhCcDd2?= =?utf-8?Q?7hef2giLPX9YExF7aU=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee3e1f21-59d9-4de8-79d5-08da5eaa232c X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 17:16:45.8688 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR01MB6785 Subject: Re: [FFmpeg-devel] [PATCH] lavu: always provide symbols from hwcontext_vulkan.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Tue, Jul 05, 2022 at 02:11:01AM +0200, Niklas Haas wrote: >> From: Niklas Haas >> >> This header is unconditionally installed, even though the utility >> functions defined by it may be missing from the built library. >> >> A precedent set by e.g. libavcodec/qsv.h (and others) is to always >> provide these functions by compiling stub functions in the absence of >> CONFIG_*. Make hwcontext_vulkan.h match this convention. >> >> Fixes downstream issues, e.g. >> https://github.com/haasn/libplacebo/issues/120 >> >> Signed-off-by: Niklas Haas >> --- >> libavutil/Makefile | 2 +- >> libavutil/hwcontext_vulkan.c | 26 ++++++++++++++++++++++++-- >> 2 files changed, 25 insertions(+), 3 deletions(-) > > breaks build with shared libs > > LD libavutil/libavutil.so.57 > libavutil/hwcontext_vulkan.o: In function `av_vk_frame_alloc': > ffmpeg/linux64shared/src/libavutil/hwcontext_vulkan.c:4177: multiple definition of `av_vk_frame_alloc' > libavutil/hwcontext_stub.o:ffmpeg/linux64shared/src/libavutil/hwcontext_stub.c:37: first defined here > libavutil/hwcontext_vulkan.o: In function `av_vkfmt_from_pixfmt': > ffmpeg/linux64shared/src/libavutil/hwcontext_vulkan.c:4182: multiple definition of `av_vkfmt_from_pixfmt' > libavutil/hwcontext_stub.o:ffmpeg/linux64shared/src/libavutil/hwcontext_stub.c:32: first defined here > clang: error: linker command failed with exit code 1 (use -v to see invocation) > ffmpeg/ffbuild/library.mak:118: recipe for target 'libavutil/libavutil.so.57' failed > make: *** [libavutil/libavutil.so.57] Error 1 > > This commit has been superseded by f9dd8fcf9b87e757096de993dd32571c4a85a2cb (which fixes the issue in a different way and together with this patch causes the issue you encountered). - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".