From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 522CF43F92 for ; Tue, 23 Aug 2022 12:37:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0164768B924; Tue, 23 Aug 2022 15:37:42 +0300 (EEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05olkn2059.outbound.protection.outlook.com [40.92.90.59]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8F51368B8AD for ; Tue, 23 Aug 2022 15:37:35 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vtsn9yZNIOSDjg5Mf1R7ogfdcl5mM+Ks6S/sxoMtavD0TueVOcrTa48S9EqQhvOYQ/2bzHIrcHKW5gsLabtZg60fcjdEJ+lH/FgN2Dd+j4IIoL7BQKIBUH/9hONBXSQ7LsYkCyPvkhICOAmZMkutKGBbPh1jLSKSTJux+HUYWk3DfsVHwGy2C6qhAGtGOJkBBcomNWozxwcfPu+ehr0LlUm/peADzbHgHpN4wSMsqSPoNBtXmzA0DCQ1tm+aMIuGhEXNSsRcNVj7HpJhMF7JgN/oHI1sSXlmn7yjPKJTAH4X4O1EuldkqriWCVJymefEnEjxLuRDjfCy17qfNiLwpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUrwl+GYHbotoq5Vt7Yyg7Hut/Ht/8pDuhL5v8lH9/g=; b=knL+Gyfq7Sgad+eCY0oH3lcr8XxIqdK2TIYv044as7fpRgILRS/h9mmDX5HzL1+/LcqP1lz24bgEnLJmfs4l54HdDaP3WBjuNGvdwRIN1gc51i5ibUhBEHhFTrzPknxmAdsFgK1ChuCBbCW+RFZRRTt2HxGIdhdJlEdZ45MzOmvZpFdOPGNoo7/xcVcprd/UpnN7UPe5SQIDE+Utj5GAX29Xgf4AckkOW3FM0mKPBNuBrEdK6Gggdeqg2ctHab9olHt+BeEPfhwkHoYRU58X8V9o00tHK2dBrAyFRb1WsckijBzL/xM2W/XK3NtNzyWeXYUsr6FHg4aZqI+cECy4PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IUrwl+GYHbotoq5Vt7Yyg7Hut/Ht/8pDuhL5v8lH9/g=; b=cSYRxNOpZbv1g7+NmIqPsxK+sqEtMo9xG0GB6bcozpzUjyd/CLbJvNocF6YXbQ4vsW79r5crWGZ6p90cuKDcw0Puk8FAAOvhittIcD4K9ZJbIwNZgSgXqGHy2cO38E/6sIerG1jnrZSYRAYuKp5iu/FYtAL7NI6EXtl4fMGYgyaaHEuQd7jVJGLC0I8Bvb0Igg5cvqNyFwY7G6Bq36a8aCl71zGk5/vgeMnvueLpCaah4RGD0OktYw0vJfVPbh5XbXtbpht7s6OiFrE/q7QBfNhSiFj4zMvL6GfI9TtFvcwU66CAf+7TkPbHdjMuS8r9WuSFferv85RnHYF8F2QicQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR01MB5639.eurprd01.prod.exchangelabs.com (2603:10a6:20b:f2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.22; Tue, 23 Aug 2022 12:37:33 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5546.022; Tue, 23 Aug 2022 12:37:33 +0000 Message-ID: Date: Tue, 23 Aug 2022 14:37:30 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [JHsubWrp1KYyG6rwWXtqJQhvCJPaniNx] X-ClientProxiedBy: ZR0P278CA0141.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::20) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <5291c53b-966e-cebb-fac8-e28298e0ae89@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b322fe89-c21e-4ec0-a90f-08da85044061 X-MS-TrafficTypeDiagnostic: AM6PR01MB5639:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KQncbKa5WHg9sfS7GBDe/VnBL22AZbTF3OQtm5WspYYdINe1uIbboJ3Ml3lcJD7Yj6QO9VxNhWH9F794XfJLUNUJWat7a9Z4oxwfiX24GaZx1qM7M9RjUPm4l4DBch0AMGJieoIL4pXU2OhV6laDOZa4Dxb0piws03Uphl4ImKjbmome6w0mXRuILpyeQbTB7RpSdSyC3n43oktX2jv9q7i0ftP0Rj4b0+sKmdcjzNB7D3QFtFofa0c/tMgQp4MHtKMHE2Dsa60BddZHghaWtjxJT6PtfYLAIN5BGVf6VY0mQq0pZ60MLSPU6LCSg9KtcTGNHtTNA++Cn+Q8ye6xPO/8MvogFrtG1mYqAfDZvV3BNGROXVwCYRaWwv5sR8slJsfijJOzERiWbQG8QCi2DAchr7swYEbLGEXE891zFFonQdZy/qcEzBIylMPDg90AcMtUOVR0vNABPHhTalOBQ5weV9pXHG3eDe35Ki2Z4oUDabvfIFB0c/Q6MbuoOAoZ1Wx4K8vTPhkM3AF2VLWdZuZbblA1YxtzqXtOGuz8VFM07Z3HjQqhmnCmLGUylv7hciVpmPKoaIDEiT8j8lbIrMRHR3s5XXjMNBVOlwRFFDKlMRYc5SLdpxJTewMgdPR50ctHAC2bD/D3F+3wpDY7U1YExz7qwiX+BNGeroOT2PI7EwDaWk5pJSuTqvrY6md+ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L09RSXYybHVmNE1LbkhHQURuWFlYNzlkTWw5YXVEWVQzZVQ5NnVtaHJjWjRn?= =?utf-8?B?dnBXcGJHZGd0NmJPUnpkUjFXUzJSNzlIQmpNNkc5TE9EYTZZcWdDbm82VlN3?= =?utf-8?B?ME55MlplV1JYWHFxU1VKY2hpWkI5Q2dFU3g1cmNDTUF6QVpmSnJXem9Xb1F4?= =?utf-8?B?WUNnbE1FS2U2MVprbm1QM0FNZG5saUIwMm50dm93WlY3S3FIeDBYdHRyZkRT?= =?utf-8?B?TlE5dlEyOHVPRFI4dHl2MXpPWWljQ2gzL2hEOGRIeXphY2dieGlvU1hDMTQw?= =?utf-8?B?YVNuT0ZLcEVJbUs2RGc1Q1dwbHkzSEd5WmhVbGo3N2J3ODJpeDFkZTQ1Zlcv?= =?utf-8?B?Z2w5a1F5VDFyaUZjRGJzcU5id2NjT2hhN3NJcGlxQk9PTWlhYVZLSW5Wd3oy?= =?utf-8?B?b3pMUitNWC9FZEdnSkRDeGQyMEkyQTJ1ZG9NVnM3aGlpK0lld1gyd25HR0tx?= =?utf-8?B?RnA1T3JSblFiUWd4MnZ5VHR4RkZlOVl5LzZpcWkzZnFManVka0UralphbXBr?= =?utf-8?B?NUM5WGhXQ2ZnZ3doY0RNRmNvZVluRVYvcVRHcWhZSGZHemJUVmNuL1ViVkxR?= =?utf-8?B?M00rMjNndXFKTFFLcFM4Um5XTXFGODljZjZ4d1pkU1hSLzdGZnozQXI5eXlG?= =?utf-8?B?QkZPOFNKNkNsNjhIRGxHelJHSi84N1pab2xJQUovS2h4c01jUEcrZUVWc3dr?= =?utf-8?B?S3dhTVdnTTdFNzhaTDI5dzBtcjdFajFubjVkOU1CdlFyeWJqSUx3UDdaZUdH?= =?utf-8?B?WHJwbXl5OHoyQ0JLYXdUVnI2S3VLTkhONGlVazJiOHFNOFBLVGpBUHBJZEtL?= =?utf-8?B?YlkySEJWTDQ1eUErTGpLUkszNjBvMGlQb1RweE5lWjYweDFiTlA5aTlWT1g3?= =?utf-8?B?SWo3bDZWTjdzZWJucFdYbUVzZU9adUJheXI1TDhQTExzNVJKRWUxdkxuOG9S?= =?utf-8?B?b0VZa1hsWnNaRGVFRjhHSHZkY2RUaUYzcWlBK21wSnRoRW1lUE5oK21tUXcz?= =?utf-8?B?WVJ2Zzg2RkQ5bnU4NUR0dU1HR21DcGN5dDFxNWdWcU5RYUtLYUVLSlA3enNS?= =?utf-8?B?aiszMCttTmNjRjA0QVVRR1BxZVVIT3R2VWlPVzEreDEraStwY1pPdW1CeFMy?= =?utf-8?B?YUgwUmNnellWV01oMW0rZlJzVjZsZGpHc1Ixdzlsazc1MXNHRDF0Y3IrQWV1?= =?utf-8?B?RGZMV1RUV2ZqTTFHMnQxWXJ1VXZrcWplUlM1MFF2RmFzY1FJUUpmSE96TFo1?= =?utf-8?B?V0x1MkZnOS9NRU1PeWRYOGRFciswa0hXaUlRbUh1amhxVnpXYXQ2am5vWHBt?= =?utf-8?B?VUNkN1A3ZFBmSWZhWVJDditSR3V0cVE2SFZaRGIvd2hpSEZsMG1NU0tUN08y?= =?utf-8?B?SGJQTnJQa3d3R0w2Rk4rVUxFVnoxYkIweDIzakRWdStubEdPN0NSUVhvY3c1?= =?utf-8?B?Qk0wSE12VkU1TmErMnkvWTVadzhyTHVvN3hFeVJWc2hYOE54SjNIZlFjZmVF?= =?utf-8?B?b0xIWElTWWViOGZCSnlueXJWeFpjbXM0ZDFQdStBMXIzS2RYb01lTngyb1Rk?= =?utf-8?B?Y1p4QnJYZm5hZkRyczBRaTlXckhLeEErbVRVdVVUQ2FPR0FGbm91blVFaHdw?= =?utf-8?B?SzA5R3EwWVI4WW1WK1RZeFFrVUlwaSt0Y2t0TTlSdFE2T0I2Sk1iNHB2aVls?= =?utf-8?B?bG53Qlg0N3dBTmZjbFUyUnNHWm1xNUEzOFpFUndWOTFlTDhOQ2NvbldtTCt6?= =?utf-8?Q?Jy5I9YgEbhAA+1PifY=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b322fe89-c21e-4ec0-a90f-08da85044061 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2022 12:37:33.5664 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB5639 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/gif: fix duration of last packet/frame X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > Paul B Mahol: >> Hi, >> >> patch attached. >> >> return ret; >> } >> >> + pkt->duration = av_rescale_q(pict->duration, (AVRational){ 1, 100 }, >> + avctx->time_base); >> pkt->size = outbuf_ptr - pkt->data; >> if (s->image || !avctx->frame_number) >> pkt->flags |= AV_PKT_FLAG_KEY; > > Where does the magic 1/100 timebase come from? For encoding, the > AVFrame's time base is supposed to be AVCodecContext.time_base. This > could actually be done generically for all video-encoders without delay. > (I know that AVFrame has a time_base of its own that is currently unset > and unused.) > Strangely, if I do exactly as above, the gifenc tests show weird durations like: +0, 0, 0, 10, 1368, 0x6cf0befd +0, 1, 1, 10, 158, 0xcd173bb4, F=0x0 +0, 2, 2, 10, 163, 0x4f7a451d, F=0x0 +0, 3, 3, 10, 152, 0x17723839, F=0x0 +0, 4, 4, 10, 160, 0x67854056, F=0x0 So somewhere a timebase is wrong or AVFrame.duration is not converted to a new timebase somewhere. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".