From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5AB8E43BCC for ; Fri, 22 Jul 2022 14:24:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B21BB68B6D0; Fri, 22 Jul 2022 17:24:04 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2071.outbound.protection.outlook.com [40.92.89.71]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 08D7368AFBA for ; Fri, 22 Jul 2022 17:24:02 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Roe/pYEbiKnGDjL+m1MNCek9Qsdwqt2AnZ3GWPW7kUDxKp2t+OxlZ9aWfxc0SA0F+2YYwkf2LBaqMv+Z8ABsuTdZUBO66NEtXXzYvRL1rVgVaoGy4+aX5ChzoTEAB5N838gFVjaPo6Sb5UjqadupXXA0KomXulxbGPcjwVlEL8MHaFyhFexeZi4ZZc2ZAeTrvC3Qd9pQMChuvLFDTP4+57LRKgF4v2Tmd7HPBkeNekpV72/00FgW+a5S2INEjqg+wryfbIZ5lRro9a2pYLAb3mjearVm3PzmHJnpJxmbdtMn0Tl9p0XLBaO9+EJ0Hx1k2owtMdkdK10SaKHucxcuzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LoVl+zUv1d3+XuP12seHac0r4VBNlxpqv6DhHm9jGc4=; b=KF9k344loVstWfE3kgZR+ICQIBZH0iDQGjZUk+hjmYYNUPvoHbWLq+Y1We2yUNbpUNUtUN1jwDoB/uatLjuvmO/Q1l8SXszw7zKBSmXNF4edCReUqAxXLNyOv7WmWlcYsjV7qwFV+3mGUvCDY/UY7o/AHA/4nMZjJ4DNk9+TCa9940c9zn7y91UaAxbQHwSwqQHcgQMthrArU5CIIIpYnVeIPwQnX9rf4x4lSLMUTfMoFSgzGJgQ8vDqEF49FvGEcdwGiElRJLH4W0TKyB95k6LW7hlaQAfrcZHtLp3fKlD9yUdhYevKrcAisCFl6tM/b8k16SIDQLZVLX2oXygZZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LoVl+zUv1d3+XuP12seHac0r4VBNlxpqv6DhHm9jGc4=; b=J723FODBWwMIGmizWCW+o7HxkYmUAZ9J2bt0e4OEsKt3SI1aBLD4AAo1uAaYdMloeXzxkuZdSrY9iTqlH9WNiQVcB1yUiSkC8StGPWaS+jKaHk0Wp+Zm4LzblQpxSFtcgRa8bJxKtIPcqn/g0iI1ZQ4t69Ff+K0DjBy2KRUWeeRm2VcjPqVfTYGmBzmeM9BwG63Fqk8buqpbp3NeLTZaWGGNk2VWgCErAknYoUXleILZNtbkuFDhlX446IOLfE7WkMXH8Hi+HuyAncr6cJsbp0hPGIBM/oOgazDf27QbPCjT6xlvB0WZDLsCcP4+1kJbUhA5i/v/0Lq+f5kjCaPVIQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR01MB6181.eurprd01.prod.exchangelabs.com (2603:10a6:20b:eb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 14:23:59 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5438.023; Fri, 22 Jul 2022 14:23:59 +0000 Message-ID: Date: Fri, 22 Jul 2022 16:23:57 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220713175948.1955-1-jamrial@gmail.com> <8b484a4e-ba96-d54e-a4b5-84e1ee5e53f9@gmail.com> From: Andreas Rheinhardt In-Reply-To: <8b484a4e-ba96-d54e-a4b5-84e1ee5e53f9@gmail.com> X-TMN: [jrxRaiiDp5jfygFj0+qpkJXLQ+7r/8hQ] X-ClientProxiedBy: ZR0P278CA0061.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:21::12) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8abb87f7-11c5-480f-adf6-08da6bedd155 X-MS-TrafficTypeDiagnostic: AM6PR01MB6181:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zz7yu8gcSLXGZmLGGNAnIT6yRx6+VFVFeesBM1Jx27yx1o7pJYQvSmJDmARJ5WWTQOwy3xvh0l9O9RhfrJP2V12pK6X9G82+PMsQEMoxVK87qHh8uNxEwiJ02MMIy/+SR5CEpPOsxeW6CLN5Xa4hEERyubn+hptE3X11zX8y3Frx9bZXj4Gp8lq2c7Ljr9wmnjkwWIuLf76DpVpODWhYVCQgFaMYoQ+hcTYB4eG98DQdck45tIsxw21yjswtX//psdrG/t9N4x5P8NxC3EKjXuXFKwiuwmGiYRBdkNh6yewBFlmAMTvmvifoMpS4/Qx0Io4uXZD0J7uUTym7I2JxmnER3HXmspKjoXrqspBJUuaIlaEOrLeP2Cxg2NzWxDB5T1fJweLa6XRf5B2441jOhqqLNEkZo8wbWDzdB4lkVhQrY10iqL+W6x283OCG8xSw0pYFw1/ivHkQNiShf6MvCMxvr+claiVXLyJC/fnATKeI3fLhzDycFgjEFfNBG4AnuJfgvub3gvL4ZOPH/jwuiXDGAHRetKWstboAp21Qp4+dTi52g/OmfPXn6qA0wo+Ju3gHAshdHXeGfnB3ZKG9S3p+2ICCLepvu3C8q9QVieNgLPzsG9dQ3PWD32zEiyxjRk35jxVGvzCMjQmHZJgpjPRAqYdX/uD/JB6Z5VkVPeEOPLoUj85fBxqwNmWpVTMi X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eTlqcnNpeVNPaGdWdDZqTFNmaUFzQUNkZmIvZTlLZys3eEtEcTVsZkVRRlRj?= =?utf-8?B?ZDZFNWlQUHVxYVNRaHQ3b2tyY2JnMjRuUi9Vd3N4eERHREdtM0NlNHBlZ25U?= =?utf-8?B?VzEwdTZja2t2WGQrai9YMi83TUwwWjE0WWxsYkZOQkdJM0F1dDdGTGxUYnFN?= =?utf-8?B?SDJHRDR2emY4QTJwQUptU1E3U0dTTVBJK0ZsSkZRdFd1b1ZYNGtLaXBZN0RE?= =?utf-8?B?WHFvcHVDUXlER2h0WHcrRENNYU9aNnJPV0RBYUYxUmxQcXJyQWRVYW5VTEcx?= =?utf-8?B?c0JWU2wyZGlhTWYvMlFGL2hOQi8wb0h1c3lQRlM1V3FtVHlOK3I4ckIwM3ZU?= =?utf-8?B?U1ZhWmUrVGRpVy9CcFZwMVo5dURMaEN0aXN6UWNIbjk4UWl0TnhQRDdJYWZx?= =?utf-8?B?UW1JUnRYOWZhSCtqVUVRWGNZeDhJRUFYb0QxOTc1K0M5MzVGZCtXY3NBUTZq?= =?utf-8?B?VjJuV1l2YkJJNFVORUwvZ0pXM0NDN2MwYWNXemNjU25weUdRbFUwWlVxSlp6?= =?utf-8?B?ckNTQ0l1bVFyZ3c1aUpIRXlaSnduQThSUStvRWprV3VZK3E1MGhjbW9ZUVR1?= =?utf-8?B?ZnoxK2kvOVhFS081Zlc5MnV3SVBrZTBWTmpJeXQ2ajF4bVE1MDFZUXE1YTJM?= =?utf-8?B?V0RMNjkvSFlzNmQ3OGh5NTgwWGpyaU5ZeVNETEpkUVZ0V05WSE9XWE1ham5I?= =?utf-8?B?WjVOUzFTa01tVUViUy93WFplRkxlNnJmYzh5K0djTHp0aWNPbHlkNGVNWjBV?= =?utf-8?B?TlQ2UlRjK1FKZktMaDBwWGM0eDUvMjcxNWZ1SWdWL1FXWHJCdVk4U3Y1VExD?= =?utf-8?B?TWV0SERtNXdwSW4reTZKZVBnUWlucEdtVGRZdmlpWDgxNWlUNm5vTUhMUmdK?= =?utf-8?B?UVRnczZxc3FDdkZGZHRiTmhDWEZoRjFLaUpkTzhxazdpYkl5Ry9aTEV6Zllj?= =?utf-8?B?WE1idW1sUFl6bGRsalZtNlV1RmJ2U01tMS9pb1g0UlpZM1o5RG9VSVNIZTFp?= =?utf-8?B?OG1PWFJCM3huUFRzeEFWbXRHM21JRDdUemxrQXpRYjFUTE9nM2RkSjBXbDVX?= =?utf-8?B?Ync3aW56elQyRms4NGtPZmRqZG14SFYyc3g3RGlZai9BRlpub3crdDBOM0JK?= =?utf-8?B?TGNvaitPYnR4VVZBQTlUd1FKUy9rM0xYR1oyckNVK2V5elc5ZWFHVVR0NjBs?= =?utf-8?B?TGVTNHlUQ1BBaVNYUkhsZ2RIMk5iNVhVbzErZ3V4TXdJb1dhM0IxUk5CNjUx?= =?utf-8?B?cWZ2MTNoMGVzVWpwTnpHNmtqVmx5MmErOEdZOFJXU0REb2d6UmJzOWxTaHh4?= =?utf-8?B?NjJmdzJUWHplcEo0eUZJVFZWdXVmVjZjYkpQc3ZDKzlTVjRMMGc4ZWFRaytC?= =?utf-8?B?VThwTlhSczE0aFpkdkVRazVNOTFCZGJWbkJ1dXpvK1c2R3VQWEUwR0J2ZmVU?= =?utf-8?B?Y1BDbXJWT3JDVkp0bnd3b2ljcGVnOGxwV0tlcnJQbnB2M1ZGK2tVMUx3R3d1?= =?utf-8?B?aUViTklkVy96bTFJSm1PWFYwRFBZbTVjU3ZOZkZYa2FyVzY1LzU2eUpoNXBB?= =?utf-8?B?YStSam1zOHlETzFMTDA2UEdrOERhTGY5UExHWGQxY1gzTkg2QytYN3QxcjNo?= =?utf-8?B?cXFTbFk4SmpPc1hZVFU1b0RSejhlY2tsUDlHUHNCcWh5M2swRTdiNS83S3F0?= =?utf-8?B?bVo3UGwvcExuR3NMWjNMTWJpU3RIMzR3bkVCSkdpWWRtL1Q3QzQrb1ZRd1gw?= =?utf-8?Q?cVre49iV93nJtW4izw=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8abb87f7-11c5-480f-adf6-08da6bedd155 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 14:23:59.3726 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR01MB6181 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: don't force HE-AACv2 profile if no PS info is present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: James Almer: > On 7/18/2022 10:57 AM, Andreas Rheinhardt wrote: >> James Almer: >>> On 7/14/2022 9:10 AM, Andreas Rheinhardt wrote: >>>> James Almer: >>>>> Should fix ticket #3361 >>>>> >>>>> Signed-off-by: James Almer >>>>> --- >>>>> This also needs an update to some fate ref samples i'll upload before >>>>> pushing >>>>> (fate-aac-al_sbr_ps_04_ur and fate-aac-al_sbr_ps_06_ur which are now >>>>> decoded >>>>> properly as he_aac mono, so the .s16 files need to be replaced). >>>>> >>>> >>>> We have both a fixed-point AAC as well as a floating point AAC decoder. >>>> Is there actually a test that tests that the output they produce is >>>> reasonably close? If not, could we make the test so that the same file >>>> is decoded once with the fixed-point and once with the floating-point >>>> decoder and then compared? >>> >>> That wouldn't help much, i think. Almost all changes to *_template.c >>> files are going to affect both decoders, so a breakage would not be >>> detected if you compare their output with each other as they would both >>> exhibit it. >>> >> >> I actually thought that the aac_fixed tests used checksums instead of >> ref files; then changes and breakages would be visible by changes to >> these files. Apparently I was wrong about that and the ref files are >> used for both aac and aac_fixed. But a test like the one outlined above >> would nevertheless obviate the need for a new ref file. > > Judging by > https://git.videolan.org/?p=ffmpeg.git;a=blob;f=tests/fate/aac.mak;h=1743428f544fad8946dba11dd4ecec0630eb70a6;hb=HEAD#l117 > it seems at least for these samples the fixed decoder does not generate > a decoded stream comparable to the float one, so I'll just upload a new > raw pcm file. When I decode both of these streams with git master, the left channel is pretty much identical, yet the right channel of the fixed-point decoder is silent and the right channel of the floating point decoder is not. With this patch applied, the result are two mono streams that are pretty much identical: The test sample created by the floating-point decoder works with the fixed-point decoder test (if one uncomments and modifies the latter). So the issue with aac-al_sbr_ps_06_ur is not a reason to upload new samples. - Andreas PS: libfdk-aac produces a file that looks pretty much like the floating point decoder from git master. Are you sure your patch is correct? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".