From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 71CF040F1C for ; Sat, 11 Jun 2022 20:14:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3530E68B406; Sat, 11 Jun 2022 23:14:23 +0300 (EEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068028.outbound.protection.outlook.com [40.92.68.28]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1F3A468B1E2 for ; Sat, 11 Jun 2022 23:14:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GzAzW8vQwuOkpDRiM/vnGc+XJuHc+hdvRU3j6hQvQBq2gjoENheFraGekMPQoZJi7zu9+dQNrslsD6adffq83LKayznaxZKxosPwjOIKSfj8ialN6Nrhvx8Lm3piQgr3E0YzJZWtSjpMLsnx9wFGp/njLwOQ5XQGpNkh6baBu1iyzpj1cQ5ypa2yQ+0x6igXkbByt8Y+uz9ZaIYAPGMAlisimo541Rqo5MphxKPdHx5rS9BvDbqKKCiDX/bsk8ZRj262J3cIIY7y/YcwHyiHPBxuUU5tfXsCTytHWhmDdDhnX/nGH0N78puRqEgThYluoKhLwBcCM8RYfYmBxtTHrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nvS3PTIm64uDbJpalS7ax6yC6md89uG9BFGfD945Lgw=; b=eGfnFAnquz3ZdvzPwJUJEKSCKCPykxAwylFW9fzlAn1xTo8PNHWi3H8WCksEmljpsu9wCPGflSObU6wSAYGhb1VXNQocdfcX30MsFWL7Uj9K6m/yTt2u8s9n+cA8LzB/NOtVSGQPBakQtTFXHmydA+nZDrashegGMe7tMv8Qu04zhGlzko4NWd6p+6G/br5axZor+s8LEvTFpE8Dxu747ios12naHmjfGA949RNhJedVl0MCVgogzvKkE26lzdbDKfk32TvFunxIWz1J1E2CIWZilSKkVdJjkLpERaXsAl9AbK3xC6NqzIgM3M8nWjxfemGj1R6bsC4Glpy79VS7jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nvS3PTIm64uDbJpalS7ax6yC6md89uG9BFGfD945Lgw=; b=Ocp+7vLf29o2dfk1JHF3h+vNp/UR30IHXR1U77gcGcGDNwcFbp3LjZkhU6X3pDF++YCiBHVY2IEIJytVO/Qw3yCbVq2R5uVO550t1O2+LiEh3JOUkht7wifoo0WC8IDqCwWgD9WD+E137ad74eqBlOMx4VHywyy4NgO2G2RjY6HkEq+gFp7IayNCa2Kyt14ztPibavYFj2mG4ynZLQ/nzp1RuEvsi4Dk9tj7lkB2fWvsQAxM/WPx3Y2e1Kl3g5/meAyxJz9LUKk/OjdXoVyyODbwDhekpECcnQPPudX+Chvxwnj49oOV8hjyu98Z0mDP/YiPI36hNJKkXJoHdIB/4A== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR0102MB2591.eurprd01.prod.exchangelabs.com (2603:10a6:802:3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.11; Sat, 11 Jun 2022 20:14:14 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5332.016; Sat, 11 Jun 2022 20:14:14 +0000 Message-ID: Date: Sat, 11 Jun 2022 22:14:12 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [6Epua8b86bCEvhxBJFd8VkjCPxT1HCMZ] X-ClientProxiedBy: ZRAP278CA0015.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:10::25) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c7184ad-243d-40c3-ce2d-08da4be6f48e X-MS-TrafficTypeDiagnostic: VI1PR0102MB2591:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XpzoPXvD5wGS+hsYzzwhBlTEdfdo6hDqRpDtUU1eqqB3QCXuuOrT/nPWa9lYpOr6yHJo9+QJPJ6NaMnOKdZ2DADXBjc5lJVMpTC769F+Xbo4Q5QS/SXMEjsTY3ton2whI3P6OCDGLljlxdFXRbaJzoIM8ODxjvmivyi28FllfbGanuNLLIolWEHBEQYy/cE51Vx7hSVgZB/Bd93jcMH/j8Y1pg5Z+yp3dORo5tF85+1h6ec9VUppYk4bqMDbMXUclgYx6m5s1phDR2oxJxgImsnCmSv+E65vN7cxkGnG3KkGcHRtT+DdmzszrCukDGM2cuTDB2aCRThIINdN4DilQnazAdApC4r+AzIdM7Gs1hKoE3TSxkSrUC2p8WW/ZPUpUusQTqTDb6Yt0cuoBbrnHoCDFNaGHCKJOckZNRR+1YLAX3rF5ewjjLpXJ5UO1VsWqiOYNmTqwfMxxUWJAcL+19J1mntdEvdJ5wHn8HjWmkZtVSslVfUCwB6CZMitJFJjCsCTgR5shM30GnLOkPWTkfB25htiZQ/Mb1O82zpmU512iLI6Xz2ZGN6qdYtRKiVWB4cJaB24G3wzIN+/kzx9Rp1FwzyUGVKW69pS4luizegs620BP9QZHsZ7FjryAvKTbIzwuM+Gmtfd0tAZQ3gPt/L9yDb1/5vnYp0+NB7tPco= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEp1WFhCNTZLQVdGOFRwUzZybEJ0SWNkSFlxMjRwQi8zMWZSSVg0bFVSQWJn?= =?utf-8?B?bmg3RWNXb0QwNThoMmJLcVd0bUF1RDFpOVNVV0FkL25iWTJYYWw1aDNNTjNh?= =?utf-8?B?ZCtOdC9TN2QwT3ROYjR2M2x6NlA1ZzI4eVRpQVJvbnRDVVpiYW1sNEJRYXJ5?= =?utf-8?B?UkZWMk5lUUJHOHZyb1EyOWxtRjB3MVF2c2FzbXdDTjlXM1ZiSUxKMlJhOW1T?= =?utf-8?B?SGJ4REJTMHl3Z1pWaEJLYjNhcyszcFBzNnZyV0k2K1RDV3JvcjYrTUpKbGpo?= =?utf-8?B?RmQ5ZGNxc2MvcE5sck5BWEFZRjhRQmNOOHl1a1hGVmtMdG1ESUJSZ1hTZGhs?= =?utf-8?B?T1FDYzJLakFXYUtrMkVsUU9pU0ExYktMNFdhMVVNMnBlajVuSms5OS84eTFU?= =?utf-8?B?Ni9mZUVXVW9pRnhyR3NrUEJWMWlDUWM4SFlHMDAxb1pYWEJDTzlJdXpMYkg3?= =?utf-8?B?b2xHVCtXZWVMKzlmN1p2M0kzaGQ2QUZmYVM3VWNhVHh5aG5rSDIrQUh5T3Yw?= =?utf-8?B?d1FZM3BtaEZYMFVpQVVSTUdHZDFlUm9LNG9iaEFVekxNYTQybzUxT09kVnJm?= =?utf-8?B?QnVENGdtek9sTGhHWitFYU51NW9Xc01VcWV2dmRZM1praXZUOGhCRm5pR2w4?= =?utf-8?B?VnpqenNkdCtUYkQ3QzlJdFk5ZGxjQkpQLzh1M1I1WFU3cHZRYy96US8rajBE?= =?utf-8?B?VlBFcWYybXVkd1hnSDd4ZTNlb2VMM0JCN1IyYlNDUHBpSXhmenB1NUtjZ3Vr?= =?utf-8?B?MCtXU25nb1d3RWRRRXpTa01sWERmR3dPWE1xaW5WV3o1YUEzb0xuaG9UVkVi?= =?utf-8?B?eG1rZ0FYZklPQlgzb1R4RitGN3VDZWdkdmJtWDBqaVJBeWFRVGgxeFlWU3hY?= =?utf-8?B?U1lrSnVHUi9SZGdpWVNKWGphaG9WOUh4SkxEZEN3cGtTK0FrQ0x1a3Q2UWNE?= =?utf-8?B?SldWZmQ3NmpramdiaWFIbGpUMWhCQ0dzTWZoa2VTeVRGRXNHeWNKa3BSSjBk?= =?utf-8?B?SjRrN2xoRGJOQWV3YjY5NjQ2Yll3c0JOQU9VdEM4SVpIcjBoY3pzMnJhd3la?= =?utf-8?B?L0pKQUJUUm9BdmN5ZUhKYUZNYkFkL3RkdkRSRVNMMENCbS9TeURjRThFZ3Bp?= =?utf-8?B?SHpIMHo0VDR6NHNwdEVUSVNUcmdxVWlKK085Sis3Y0Q0dTl5QnNNTUNRdmJm?= =?utf-8?B?RDdLZzlvc0lWYzRPU0hCRGpUUVY2eGk1YzUzYVV4NXZWcFFsRVdlYmEvbmpo?= =?utf-8?B?LzN5UlJtR2d3T1JIbml5OFp1MUovb0EwTG5yNDhoREJTcnhaNGdLWmtPdzR2?= =?utf-8?B?RVc3b3BjaUtFR1p1d2gzWVV0d21HSG9adWVjdmtlTVBlY1NZb2swbEFITG94?= =?utf-8?B?SzR0UU4yMlBGODRRU2FlMWo5YnQrNE1VdzRMR0lJRVVTdXpScEhNemxuY2FZ?= =?utf-8?B?Q2hwcmdiVmpSbUZHOC8rYTRIcGFNcDJjYzd3UTZzcW03SlB5STkvMXB6TFND?= =?utf-8?B?c3FoWHhPMDlKc2c2c2N4ZWp4U1BwS09Ub0s3UHc2QllZNG80L3hDeitxVDdZ?= =?utf-8?B?bmdza1h3MmZ6amNQM2dBWTJ5NmZtUVdYcEQyZWMyZXdhaXRNVVdpbUQ4NEFS?= =?utf-8?B?blpUYmZWUWhrQlFLaHlyTE5hb2VBWDdVcUplckJPSGhPcEZtYjJqWVpjSHQx?= =?utf-8?B?WkVoUDZiWExNcmNkbDlaK2Q0SGFvaUdqSm5NNmJkZjQydnY4b0l0RkNUOFdS?= =?utf-8?B?SXVvb251QkpvYk9GbVk2WHFqa3Q2d1VTQlNpR2VKblR4TVJ0L2kzSXFubmdP?= =?utf-8?B?NldOdnpyaWdwUDUycGxPWVMvbEdQMUplUmh0NXBrVGpVWTVybzE1T3A0N2x3?= =?utf-8?B?bnJJODFtcGl2K3lYNXRzRVNBK2UxazZwZGZxNTY0c1ZVY2QzTFpRejkvWTlz?= =?utf-8?B?NEoySktRTko2WnpscnRDNDR2QVJyQW9JcEVmdkJ0eGlCUHNleUUzcFkvR296?= =?utf-8?B?cDZTdW10b1p3PT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c7184ad-243d-40c3-ce2d-08da4be6f48e X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2022 20:14:14.7501 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0102MB2591 Subject: Re: [FFmpeg-devel] [PATCH 00/41] Stop including superseded functions for x64 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > x64 requires MMX, MMXEXT, SSE and SSE2; yet there is no shortage > of code like the following: > > if (EXTERNAL_MMX(cpu_flags)) { > c->ssd_int8_vs_int16 = ff_ssd_int8_vs_int16_mmx; > } > if (EXTERNAL_SSE2(cpu_flags)) { > c->ssd_int8_vs_int16 = ff_ssd_int8_vs_int16_sse2; > } > > Given that SSE2 is always present on x64, the only way > for the mmx version to be chosen in the above example > is if SSE2 has been disabled either at compile-time > or at runtime, i.e. it is never used unless one shoots > oneself in the foot. > This patchset therefore disables such functions for x64 > by #if'ing them away; x86 has not been affected. This > saves about 140KB. > > (Another way to handle this would be to remove every function > that would be overridden if one had a processor capable of > MMX, MMXEXT, SSE and SSE2. x86 processors not fulfilling > this requirement (which are truely ancient nowadays) > would still work, but would be slower, i.e. they would be treated > as second-class citizens. This would have the advantage of > avoiding #ifs and would lighten x86 binaries of code that is > not used at all by the overwhelming majority of users. > I'll update this patchset if it is preferred to do it that way.) > I have now implemented this other way mentioned above (i.e. removing stuff that is overridden if SSE2 is available altogether also for x86-32); the result can be seen here: https://github.com/mkver/FFmpeg/commits/mmx2 I prefer this to the old version because of the reduced complexity which dwarfs the potential to slow down some ancient systems a bit (if these ancient systems use an up-to-date FFmpeg which is quite unlikely). Furthermore, some of the MMX scale functions that are removed are buggy/not bixexact. See https://github.com/mkver/FFmpeg/commit/c5513ad962100040601b5eba0042692a740ac50a (or shall I post these patches?) Is anyone against this removal? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".