Re: [FFmpeg-devel] [PATCH 3/4] configure: Add msmpeg4(dec|enc) subsystems

[Andreas Rheinhardt <andreas.rheinhardt@outlook.com>]

Martin Storsjö:
> On Sun, 31 Jul 2022, Andreas Rheinhardt wrote:
> 
>> The msmpeg4 decoders/encoders share a common set of prerequisites,
>> ergo it makes sense to use common subsystems for them. This also
>> allows to remove the CONFIG_MSMPEG4_DECODER/ENCODER ad-hoc defines
>> (which violated the CONFIG_ namespace).
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>> ---
>> configure                  | 24 ++++++++++++++----------
>> libavcodec/Makefile        | 16 ++++------------
>> libavcodec/h263dec.c       |  4 ++--
>> libavcodec/mpegvideo_enc.c |  8 ++++----
>> libavcodec/msmpeg4dec.h    |  8 --------
>> libavcodec/msmpeg4enc.h    |  6 ------
>> libavformat/protocols.c    |  1 +
>> 7 files changed, 25 insertions(+), 42 deletions(-)
> 
>> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
>> index a6311411d3..33b913c4fc 100644
>> --- a/libavcodec/Makefile
>> +++ b/libavcodec/Makefile
>> @@ -141,6 +141,8 @@ OBJS-$(CONFIG_MPEGVIDEODEC)            +=
>> mpegvideo_dec.o mpegutils.o
>> OBJS-$(CONFIG_MPEGVIDEOENC)            += mpegvideo_enc.o mpeg12data.o  \
>>                                           motion_est.o ratecontrol.o    \
>>                                           mpegvideoencdsp.o
>> +OBJS-$(CONFIG_MSMPEG4DEC)              += msmpeg4dec.o msmpeg4.o
>> msmpeg4data.o
>> +OBJS-$(CONFIG_MSMPEG4DEC)              += msmpeg4enc.o msmpeg4.o
>> msmpeg4data.o
> 
> Typo on the second line, should be CONFIG_MSMPEG4ENC?
> 
> // Martin
> 

Thanks for spotting this. Fixed it locally.
(Using static builds can hide compilation issues (namely if one adds an
unnecessary OBJS if said object's dependencies are not met: in this case
the unnecessary object file will just be ignored) and therefore I tested
this with a shared build by compiling libavcodec.so. Which worked,
because libavcodec.so just treated the unknown encoder as external. I
should have (and now have) compiled the whole of ffmpeg. Sorry.)

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".