From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C94DE43A3B for ; Wed, 6 Jul 2022 13:08:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B5A2168BA61; Wed, 6 Jul 2022 16:08:16 +0300 (EEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-oln040092065019.outbound.protection.outlook.com [40.92.65.19]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D829168B3FD for ; Wed, 6 Jul 2022 16:08:08 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zib5V/oXTyrkyvFFnutop8kC5/+EadRcIeJb93b7p5bVpHiIhHsqv1xBjmN6eRNF80UVRqE90fvM/pBeJjx6EfsocSE5DOa+kAIFYsnt6R0oejDUi17QiLZeVfTYghgQ3gqXzjVHIMtgX72cJIFxaJk0vFNN4mRLhq8Z/vkmFLG2WNu6yec6GuzF3HDbIyFD+5l9JLOkay9Zi8U+Zve7Z8uYjhsG/4x18gw5bI6FA34cUuDDTye9XaL2EYDEEC6lj+YyJP7rMIpDimuxS41siYMwRB4gz0VOhS3nm8rmsqBQicSlrTadhO0uZZcTom8Ne/Iji2QoZukLJWTMiORYYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bo6Kd1+mlmXJF7QY1K37eEjqEsYqKec3GA9ymwBvXSc=; b=gPDun+tkeQZ2Aj66VyoGNKzeBAXFwaGhtbQhroDIt1O806LESt8gsBXkB5f7OefvW/zTzHcOrC4fzQgq8YT02Cgx4EDcDzWyuHEGU26vQExlF3aK+TlDPqwGjoi63PlMjF9s4iNw3sRkLWJmkwJhPL9tvKRoHHuRhU9mRv0dTp0q80SRr48u3W1HvYK7B6lDH3QG/VGYsZytjeIfDd1wuTzxvie5SWO4j6hcdLfyrt0WovdX3JZnmDafIzbsSodaUQpNIqNrX+rhakk6QETIvrJ4aAd2hlOP6Gd+1XzQwRVY9YlzQQ7Th2vVwQUQaVmyLbvMJmfTjcxq/JWnxWdZOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bo6Kd1+mlmXJF7QY1K37eEjqEsYqKec3GA9ymwBvXSc=; b=MlwNqzK4Z40cP4ByUZ3jKGXtOOobQP9N9cR2zTbY2Es7kWql3PbZgkr/C0wYQmlKK/6qM8lzctGmlYivHLaxzPCq78iWt8Bi7VJFr3LHeOLUb3UFbSXKlShgmeOpCVghjPeTDh6BSHIxUqNjuQONkV6Ca65H6jQCzNZzZaC2J6v2Zi5vbt1G0P+ze37fsriGkDDUiUzvMDPUOZO9xywz1NKthcGFCyPslNp5Y5DE4NDFXtgf6WNuEh0LZRsh4O3cVV7XpXsjVO7mg2DQ8hxwvbENyLyQFW+kQz/gmJssoJUw2LFS+fnK2ycjYpuV36CXfFGGPi3fBHdEsNZHmUuwGg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DU2PR01MB8280.eurprd01.prod.exchangelabs.com (2603:10a6:10:2d3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 13:08:07 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5395.021; Wed, 6 Jul 2022 13:08:07 +0000 Message-ID: Date: Wed, 6 Jul 2022 15:08:05 +0200 Content-Language: en-US To: FFmpeg development discussions and patches References: <165711257972.31466.12114443019970009070@lain.khirnov.net> From: Andreas Rheinhardt In-Reply-To: <165711257972.31466.12114443019970009070@lain.khirnov.net> X-TMN: [2CKV/2icKuZA/9HilVDAp+b5Xo2fbTku] X-ClientProxiedBy: AS9PR06CA0346.eurprd06.prod.outlook.com (2603:10a6:20b:466::21) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 56be6525-b3b0-4693-b97c-08da5f509168 X-MS-TrafficTypeDiagnostic: DU2PR01MB8280:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lKotKMOZjf6OBHMRn8GcSdzzIXQF+PpEHbll0yu+79TLiDV6jtYulGoJb7ufzghxlKMKbIgXwa1LckcIDjZLxy8woqzQt+vDB9/KD2eeOi0tDVeSXME34xNu/UqLDncuVLMrtz/rUsPg7ZVhIO89L8eCqHnnxHiVU89kt0iZL3RuZAArWZJtVMkV5uZH0QfV1loLfVud6manGY8r6S3w0QvTNGUTQD9Pm9/PudcCdDoUCGadJWo5ulbZnOapB3S8lsxAzzXYvaZn1U1DTWdFryQYDqgQ8Pf62QhhzSb6o9P8D+ATjQ965DZe6QMwB9X0fXNRHNBecdilYvU477ljBSsIcw2O7l0B9jZ/j8KGIXwo3RE3lqssjsHcMUrQ8KGjZrnQlTh4SLZZsr0JUFFHv12wuxgJF8jqLina4bSW6l1VHTSvOvT0CK3xWip78LxQwQdZe6ivy6kj4d2PXNYCjlsYItGAu1megTbd+o/UiDgoMTZkc+PvnadT3PQeGabrO28lVsdJ2e8kskTpuc6wBQXH85cURUfMxnZTWbxilF73bpx9poysNO4Xv8WL7rh6VkaylicMOe499qUUZJ6ZhUQNHTY0NZlWVjFNYiiPht+qT8CtIp1uDjrFySUrowGAdrfxQnw7xPrlOK0YmjFjUQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFR1dnczc0Yxcll0blg1S0pvVi9pU0xmbVV4SWFyajFwUVArWUVoU0o2YXZu?= =?utf-8?B?aW1VUmtxYk0ycEZLUUZuamNZY0sycDI0OUhTTWhBMklpS3dISStrUFQrYUpG?= =?utf-8?B?dDhZZk1OR1MrZ0VCMGs0TlNaSGZjMWp1NDAyOUxUUWVvK21QWUh5QmFkVVQw?= =?utf-8?B?cmpQTXE4dFh5L3hMYWFCT2F6bEY2VTE4YysrUnhoTE1xM0k1USt5ZkNMeW8x?= =?utf-8?B?MlJXOC8zaGdvc2xObnZtWXZ4MmVSV25ySWM3VUIzckJoZkZqNVI4ZG0yNzVR?= =?utf-8?B?djFjdDhtZm9CTDhSMlFUV2JRcHdoWHdYUnA0VDFpZXp1N2NscVU4aXQzZzBQ?= =?utf-8?B?amxjem5pZVMrR2NSRjNFUzV0S2ZkcVo1Nm1JRzRtM05WUER0NE9kOFk2ZHlX?= =?utf-8?B?UnJRUi9EU0ZrUC92U29DKytHaVQ1cG8vWnB3MWNwOXFxR3cvS1dUYVhmSUs1?= =?utf-8?B?emNncXZjbnAxclNld2s2WkliMS9acE1UelliTEhqM0xTOC9obzFhN1JTVFdN?= =?utf-8?B?VXlVZ05JSDdjVmM3M211aVoyYWt4cVVCWkJaYmNSYndEWk9kZ3gwVzBQRTFh?= =?utf-8?B?MDcyK0R0cWJ3K0QwdklScUw2UXZldVFjL2FQRXRCbU9oUkJWMHBxL0htazJk?= =?utf-8?B?UEtsV0FsMGlkczJZbUNxekpnZ0ZvRTVhRVBnYXNtbnNiK3pIL2RtM1ZDSUJh?= =?utf-8?B?bWNBT0NmenBUUE1YVFU2THhpVEkweGhwV3JaKzBjZ3plWHlYMkNIRUVUc1ZC?= =?utf-8?B?WWJOWTg0RmlROHZNdGpVQ0lYUThvN1FGdllTYllaNC9JWHBKZHFJbEE1MUl3?= =?utf-8?B?U055KzN0eUk3RFdjWUhNUURWVThQYWk0RHRzejNSUzA4VFhPaml0Sk5NTHRI?= =?utf-8?B?YmdsOFdrTDk5WXV6Rk1hbGV4eGgycmpKbTM0MFRIVFYzS2xYQkMzWFIrZENh?= =?utf-8?B?RisyM3NFR3pLUUJmN3VKMDV5aWVEODYzM09mcEJYODZ5R1p3OHlGcWVlSEF0?= =?utf-8?B?SjVrL3pnc3JBL0czSU42SGxxT0ppc2h1czBWdnZvUHBLaSs2V3dnbDlvbWhJ?= =?utf-8?B?djEyV3FVd2s1bExXSUtOcEhFaTNQaWwzRlM3SW9UeW1RNVpuUWdYR1lLM21j?= =?utf-8?B?QnllVzg5RENpOUhzRldtS1oycXRPSnlrbTBPRTFZNkdKNnhtL3hiaW1kMHpE?= =?utf-8?B?Q0xJdUFZeGVPVjJOdkZJOU9qeU93V3lLTHhtYWZFcXhtSlgwK29kK2I5Q2Rl?= =?utf-8?B?NnRuMllTVHU3VnUwOEYvWk1Va1BlQmd3aEt6b3NsaUFCODBFSHF2NGZQandP?= =?utf-8?B?QjhDbWxrNWJOMDgvS2tLYm9SV0pwbDdzd1NDVjE2WHlQUmIvd1Jjekp5enNQ?= =?utf-8?B?d0htZEE1M3lTbHhQZEdwaTdoRUJBZVQvTmYyS2xyV3FJSDhpNW5EUFd6STlO?= =?utf-8?B?NE9BY0ZGTk56OUFmd29tVzNLd0hlRG1oSFlIV3JoTjg4UGN5TUJmU2pVd25z?= =?utf-8?B?cW9hVi9kTW9kNVc3UUs3VTVMT2lkOWxMbUowOERUSGJ6cFpuT3o0R1dFUGVD?= =?utf-8?B?N0toaHhwSG9DNEUvbGppc0FlNzJuNWVNYmtuUU84K3BseHZsMGpnNHdRTUo2?= =?utf-8?B?T0tUT0dJVUl0L1hCOXRhRENRSUNSSWo2Y21vcjJXdk9IR3NqMWNmNnZWN1ps?= =?utf-8?B?YkN3cnA1bGxGZEE4MnFPS0VRb3dkT1hIOWo2WlM3c2NUbzNwY01iTGk0SjZX?= =?utf-8?Q?Q4QZj7niOgcAvTgGfg=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56be6525-b3b0-4693-b97c-08da5f509168 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 13:08:07.1921 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR01MB8280 Subject: Re: [FFmpeg-devel] [PATCH 1/8] avutil/mem: Handle fast allocations near UINT_MAX properly X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Anton Khirnov: > Quoting Andreas Rheinhardt (2022-07-05 22:09:37) >> av_fast_realloc and av_fast_mallocz? store the size of >> the objects they allocate in an unsigned. Yet they overallocate >> and currently they can allocate more than UINT_MAX bytes >> in case a user has requested a size of about UINT_MAX * 16 / 17 >> or more if SIZE_MAX > UINT_MAX. In this case it is impossible >> to store the true size of the buffer via the unsigned*; >> future requests are likely to use the (re)allocation codepath >> even if the buffer is actually large enough because of >> the incorrect size. >> >> Fix this by ensuring that the actually allocated size >> always fits into an unsigned. (This entails erroring out >> in case the user requested more than UINT_MAX.) > > I really dislike this av_fast_* naming. > > Given that all these functions use unsigned int for something that > should really be size_t, how about we deprecate them all and replace > with something that has a sane naming convention and uses proper types? > What name do you suggest? And what's your opinion of the actual patch? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".