From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 631CC430ED for ; Mon, 20 Jun 2022 00:54:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6EEE568B58F; Mon, 20 Jun 2022 03:54:33 +0300 (EEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073010.outbound.protection.outlook.com [40.92.73.10]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2A1CB68A7FD for ; Mon, 20 Jun 2022 03:54:27 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtFFdoJCA0hIqBAugyXNAtCWISOkNzWZXOnWhSAbcHThQ91sublwQRYuWKF0IxQPeYIbA2aHZqVKgt6+FxKAbPyggV8xgkppYse/sy7JWCAshxC5rz3in3EN4aaesCpIRaUX7wqoB17rRr3NC/RoPYh+D+XbGcRWJt5nphK10a5aKBs1NI15Vrd8KKWqQixpApKeJPjPuKzR9m1ebpUX//1pjyHOO+BQrsTorEPLd9I29p5IS95jQtNLuTBwJOa/N5EnI/f5fm5yNQKmh3dINFaDKrWiFx/s37ZE2Nn62/tOVLcifgnZ1voZ8J0mgtdouzuoQZxjQWLaJijf3LrW6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u8luTCKAheqZ0Mvm6IrqwvguChCNsuhna9+Ad7e0O/I=; b=FjUJ+IkeRAWUl7AUFCfQjiTIQ8xVWr16w34jldD9V7T0Ygp862q5IHtYYWxoNd6UGIs6ajVxST4gLwWgfy7lKUPIkf9AGVvsCtgx42JEXdN9HQuTCRA9ruMT4YQAxEqcblZ7bkMyEYSydqwqczHJUWz4O0X+uwp2whsYEXz1Z4xMsbSh/jrfEvx+gUJSDlwA4UKiyP9kF7cpZUJmWrAkZ0ZN5AZcOX+8DGiv/Tdm0NJjkwCEucQNetV35iCR4D1A4dyHjyAR46zLn0xPXQLgAM4G3hTuqitKGD9JAvSQPRmnAv2NExVPpuWJWJlR0jxuGUKu7aTwA0MpdMH0fA4Few== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u8luTCKAheqZ0Mvm6IrqwvguChCNsuhna9+Ad7e0O/I=; b=rDnbr3EMyPADXTkRf8ol8lFMOl/TsMSckohmeHM8DfcoDttrG+v7w9Qs1cfrJhUPBR7vfE67LKKUWDOG9EqsVvyf0rBJOYAyzB4SKDf93Ylo/pCttkirxhOBeDcBiiPVj6YLpcxLtCa/JcySbckFBG7vmhr4WOBWCqk5cVnvnNBDWi/gefPv5kkW08sispgAqsoIY/hZbr/Wx6HeiVkU01Zy4/ma+4dG36GbjRB16DYU3vLemcz4Ne3FH7uhiams3BHDwtODLRQa/djMh0n9IpIrQopmlCxjRWrqIbVzlzSqbkiz4gTD5hwhcO0SOQnEhfqSv7Ql+TbDE08lk9oszg== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by PR3PR01MB6234.eurprd01.prod.exchangelabs.com (2603:10a6:102:38::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.13; Mon, 20 Jun 2022 00:54:25 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.021; Mon, 20 Jun 2022 00:54:25 +0000 Message-ID: Date: Mon, 20 Jun 2022 02:54:23 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [hwSQdjksVRAc9RQpvle+I6L+AE8b8S0U] X-ClientProxiedBy: ZR0P278CA0043.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1d::12) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <1d1290a0-cf66-7dcc-bab0-d7db0d451de3@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 99f19b7c-410b-4e55-613e-08da52576bbb X-MS-TrafficTypeDiagnostic: PR3PR01MB6234:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pZlUmICIAe0tMk6VSQvR02KUZU8T6ldvI5QxGABdiIGq7sKJNpN2aKChaBciH5Ez7e1mLK+Dfdlte2UzjX7gPm5M3GlDFTlRqyxYmsRAUwytHiRjGNZnZaUoUrEouYwXn894uh9b/ywvGKpKVT+2mS4XQz+JWYz1lkmCYRLseh9R2Du3b4Fnulu3lPKnpk9bGae1Q0Bhrpf0O5tqhcJJlRxFQ0s0OyPXm6zUL3VxAq/d2yelWSNYH3M2mnRfiEQJvqZ7cOKPKujRSikuphVVYz5DvDbvD5wpnj3X1sOOFdv0FxZL2zvqaZlsY0X++gHFQMZKV0TeLohI8h3R4q856Re5G7MMdmKxKX6FTeLvP60aHCKp0nc65ut+K2m0/EpkcDwRReBMeTMmpQkVlI3GFw+ZC/RijipAIw3AKw5H3NbjAVdXhaWlInQJsONJZq/8f4ycqp5q7lJh3UD727qDXaVqIhKI7eCaSGYPKYfGn3+VtK04snjIb3Wth8h5ZQQiazC3wRxTRaOoGqomba6Di/chymD7Q6vMu2q9Ox+gMIXUt3Tbx1+6u+e/vn0tn5zM8wDSWA3GWYBZStmXJ29MDBpIxCds5doXFGe0Maoc9SNdYmQth5TAEaJ3A01JA+Kn2mhkyyLsOFyxwJzMwyrlh+A0nXTKIfyWLOTFVSVk2fw= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2ZhTVQxQTltUVd5UXZ5UTJUU1kwYVBvRzlHNCt2RkE3ZUErNWRTRlV1TXRR?= =?utf-8?B?R3JZWWpVTDYxb1k2akpOZDdIazFTMkZsWnZVTGxoL3hiOUZ1SXE0ME9zL3dt?= =?utf-8?B?VjY3NTB2UVRaaG1hWkdsbmdKNXdrMUNpZlIrK2REMUxVYVNhVUdJTWJYaGc5?= =?utf-8?B?OXd1KzdYZFRrVDhNQU9ST0t1cUplaHdsYlpYVXhyWFc5SCtTcmxjc0tEbktj?= =?utf-8?B?dVZKZGtmbWd3a2pub3BwMVdvdm5rL0psS0dYL001ZFhIMm9RZkxLdEFXcnFq?= =?utf-8?B?dWR0Qm5VaW9EU1BFdXozc1c2QWFzc1FUd2d4bFJYTE5WZE1wb1NwU0FLUzZu?= =?utf-8?B?RGdLRVFPVzV4V0JhWHZzL1dkMTQ0MDRTdXJxeXI3K1MraFNFZGFnbm5UbHNr?= =?utf-8?B?L1V0N1A3TlpvOTU3bmRIRVZVNm0vam9HU1dFcmtvM1ZFYmxyWVJJMmNTSjJj?= =?utf-8?B?cklkcmk2NThxdmN6b2tJdlpPcGxpTnY1OXNKSEJWQTRwWGZJYVVMaGcranI4?= =?utf-8?B?S3FDQ0V0d0Y1Y0V2SllKZzlhSkx3N2NzK0FRYzYxN0Z0MEIyYndrMlphRkNv?= =?utf-8?B?dmFranN5RksxcEpUS1U1eHBZY1J6aW1yUlMxUHI4MmQvYmFaK2x0MkYrckZm?= =?utf-8?B?K0gwa3ZOMEVKY3ExelpYNlVLekJRWFdmWkhuZU91empJaW5jaXJ2OWM2d29I?= =?utf-8?B?b0lxWUV3cFRBZzlqQUhHTVExSGJaV0ZESFBUOE5KZlNOSkNCNEhuekx3dkd0?= =?utf-8?B?UkprYXAvVVBnemN1a0N3ZU5oMUpRNGE5YUdkdnlMb0VUY0VGNVBzTS9BaTVE?= =?utf-8?B?UWtkazYzUHg5aEpjaE5vRmlLR3YxQ1o2L09LdkF4VkdSWTB0a1RJTDlYNlNO?= =?utf-8?B?dzdRT05kbHdvWVpRMkVZbUdVeUlGVGQxNGM5cVl6S2lqZ01KaytpUFltUFlt?= =?utf-8?B?MHFqTFlNUGxiMUxUZE5Zcyt1a1JPRGJTNGxVR1hzL2YzdkQrYWdiTzdTTlN6?= =?utf-8?B?NnZaWFNRYUZWSUZCU1BGczQwM2RaNmhHN0RSOURmeVlRVUJYZHBPL1RJMnF0?= =?utf-8?B?cFNvWlFRZytwdHVIVlJDZXdTcFErbzJmRm1ZV1drdExVaW1nSGpHTlIxWmNv?= =?utf-8?B?OFo5anRtdndxZlVFTEhpVVdZRXhYaEExOEUyaVY3ZkpiV05yQlFITVNyeS9K?= =?utf-8?B?MDhqZWkxVjg0QlhpVTJhWmFYQzRRN2lUbEJKbUVsallYWjIrVXM2S0QvZ1Er?= =?utf-8?B?UFg4Z2NQNnZ3Y2hubHQ2ZEJ6aExKb0hCS2N4aFpIcUFIcmFlUWdWd3c3QStF?= =?utf-8?B?RmdQZFlIZUh2ZnRNM0tBYjd0VGk5ZlNSSmVKRUMxc2FhQjBjUm45d2o4NXBH?= =?utf-8?B?VnBRWmJ1OWc1cWEwaFdaUGEvRG9FSGtOVFZ5OEMwdGZMM1BxdlUySW0yUkVP?= =?utf-8?B?WEk0VXY5WUFaUEdnNmVPQndWSTFXNWhyVXQ1OG1GMk9TWGx6SGlVV3hYeDFO?= =?utf-8?B?VzI3dWtmUjhCV0xqZFRVMkdmZGdlUHh1R25ja2k0Qk9MWkFYZ2oxSjhlQlBP?= =?utf-8?B?TXlyTkl1VG9ETm9QZGJ5d21RMkYrUitSVWVlVkNqKy9HYU5wR1FmVW93ckxu?= =?utf-8?B?MXFxeTUrSUE3Z1NaTk1uUHg0d0toQnhIb3B0NzVLVHAzdDFFbWtmS1YreDMr?= =?utf-8?B?ajQyNi9rTjlDK3RLdmxqS3o5NklwcGNqZzRlT2JVMXV1cWlBRk1ucjlCMjYz?= =?utf-8?B?ZFFzZm9hVkdHSDdNV1ROL2lIRXpIRUhPN1htWGU0eWN2Wlc0ek9xd1EvaEZY?= =?utf-8?B?NGxTUUxLQ3ZpZGZuZURUOXNhSXVwcHQ2Ly9DdElMVVlRMHNiS3BXMFkzT0lp?= =?utf-8?B?ZFNHZzV3V1prVmExLzVGVjBJbWhRN0FqU2Z5MXRaUDAwY3BuSE5jSUFQTHJ4?= =?utf-8?B?WmxlTDA2UjE4SThzKzZaeVpWVzJPM1pWYWNtbnVjaklOaHlxVTI2VDdpdEx1?= =?utf-8?B?L0lIQ0FuMmxRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99f19b7c-410b-4e55-613e-08da52576bbb X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 00:54:25.2389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR01MB6234 Subject: Re: [FFmpeg-devel] [PATCH v17 1/5] libavutil: Add wchartoutf8(), wchartoansi(), utf8toansi() and getenv_utf8() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: nil-admirari@mailo.com: >> This forces allocations and frees in scenarios where this is wholly >> unnecessary. This can be avoided by adding a custom deallocator for >> strings returned via getenv_utf8: Namely a define/wrapper around av_free >> in the _WIN32 and a no-op else. > > Done: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-June/297804.html > Thanks for this. > Note, however, that the introduction of freeenv_utf8() > doubles allocations and deallocations in vf_frei0r.c on Windows: > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-June/297802.html > > These additional memory operations can be avoided only with a whole bunch > of new #ifdef _WIN32 and #if HAVE_GETENV, which haven't been done. > Or any reuses the #ifs from getenv_utf8.h. https://github.com/mkver/FFmpeg/commits/getenv contains a version that does this. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".