Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag.
Date: Sun, 19 Jun 2022 11:24:43 +0200
Message-ID: <DB6PR0101MB221428441CAF69E4E83BFF918FB19@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <DB6PR0101MB2214A19821CA08F85C864E518FB19@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>

Andreas Rheinhardt:
> Gyan Doshi:
>> Default avctx->frame_size is 0 which led to init failure for
>> audio MediaFoundation encoders since 827d6fe73d.
>>
>> The MF audio encoders accept variable frame size input buffers.
>>
>> Fixes #9802
>> ---
>>  libavcodec/mfenc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
>> index 13ed7b3e11..8618e54ea3 100644
>> --- a/libavcodec/mfenc.c
>> +++ b/libavcodec/mfenc.c
>> @@ -1239,7 +1239,7 @@ static int mf_init(AVCodecContext *avctx)
>>          FF_CODEC_RECEIVE_PACKET_CB(mf_receive_packet),                         \
>>          EXTRA                                                                  \
>>          .p.capabilities = AV_CODEC_CAP_DELAY | AV_CODEC_CAP_HYBRID |           \
>> -                          AV_CODEC_CAP_DR1,                                    \
>> +                          AV_CODEC_CAP_DR1 | AV_CODEC_CAP_VARIABLE_FRAME_SIZE, \
>>          .caps_internal  = FF_CODEC_CAP_INIT_THREADSAFE |                       \
>>                            FF_CODEC_CAP_INIT_CLEANUP,                           \
>>      };
> 
> This will add this capability to both audio and video encoders, although
> it makes no sense for the latter.
> 

This should actually been covered by the libavcodec-avcodec FATE test.
How did you test your patch?

- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-06-19  9:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17  5:44 [FFmpeg-devel] [PATCH] avcodec/mfenc: set frame size for audio encoders Gyan Doshi
2022-06-18  4:01 ` Gyan Doshi
2022-06-18  6:49 ` Andreas Rheinhardt
2022-06-18  8:28   ` Gyan Doshi
2022-06-18 15:05     ` Anton Khirnov
2022-06-19  9:02       ` [FFmpeg-devel] [PATCH v2] avcodec/mfenc: set variable frame size flag Gyan Doshi
2022-06-19  9:18         ` Andreas Rheinhardt
2022-06-19  9:24           ` Andreas Rheinhardt [this message]
2022-06-19 10:06             ` Gyan Doshi
2022-06-19 10:10               ` Gyan Doshi
2022-06-19 10:12                 ` Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB6PR0101MB221428441CAF69E4E83BFF918FB19@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com \
    --to=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git