From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A278F40590 for ; Sat, 25 Jun 2022 11:42:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 72AF268B7AF; Sat, 25 Jun 2022 14:42:23 +0300 (EEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-oln040092074108.outbound.protection.outlook.com [40.92.74.108]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B57B868B743 for ; Sat, 25 Jun 2022 14:42:16 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gSQMjraGRB0AFUtZo0rF1n86VNyakYdvf/GuxDJK/YIa0jGrOj5RmKWv1WKfJ0for5abXwXUytioPCpS1+cPWPgXi+/Ki3QufSSxiD0zHhUK9wLNJkIcByUoozI6wbazcOBar4qo84TTAnNeQFHI+3Lf801xRSnu60w9aCYJw8IlRfsHmQPcpTkIQvEVshGMyaynrUVUo1CQWGQ0UEG7FVRE3jJYvvH1g/ZFWV2O74w07OwSrXo/Fk8WUIEbIhAQzeTBfGU9YwV+A1Ngf/xGqb5Qt6Xyi1mFJv202l9UgvswW9rYQieZ7R1iobiQdCqRBjn6FLPi7XgL9dkzIkxwlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rx+tMIh50c+zTGYRAjboC60t6/i9P3LwRpYWEgXslgs=; b=iIlr118FZyQZPZWa6XikgSK1q7AK8M4cHOaQFBbwhHvzrlwl5vautUi7k4RWxyOg5vyEawcVzuNq8rt2KiR6i79ZXR+oI8jkxd0R7eSSXJltPLgf+hWtIlAsJ+X7yAXxbRpVuWIeJiwTcnzmg1xeY+kAtNR26v1qgxKsROgEQAHBC1rXH7L+910DtJsOp3J79xQf0a6158MpNrQJmapTdWGJdE/y/ySYPsyrKejU3qoGPY+D5F3FLm53i/dLqbyDWadge5hP2J+boOf2QvLRZAr5nJ7tvGy5XujaEyLNKuU445rrisCuui6ImgVOhaExghfWv1HW03TagGrt1GqUHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rx+tMIh50c+zTGYRAjboC60t6/i9P3LwRpYWEgXslgs=; b=XvqdIQgp5UHR/c2AqWX+lOeR+ngCnTWaWj6FfXtsfbDzBf1xnEl6LaVii7/8tyk87Zy37MD1pY15aeBOHEtiQDa0OIsO50QCgu7V7wSs3dC73cnxyEHEjYfstUbtyWUVJmw6KLM+XLi+NJjQ5YIShRPF6D6I9u8me7EhgoUVrSm93Sn6awlDR1ZQvmXOacO9xquR/cPC5mYB5abz6RTpfbcgVw04YdlwwIZAI9HhmcIaWmq/Ea4EfyduK3JtMsqBIsNmZxZybfKXf96B3Swxzn3ckO2OfaRVDFtZ4I0VXdJJ9xYNXlQ9LJdkF93Ss6up95gJ0bP7qaTTkbDs7K/dvw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AM6PR0102MB3047.eurprd01.prod.exchangelabs.com (2603:10a6:209:10::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.20; Sat, 25 Jun 2022 11:42:14 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5353.024; Sat, 25 Jun 2022 11:42:14 +0000 Message-ID: Date: Sat, 25 Jun 2022 13:42:12 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <2645a1a8426d406de339813d97a69aed1d205967.1656151077.git.ffmpegagent@gmail.com> <20220625113452.GR396728@pb2> From: Andreas Rheinhardt In-Reply-To: <20220625113452.GR396728@pb2> X-TMN: [h4PU5Cgsa9z/njc+5A3Y0BWH1VOK57F6] X-ClientProxiedBy: ZR0P278CA0024.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::11) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <69febc64-be5a-9838-4f8b-e667cad7a312@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28f1b70c-97c0-42a7-4f7a-08da569fbfb2 X-MS-TrafficTypeDiagnostic: AM6PR0102MB3047:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: og08pIu4zb3BMBAMh7PGDIP34ZSd6NtHpAL9HVfiiyN/ygOYxDtbQ35JHnHbV24mhmxnGAZCG2vieYW74EO/smQYcqYlfRvQ0hRHInCjvz9aA8Q+efaMww8zssPjc+CZ0HiS2C7d7+2scVU+B+9zh3U4mMPoJQsqQ3jUKSKVwdpDDc58bzPM9KrVoKDwzznY8NvGI7mDl1V8FZTEmcxCsXlZkK4WFWBVxJA9kNiGHcbXd2Kh0HQoefllp6wJvprHSSWl5MbzCuPZjtnZUBCBHksA8wZL5f7UfVae9d8jYmHzLOil+k/FQ/kiMahN7/nyMckHp+PK/8qOQgiW1NXOd0GamVbepDzT8qAecec7hk9xdNpeK7TrTOy9SVubDq05vJkbhvm2s8rJq7hfGFTI/o6ejd7d5gHmYBpNMinU3mNlNuutHxpFFhn6UQgBn9J0HO6bOcjtOR+vZhPVDAmTHXE37+T9Z1AV6pLLnlqUzfJJde3G2fIaPQUuXFfV0rbRpkNUCw6LzGzJyuLFDgOoiFVWyx9TQx/qg1uRVIVx5hklJzN0x2HNHnEqYTC1qBTqog2J73fcwbwGZOlCtjZggv+lnShFNl5vVKvAFlsQHV8Q8MXJU744yaJp86RDkg2OJb/BFgJs2kbpMclwvrNjkg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmQzNEhjbC9seDdDb1ZzUDlvSTJtVHBrVFlPYXpOSHFJTTFtZWJ5WE14VVln?= =?utf-8?B?ZXJ0S1JnbStuL0NFaUQwVGRLR1FiVm5ZK1BzK1BlcFZOZ0ZaMUwrMDRjWWZT?= =?utf-8?B?cDBlUXBKKzVqTEVLand0eXdVUjB4Zk9VQUxMems4ZG4xTkMrNDdzTjIzNDlN?= =?utf-8?B?Mk1LZnp1RDRrMUJqL3pkK0NwV2gyVVN3UW0rNUdXa29XOTlVbzNBeU9mOE5x?= =?utf-8?B?RTd6bDhLRHZGNEwvYlU4akJ3c3I2Tlp3ZEVySk8zSkpwR2Ztb0w3bk1CSnhE?= =?utf-8?B?Z016OEZRZ1YvYzJJa0t5SDExcm9BK1R0Z3ZpSlQreVR0am94eDlsak5XSzQw?= =?utf-8?B?M3ZCSDRkbGt5VlNVSHd0QTFpY3AreTYxaktsbEJjOVprTXNHSSszbmZFZzU0?= =?utf-8?B?QXBGYkFpLzVqa1ZWTVl1dkcyZ2VldjFOR0JGU255aG0wNlJXNnlSbTFBd2Np?= =?utf-8?B?R2F2YXM2Rk9JSGFFZ2V4eUVvaytyN21GOVMxZ3JkczFNMFVwVFBSOXkzdVNE?= =?utf-8?B?dGxueXAwY1hncmlybXhBOWlsSlFLN0V3anVQWDJmSk1ZNUtBeFY1UVZJTkxN?= =?utf-8?B?bkFsVVBuYm5pUFl5U1E3VXFUVHVIK2k2eWh2K2wxL1JrU2NIVU9lT1YxelRj?= =?utf-8?B?TjNNQktUQ3Y0NnJ6Wk4xZlFDR1VPaUdoemdaNXRsSjEyMG45ZFdzWjJDSGZC?= =?utf-8?B?RE5lYlBCSlo3N2xMVzlLMGpZcC9oYWhJZGpNclBucFJ1Ulgrc2gvRTRUYWg1?= =?utf-8?B?OG9xUmplckpaWSswRlN4Rnp4WWNRdHF6QXlqZkJlYmphcUttRXFrZ2hhcTBX?= =?utf-8?B?V256TThNTlUySE5XblRibWp6dUpFcTAwemh4RlVXTnJKMk1lNUF3Q2x4R2sr?= =?utf-8?B?V3d5cWdTVFVYVHU1R3RPMEVMdldWWGNuYUNyM1duaVNaWFFNV2EzK1BkUGhK?= =?utf-8?B?YWFWZkJTVXpYTmc5SkJ1V1V5dTlnekgwRWNTSTFhRm1hR0o3cmtML0xEZ2NQ?= =?utf-8?B?UUh3NU9uUWFOYXo4MXZhRTRRR1BKQ1ZWd1FXblJIKzFrRDBpK0I4SHoyajNv?= =?utf-8?B?RldrMGNHdzNha2NzK0VUTkNpTmEwcWV3QXlFMWxmNlgrZEhya1N0aHErZUVq?= =?utf-8?B?RENEMDZ5UmJ6aFo1NWc1UThaYURYcTcxVFpIM3VIZUJHeHRkTmVqRm82T1lI?= =?utf-8?B?aUN0K0dJcEtycjdVRjJvb3NuL2huMlBEV05sa3QzdUtBaHFQZ1lCYmx4bW0x?= =?utf-8?B?SnhTcHpvNWlSUjVsS2xLTXU2Y2xua244UHFwbXRLdjZSVGVOemV5KytXQUsw?= =?utf-8?B?QmRUYnFwVVA1MW8vc2pQdTcyeEtob3pid3JSYUFNbWZCczAyRzRtSjRGazVk?= =?utf-8?B?Q0doM0pCcnU0bkRZcVdURjgzaXVkeTNZdXRrelVCL0JqTVZneXhIQUNOaEtG?= =?utf-8?B?U1V6OHd2UE1IdkJUekJEMDNRN2hIemJMd0pOcG9La05mNWZHSnllR0c3ZERa?= =?utf-8?B?c2cyOGtTdDFrSzhLV1Bvb1ppWEJoTW9IbGp2N2FLUElXY0R2bkc1Z3Z0Z3NS?= =?utf-8?B?Vnd1VFlpNlBMMlFPNi8rL3I1VXlUNWh2cDBYb2Y4S1V4RFRsVFNyaGVFTnZw?= =?utf-8?B?K0lFR0I5YytiS29YTzFiOTBBSlpvalpWaXBuK2NMUzZaU0Rsd2xsZ1lZQzNx?= =?utf-8?B?Q1BLU21maG4vZVY2eTVieDBRYlg4Vmt0TWFIeTd3Q1BnSFAyRngvR1NjTncw?= =?utf-8?Q?6Zmx/B0eEbeUPO+jZA=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28f1b70c-97c0-42a7-4f7a-08da569fbfb2 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2022 11:42:14.4925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0102MB3047 Subject: Re: [FFmpeg-devel] [PATCH v5 24/25] fftools/ffmpeg: Introduce subtitle filtering and new frame-based subtitle encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Sat, Jun 25, 2022 at 09:57:56AM +0000, softworkz wrote: >> From: softworkz >> >> This commit actually enables subtitle filtering in ffmpeg by >> sending and receiving subtitle frames to and from a filtergraph. >> >> The heartbeat functionality from the previous sub2video implementation >> is removed and now provided by the 'subfeed' filter. >> The other part of sub2video functionality is retained by >> auto-insertion of the new graphicsub2video filter. >> >> Justification for changed test refs: >> >> - sub2video >> The previous results were incorrect. The command line for this test >> specifies -r 5 (5 frames per second), which is now fulfilled by the >> additional frames in the reference output. >> Example: The first subtitle time is 499000, the second is 15355000, >> which means 0.5s and 15.35s with a difference of 14.85s. >> 15s * 5fps = 75 frames and that's now the exact number of video >> frames between these two subtitle events. >> >> - sub2video_basic >> The previous results had some incorrect output because multiple >> frames had the same dts >> The non-empty content frames are visually identical, the different >> CRC is due to the different blending algorithm that is being used. >> >> - sub2video_time_limited >> Subtitle frames are emitted to the filter graphs at a 5 fps rate >> by default. The time limit for this test is 15s * 5fps = 75 frames >> which matches the count in the new ref. >> >> - sub-dvb >> Running ffprobe -show_frames on the source file shows that there >> are 7 subtitle frames with 0 rects in the source at the start >> and 2 at the end. This translates to the 14 and 4 additional >> entries in the new test results. >> >> - filter-overlay-dvdsub-2397 >> Overlay results have slightly different CRCs due to different >> blending implementation >> >> - sub-scc >> The first entry is no longer in the output because it is before >> the actual start time and the strim filter removes such entries >> now (like for video and audio) >> >> Signed-off-by: softworkz >> --- >> fftools/ffmpeg.c | 613 +++++----- >> fftools/ffmpeg.h | 17 +- >> fftools/ffmpeg_filter.c | 270 +++-- >> fftools/ffmpeg_hw.c | 2 +- >> fftools/ffmpeg_opt.c | 28 +- >> tests/ref/fate/filter-overlay-dvdsub-2397 | 182 +-- >> tests/ref/fate/sub-dvb | 162 +-- >> tests/ref/fate/sub-scc | 1 - >> tests/ref/fate/sub2video | 1091 +++++++++++++++++- >> tests/ref/fate/sub2video_basic | 1238 +++++++++++++++++++-- >> tests/ref/fate/sub2video_time_limited | 78 +- >> 11 files changed, 3010 insertions(+), 672 deletions(-) > > seems to break fate > > Input #0, ass, from 'fate-suite//sub/1ededcbd7b.ass': > Duration: N/A, bitrate: N/A > Stream #0:0: Subtitle: ass > Codec AVOption threads (set the number of threads) specified for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. > Codec AVOption thread_type (select multithreading type) specified for input file #0 (fate-suite//sub/1ededcbd7b.ass) has not been used for any stream. The most likely reason is either wrong type (e.g. a video option with no video streams) or that it is a private option of some decoder which was not actually used for any stream. > Stream mapping: > Stream #0:0 -> #0:0 (ass (ssa) -> ass (ssa)) > cur_dts is invalid st:0 (0) [init:0 i_done:0 finish:0] (this is harmless if it occurs once at the start per stream) > subtitle input filter: decoding size 1280x720 > [out_0_0 @ 0x557cab64bbc0] Subtitle format change from 1 to 3 > Assertion c > 0 failed at libavutil/mathematics.c:61 That's an av_assert2-assert. softworkz probably didn't test these. > Aborted (core dumped) > tests/Makefile:304: recipe for target 'fate-sub-ass-to-ass-transcode' failed > make: *** [fate-sub-ass-to-ass-transcode] Error 134 > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".