From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3BDDA40231 for ; Thu, 19 May 2022 18:16:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4C3CB68B480; Thu, 19 May 2022 21:16:27 +0300 (EEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03olkn2037.outbound.protection.outlook.com [40.92.58.37]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 87C1468B226 for ; Thu, 19 May 2022 21:16:20 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kkh7H5Z+aCORZ3f+5qXVCYEasJQ6Du7Wg94edinDHK/pSmn66UGvPFP6yvBevUXOc/hUNzbGhOMFKVxR+NJmF5BkzLrpB3gfRC4cvxmVcSL6zx0pX/aQXmefVTIKt8eKea6+3AcejLQLlEB5vWoJgJ133pz8X0/d23N0dl4SuDJyaHrkG8e/DygXpVa+IvxnylexfkxCRFvIpUJIHvDAOkBe/66jyPt8ygtUDisqo7SoV7TxvZ9XX96VFB5Qh2L4xdVQLSGSAUcnUXQDZ8F4Y38Y//qCZ04qrwdL/AnZA5hq9NblMLwCk4SF1Wd7utMzd/BJhj+fzoyNhWhS9RuZUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NGvKnpT1Zmqrk0sOV8etW8BrwsXhtZrqV1xw0VRiVBQ=; b=CGTCCn05VvSBJnb9i2WPZ542TAdzh0NHJ3kAoWRKtXkQl+Eu//3w/xKSnqwNurjd+yg6LZZzmvEYz4pc0sN4OaZZGEtjHPnnJ3FLyp1dkjAYl1JHJUC6seBWNnm20iIjb64VizMq2/zHOB/93JpRQfwkZPSiq22NwpZNbPlsZgW/xKqjwdEVJz6D6wQ/1yOVUOmxV8wbpaTIa+bCAyCfo7tb72YnBawSYFS0VXIDUgf5xiRT2Jf8qQSVquk3USrd29gumQ4POXPRRs3jdtVjGhliB4ypuuUVk94MP6cVGr8/Py/KVBalTGq5WUfGg59+RSbrgDeb1pyDTmBGA3mSjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NGvKnpT1Zmqrk0sOV8etW8BrwsXhtZrqV1xw0VRiVBQ=; b=C9GkFFC0n958RBkZFzobcV1oYBiwYjWnGrZNn120seuhCdZAmqbymJbaqP4ochAeMGd1jK2eoonDZIkCXrsBnvKWNVbSLao5V0v+tsw5vtpdDdtGNpaKA2cafBkl0jI68VLRyxIHQlnFMlIKN7pCHUpItpc+AjRupO2CAq1+SULfXaoTZQffANf1mB3tFU+cGEkYQkwPBhbjLkQNruV4WslyeRyyWIPJ+hYiqmcHP34Zwe4y8+n0iyWkCyCx61ldvA2VK9jhDmZrKVm5uKnp6ZLc+sRm/ch4y1nUenNB3tnt2OPP8jD/Atuzx9xVvR1m43RAlFK05hOqRcd978ahlQ== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by VI1PR01MB5117.eurprd01.prod.exchangelabs.com (2603:10a6:803:ce::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.16; Thu, 19 May 2022 18:16:18 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5250.018; Thu, 19 May 2022 18:16:18 +0000 Message-ID: Date: Thu, 19 May 2022 20:16:16 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [xLkUk8IAsSIrHrP9OG8y8IL2lOa+E1GI] X-ClientProxiedBy: AS9PR04CA0089.eurprd04.prod.outlook.com (2603:10a6:20b:50e::13) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <74f2fd51-3cf8-c708-770b-365944acd524@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 03a93267-9cf9-4cfb-b30a-08da39c3ab59 X-MS-TrafficTypeDiagnostic: VI1PR01MB5117:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wt3YMsBbHuCOb0sLy+LFOviOEtwOsVfruv2d+WMjOf50HnBvSPfRJtkHrp59NphnWLCAZjdT4+H2dx1yy/2mnRMuGkV2D5MI6vmrgm4k9q6FIdR2K4/Jcvcq+uHtDSiPDeUWLOLqEO2LRz0TZgyOyDKOEMF8XV3jOz+zElWYK7QPZ8VGclVZnq+pjcdNwy0og9ECSUKvYZGCezIjATk6IEDiIArJUPjeolDvnlplEg3EXnb5UEZFaX+RZOBKXIc0aHhQVcpHODOPs6aEgq7okukJlnlHdgXayrBvxm5WwlFXDQh8WdmUGjk3UsDXxbxKgzMnHYx+Y74x3fZgcH41J08ogOkZTmtwxrlNvhOAFAoShvnbthvLNhytDyXXzev0PlATmIKPB1/RLpeD4WjoG+XHh3FJhq88UbwCdnZs9z2rBjPqT0GqwoA7nUyUJqr1O2/d/pclDDZBwfaGADjY4KvBmCP4WHa5kRXXFqd041brrVcFPC5FMRkyh4h4QNHxhLrsS5FjClKoYK9sQTYOo7LRtu1FBy+6hU7UhjZHVcyDEwpa61k0jIacvtIJRRmLjN4R4JbIawMmOctHHd8A2w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVoxTlk1UTZoaFBKWUdicE80Mi9sQWJlVkZNbWkwdUVGZkF3QU05THNVMjVx?= =?utf-8?B?eXZPck9hTUFDVTlaMXdTeG9wSGQwVHRpaVEyaUt1RXE3TFpycXFhclBVZnp0?= =?utf-8?B?ajM4NFcrZmdOU3lsVjA1NTNOSytSMnljUzBBU1NFS2NuUERFK0xnMGo1WGNs?= =?utf-8?B?UkZneVVnQkc4NGpKb2tMK0t5Z2tpT2hmLzNUNjh2Q28zcVVxMFVHMDl5bG5L?= =?utf-8?B?NHJoM3laL3FFcGdXeTU1bFI4bFliTGtESjJLYi9yaUZFQkdWb1h0QVJkNDNt?= =?utf-8?B?THBpclBJU0ZvQjRNQi9PYjIra0pWaG85OWZZMTdpZERhSDVJUmRzcTQ0cnN0?= =?utf-8?B?K1R5c2RsN0E2OEhjRDRkR1U4eEFILy9PNkh1bDczeUtacDJKTjFkSHJlUExy?= =?utf-8?B?eDh3TTR5OGhiOUhYMVZCT2JWL2hIcjlMRVcvYzBJTjA3MFJmdmxQRXB6ajcr?= =?utf-8?B?Q2JxeWpUMjNHMGQwUTUvSmxCUGlhanpsOWgwRDY3d09kZkFFTXFydkV4Qm56?= =?utf-8?B?TEI1NmdVUjZDamFQVGVkd25wcFNmckI0T2s2LzVRVGVJRW4yUGFSemx2NHJP?= =?utf-8?B?a01rZldybG1JaS9FSFV0Ylhsak1tbVFkTiswTm9VaXZCL1VKVkdYNHVjRjNZ?= =?utf-8?B?YkZlSyt4aWZ6eTdtM3Q5ZXkwRlh4bVNBSmZtM1pIdldFS3VGbUtpQmp2TVl3?= =?utf-8?B?emhqUW5KcmJnWnBwRVpkWFVYRXlCRFVJdCt2Ri9GS2lzcXJFdnp3VXRDalQ0?= =?utf-8?B?R2V0OWtFQU9Jc3JZK1k4cFphQVJmNFFaaFpEZkpsdTVTbXJuMjMyWjh4MVJY?= =?utf-8?B?R3pFV3hPY3B1bkFlRFVIZlhzR2o4YVhHTThVNlFYUjBXMkJiLyt6VENua2FB?= =?utf-8?B?QXUwNW8xV0Z3eWg5MXFENGc1N2U1UUlXazk3aTJFMkxrYnVvNjdZSE1PQk5z?= =?utf-8?B?S09pb3VrN2VuYTNtTDVwT1lYSkVWQzJLSzY2cVorTHBvQmprNGxoY0dCakNo?= =?utf-8?B?RFNhenNzVzh2MUdJcFdYQVpZTG5DUWoxV3dlOWw4eGp0OHVsZktpcDZzTG4v?= =?utf-8?B?ZkZuTDZRTEdmVkMrMXcxQmpSbGdnM1cvZGJvR21TWk8vK0NHaFBsUndxbWJk?= =?utf-8?B?Kyt1eUtrbWlnUlpEOVZ1alBJWGhFSzFscGF2bngwSVV1VWZaeUM2a3dwSHhN?= =?utf-8?B?cE5ZVlVIS2pEbXJhZjgzN0g5RFI2VExpNW56WVdhbmRONHZxb25tZEk5RE45?= =?utf-8?B?MDZkamhTVzNueUwzeXprNUJGNkZTTlQ4d2c1dDNLbVNRQStMeFFOY29icGdO?= =?utf-8?B?V2NjcVBhMDZDNVJaMEMxaHJjUFk2RmRPN0xKKzVLYy9QNEF3Zk01VTY2TTNm?= =?utf-8?B?SkFPMkRyR1NUYS9TMEs2WDBsQmxlMytMS2tBVHcxOWI4TURqd203M0RHNWVv?= =?utf-8?B?OW5HNFpiOW9UOS9lQkpVT1hwcnNTK0VjRTZGMnEwUWxGY3BRZ3hHZnU0d1gr?= =?utf-8?B?WkNCaWlJVkh3SFB5amtzc0xlRFBNSE5GREV5NmFPS2MvNHhzU2NvK1RNRUpT?= =?utf-8?B?UFVIcWFHcGxsNlRjY21JM3ZXR1lBeXVBZjY3dS9qS05MaWVtNGVWTmF6SG9t?= =?utf-8?B?dndKRjFIMVVyV2J2b0F6S05OZm9rNVJGRWxxZ1FMVEhxTDhSeDZYVEpBMnFM?= =?utf-8?B?Y0MzWUREdE1YYjdFN0M2L1JvNlZzaVdmWTEwNklTeURUNktVY0tLa1Q3dzNE?= =?utf-8?B?T2pPb25ZMjZFT3dYZFZHUktLYzIwUEpMei9neDBmVlp2NlNhQUtqdGdzMitM?= =?utf-8?B?aFpkczg4RkhqV28rdXFKRnkwb0Uvcnk5TDJTNGVPSE0zSURMSzBJdkZmT3Mr?= =?utf-8?B?bzZkT2srRFJmTWlPa1lDeXU1Z0haakErMms5Wk1ZZUVPR2dqUS9VWEtBVXVk?= =?utf-8?B?QnJucENvNGcxUVJhNjRJNFVkOU1hN3BNeFNCWHkwS1BFeU1Qcy9RTXRXVHh6?= =?utf-8?B?bzB4a2xRRTdRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03a93267-9cf9-4cfb-b30a-08da39c3ab59 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2022 18:16:18.8003 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR01MB5117 Subject: Re: [FFmpeg-devel] [PATCH 4/7] avcodec/mpegvideoenc: Remove ineffective [pb]bias options X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Andreas Rheinhardt: > The user-provided value is overwritten in ff_mpv_encode_init() > without having ever been read. > (This has been broken when making these options mpegvideo-specific > in commits 910247f1720c6aae422723c05dac6d0b19f20bec and > cf7d2f2d2134c0854edf2db91e7436ac2bc9874f. No one has ever complained, > so this commit removes these fields.) > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegvideoenc.h | 4 ---- > libavcodec/version.h | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/libavcodec/mpegvideoenc.h b/libavcodec/mpegvideoenc.h > index a0e8913ea6..ecc389a6d3 100644 > --- a/libavcodec/mpegvideoenc.h > +++ b/libavcodec/mpegvideoenc.h > @@ -43,8 +43,6 @@ > #define FF_MPV_FLAG_NAQ 0x0010 > #define FF_MPV_FLAG_MV0 0x0020 > > -#define FF_DEFAULT_QUANT_BIAS 999999 > - > #define FF_MPV_OPT_CMP_FUNC \ > { "sad", "Sum of absolute differences, fast", 0, AV_OPT_TYPE_CONST, {.i64 = FF_CMP_SAD }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS, "cmp_func" }, \ > { "sse", "Sum of squared errors", 0, AV_OPT_TYPE_CONST, {.i64 = FF_CMP_SSE }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS, "cmp_func" }, \ > @@ -94,8 +92,6 @@ FF_MPV_OPT_CMP_FUNC, \ > {"border_mask", "increase the quantizer for macroblocks close to borders", FF_MPV_OFFSET(border_masking), AV_OPT_TYPE_FLOAT, {.dbl = 0 }, -FLT_MAX, FLT_MAX, FF_MPV_OPT_FLAGS}, \ > {"lmin", "minimum Lagrange factor (VBR)", FF_MPV_OFFSET(lmin), AV_OPT_TYPE_INT, {.i64 = 2*FF_QP2LAMBDA }, 0, INT_MAX, FF_MPV_OPT_FLAGS }, \ > {"lmax", "maximum Lagrange factor (VBR)", FF_MPV_OFFSET(lmax), AV_OPT_TYPE_INT, {.i64 = 31*FF_QP2LAMBDA }, 0, INT_MAX, FF_MPV_OPT_FLAGS }, \ > -{"ibias", "intra quant bias", FF_MPV_OFFSET(intra_quant_bias), AV_OPT_TYPE_INT, {.i64 = FF_DEFAULT_QUANT_BIAS }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS }, \ > -{"pbias", "inter quant bias", FF_MPV_OFFSET(inter_quant_bias), AV_OPT_TYPE_INT, {.i64 = FF_DEFAULT_QUANT_BIAS }, INT_MIN, INT_MAX, FF_MPV_OPT_FLAGS }, \ > {"motion_est", "motion estimation algorithm", FF_MPV_OFFSET(motion_est), AV_OPT_TYPE_INT, {.i64 = FF_ME_EPZS }, FF_ME_ZERO, FF_ME_XONE, FF_MPV_OPT_FLAGS, "motion_est" }, \ > { "zero", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = FF_ME_ZERO }, 0, 0, FF_MPV_OPT_FLAGS, "motion_est" }, \ > { "epzs", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = FF_ME_EPZS }, 0, 0, FF_MPV_OPT_FLAGS, "motion_est" }, \ > diff --git a/libavcodec/version.h b/libavcodec/version.h > index 87b7284a95..5183deb68b 100644 > --- a/libavcodec/version.h > +++ b/libavcodec/version.h > @@ -29,7 +29,7 @@ > > #include "version_major.h" > > -#define LIBAVCODEC_VERSION_MINOR 28 > +#define LIBAVCODEC_VERSION_MINOR 29 > #define LIBAVCODEC_VERSION_MICRO 100 > > #define LIBAVCODEC_VERSION_INT AV_VERSION_INT(LIBAVCODEC_VERSION_MAJOR, \ Ping for the last four patches of this patchset. I plan to push them on Sunday unless there are objections. - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".