[FFmpeg-devel] [PATCH] avformat/movenc: Fix invalid check

[FFmpeg-devel] [PATCH] avformat/movenc: Fix invalid check

[Andreas Rheinhardt]

Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b.
Fixes Coverity ID 1506839.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/movenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 0ef6b3c76e..a4dace7c1d 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -424,7 +424,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
     if (!info->pkt && !(info->pkt = av_packet_alloc()))
         return AVERROR(ENOMEM);
 
-    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) {
+    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) {
         if (ret == AVERROR(ENOMEM))
             goto end;
 
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Fix invalid check

[Jan Ekström]

On Thu, Jun 30, 2022 at 11:15 PM Andreas Rheinhardt
<andreas.rheinhardt@outlook.com> wrote:
>
> Regression since c9de096851803d45444ae9dfe3a390a2d53ac71b.
> Fixes Coverity ID 1506839.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  libavformat/movenc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 0ef6b3c76e..a4dace7c1d 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -424,7 +424,7 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
>      if (!info->pkt && !(info->pkt = av_packet_alloc()))
>          return AVERROR(ENOMEM);
>
> -    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size) < 0)) {
> +    if ((ret = avpriv_ac3_parse_header(&hdr, pkt->data, pkt->size)) < 0) {

Geez. Sorry for missing this and thanks for noticing it.

LGTM.

Jan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".