From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 760CA42BC4 for ; Tue, 31 May 2022 10:40:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 49A0768B65D; Tue, 31 May 2022 13:40:01 +0300 (EEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-oln040092066040.outbound.protection.outlook.com [40.92.66.40]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CEC0A68B573 for ; Tue, 31 May 2022 13:39:54 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V3agT56B3z6MB+wavVQJeY781oD9oWirZLRGtsowYet7rrmYIsAbuZqwlw/NXfn2AQ1SEXZ+5mJV17UspLxUcg1g6BLJ/KzVk4OgbojuICMpG7Z7XEDdBoFlzpZDm1bYOGh5MYpJ3nS4z+eyNT2lpQmEYX/nayFQvhAYXyLMbh7QM9owMWxnj9JBPs5IMgw1MaOeG4nn9woZLCgx8yaSkoNBzHRdiu3miiO8I0uzClJslm/sOfjZ3qnZL/msMCExFqVUXzYtRKwQIs6MzGmf/FElBsbj+ITXngrt1rnAJk339RGyX3vffFCx/muQ2FRZO7OEemrn3MjU69S0O1wg2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qGpPQ8iIBd5NVms+F/gV7tZtbKY30o0OW0HrcNa2Gsw=; b=M+KuVfE9nUoss37paiDIZXCaZ8VMXSpNNhqF81HowuLvQvrZX6yVXXUsMDwCAwu8sQSrQeArhSGUSMY836VFocTV5S5xlGGR3Ump0ui4EVhLUSaQbFLwttchaSfDkWHkPce0tp4lcRLfzp7jQPpQUKTYPW+2Yyp15gkOnPgt0KT8aeyzb26I5mck2jm0f7UuJiNkPj9Lwb9mpjeCZ/YYk96NikYXbSLwfwsYw1f2kd9LJSEg8CQPvLyZKC8t9vEyRTlojcZSX7bigExLQfhgaJSQlI59pHIqK1YGo6orvcPBpMmvUpzw9mZctOKadK9MkG1Lnva0CIs8c+6QbgV3bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qGpPQ8iIBd5NVms+F/gV7tZtbKY30o0OW0HrcNa2Gsw=; b=Vwf54jLH00zUcAuYTO2e3MkSfuDj0GSsaau43mzkjd+9W/zLmBQs5IwQZ19vBPZmyEpQ3epH3DRQeFjqnH/HRudW3Vk/3gsq1UeGTYdUh00SvZJpuXa2eOTWLP5jw2NMAgQAeTIf6pAx8IOEUALsYNcephqE+H9AlPyoVgdygFQanzV4Ln4cuaEpcn02JFJpcspOcxs9OTbOZtMuCKLljOWJJvbdQaPK37qDoNIuE+a+0cwq/cJW5ue9Wx59YbTzwOWs78185M39s+cVmJFvr87PdBcPcjI6F1cQw+82UHq1+FjQUkGTGYs6e5yzDGzi//pPR+JntvX1iT5DmcLjgw== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by AS8PR01MB8811.eurprd01.prod.exchangelabs.com (2603:10a6:20b:40e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Tue, 31 May 2022 10:39:52 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5293.019; Tue, 31 May 2022 10:39:52 +0000 Message-ID: Date: Tue, 31 May 2022 12:39:49 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220531031334.19488-1-pal@sandflow.com> From: Andreas Rheinhardt In-Reply-To: <20220531031334.19488-1-pal@sandflow.com> X-TMN: [AoYP2JVHiH+e2Hv3R1SAydBcvPXDpieY] X-ClientProxiedBy: ZR0P278CA0077.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::10) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <59e39c98-c7a6-a001-ebee-0e0bdd3688a8@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6699553a-8de0-4699-60e0-08da42f1e4b0 X-MS-TrafficTypeDiagnostic: AS8PR01MB8811:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UWDdMkY/xXNbwXRZdURXPTLdjIVn6qjk/mjgNDcgg2oo/yNjG52+TEm5vgDpupq9Tw+tdIQihJvpzovOFQsdTEFPkV0z2+rOLIEqwltv6uJgLnGWh7ZZqS98umh5cEG3JRwg/rH8d6YX0D9396nV4X63jTNNJ6u5lC2dLaoR1ljGb7y2Nnc4ddMQLhSQNcPdrEc6AUNgIUUpggpJFKfpXpf/BkrCQ7n6sVw71H0VNuHQVSxFyQXEeiQZisCYLv8knrUnbaLwLXEClDNwiYa2WwhLGHWCkOa9KRpk7GjWBLqyYHkaqSPwmVtwghyzRJH63iOw6EITGO1PBFSCd0mVF1C9co2jNd3twX1mhehd21NSHRAtzjXGu9GRlIAZvynxccZHdjk/JVgNIvffUeWHvRrnEoqOSg2ZrytAL71ZZNKCFh4SLGzqbDN6RlATe6FXeyC12pijw5DYwOjW0RPrMy2T3jcmIMoU8z31nwPYaNja7ySugd1P81Y7Nm+Pm6J2d4vMR3xlxtOJA6+io4+US5jBfedrPhPJ39h20xB3jYXfcfHfo6dsQNsEFQ/eZGi6hp5nvsMoTajJvoaC/xc/Qw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YkxwalBvcUt3SzQzQ1lBNVc3VVlEand5MWFlZ0pnTlJ3TUVrN3FlYUdMMk9N?= =?utf-8?B?V29yY2xKVUJQOWlTd2xMYnd5YzdJb1NOOXcwaHlKa0M1ZkJWMHVaVkdmUmND?= =?utf-8?B?Vyt2NU1mTmdpcjdWNG9vWUZneVNSbU5uNHl4bjZ5YmRaRUFkZFU3U0g0NUY1?= =?utf-8?B?ZlJhWklrbW1uckhOWnk5M085Z0RwOTh4NUN5N1JZMzdPSEdIRDBRZzM5MEF4?= =?utf-8?B?dGZFYXBKOElwdmdUYnkwSEFFMjU2b3p3NE94ek1XV1Y4SjlvNDZRbURLZHdR?= =?utf-8?B?TVNQWGVVeWlab2FRYS9uU1V0UExwWlpFL2FpTHBwL04rTVlTOEF5a3pnTk44?= =?utf-8?B?RkNGOUE1dkR6bVdheUtMbkFsKzAyTmFtZFFSUlBzbk9VbmxtS2ZjMnhRVGhp?= =?utf-8?B?TUROeXR4d2s4emM0Y2wyVXJFbzJUWVZxN1JXc2k2ZmpyVHEwdWl3SGdGMk5G?= =?utf-8?B?MmFxbnE2emtiM2pFNmJzZm5zdkpkMlZISDBiR3J2RGdPRmk0WEVET3l1V3Jm?= =?utf-8?B?RU5rUTUwdGVRNlZlcWtUNExIUUxBNDNVbWMxMTJYNHAyZE9GV2FZZmpDRThq?= =?utf-8?B?YUd3c3g2YThJMWJWY3Qxc3ZnNzU0eWlqcUp5UmdITnNVUHlpK1VkUEFFNlAr?= =?utf-8?B?MjlGN3BwejNDL1dwY3ZyT3ZQeHoyUWNrZ3dXdE9Mc2VJaWNhdE9vYTBYS1A4?= =?utf-8?B?ZDJLWS9PeU9CbVgzL1dWYXprNnZFc0xDbnBnajZ4NFdWclFzV09iMnB5T2p0?= =?utf-8?B?S2d0T3pWLzNicE5EWHpNeTV5dmJEb1lFbEMyRlo5RHd3TFk0eTVUemk0VXAv?= =?utf-8?B?ak9vdVZpTVZnYk83OHNFbmRtQ0d2Y1VySnlZL1VvMGFyc2pheGdCRjhjOFlr?= =?utf-8?B?ZFI5em04b3IveGhIbXUwYzJYYUUreXdyZUJsQmZlemdwYUtaNHJWYURKaUd3?= =?utf-8?B?WjU0UjM3NTZiSGdHZXppVVVvclowTHNnSWplRVBBNE4yald6NXdlbzlxRjVZ?= =?utf-8?B?czhwUWc0d21UbXh2Z3VvdW5aRExMQVNMSVc0YXp2WUl5YmxmSmR2U3Z5MlUv?= =?utf-8?B?L1lQUUpZa3c1S2Zibmc4bTVocnM0SldEbUhMeFp2OHkvMVNTYVI1MWtVbzBo?= =?utf-8?B?VDVaTUgzR2xqTjV4WHJWNUpnaWVlWTViUUFmRG92VTNkbVRUTkdPYzM4NVVG?= =?utf-8?B?TDhJQXNmVUZtaTJ5alZUQWwzNTcva250NW83MHBDVGh4bjFHTnJDMTI0RTlE?= =?utf-8?B?NjdoOTV6eXU2TzJna2FSeVRobHhaQ2VGWDRKdGxQcE14UEg1YjNmQ2hBYTEv?= =?utf-8?B?cW9wTlNwM1lhNUVpdldUeVQyVGpaYyszY3Z1SGdORWw2TWZmYVFFTDRXaGpv?= =?utf-8?B?bmFoR2lBQU1hdExiOURaY1F0cGFZT25MNFpzc3pXS3diYk91dThvank2cHNK?= =?utf-8?B?WFRKSGtETFRuV0IrZTFZdTYrcFdUM2xDbDVZYm1WZ0tHNjJ1TDYxNkxodEVC?= =?utf-8?B?VmRCYTNURU9UQ0ppbjJTR0JRemhyRC9LRWt3TndJY3ZZSXdscHUvOUlrbmRG?= =?utf-8?B?NEUwZXBXaWg3ZFUvT2NUWDVlWjVjMllTV0tBbnlJVzFHbjNFRDNDa1VOMDBQ?= =?utf-8?B?dEFiNGJwNDRmMldDTmdUcWY1bmd3RnRSRGxrVjVwMC8xamxKQ3dBWUczRkNS?= =?utf-8?B?alpvQzM3dENNTWZBYU1XTWJwNWRrVXFWVm0vSWNJcnJWKzE5YlNQSDREcy9p?= =?utf-8?B?VXBzMENibWMwT3A1cUsxZW1JVlBVUWNSQ21UTExNTlBFSmVnYU92a08vd1d0?= =?utf-8?B?UldzR3ZqOXFCTHNiQUM2OXZRUTZ4KzRlb01jTG5FMExtTm15L1VIMExlamo5?= =?utf-8?B?bDk3LzQxQnVtSWdYZkhhK21Ub0diVHZuaEFSVjg5L2x3d1FNcXBVTkxXSjh5?= =?utf-8?B?a3kzQXpHN1lQMkx3TVRzakJIMUN4dHNPNkU2SEh3eldQRndwRzVmcFZFRHNo?= =?utf-8?B?SVdmOXhLOGFRPT0=?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6699553a-8de0-4699-60e0-08da42f1e4b0 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 10:39:52.1099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB8811 Subject: Re: [FFmpeg-devel] [PATCH v3 1/6] avutil/uuid: add utility library for manipulating UUIDs as specified in RFC 4122 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: pal@sandflow.com: > From: Zane van Iperen > > Addresses review comments including: > > * simplifying av_uuid_parse_range() > * removing avcodec/cbs_sei from this refactoring exercise > > Co-authored-by: Pierre-Anthony Lemieux > Signed-off-by: Zane van Iperen > --- > libavutil/Makefile | 2 + > libavutil/uuid.c | 142 +++++++++++++++++++++++++++++++++++++++++++ > libavutil/uuid.h | 147 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 291 insertions(+) > create mode 100644 libavutil/uuid.c > create mode 100644 libavutil/uuid.h > > diff --git a/libavutil/uuid.c b/libavutil/uuid.c > new file mode 100644 > index 0000000000..8943212f30 > --- /dev/null > +++ b/libavutil/uuid.c > @@ -0,0 +1,142 @@ > +/* > + * Copyright (c) 2022 Pierre-Anthony Lemieux > + * Zane van Iperen > + * > + * This file is part of FFmpeg. > + * > + * FFmpeg is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * FFmpeg is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with FFmpeg; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > + */ > + > +/* > + * Copyright (C) 1996, 1997 Theodore Ts'o. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * 1. Redistributions of source code must retain the above copyright > + * notice, and the entire permission notice in its entirety, > + * including the disclaimer of warranties. > + * 2. Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in the > + * documentation and/or other materials provided with the distribution. > + * 3. The name of the author may not be used to endorse or promote > + * products derived from this software without specific prior > + * written permission. > + * > + * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED > + * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES > + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE, ALL OF > + * WHICH ARE HEREBY DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT > + * OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR > + * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF > + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE > + * USE OF THIS SOFTWARE, EVEN IF NOT ADVISED OF THE POSSIBILITY OF SUCH > + * DAMAGE. > + */ > + > +/** > + * @file > + * UUID parsing and serialization utilities. > + * The library treat the UUID as an opaque sequence of 16 unsigned bytes, > + * i.e. ignoring the internal layout of the UUID, which depends on the type > + * of the UUID. > + * > + * @author Pierre-Anthony Lemieux > + * @author Zane van Iperen > + */ > + > +#include "uuid.h" > +#include "error.h" > +#include "avstring.h" > +#include What is this used for? > + > +int av_uuid_parse(const char *in, AVUUID uu) > +{ > + if (strlen(in) != 36) > + return AVERROR(EINVAL); > + > + return av_uuid_parse_range(in, in + 36, uu); > +} > + > +static int xdigit_to_int(char c) > +{ > + c = av_tolower(c); > + > + if (c >= 'a' && c <= 'f') > + return c - 'a' + 10; > + > + if (c >= '0' && c <= '9') > + return c - '0'; > + > + return -1; > +} > + > +int av_uuid_parse_range(const char *in_start, const char *in_end, AVUUID uu) > +{ > + int i; > + const char *cp; > + > + if ((in_end - in_start) != 36) > + return AVERROR(EINVAL); > + > + for (i = 0, cp = in_start; i < 16; i++) { > + int hi; > + int lo; > + > + if (i == 4 || i == 6 || i == 8 || i == 10) > + cp++; > + > + hi = xdigit_to_int(*cp++); > + lo = xdigit_to_int(*cp++); > + > + if (hi == -1 || lo == -1) > + return AVERROR(EINVAL); > + > + uu[i] = (hi << 4) + lo; > + } > + > + return 0; > +} > + > +static char const hexdigits_lower[16] = "0123456789abcdef"; Our typical order is "static const char" > + > +void av_uuid_unparse(const AVUUID uuid, char *out) > +{ > + char *p = out; > + > + for (int i = 0; i < 16; i++) { > + uint8_t tmp; > + > + if (i == 4 || i == 6 || i == 8 || i == 10) > + *p++ = '-'; > + > + tmp = uuid[i]; > + *p++ = hexdigits_lower[tmp >> 4]; > + *p++ = hexdigits_lower[tmp & 15]; > + } > + > + *p = '\0'; > +} > + > +int av_uuid_urn_parse(const char *in, AVUUID uu) > +{ > + if (av_stristr(in, "urn:uuid:") != in) > + return AVERROR(EINVAL); > + > + return av_uuid_parse(in + 9, uu); > +} _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".