From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 66D40433D2 for ; Sun, 10 Jul 2022 23:12:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3B1C168B63E; Mon, 11 Jul 2022 02:12:44 +0300 (EEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2022.outbound.protection.outlook.com [40.92.89.22]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EB02468B5F7 for ; Mon, 11 Jul 2022 02:12:37 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bkXBqRgsF/HyjKCpuLsXWgBBFPJgfHDPPotNyxKHKAOfe23Zwx1lGyr0EUhSYxAsxY79mB0o+l1RMpKClk/VU7bltL3V19ObfTWOaFsqZkTMXfHF4XaXaw2cyAkTIkiG1HWgFkOupGDQDCsqjE1skG55GQ2plU5N2RILcqdnEz4xcWheHd0fjV56AA2XksNgPUXoOY++7oC4aNvkz1/c6g5yQjNEvumnLe8vPlRW24sp5xlw/tiW+rpl/OErwKLCwYDChm+9Y+UB1sfAW7ty1ZQACDvz3bLW0e8zl/P6hceNVxHVEwmaAUw1CJluJcPeIRQxNIZYDyKYiNT4cMFZnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QhjAyK9Cys9fWVoT3gDs2oxpGnNHOuQ/UTziXaojWnQ=; b=Jkwvs/lfgc+QhdZkgaB0HqAiwInpdGBGGMHfN641XIhVxwzv9DQB6DHFABtYXyIXS0LwOOabJWLmz38nUhLaTPnPMG46yAhPTuz4NmW6Udtqpf3gYBnWesheej+xCYhCkqDzN6gfWTe146vmgXr3+DIw0Vqif5+2j0VG/24lWV/Pt2m+fcTsYfgCCXunoI6INQ1pcvtmN0b2WgUIXCc6nFuA31mzd81ceOWRN16lofEti5EwA4SZ9QkKo5+YldNh9oM75zzp2yG8vky270ZlMSw06KDuqnZayAIUlwcjNmznUinZh68p3r9gOAdUScpNqfD/ORgebHf3Ai6BW9pAsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QhjAyK9Cys9fWVoT3gDs2oxpGnNHOuQ/UTziXaojWnQ=; b=PDWeiZvFVP8sp0c2jyy2Vw1hJm3gZj7eKGYNu8D967pD7u9WcWzfjjd/dOHGAxAb9Z4BbOA70YudoJjzZwQc66FEV9Uwlvw49DvbHnENf8/ci6smdvrNA4momBMjXEvqqIsMAxcrVhLVAbo8+5suXMBHeIhLC0X6WliWokcjtjqBVSjelF5JJ2MVXv/Ux6t0+kwhMbxDGd1U2QsJ++ELjz3XzB6/m+XELXXw/zVleVr0EW4TJDQCR1iNNaHL4XeV/39wOeK8gR0F8cBFP63swjL22hJ5KjudZQ5YyjTGVJMyu8mcM1ssOh0fEp3q4mbbKnIxSblr31U1LhUWErxC5A== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by PA4PR01MB7216.eurprd01.prod.exchangelabs.com (2603:10a6:102:f4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Sun, 10 Jul 2022 23:12:35 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::210e:b627:bcc9:8c46%11]) with mapi id 15.20.5417.025; Sun, 10 Jul 2022 23:12:35 +0000 Message-ID: Date: Mon, 11 Jul 2022 01:12:33 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220617203519.74426-1-tcChlisop0@gmail.com> <20220617203519.74426-2-tcChlisop0@gmail.com> From: Andreas Rheinhardt In-Reply-To: <20220617203519.74426-2-tcChlisop0@gmail.com> X-TMN: [2rJnPPmllNh42Bq8vBT1QKi0o5dvg4yc] X-ClientProxiedBy: FR3P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::23) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: <56695767-fcd7-7c14-b5f9-e3ac2c4d743d@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59e50d6b-51dd-4943-14f9-08da62c9acb9 X-MS-TrafficTypeDiagnostic: PA4PR01MB7216:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uu4tFAu0zEub5XkYUX21S6kqbqCxdB3/HHvmlAXqfOkpnODvvHDcjX90ltTLl1ruYisl2qfsHX/KM2LO6WcHoRQ18iuMNiTMn5CSbljrpmitmWTP1i6a2tXKfpu6t9al6dpkVr36fzauzQwaGdjgoahdJcTh50gFZ9Vcbudhi98vwWoXdg24vPAG0v77zGgUmpLnH1iSXUtFIbRhiZaHE46hbjWibmnNVSaqvtFkztS51mKR1UMNJC7FMRIlcA1R7crXigplhKD0P6GukuCTCIWwvCj4PC+KXpB4ZYEega945S4dO3lRvKSeefq3XDPHfHpDTOQdbozX9s6aSojVGS4YbLuP1CJfH2Us+FWXBXfM0EJBLy/o0Y27PMrF6qnSRmypScrFmQADPPefozBFbF6bynAhnXI4aY+6iQkJrxJOkapXW+aZzUozYtEg8AlMCSuh4AgLZlZVsnLbycSORiKoc++78oYfhXP27ttUcC+I0d3aB1t7HHntzBf4ZpUG5yb8vGcnXyJuBj/qcMvb8w6i2SE9ZjKEs88NXoG6wfRGMDJyWISbDk8Sz8w+H/GxISBKDYQ3ua0SfMyXssiz/iaYe+7YamTJ4Jigp4iCcy/iLr13ZGbZhSAxB0hsWaqDgqgx25x2QH4CBEi+5lyBI8gu4Br8zzJRvzkaBfRMEEn/DDfyxKiLXyZqHWWyvBjAfk/ySjMCjE4WWz1JkFeJpG/gMMyyTXO0HwPGUvq2Rus= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFF4YncraFpHS0kxYkozYS8wY3BMT0E2NUpncVlNWXBXdk11cDNFaFdwZ1VH?= =?utf-8?B?TEEyZnpkQlRKdngrN2krUW9Xb2NOU1NFaFIwOUNFeURzbkJnVGlBL1N5TXh1?= =?utf-8?B?MU9naWp2aWF5UStYOSszcDRtUisycnJpM2JXTkxmM0cyOWNWR2ExQlB1UUxz?= =?utf-8?B?ckVieEhnZ0N0ZFNMaWd5OFFmbCt0MjlLcmp0UkZOanovVjV4cDhsK2RROE9D?= =?utf-8?B?eVNKMkMwNDRKeVVFU3RWcitXcEFIYU15ZGdKNXdQd3YyK3AwbFNyNVBLeVBz?= =?utf-8?B?U25hTkVVbmFqRnVyNFIwWVpoMzRLZ3QvZVAyUXVnWitEcVduRVRtd3NJV1hT?= =?utf-8?B?UFZFb2VZZXk1YkJWRmpYK3k3YU4rdm1XUGpYeWxuSm1ISmY5V1hDaUhEekF6?= =?utf-8?B?S3Q0RTMwZkZ3YUh1K3k2dGtzRWxWZGRaazNGanBqc3JKYi9Hdk9RR01zaW1x?= =?utf-8?B?eFJIT3MvTzNmaGlObklaRTNMZTBkeG1mZ3pud2hjdjJJR3dVazFML2twOFUy?= =?utf-8?B?YmUvN3ZFYXpOQTdPT2dUTkNTSi9jVmFUck1LVFhyVkYrQWxvSlU0WmF5ZTFY?= =?utf-8?B?NWlaY1NnSWxQSHNBOEkzZDI3YlJDTC9OLyswSEt0Ky9NOGNjSE9UeEs5QVl1?= =?utf-8?B?NDV4OUJuQ21BaXlwU3M5b0x6SGt6eGdvakVzbE9zd213NWlqZFhNZDUyb0Jk?= =?utf-8?B?WnA3T3JaTnFrR0xzSnFZNy9yWjZST2lKRGFpWFhCY1dHZDhOM04zYy9ndHdm?= =?utf-8?B?YlljZ0dKV3Y3OTl0Ymszc0ZaQW1XR1BUbG1VSUhYZXBPOXJiMEdpTDZJcHpN?= =?utf-8?B?QWhHMzlwRUdhcEpDd2s2Vy9pU242OFVST2szSUI2SHc5WS9yekpiOC94aFNL?= =?utf-8?B?MjZ0Qk8vZG1KblRrZG5DVndCYVZwclptK08zSmxzalIrSEw4ZHhCRE15NzBt?= =?utf-8?B?T0hkSm5QNWMxT3p5WnBQUzA1eUxBcThLTDh4S2VBdHRGaUhTVlArUjBOMi9a?= =?utf-8?B?ektvK1JGT0RXOTVKZTAxUlhKd0ZvR1NoZzE5eXByaS9YOWg5Q0JmbzBYam9o?= =?utf-8?B?dG80R2xNTHk0dWE0K3hET0hqOFoxbDdRUHZ6NTRuSWY0amxrNjJBMXM3d0NW?= =?utf-8?B?Smx5b1doRGlnTHR0Ump0elMvUnNUSzErcnAvczNOWlg3TDB0M0Y3Q2lUbDMy?= =?utf-8?B?Nk1IV01uczdEWm5nTWNzYVVBblRhNS9DVTRhWFd5a0Y2Y1hsMTV5Sy9Zek40?= =?utf-8?B?NHpjNFVBNUhpQWxiZE5uZUdjRzBnYnhzY1BySmRld3VDak5BNCt3VXJRbDRI?= =?utf-8?B?cEgrVDVYYk0vSks2RUJHWlRNRy9BbXJRZHNTNmVzK3ExUUdmVmF4MTBzSnRm?= =?utf-8?B?WTlMY2p5K3ZQSTg3Y1R3dWVkSDV0c2gwQngvS0lFWWhzc29lUGZsRkpjb3NE?= =?utf-8?B?WC9EMEtlbUdLa3B5TjdZeEQzYmtZSDRsSDlZRXpoRTBvazlRZ3g4OFQzc1Y2?= =?utf-8?B?ZW84Q2x2cWh1OExwUmZWUVVDQkVZS2JIZWlGZVpwM1cyWTQrTEFwcDBsa0tr?= =?utf-8?B?L0VybmxubFRLTGlPYVFJbTBKSFJ2SHJBeDBOeEdyNHNkWjBDWi9TWkxzczNr?= =?utf-8?B?ZlRvaVlTaDlQampwNW9URFlxQjNmMlNMVEcvY1JOSDBoWEx5N0paNHJkZnM4?= =?utf-8?B?V01SMmlxZWwvd0hrVmxhdE9BWE1waGpoQW9JdllDcHB6VHFsbWZEREZCMWxR?= =?utf-8?Q?ZQ849nXZXLutK8K0bY=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59e50d6b-51dd-4943-14f9-08da62c9acb9 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2022 23:12:35.5855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR01MB7216 Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: quietvoid: > The NLQ pivots are not documented but should be present > in the header for profile 7 RPU format. > It has been verified using Dolby's verification toolkit. > > Signed-off-by: quietvoid > --- > libavcodec/dovi_rpu.c | 9 ++++++++- > libavutil/dovi_meta.h | 1 + > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/dovi_rpu.c b/libavcodec/dovi_rpu.c > index a87562c8a3..31e87cfbcc 100644 > --- a/libavcodec/dovi_rpu.c > +++ b/libavcodec/dovi_rpu.c > @@ -117,7 +117,7 @@ int ff_dovi_attach_side_data(DOVIContext *s, AVFrame *frame) > /* Copy only the parts of these structs known to us at compiler-time. */ > #define COPY(t, a, b, last) memcpy(a, b, offsetof(t, last) + sizeof((b)->last)) > COPY(AVDOVIRpuDataHeader, av_dovi_get_header(dovi), &s->header, disable_residual_flag); > - COPY(AVDOVIDataMapping, av_dovi_get_mapping(dovi), s->mapping, nlq[2].linear_deadzone_threshold); > + COPY(AVDOVIDataMapping, av_dovi_get_mapping(dovi), s->mapping, nlq_pivots[1]); Do we need the [1] here? I think not. > COPY(AVDOVIColorMetadata, av_dovi_get_color(dovi), s->color, source_diagonal); > return 0; > } > @@ -315,7 +315,14 @@ int ff_dovi_rpu_parse(DOVIContext *s, const uint8_t *rpu, size_t rpu_size) > } > > if (use_nlq) { > + int nlq_pivot = 0; > vdr->mapping.nlq_method_idc = get_bits(gb, 3); > + > + for (int i = 0; i < 2; i++) { > + nlq_pivot += get_bits(gb, hdr->bl_bit_depth); > + vdr->mapping.nlq_pivots[i] = av_clip_uint16(nlq_pivot); > + } > + > /** > * The patent mentions another legal value, NLQ_MU_LAW, but it's > * not documented anywhere how to parse or apply that type of NLQ. > diff --git a/libavutil/dovi_meta.h b/libavutil/dovi_meta.h > index 3d11e02bff..6afc7b055a 100644 > --- a/libavutil/dovi_meta.h > +++ b/libavutil/dovi_meta.h > @@ -147,6 +147,7 @@ typedef struct AVDOVIDataMapping { > uint32_t num_x_partitions; > uint32_t num_y_partitions; > AVDOVINLQParams nlq[3]; /* per component */ > + uint16_t nlq_pivots[2]; /* nlq_pred_pivot_value */ > } AVDOVIDataMapping; > > /** _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".