From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E5CAC437E9 for ; Tue, 28 Jun 2022 20:03:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DDB1D68B938; Tue, 28 Jun 2022 23:03:13 +0300 (EEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-oln040092068045.outbound.protection.outlook.com [40.92.68.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 817676800C7 for ; Tue, 28 Jun 2022 23:03:07 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jj9xrToRVZhop1ig3N85unQ6VXdyaRsW8XQ6HRhOlrE11JbLjfOGcA0uIB3AvE7m4rPmauPcQmxkX7rzmgxa8uwNODV1A7W9OTUTqfhi5EcwBsTbbX15NuRY0/0OrOfPap+GJn5qhIFnl++RUxWdV4XhEPdqdwHKzRVI2x5qKRTkeMSNKSiIJ6eRXcL62ck0Af9cA19LBOUff3DQ7mkknSKky3CN8qPgdjCM16jgZvbCPurkKM4yB0Zxpr8EPsyTKT5SfYGpWmONSt3TiqJmWknSLP44o0zKwDhLZiPVeZ2PRLS5nAZqhjRlf/VVLJSjL9HH7tGxO3QpLyEXiMMoeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wp5tSMD+WAjV2vd7Fht+e0HoMOi5jI9vp/BlXInMSTE=; b=ImohU6J6RLfg1qNvmQPtf0oZTtjpGdMX/1zMMOvCFaeyCLaNzZZZh0uoWsd/zDdzdNcwL/P/OyEDIQGLx1qdnYxvl2V7xdaPx7RqWEodJwTuUoiIN7/PtaTsXD1Agy/9F7+MhQtFYSroTKq5gcIZkVOwVH37Yn6hBSwdPtCAg9D16jXOQFVj5ahLnqFIJezi5G7mPMRMnt55yFpRfyYZbvhNGadhWVOt+eIuFdtY8ncut1msTm3JlV0GNnBH5jR8LFnDiZyT6tkrHO+CnLFkKbm7nQevcisKZpuoVmsSmOdRHCLoOIx9m2ilB4C6P5IH/LGNT5tpV2NQA5F/H8Y3yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wp5tSMD+WAjV2vd7Fht+e0HoMOi5jI9vp/BlXInMSTE=; b=MiVO1ZATJiTsPFHgb2hJUTAp84quBNj5q4y1TojXpjPdkjrgl/FQ1MWfnNwJaF+xw8wF0+4Sti0FKRWab4eQw/iQLSp3L3ZmuoklpHGNXB6Gx0GpeIWw/HZvyW/N4KExfxnlmpIwZWQFOj7TvgREoalGUGH6NRXqbfnPzTesot/DY4GKgNSDSw2NBZNvaSk8qdl1I6D7pSKxEAbKKsDo6ukPkOrJUGhP6i9Gp3mH3zLLYqNAmEEhUd80aNZZMkbuPuGfl5FEG9Fv9+ItZbjhvBR3TpB8D3K7tNjzVbiSzd97jseqrnaNhqflgDA6sLUmZ+X1JICEuAMPFTY6AviEww== Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) by DB6PR0101MB2279.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Tue, 28 Jun 2022 20:03:04 +0000 Received: from DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c]) by DB6PR0101MB2214.eurprd01.prod.exchangelabs.com ([fe80::60b9:9f29:40cc:f01c%10]) with mapi id 15.20.5373.018; Tue, 28 Jun 2022 20:03:04 +0000 Message-ID: Date: Tue, 28 Jun 2022 22:03:02 +0200 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220628134110.87770-1-ffmpeg@haasn.xyz> <20220628134110.87770-5-ffmpeg@haasn.xyz> <20220628195720.GU396728@pb2> From: Andreas Rheinhardt In-Reply-To: <20220628195720.GU396728@pb2> X-TMN: [L+UdREFycr5vs+ejELA3rg9ztuhnPAhf] X-ClientProxiedBy: AM6PR05CA0014.eurprd05.prod.outlook.com (2603:10a6:20b:2e::27) To DB6PR0101MB2214.eurprd01.prod.exchangelabs.com (2603:10a6:4:42::27) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8abb7847-e143-4731-cf99-08da594135d8 X-MS-TrafficTypeDiagnostic: DB6PR0101MB2279:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O+XH8BLgpPLXPBV7PnbkLJb1213E7Bihy9Gg3kxyk751RidLKZbZbp1l9qMxThYa6+tqP+Wm3wafLiX/x2aubb5e166kiC2t594yUtLpqjF2rts4YtS8yZOm2lzonA7PXGxxQ+c6Pm8tQVOQ98O0kiJqFj1rw51HVd9Or47AwPsuVNgK4T4lrm+14yaP8162ESdvGhmueqlppacPzdnOh4cHc+9Aa4txTxzCriE+6UWZgg7c29JT/qz0GnPrwTSpRqAn1Zv30ZcySwB680k6E7ZHTvM7wInDqAeN3gjEiCaFI7CS/Vmjyn9F0zOPeQrSCGQgoI80QQrPDHqikZDlaQnDaec0xmqZ5oc95YvQjr4StlyXNC8j5ktzNYWEG+YjNWkrs/1v7PpZmwu6Qian+Fx0qkL6Mc+7MulSLzfSM0bl8j/2Ttr96Hmhl7tU0Ybq3FJSivnQ6zi3BofFbK2765p2yi7ooagWg908E6nY3QfNzzNZQghIzgbLGExNH6UhFKgswbuwP/lzML6/3aWhoEBCdTlJqPIKtg7s6DgVTlxXUnoayJ73Qwkxctrl15wrwLLDBuCXkt4SLyPsegVcjvi3YC/QLxxm1wfXT0jEt/T/FyYYGwJzwvO7myIPSXRHPj1TXEIL4QEuO5oa8P5hNQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3pvVDZoSjNNaHYyNEFmR3hWZDNXdWZIK3ZLQzRDcVBCcTdnVHpUZXJUVTll?= =?utf-8?B?bFJ5MythZGtqVVV2UDFmSnJSRTJHU0VYL3lTcVM3MmJCYWhJeTdLQ1BoMVAv?= =?utf-8?B?NlM5bDB5WVJMcnNuZ0ZsZ3I2VHlhZTNBRUFpcmxSQThwd1Nzd2pZYnk0ZUlq?= =?utf-8?B?Q29hRnZXRTdHZVZYcU9SR0p4bHdac1E4WDJhNzI2OEVySGh5RVZyVnNRckpV?= =?utf-8?B?bHplSHV5MFN3WFl6NTJFcW41NDJGcEFONHZncHE4VDZ4K1p2aVBJeTh6R2dH?= =?utf-8?B?V0dzaTdtSjZnTTE5Sm1QamNsZkhueUlyamI0MDVCWmVBWk5BMlZ6cHdwVEVo?= =?utf-8?B?aEZzc2ZTOHZtcG9iL01KbUFCNzRjaDd6KzlHQWxWck1sa0w5RDFwcnk1L3N5?= =?utf-8?B?VXZmVjUyOGN6OFY0aUU2NDkxVHhSYmhPMnpNRXFoWmVxN2VZSjRGR3FXUjhm?= =?utf-8?B?c2xsSTVqM1lSWThhUGtteVVOV1VrSkplWi9BcU1Wc3dwdGxJb1dXUFdYdjkx?= =?utf-8?B?Y2FuNzZRaXNERlMwQnh2Z2ZKRnJCZnNkaG96cnpzd2ZhY2FPQ0R6WXdZMEJW?= =?utf-8?B?SEovRTBrS3V5T0NsekVCemtlbE51dGNBTjVSU2RZMit6dmFtYy9lRWhZWlhR?= =?utf-8?B?dEtOSXVpd0NRK0NtczZ5ZHZMQnB0b2NoUjh3cnFiR0xPbnBCTVZ3TU44RWQz?= =?utf-8?B?cTF6UTN4Y3U1TXFhMnIwT2hHSWJzZmdhZjdwdiswaUt5NTBjcndCeDd0RnF1?= =?utf-8?B?R2VoQ1k0d2RINC9hdEUycW8zK2kzR2VWanBqV29FR3ZHTjUxMGorWEVqd25N?= =?utf-8?B?bHpERjVSV0t2WEpTMTMvaEVCQXN4d3FwbHlBbzZnOFYzS01TVml6VTRzdWJL?= =?utf-8?B?QjYvekZJOVlUYU0zNTFrRjlaZXgwY2ZQUy9zRmZCaGZXYzR3b1BueklrRUlr?= =?utf-8?B?Um8yQkhwRnNoTUZYWVZUeFFrMXpYNTl4NGZZUEhnK0VpUzczNW1TTHN5b210?= =?utf-8?B?SmgzZDhBLzFPTkNqNmd5TnR3bUowYmZnZkRvQmFlSGY2SFFOV1AveVZiU1p6?= =?utf-8?B?eWpFdDE0Zk1pSHcxcXRVTll6VU9qclMyc3o1ZDBHZFBzMS9TeHFwOElVaG15?= =?utf-8?B?SlU5cWZtQ09sSy9LT3JWVmpJYXhIOWZuQVpZSDVzRW5NYzZRWm93bEpXYnZW?= =?utf-8?B?MitENldqUnRubHpDL0pwd0w2WTBpcEFXa0t6TXRDM0dTUWRkYmJZQmwyeWN6?= =?utf-8?B?K0hQVlAvWVpKYnUxNW9nR2Y3eGduWSs4WjZCeisvWVBkZkJtT2JTL1hRSnZr?= =?utf-8?B?dmNhbHFUS3ZrcisySVl2VEQ3Y2ZrOForTWlBVmV5cVhXeHNGVFpaalVTN2pJ?= =?utf-8?B?U0gxL05QVkJ1SU9HbGhXd0hLTTA1VnptSFJraXh6MW1OdENxZFQ2cktQbCtu?= =?utf-8?B?a2FRRUR0NGR3cjNMeERJSkxMb3RMS3RkYjBFV3NPcHU2LzVBSVliQjBtVkRY?= =?utf-8?B?aU9CMzFrc1JhNExLMTdrQlpTWHJNK1BMcStDbS9tSGZZSVNrWUFTUXlVcGUr?= =?utf-8?B?dGtVUlVZeUJxMmV3NWpmdGd5bUtkQ0dpcUpTYzhiU295MkRTMFNhekwwTGZ5?= =?utf-8?B?UW9ncnduK0RsUEdZSnh5K2ErZlZ6Qk5kM1VpeFlqQlpVUFlwWVNzRENTV205?= =?utf-8?B?SHMydU1HUWlxRDR5N2IvcXUzanVEbE9BUW55Z2hxeHhUL0FFa01DN2dTNkdE?= =?utf-8?Q?hDNKRHE4ltuBrPduh8=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8abb7847-e143-4731-cf99-08da594135d8 X-MS-Exchange-CrossTenant-AuthSource: DB6PR0101MB2214.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 20:03:04.0462 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0101MB2279 Subject: Re: [FFmpeg-devel] [PATCH 4/6] avcodec: add common fflcms2 boilerplate X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Michael Niedermayer: > On Tue, Jun 28, 2022 at 03:41:09PM +0200, Niklas Haas wrote: >> From: Niklas Haas >> >> Handling this in general code makes more sense than handling it in >> individual codec files, because it would be a lot of unnecessary code >> duplication for the plenty of formats that support exporting ICC >> profiles (jpg, png, tiff, webp, jxl, ...). >> >> encode.c and decode.c will be in charge of initializing this state as >> needed, so we merely need to make sure to uninit it afterwards from the >> common destructor path. >> >> Signed-off-by: Niklas Haas >> --- >> configure | 2 +- >> libavcodec/Makefile | 1 + >> libavcodec/avcodec.c | 4 ++++ >> libavcodec/decode.c | 4 ++++ >> libavcodec/internal.h | 8 ++++++++ >> 5 files changed, 18 insertions(+), 1 deletion(-) > > doesnt build here: (ubuntu x86) > CC libavformat/4xm.o > In file included from ./libavcodec/internal.h:37:0, > from libavformat/4xm.c:32: > ./libavcodec/fflcms2.h:32:10: fatal error: lcms2.h: No such file or directory > #include > ^~~~~~~~~ > compilation terminated. > ffbuild/common.mak:81: recipe for target 'libavformat/4xm.o' failed > make: *** [libavformat/4xm.o] Error 1 > He uses +#ifdef CONFIG_LCMS2 +# include "fflcms2.h" +#endif where he should use #if as we unconditionally add the CONFIG_* defines to config.h and config_components.h. (This has already been mentioned on IRC; the "if (trc = AVCOL_TRC_UNSPECIFIED)" in 6/6 has also been mentioned there.) - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".