From: Marvin Scholz <epirat07@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH v2] configure: improve ar test for response files Date: Tue, 18 Mar 2025 19:11:09 +0100 Message-ID: <DAA17F01-E0A9-4EC2-9A69-4769A7BBF3E9@gmail.com> (raw) In-Reply-To: <20250318154924.356-1-ffmpeg@gyani.pro> On 18 Mar 2025, at 16:49, Gyan Doshi wrote: > --- > configure | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/configure b/configure > index d84e32196d..14f7bcde0e 100755 > --- a/configure > +++ b/configure > @@ -5230,12 +5230,6 @@ else > ar_o='$@' > fi > > -if $ar 2>&1 | grep -qi "@.*file"; then > - ar_objs="true" > -else > - ar_objs="" > -fi > - > add_cflags $extra_cflags > add_cxxflags $extra_cxxflags > add_objcflags $extra_objcflags > @@ -7759,6 +7753,13 @@ case $ld_type in > ;; > esac > > +{ > +ar_out=${FFTMPDIR}/test$LIBSUF > +respfile="@/dev/null" > +out_arg="$(echo $ar_o | sed "s;\$@;$ar_out;g")" > +test_cmd $ar $arflags $out_arg $respfile && ar_objs="true" || ar_objs="" > +} Wouldn't that break on Windows where you don't have /dev/null? > + > enable frame_thread_encoder > > enabled asm || { arch=c; disable $ARCH_LIST $ARCH_EXT_LIST; } > -- > 2.46.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-03-18 18:11 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-03-18 15:49 Gyan Doshi 2025-03-18 18:11 ` Marvin Scholz [this message] 2025-03-18 18:28 ` Timo Rothenpieler 2025-03-19 9:24 ` Martin Storsjö 2025-03-19 10:13 ` Gyan Doshi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DAA17F01-E0A9-4EC2-9A69-4769A7BBF3E9@gmail.com \ --to=epirat07@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git