Re: [FFmpeg-devel] [PATCH 1/4] avutil/intreadwrite: add missing aligned read/write macros - Rémi Denis-Courmont

From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/4] avutil/intreadwrite: add missing aligned read/write macros
Date: Fri, 26 Jul 2024 08:47:51 +0300
Message-ID: <D8F49E05-E14B-48D2-A601-A1EBDE44672B@remlab.net> (raw)
In-Reply-To: <20240726021535.6354-1-jamrial@gmail.com>

Le 26 juillet 2024 05:15:32 GMT+03:00, James Almer <jamrial@gmail.com> a écrit :
>Signed-off-by: James Almer <jamrial@gmail.com>
>---
> doc/APIchanges           |  3 +++
> libavutil/intreadwrite.h | 39 +++++++++++++++++++++++++++++++++++++++
> libavutil/version.h      |  2 +-
> 3 files changed, 43 insertions(+), 1 deletion(-)

LGTM

>
>diff --git a/doc/APIchanges b/doc/APIchanges
>index fb54c3fbc9..d26e05e0ff 100644
>--- a/doc/APIchanges
>+++ b/doc/APIchanges
>@@ -2,6 +2,9 @@ The last version increases of all libraries were on 2024-03-07
> 
> API changes, most recent first:
> 
>+2024-07-26 - xxxxxxxxx - lavu 59.30.100 - cpu.h
>+  Add AV_{R,W}{L,B}{16,32}A and AV_{R,W}B64A.
>+
> 2024-07-25 - xxxxxxxxx - lavu 59.29.100 - cpu.h
>   Add AV_CPU_FLAG_RVB.
> 
>diff --git a/libavutil/intreadwrite.h b/libavutil/intreadwrite.h
>index 8abc3b9105..120bdbc8f0 100644
>--- a/libavutil/intreadwrite.h
>+++ b/libavutil/intreadwrite.h
>@@ -539,9 +539,41 @@ union unaligned_16 { uint16_t l; } __attribute__((packed)) av_alias;
> #if AV_HAVE_BIGENDIAN
> #   define AV_RLA(s, p)    av_bswap##s(AV_RN##s##A(p))
> #   define AV_WLA(s, p, v) AV_WN##s##A(p, av_bswap##s(v))
>+#   define AV_RBA(s, p)    AV_RN##s##A(p)
>+#   define AV_WBA(s, p, v) AV_WN##s##A(p, v)
> #else
> #   define AV_RLA(s, p)    AV_RN##s##A(p)
> #   define AV_WLA(s, p, v) AV_WN##s##A(p, v)
>+#   define AV_RBA(s, p)    av_bswap##s(AV_RN##s##A(p))
>+#   define AV_WBA(s, p, v) AV_WN##s##A(p, av_bswap##s(v))
>+#endif
>+
>+#ifndef AV_RL16A
>+#   define AV_RL16A(p) AV_RLA(16, p)
>+#endif
>+#ifndef AV_WL16A
>+#   define AV_WL16A(p, v) AV_WLA(16, p, v)
>+#endif
>+
>+#ifndef AV_RB16A
>+#   define AV_RB16A(p) AV_RBA(16, p)
>+#endif
>+#ifndef AV_WB16A
>+#   define AV_WB16A(p, v) AV_WBA(16, p, v)
>+#endif
>+
>+#ifndef AV_RL32A
>+#   define AV_RL32A(p) AV_RLA(32, p)
>+#endif
>+#ifndef AV_WL32A
>+#   define AV_WL32A(p, v) AV_WLA(32, p, v)
>+#endif
>+
>+#ifndef AV_RB32A
>+#   define AV_RB32A(p) AV_RBA(32, p)
>+#endif
>+#ifndef AV_WB32A
>+#   define AV_WB32A(p, v) AV_WBA(32, p, v)
> #endif
> 
> #ifndef AV_RL64A
>@@ -551,6 +583,13 @@ union unaligned_16 { uint16_t l; } __attribute__((packed)) av_alias;
> #   define AV_WL64A(p, v) AV_WLA(64, p, v)
> #endif
> 
>+#ifndef AV_RB64A
>+#   define AV_RB64A(p) AV_RBA(64, p)
>+#endif
>+#ifndef AV_WB64A
>+#   define AV_WB64A(p, v) AV_WBA(64, p, v)
>+#endif
>+
> /*
>  * The AV_COPYxxU macros are suitable for copying data to/from unaligned
>  * memory locations.
>diff --git a/libavutil/version.h b/libavutil/version.h
>index 852eeef1d6..028d072873 100644
>--- a/libavutil/version.h
>+++ b/libavutil/version.h
>@@ -79,7 +79,7 @@
>  */
> 
> #define LIBAVUTIL_VERSION_MAJOR  59
>-#define LIBAVUTIL_VERSION_MINOR  29
>+#define LIBAVUTIL_VERSION_MINOR  30
> #define LIBAVUTIL_VERSION_MICRO 100
> 
> #define LIBAVUTIL_VERSION_INT   AV_VERSION_INT(LIBAVUTIL_VERSION_MAJOR, \
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".