* [FFmpeg-devel] [PATCH] avformat/libsrt: fix deprecated warning
@ 2022-03-25 7:39 Zhao Zhili
2022-03-29 13:18 ` lance.lmwang
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Zhili @ 2022-03-25 7:39 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Zhao Zhili
srt_socket was deprecated after 1.4.1.
---
libavformat/libsrt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
index 19b9cb9895..1610ce8318 100644
--- a/libavformat/libsrt.c
+++ b/libavformat/libsrt.c
@@ -429,7 +429,11 @@ static int libsrt_setup(URLContext *h, const char *uri, int flags)
restart:
+#if SRT_VERSION_VALUE >= 0x010401
+ fd = srt_create_socket();
+#else
fd = srt_socket(cur_ai->ai_family, cur_ai->ai_socktype, 0);
+#endif
if (fd < 0) {
ret = libsrt_neterrno(h);
goto fail;
--
2.31.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/libsrt: fix deprecated warning
2022-03-25 7:39 [FFmpeg-devel] [PATCH] avformat/libsrt: fix deprecated warning Zhao Zhili
@ 2022-03-29 13:18 ` lance.lmwang
2022-03-30 2:31 ` Steven Liu
0 siblings, 1 reply; 3+ messages in thread
From: lance.lmwang @ 2022-03-29 13:18 UTC (permalink / raw)
To: ffmpeg-devel
On Fri, Mar 25, 2022 at 03:39:04PM +0800, Zhao Zhili wrote:
> srt_socket was deprecated after 1.4.1.
> ---
> libavformat/libsrt.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
> index 19b9cb9895..1610ce8318 100644
> --- a/libavformat/libsrt.c
> +++ b/libavformat/libsrt.c
> @@ -429,7 +429,11 @@ static int libsrt_setup(URLContext *h, const char *uri, int flags)
>
> restart:
>
> +#if SRT_VERSION_VALUE >= 0x010401
> + fd = srt_create_socket();
> +#else
> fd = srt_socket(cur_ai->ai_family, cur_ai->ai_socktype, 0);
> +#endif
> if (fd < 0) {
> ret = libsrt_neterrno(h);
> goto fail;
> --
> 2.31.1
LGTM
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avformat/libsrt: fix deprecated warning
2022-03-29 13:18 ` lance.lmwang
@ 2022-03-30 2:31 ` Steven Liu
0 siblings, 0 replies; 3+ messages in thread
From: Steven Liu @ 2022-03-30 2:31 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Steven Liu
> 2022年3月29日 下午9:18，lance.lmwang@gmail.com 写道：
>
> On Fri, Mar 25, 2022 at 03:39:04PM +0800, Zhao Zhili wrote:
>> srt_socket was deprecated after 1.4.1.
>> ---
>> libavformat/libsrt.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
>> index 19b9cb9895..1610ce8318 100644
>> --- a/libavformat/libsrt.c
>> +++ b/libavformat/libsrt.c
>> @@ -429,7 +429,11 @@ static int libsrt_setup(URLContext *h, const char *uri, int flags)
>>
>> restart:
>>
>> +#if SRT_VERSION_VALUE >= 0x010401
>> + fd = srt_create_socket();
>> +#else
>> fd = srt_socket(cur_ai->ai_family, cur_ai->ai_socktype, 0);
>> +#endif
>> if (fd < 0) {
>> ret = libsrt_neterrno(h);
>> goto fail;
>> --
>> 2.31.1
>
> LGTM
Applied as 397a777aa116f7da0d8c23bfc21874c3381e1c71
>
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> --
> Thanks,
> Limin Wang
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Thanks
Steven Liu
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-30 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 7:39 [FFmpeg-devel] [PATCH] avformat/libsrt: fix deprecated warning Zhao Zhili
2022-03-29 13:18 ` lance.lmwang
2022-03-30 2:31 ` Steven Liu
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git