From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id B8AC94DAF7
for <ffmpegdev@gitmailbox.com>; Tue, 22 Apr 2025 21:15:24 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1088C687DA1;
Wed, 23 Apr 2025 00:15:22 +0300 (EEST)
Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com
[209.85.221.44])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 62FA8687D6B
for <ffmpeg-devel@ffmpeg.org>; Wed, 23 Apr 2025 00:15:15 +0300 (EEST)
Received: by mail-wr1-f44.google.com with SMTP id
ffacd0b85a97d-39141ffa9fcso3068963f8f.0
for <ffmpeg-devel@ffmpeg.org>; Tue, 22 Apr 2025 14:15:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1745356515; x=1745961315; darn=ffmpeg.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=FwVGTsPzRbTo4iF/uedrk6NdmhBIyE8+nfA/a8WuP8k=;
b=XF1NZfQDgFasJEmuOcU4cmRVYfRWK9UCQ4sWwH+A9pLICzrhqQALi+SpuE8CLpthAo
ulLsJkocEHkAVlufaG/xnF810ImtPy1Y7H8I45LUIg1eLoLNVm15fhCNSqoT9/5k75d9
zN53XSHorcrgspnjaehOAsglmqgr2SCKazeOEi/wniTma8uaw+/5PlO0hL0iHIYlOgtO
kl6Omufru3z+4JyWgLvd/rpGjHP9Dvs1SaJS8c/DlddAmQ4apC3+2WnKVgEy2nn8tHsY
AAFmvyDUB/z+qpdrx5wyHk+nrd/Wdd8Q0yCKnW2B6eQyS6C7TM/BS5HbblUFNpH+dtp8
oaCw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1745356515; x=1745961315;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=FwVGTsPzRbTo4iF/uedrk6NdmhBIyE8+nfA/a8WuP8k=;
b=I0GxnnhymL6ecjnHlYlc9Wn1RMzvC/ZHmZL9z+behmGwPS6nsYCaCosbAyE/Oo9IYc
1pslLz8e+/hDhfMQ6HGSOCIGueZeZEPZ/GmvR5U4cZepr+cNhr7YIFev/Gn9y2KT0JW1
/bBt8Fc2KwkUDkhNHV40Wo6SLaiIA0U0R2elzxE12QlZqtjnyS62DwQ9DD6ig87hKU4+
kJpk6hkyjpKrZv7fauryQrLr153G8suG2zT6TbClp94RM+P365/Zllf+nEBFM7A2Q4SY
Zdmd6JK4hYH6ERgCNjwFUViGxh6HfXKkt1WmmsN9c6/87+7+go07a3OzpOZXUkABasZB
XKZg==
X-Gm-Message-State: AOJu0YyVfX82ViZ4uBA4sfIZumIC7OW7mDppS35nFQ1+vdU52NnjLctl
BGzDhM3HtkbSCoCoyU/37JoxZYyK6LuLQ7s/M/Rr6W4qjbVNFztC
X-Gm-Gg: ASbGncusdvrbbMZqsKEPjetU2+G+9EX0TJAItfQuXaN6RzbHuphZtAgmaD7/8L4LRbl
E6LSlZ8rIreWZjxjfeJfmr22ak2oq2Xq7N5cx/o2/qJhPTh0OXhzniphbpwlRklMR/Sqre6jKaH
L3I3hakckxZ3geUQ6cDRJagroMkK3li30yHBD04nKzphCR2LMm7jGML3gVupMj8OTqo5zNMl+T2
yqZizHPdZi7xgAxyZoW5W9Wjm+Rd741J94B0qytb6+c44txXvqHvkJzD+Zv0MdRfDRehWjS2/DN
SRZp+7pl1LQKgJyLBfl0K+sOcEjHFI1hKs6a+CuUtPQvK3NvX6qMzgzrBO+zknobYPiM9n3xYac
T6SpjBJpqvvRuTU0YgmsU9AybeIBtfSbMDis2Mm8qIzj7yDxajMzOwQ+reQ==
X-Google-Smtp-Source: AGHT+IEGZ/uWhEBXNBezg+ru4yUZlKMBUp5JoWyKRsm26iG/gKUnI9IWujCGszUQiuNw6pm/gJi2QQ==
X-Received: by 2002:a5d:59a9:0:b0:39c:d05:3779 with SMTP id
ffacd0b85a97d-39efbaf22e5mr11994976f8f.49.1745356513014;
Tue, 22 Apr 2025 14:15:13 -0700 (PDT)
Received: from [192.168.178.57]
(p200300cccf18bd005caacfa52a5bba5c.dip0.t-ipconnect.de.
[2003:cc:cf18:bd00:5caa:cfa5:2a5b:ba5c])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-39efa4a4f21sm16657926f8f.91.2025.04.22.14.15.12
(version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
Tue, 22 Apr 2025 14:15:12 -0700 (PDT)
From: Marvin Scholz <epirat07@gmail.com>
To: Marvin Scholz <epirat07@gmail.com>
Date: Tue, 22 Apr 2025 23:15:11 +0200
X-Mailer: MailMate (2.0r6222)
Message-ID: <D536FEBA-1F3C-46DA-AEAC-31FCCB519548@gmail.com>
In-Reply-To: <20250130002552.49220-2-epirat07@gmail.com>
References: <20250130002552.49220-1-epirat07@gmail.com>
<20250130002552.49220-2-epirat07@gmail.com>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavfi/f_sendcmd: clear Command on
alloc failure
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: ffmpeg-devel@ffmpeg.org
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/D536FEBA-1F3C-46DA-AEAC-31FCCB519548@gmail.com/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On 30 Jan 2025, at 1:25, Marvin Scholz wrote:
> If the command array failed to allocate, the current parsed
> Command has to be cleared, else memory allocated for it
> would be leaked.
>
> Fix CID 1638635
> ---
I intend to push the set in a few days, if no one has comments or objections.
> libavfilter/f_sendcmd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/f_sendcmd.c b/libavfilter/f_sendcmd.c
> index 8a0c368108..64f284f4f1 100644
> --- a/libavfilter/f_sendcmd.c
> +++ b/libavfilter/f_sendcmd.c
> @@ -263,6 +263,7 @@ static int parse_commands(Command **cmds, int *nb_cmds, int interval_count,
> if (!*cmds) {
> av_log(log_ctx, AV_LOG_ERROR,
> "Could not (re)allocate command array\n");
> + clear_command(&cmd);
> return AVERROR(ENOMEM);
> }
> }
> --
> 2.39.5 (Apple Git-154)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".