From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B96E84BB4D for ; Tue, 13 Aug 2024 18:07:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCC9968D9D9; Tue, 13 Aug 2024 21:07:06 +0300 (EEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E123368D92B for ; Tue, 13 Aug 2024 21:07:00 +0300 (EEST) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-52f04b3cb33so11620384e87.0 for ; Tue, 13 Aug 2024 11:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723572420; x=1724177220; darn=ffmpeg.org; h=subject:date:from:to:message-id:from:to:cc:subject:date:message-id :reply-to; bh=mAIQtFXIZ9F4pd7Uhb2oMBOrEuip9PwQ0Ehk5Hy/bKA=; b=IVIzcHI9Ww07goksaCJ6YSsbER3Fv5WtXObu0FB3KV3C1SQCohhsBhr7xg1FasvSDk RXIYc/cNk7y1R+vfHOCbDoYExnobHNLpfZvoAoI4a4rJBW8bjlzdaotDlzLypEE8RDzP WTQe9y+J6vpAfeQgtrva9X60lRwDB1HtJK1mgKPkk5/J3LgGodoaccY2rXyjUTI6r9UD TYH190VyYLKBs8r0uDxm1xb1sW07dFYEIOGQxWY3Lvm0Wl/UffyE9uzWv309tmC7YYSl L4WFHVncEWJ0nnIktR4XR4YKhVJfw43ivhHG6OsjHjOPfPehuD/OVtj0rgPfKh8nEBKW +gag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723572420; x=1724177220; h=subject:date:from:to:message-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mAIQtFXIZ9F4pd7Uhb2oMBOrEuip9PwQ0Ehk5Hy/bKA=; b=CBVblJVcpo39qbKlWRS0JMkPG5UANEuBg8WNntSnVwtomG2G5/CRuktQDdfqpOSVEh pFM35QXAiUw2khkO58U1HxxeB3S1D6Px6wJPuOqm5LSzudPbEROHynwdXnduXt92QyS9 TQiwVHquehvIvZOcxE+yptAhVPWFxRvtaMUi+g+mUGGh102SWaJoHw6kLPM8od73UTeM BdNc7w3lYIIJOBDxCSkDETK6x0JEiYO4ufv9O3YuFHtF4VwfElj6N8HGqEm3hNOa5cfp RYquJGgODNx8J8hDFgMDoZfmpFEwt53r6r4Zt1cFnTBZtjkog4tFTriuJUB1nfalRCwd kJkw== X-Gm-Message-State: AOJu0YzrnFTkf84B4jUz6Q+Ftebcb9UJfPsGdvwPKxTfdgK+GrhbUcTN QeOQ5QT9SATIjxO4odrJ3cLP++n8yaHL7Te+anzxkMTPX4Ygs8MFGftsOA== X-Google-Smtp-Source: AGHT+IHHqcr7q/kCJa5v531phr8JYfuQWeoLD4EUWlHOzWkOj6QicuQiV1KboiHtm4BsYzvp5Mzuqw== X-Received: by 2002:a05:6512:e85:b0:530:abce:1daf with SMTP id 2adb3069b0e04-532eda671f8mr192384e87.6.1723572419587; Tue, 13 Aug 2024 11:06:59 -0700 (PDT) Received: from localhost (p200300cccf11780050ac0752aac24928.dip0.t-ipconnect.de. [2003:cc:cf11:7800:50ac:752:aac2:4928]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f41855d4sm87362266b.203.2024.08.13.11.06.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 11:06:59 -0700 (PDT) Message-Id: To: From: "Marvin Scholz" Date: Tue, 13 Aug 2024 20:06:42 +0200 Subject: [FFmpeg-devel] [PATCH] fftools/ffmpeg: remove useless error check X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: When ret is checked here, it was never assigned anything, making this check useless, as highlighted by Coverity. It seems to be a copy paste mistake given that opt_match_per_stream_str does not return an error code that could be checked and the previous value assigned to ret is already checked above. So just remove this check. Fixes: CID1616292 --- fftools/ffmpeg_mux_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fftools/ffmpeg_mux_init.c b/fftools/ffmpeg_mux_init.c index e84fa9719f..6aae1add02 100644 --- a/fftools/ffmpeg_mux_init.c +++ b/fftools/ffmpeg_mux_init.c @@ -1198,8 +1198,6 @@ static int ost_add(Muxer *mux, const OptionsContext *o, enum AVMediaType type, const char *format = "{fidx} {sidx} {n} {t}"; opt_match_per_stream_str(ost, &o->enc_stats_pre_fmt, oc, st, &format); - if (ret < 0) - goto fail; ret = enc_stats_init(ost, &ost->enc_stats_pre, 1, enc_stats_pre, format); if (ret < 0) base-commit: e26276d829cc608fc95734969bfcf93c3d90162e -- 2.39.3 (Apple Git-146) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".