From: "Marvin Scholz" <epirat07@gmail.com>
To: <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 08/11] avfilter/vf_coreimage: simplify list_filters code
Date: Fri, 12 Jul 2024 19:19:37 +0200
Message-ID: <D2NQZKJWIUSO.2M8LVYYNE8KJ4@gmail.com> (raw)
In-Reply-To: <D2NQZKJWHOCW.282WOMUB0ZOAZ@gmail.com>
Use fast-enumeration and get rid of unnecessary intermediate variables.
---
libavfilter/vf_coreimage.m | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/libavfilter/vf_coreimage.m b/libavfilter/vf_coreimage.m
index bfc17764b5..38355414bd 100644
--- a/libavfilter/vf_coreimage.m
+++ b/libavfilter/vf_coreimage.m
@@ -102,18 +102,13 @@ static void list_filters(CoreImageContext *ctx)
filter_categories = [NSArray arrayWithObjects:kCICategoryGenerator, nil];
}
- NSArray *filter_names = [CIFilter filterNamesInCategories:filter_categories];
- NSEnumerator *filters = [filter_names objectEnumerator];
-
- NSString *filter_name;
- while (filter_name = [filters nextObject]) {
- CIFilter *filter = [CIFilter filterWithName:filter_name];
- NSDictionary *filter_attribs = [filter attributes]; // <nsstring, id>
- NSArray *filter_inputs = [filter inputKeys]; // <nsstring>
+ for (NSString *filter_name in [CIFilter filterNamesInCategories:filter_categories]) {
+ CIFilter *filter = [CIFilter filterWithName:filter_name];
+ NSDictionary<NSString *, id> *filter_attribs = [filter attributes];
av_log(ctx, AV_LOG_INFO, "Filter: %s\n", [filter_name UTF8String]);
- for (NSString *input in filter_inputs) {
+ for (NSString *input in [filter inputKeys]) {
NSDictionary *input_attribs = [filter_attribs valueForKey:input];
NSString *input_class = [input_attribs valueForKey:kCIAttributeClass];
if ([input_class isEqualToString:@"NSNumber"]) {
--
2.39.3 (Apple Git-146)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-12 17:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 15:44 [FFmpeg-devel] [PATCH 01/11] avdevice/audiotoolbox: fix mixed declaration and code Marvin Scholz
2024-07-12 15:47 ` [FFmpeg-devel] [PATCH 02/11] avfilter/af_channelsplit: " Marvin Scholz
2024-07-14 17:39 ` Leo Izen
2024-07-12 16:07 ` [FFmpeg-devel] [PATCH 03/11] avdevice/avfoundation: fix mixed declarations " Marvin Scholz
2024-07-12 16:09 ` [FFmpeg-devel] [PATCH 04/11] avdevice/avfoundation: remove write-only variable Marvin Scholz
2024-07-12 16:17 ` [FFmpeg-devel] [PATCH 05/11] lavfi/metal: fix mixed declaration and code Marvin Scholz
2024-07-12 16:21 ` [FFmpeg-devel] [PATCH 06/11] lavfi/metal: simplify fallback Marvin Scholz
2024-07-12 17:13 ` [FFmpeg-devel] [PATCH 07/11] avfilter/vf_coreimage: fix mixed declaration and code Marvin Scholz
2024-07-12 17:19 ` Marvin Scholz [this message]
2024-07-12 17:30 ` [FFmpeg-devel] [PATCH 09/11] avfilter/vf_coreimage: silence AVFrame deprecation warnings Marvin Scholz
2024-07-12 17:36 ` [FFmpeg-devel] [PATCH 10/11] avfilter/yadif_common: remove unused variable Marvin Scholz
2024-07-13 0:50 ` Andreas Rheinhardt
2024-07-13 14:47 ` epirat07
2024-07-12 17:43 ` [FFmpeg-devel] [PATCH 11/11] avfilter/yadif_common: fix mixed declaration and code Marvin Scholz
2024-07-15 8:39 ` [FFmpeg-devel] [PATCH 01/11] avdevice/audiotoolbox: " Zhao Zhili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2NQZKJWIUSO.2M8LVYYNE8KJ4@gmail.com \
--to=epirat07@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git