[FFmpeg-devel] [PATCH] avcodec/aacdec_usac: Fix array size

[FFmpeg-devel] [PATCH] avcodec/aacdec_usac: Fix array size

[Marvin Scholz]

The array in ff_aac_usac_mdst_filt_cur that is passed to that has a size
of 7 elements, not 6 and the code in the function accesses the array at
index 6, which would be out of bounds if the size was actually 6.

Fixes: CID1603196
---
 libavcodec/aac/aacdec_usac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
index 4856c1786b..32b3c534bf 100644
--- a/libavcodec/aac/aacdec_usac.c
+++ b/libavcodec/aac/aacdec_usac.c
@@ -1134,7 +1134,7 @@ static void complex_stereo_downmix_cur(AACDecContext *ac, ChannelElement *cpe,
     }
 }
 
-static void complex_stereo_interpolate_imag(float *im, float *re, const float f[6],
+static void complex_stereo_interpolate_imag(float *im, float *re, const float f[7],
                                             int len, int factor_even, int factor_odd)
 {
     int i = 0;

base-commit: e783e45e29e78616debba7f6d1fe6e54dc336496
-- 
2.39.3 (Apple Git-146)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_usac: Fix array size

[Lynne via ffmpeg-devel]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 1083 bytes --]

On 02/07/2024 23:25, Marvin Scholz wrote:
> The array in ff_aac_usac_mdst_filt_cur that is passed to that has a size
> of 7 elements, not 6 and the code in the function accesses the array at
> index 6, which would be out of bounds if the size was actually 6.
> 
> Fixes: CID1603196
> ---
>   libavcodec/aac/aacdec_usac.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c
> index 4856c1786b..32b3c534bf 100644
> --- a/libavcodec/aac/aacdec_usac.c
> +++ b/libavcodec/aac/aacdec_usac.c
> @@ -1134,7 +1134,7 @@ static void complex_stereo_downmix_cur(AACDecContext *ac, ChannelElement *cpe,
>       }
>   }
>   
> -static void complex_stereo_interpolate_imag(float *im, float *re, const float f[6],
> +static void complex_stereo_interpolate_imag(float *im, float *re, const float f[7],
>                                               int len, int factor_even, int factor_odd)
>   {
>       int i = 0;
> 
> base-commit: e783e45e29e78616debba7f6d1fe6e54dc336496

Thanks, pushed

[-- Attachment #1.1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 637 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".