From: "Ondřej Fiala" <ofiala@airmail.cc>
To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/ffplay: split filters & show modes cycling into separate keys
Date: Wed, 20 Dec 2023 11:48:33 +0100
Message-ID: <CXT3OPSNCVZV.UV148LBA24Z4@airmail.cc> (raw)
In-Reply-To: <20231219201239.20996-1-ofiala@airmail.cc>
On Tue Dec 19, 2023 at 9:12 PM CET, Ondřej Fiala wrote:
> ...
>
> diff --git a/fftools/ffplay.c b/fftools/ffplay.c
> index 873ee8cc74..05182d9f49 100644
> --- a/fftools/ffplay.c
> +++ b/fftools/ffplay.c
> @@ -3370,14 +3370,11 @@ static void event_loop(VideoState *cur_stream)
> case SDLK_t:
> stream_cycle_channel(cur_stream, AVMEDIA_TYPE_SUBTITLE);
> break;
> + case SDLK_d:
> + toggle_audio_display(cur_stream);
> + break;
> case SDLK_w:
> - if (cur_stream->show_mode == SHOW_MODE_VIDEO && cur_stream->vfilter_idx < nb_vfilters - 1) {
> - if (++cur_stream->vfilter_idx >= nb_vfilters)
> - cur_stream->vfilter_idx = 0;
> - } else {
> - cur_stream->vfilter_idx = 0;
> - toggle_audio_display(cur_stream);
> - }
> + cur_stream->vfilter_idx = (cur_stream->vfilter_idx + 1) % nb_vfilters;
This actually doesn't account for nb_vfilters being 0. Use version 1 of the patch instead please.
> break;
> case SDLK_PAGEUP:
> if (cur_stream->ic->nb_chapters <= 1) {
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-20 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 20:12 Ondřej Fiala
2023-12-20 10:48 ` Ondřej Fiala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CXT3OPSNCVZV.UV148LBA24Z4@airmail.cc \
--to=ofiala@airmail.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git