Re: [FFmpeg-devel] [PATCH] libavcodec/dxva2.c: fix dxva2 does not support H264 baseline profile - Benjamin Cheng via ffmpeg-devel

From: Benjamin Cheng via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: "FFmpeg development discussions and patches" <ffmpeg-devel@ffmpeg.org>
Cc: Benjamin Cheng <ben@bcheng.me>, xyz1001 <zgzf1001@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] libavcodec/dxva2.c: fix dxva2 does not support H264 baseline profile
Date: Sat, 14 Oct 2023 12:36:42 -0400
Message-ID: <CW8B4RUTL6XQ.2GZYWSUGQ64EI@bcheng.me> (raw)
In-Reply-To: <20231014035957.66508-1-zgzf1001@gmail.com>

On Fri Oct 13, 2023 at 11:59 PM EDT, xyz1001 wrote:
> dxva2 fail to init when decode h264 with baseline profile becase `prof_h264_high` does not contains `AV_PROFILE_H264_BASELINE` and `dxva_check_codec_compatibility` will return error

prof_h264_high uses either DXVA2_ModeH264_E or DXVA2_ModeH264_F, which
only supports up to H.264 High, and H.264 Baseline has features that are
not in High. You have to use a different DXVA profile for Baseline.

> ---
>  libavcodec/dxva2.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c
> index d7bc587562..e6b83f89cc 100644
> --- a/libavcodec/dxva2.c
> +++ b/libavcodec/dxva2.c
> @@ -61,7 +61,8 @@ typedef struct dxva_mode {
>  static const int prof_mpeg2_main[]   = {AV_PROFILE_MPEG2_SIMPLE,
>                                          AV_PROFILE_MPEG2_MAIN,
>                                          AV_PROFILE_UNKNOWN};
> -static const int prof_h264_high[]    = {AV_PROFILE_H264_CONSTRAINED_BASELINE,
> +static const int prof_h264_high[]    = {AV_PROFILE_H264_BASELINE,
> +                                        AV_PROFILE_H264_CONSTRAINED_BASELINE,
>                                          AV_PROFILE_H264_MAIN,
>                                          AV_PROFILE_H264_HIGH,
>                                          AV_PROFILE_UNKNOWN};

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".