From: Yubo Xie <xyb@xyb.name>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: pkt_size option is not honored in rtsp
Date: Wed, 6 Apr 2022 13:49:30 +0000
Message-ID: <CO6PR17MB5025317A662421A65537FD17D3E79@CO6PR17MB5025.namprd17.prod.outlook.com> (raw)
In-Reply-To: <tencent_E7E90A0EA76545F30FC859B3E2B363B5C005@qq.com>
Yes, I've removed it already.
________________________________
From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> on behalf of "zhilizhao(赵志立)" <quinkblack@foxmail.com>
Sent: Wednesday, April 6, 2022 6:28 AM
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libavformat/rtsp: pkt_size option is not honored in rtsp
> On Apr 6, 2022, at 8:52 PM, Yubo Xie <xyb@xyb.name> wrote:
>
> Signed-off-by: xyb <xyb@xyb.name>
> ---
> libavformat/rtsp.c | 4 ++--
> libavformat/rtsp.h | 1 -
> libavformat/rtspenc.c | 2 +-
> 3 files changed, 3 insertions(+), 4 deletions(-)
>
[…]
>
> diff --git a/libavformat/rtspenc.c b/libavformat/rtspenc.c
> index 2a00b3e18d..5c7e0b4e8b 100644
> --- a/libavformat/rtspenc.c
> +++ b/libavformat/rtspenc.c
> @@ -174,7 +174,7 @@ int ff_rtsp_tcp_write_packet(AVFormatContext *s, RTSPStream *rtsp_st)
> size -= packet_len;
> }
> av_free(buf);
> - return ffio_open_dyn_packet_buf(&rtpctx->pb, RTSP_TCP_MAX_PACKET_SIZE);
> + return ffio_open_dyn_packet_buf(&rtpctx->pb, rt->pkt_size);
There is no more reference to RTSP_TCP_MAX_PACKET_SIZE now, it would
be better be removed.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fffmpeg.org%2Fmailman%2Flistinfo%2Fffmpeg-devel&data=04%7C01%7C%7C999d4c6c586540d2b47708da17d171ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637848485562446851%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=m1TPJnGtWKd6ESBlhlsv9lwPEGJS0N8iXQAJsYpM9o0%3D&reserved=0
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-04-06 13:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 12:52 Yubo Xie
2022-04-06 13:28 ` "zhilizhao(赵志立)"
2022-04-06 13:49 ` Yubo Xie [this message]
2022-04-06 14:03 ` Zhao Zhili
2022-04-19 14:03 ` Tristan Matthews
2022-04-25 22:40 ` Yubo Xie
2022-04-27 12:56 ` "zhilizhao(赵志立)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CO6PR17MB5025317A662421A65537FD17D3E79@CO6PR17MB5025.namprd17.prod.outlook.com \
--to=xyb@xyb.name \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git