From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1C63745BAA for ; Fri, 24 Mar 2023 16:09:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9396868C890; Fri, 24 Mar 2023 18:08:57 +0200 (EET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D0F968C874 for ; Fri, 24 Mar 2023 18:08:50 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679674135; x=1711210135; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=sKidqukcStxSbBcbJNiWRJAJB+iioupfueI4Ouzl77o=; b=YZDttiFEKbqWp6QyL5X70nO6QQGnQsynKO7ziN6z3YYdXnZbYqUGfnvJ LAFle5oiDx9CF7Zz1JSlceNpWv1KRK10odCyfHfReKeF7rG7Q4uwnfZ0a 1YTswQ4ZtikEMB5y3xeX0iAIZQF4YSTXnQwCp3muuOmCL/IK4R8cPPlN2 3skhUQWItJEH6sd0I++viyWIs9d1e+FGPwmkeD8LFwyp+me0IXMHTE3Hv pYMGyjjDBoYLeUREJLuo0NlomyHxYpsx5Q9hzeBdy1wLjIMjiUE3ftLip MtwpKV3cnw+ZpW8mCeobUUi5rQrDbaHrxNT7f57WQpm0DXcxsPa890XSp A==; X-IronPort-AV: E=McAfee;i="6600,9927,10659"; a="320211592" X-IronPort-AV: E=Sophos;i="5.98,288,1673942400"; d="scan'208";a="320211592" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2023 09:06:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10659"; a="1012300568" X-IronPort-AV: E=Sophos;i="5.98,288,1673942400"; d="scan'208";a="1012300568" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 24 Mar 2023 09:06:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 24 Mar 2023 09:06:14 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 24 Mar 2023 09:06:14 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 24 Mar 2023 09:06:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d4dbSZC33As4ImWpsMZc3MryoGrjm210tE0qc5+5ZfW6Ha6G08NxFgzdNG/sGtSquyYB9nUqt0ZLOUr2TDA0el6L4YcoVI46kKb9DKSANH8NVUJzwj4vpgLN0/dikp5pf9C/Fsa9qRB0iTcfPuUUR5oFqFWxbnjjQ3++nC9snlWH8KaW6ZwIz1+iG/HsuINwhBzMgwV5nNL30itMi+ywB6Jz/tpySZ7HLxLbhm11CQZaej0ltkfGVtvJlZ/ovqDWuwxwnOeCVVUQlOfoYHsibPhLaahmsWUeAgy7Qx/mnnlx5pew1+4PkxBM79W/gddv87dD9HrFs/m8DtmncM1grg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5fRZ2AFYcUQldRkuqPk+C2SxUbyZfy0oaLkr4Vw4Fto=; b=JC4DCzxRKoW+oQQPxsQavEipLJNg6E2Hi2t9BS51Pi5JXYBvr8TyFC5jrxIlRL/sN6MSZzyqPY7brcjc5bU7uudXP4JWQ6mmyRThS1WxkiyluW2U8FLTLzB26cUQCYv1P3XEFNru16VYOO/Iycz0XcomW7aJqbqQchxPBMIARAikZxEYRzYe80SRRcYO5uHDYq2PLqJ/usMAvXSWoc26yNcV0H3RFG1ISTsZB25Q01+rpNVQX3LaofOTM7pDN1GcrFFJkqe1FtObZIzJyI/CdPFfpV++bWgE8BvJmRJpuNn9Y4eytnsd/yrYCx0MkxS5Bk3mjgH789lOauYQ0LVxEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO6PR11MB5668.namprd11.prod.outlook.com (2603:10b6:5:355::11) by CY5PR11MB6212.namprd11.prod.outlook.com (2603:10b6:930:24::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 16:06:09 +0000 Received: from CO6PR11MB5668.namprd11.prod.outlook.com ([fe80::fe4f:a9ae:434c:4704]) by CO6PR11MB5668.namprd11.prod.outlook.com ([fe80::fe4f:a9ae:434c:4704%5]) with mapi id 15.20.6178.038; Fri, 24 Mar 2023 16:06:09 +0000 From: "Eoff, Ullysses A" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH] lavfi: add hwdevice flag to hwupload/hwdownload/hwmap Thread-Index: AQHZXl55LQv/rklgRESha7pb0oTGK68KE4eAgAAEVnA= Date: Fri, 24 Mar 2023 16:06:09 +0000 Message-ID: References: <20230324143916.755104-1-ullysses.a.eoff@intel.com> <167967293376.27013.5322805036723610095@lain.khirnov.net> In-Reply-To: <167967293376.27013.5322805036723610095@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CO6PR11MB5668:EE_|CY5PR11MB6212:EE_ x-ms-office365-filtering-correlation-id: 257dad65-fe8e-4a6e-592f-08db2c81ae7d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zC2faium6vzfqiXgz3MD6o2PwVhHUJNUrsNkx9PfSrLc3ms3AeMWmFHGD8Kstfwrcta8hEQlWKLwN46IZrruSLndTRgo0mA+iFQ56+91LzlSwAukQy70J/UeA+rvAZT8v3TUmNPhz6clfTgcnzQoyADycVeOLZd0qVvgRh6zpZBay6EMF82vl487q1ISOVsV2LXVcAOwE84B6F7qG6fgdR/ypaY3j3llzRWPic3ndSLm5qUMo8GBTATkiPO+9HoJPiLXLI4zB4QLXqvGK2uBwV+5/fYgLT8yaql9tcdmT4yLP7nzm2CcUxiMZYttd6UCUMxM54do5rc5qy+i5av+U1FVzmGZYLRqVEVLuAas2/ppy1boiWHLFiLdjDa/nARLETw5X7nE55ExExT4YbXNH3r4BtqgGmbkCK+w3jd+Lj0vecVCcefczeqimDIYcbBKnCwXB6uH0jFR7DEHbBnirOhI2LHpVx8w9hOxpEmf44gUYpscWYaECr2NSRineL/vP03zruIitLdTxbf8wPCcQwFhvyh9iAITwI0SWDhhN4/PUInrqvfVfmebQ5MkoWIOQH3ZUktqj9QnA2qncJRMv0OTUOqJqOjqiRZlQov4U32czBYs/VL7SuGiOpYzZl/bER+49Cws9h1i1pczFD2jB7IBi3OK2m1F5HHLi5svQynl4pz0SHmWtxyjXh7P3HKm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR11MB5668.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(136003)(366004)(376002)(346002)(396003)(451199018)(478600001)(7696005)(83380400001)(33656002)(71200400001)(82960400001)(2906002)(122000001)(5660300002)(41300700001)(38100700002)(8936002)(52536014)(86362001)(38070700005)(55016003)(66476007)(64756008)(66446008)(76116006)(66556008)(8676002)(316002)(66946007)(186003)(6916009)(9686003)(6506007)(53546011)(26005)(66899018)(966005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kQ+S/cQTYxttNB4UFd2zZeu1rCcsjXski5c7Sf6g2eQFL1i6DjkQpzODVRR+?= =?us-ascii?Q?m7hkpDbHkTE7no5kbY5uasR8JlGWyfSpZXmTlcvUCflhQl2q2VbGVn7Hpl1i?= =?us-ascii?Q?//wJquTOaNR88UAwn8mHN6KcFdW4FKcxibDZonl5UpjoqCVt8DtjO5srmbvz?= =?us-ascii?Q?B/c8A1LckammOdzepjUeetuMs7//wFiI+SCI2cbHAHFp1rIWx2rFEC7IpvWc?= =?us-ascii?Q?zrsZfQNA88MT1vZivrEa0YlkIkgJjAI1bAJN7p9+Wh+8DsrKkjBMK7hxkFhL?= =?us-ascii?Q?WGy+SMJCDVXL/aeu6Yqd0G5bDhywtPJKPZgEzO6Ugd3sYSYksBnW1OHwepCN?= =?us-ascii?Q?nnOpi9OcfyFbvAfBm+PTbMWAFy3W0ZaUpFeFylbutVpYVnmx5oB1GSHE/4LO?= =?us-ascii?Q?FHIvsWl168eK4HvOWvCEUelFoY6WJ0UTpoPcEpLWvc8JgPQddb4YdBcr9sdo?= =?us-ascii?Q?XntgOt6YZHhcVNb5B/b7ALI1KdPqc5rXkl/gd+pYan0Y+i+1F1WF6UUe98VQ?= =?us-ascii?Q?jkEsqUq0IqokB5zhuPZfScaPnVPxwaLnr/Q6NhyAJMHsvO0hSA0co9+Rxyyo?= =?us-ascii?Q?KcoMzrSBFbivjq2Tu+s+9T7FJ+5mMkiQihYimvH16F4uKEj3j/0qhDJD2IgI?= =?us-ascii?Q?JgCWLym5N55casCd3MmesjnHAuVoo7wXHgy+O59RzuNn6dIdFKj9nYhUchEE?= =?us-ascii?Q?4syV0ocLrfhKMrY6pgUwdrN1hpibUxq3qQDq6i5AfZCDkWAU4fbl4sHyGK/T?= =?us-ascii?Q?0dGeNy7C8ljoC7vR0HN+p6cAsIyoB/Q8l70zzbI8SxuTbX8fGaRhAZ6WbEHq?= =?us-ascii?Q?WXeBk3xBi7ccd5x4etP3GZaGt0iZrpx7awdN+i3+3MekH5Bv9bv1ZRCihq0S?= =?us-ascii?Q?Xnb+4x8ufGRRGv6PlqBYujMJTdMF16+1W97syEscSqcV+3K9cKnIS7OJr1XW?= =?us-ascii?Q?kU8wGL5Utv9BOj9S0ooSL37f2L1SxmAmgndF6AcEYIEGWCHAdXvReWf6a7Dj?= =?us-ascii?Q?43YbsQA2DWnPsAfOjn9g/gaj2fL3c92ceuHu8uBmsXwFoSDipqwX6RChbVex?= =?us-ascii?Q?sBIYJmex1IT5TRiuLc4bVLjd37qLPKnDrAqOZZNeArbxd4T5mID/C1YF1RLH?= =?us-ascii?Q?qSwPppfkI4TY4iL2jtoQWOrOENOAA/1bdxIqRU79IZ0bdSg6AuySbFoZJwfE?= =?us-ascii?Q?fZsNPFnVPiYFoBMoe0hgYQSoTWaJyG4OcP0TtHwuuNoldZ09phstili2fvMX?= =?us-ascii?Q?ui1fstPucCQa1uxga+0s58q/TwC8hJLMghD0i6aWh/0/+LFldDvWzMZDqRJ4?= =?us-ascii?Q?IjMfG8AqVrqdEXA01SlTHxUwvQYpqOFit5CZoD9mEjFaFNNhspQT21RYHhZ5?= =?us-ascii?Q?5b+/ba7gjbnvZkx5jPuh/DqQDLdYXB7Vai2Ray9eAe7E4x946moreemqndYJ?= =?us-ascii?Q?au96R0ftXMxsw5kV9/wSwVl5zT8mt9xY2LZNPmnB2VQbho0jqR0ALQ6oYStN?= =?us-ascii?Q?CzTqOwbMWxBJers3TdJF54tH/F6YIeGNdjL0udpl+inGLAcOn0RFYe4ZBci1?= =?us-ascii?Q?6Y8EFDu2+xP3lNVQnlaSHcI/MPwvQsQ3zsxGNppy?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5668.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 257dad65-fe8e-4a6e-592f-08db2c81ae7d X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2023 16:06:09.2598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XgbOVGnMP3T9QoHpTUxT++fTP08LHxWXQD6c0/R9RUB0vqeEe+OWg5C9IZdO4rS/VKzoIKlhRPa7j2muBOBLbzXAo6E6g1ujR/0S1kCiA0M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6212 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add hwdevice flag to hwupload/hwdownload/hwmap X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > -----Original Message----- > From: ffmpeg-devel On Behalf Of Anton Khirnov > Sent: Friday, March 24, 2023 11:49 AM > To: FFmpeg development discussions and patches > Cc: Eoff, Ullysses A > Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add hwdevice flag to hwupload/hwdownload/hwmap > > Quoting U. Artie Eoff (2023-03-24 15:39:16) > > This fixes a regression introduced by: > > > > commit 3f63685c3554aea7f72bab1fdbde440820816d37 > > and > > commit 632c34993195f716e9fa575af3de80d07fd50991 > > > > ...where command-lines like: > > > > ffmpeg -v verbose -hwaccel qsv \ > > -init_hw_device qsv=qsv,child_device=/dev/dri/renderD128 \ > > -hwaccel_output_format qsv -f rawvideo -pix_fmt yuv420p \ > > -s:v 352x288 -r:v 25 -i input.yuv \ > > -vf 'format=nv12,hwupload=extra_hw_frames=120' \ > > -an -c:v h264_qsv -y output.h264 > > > > ffmpeg -v verbose -hwaccel qsv \ > > -init_hw_device qsv=qsv,child_device=/dev/dri/renderD128 \ > > -hwaccel_output_format qsv -f rawvideo -pix_fmt nv12 \ > > -s:v 352x288 -r:v 25 -i input.yuv \ > > -vf 'format=nv12|qsv,hwupload=extra_hw_frames=16,vpp_qsv=procamp=1:saturation=1.0,hwdownload,format=nv12' \ > > -pix_fmt nv12 -f rawvideo -fps_mode passthrough -an -y output.yuv > > > > ...produced errors like: > > > > [hwupload @ 0x55b6171d0dc0] A hardware device reference is required to upload frames to. > > [Parsed_hwupload_1 @ 0x55b6172053c0] Query format failed for 'Parsed_hwupload_1': Invalid argument > > Error reinitializing filters! > > Failed to inject frame into filter network: Invalid argument > > > > Signed-off-by: U. Artie Eoff > > --- > > libavfilter/vf_hwdownload.c | 1 + > > libavfilter/vf_hwmap.c | 1 + > > libavfilter/vf_hwupload.c | 1 + > > 3 files changed, 3 insertions(+) > > > > diff --git a/libavfilter/vf_hwdownload.c b/libavfilter/vf_hwdownload.c > > index 5ef23cb5d465..8e8044d5bc0a 100644 > > --- a/libavfilter/vf_hwdownload.c > > +++ b/libavfilter/vf_hwdownload.c > > @@ -199,4 +199,5 @@ const AVFilter ff_vf_hwdownload = { > > FILTER_OUTPUTS(hwdownload_outputs), > > FILTER_QUERY_FUNC(hwdownload_query_formats), > > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > > + .flags = AVFILTER_FLAG_HWDEVICE, > > I don't think hwdownload should be flagged, I don't see it using > hw_device_ctx anywhere. Not that this flags is just for filters using > that specific field, not all hardware filters in general. > [UAE] Ok. I will verify it locally without it and provide an update (v2) as needed. > > }; > > diff --git a/libavfilter/vf_hwmap.c b/libavfilter/vf_hwmap.c > > index 2e03dfc1fec7..e246b22603b5 100644 > > --- a/libavfilter/vf_hwmap.c > > +++ b/libavfilter/vf_hwmap.c > > @@ -427,4 +427,5 @@ const AVFilter ff_vf_hwmap = { > > FILTER_OUTPUTS(hwmap_outputs), > > FILTER_QUERY_FUNC(hwmap_query_formats), > > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > > + .flags = AVFILTER_FLAG_HWDEVICE, > > }; > > diff --git a/libavfilter/vf_hwupload.c b/libavfilter/vf_hwupload.c > > index dbc41734ccc3..ef61bb413757 100644 > > --- a/libavfilter/vf_hwupload.c > > +++ b/libavfilter/vf_hwupload.c > > @@ -258,4 +258,5 @@ const AVFilter ff_vf_hwupload = { > > FILTER_OUTPUTS(hwupload_outputs), > > FILTER_QUERY_FUNC(hwupload_query_formats), > > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > > + .flags = AVFILTER_FLAG_HWDEVICE, > > }; > > Huh, wonder how I missed those. I do remember looking at them. > > In any case, thank you for finding these. > > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".