From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E43764AD2A for ; Mon, 20 May 2024 15:10:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 06A0668D16C; Mon, 20 May 2024 18:10:37 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 915C868CF9D for ; Mon, 20 May 2024 18:10:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716217835; x=1747753835; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=X8igE9JUYnzBaRkCxrqgaOfs5y+27WwVSnIU6VVToYc=; b=ULa6+kLPF19nLpTqB2xKpeUFulDVxTfsFWte9BCwgjAlPkGl0EsI7YUt ddW5IRp6xBPzXwB2DMWKzAsVS5W9YB0fpHc3r/aPJ6fHbo2amaFZXGNvU dKyOT6JS0VaT8oC75vH9lsQ6pnEXrlzISoNyHuR4UDY4GvVFCuaSIRyAu lbeBlDF6qxg0Vt/r4aVhzkzs/FCvp9NJtBakoJWN8G7maKQ1u92zXEIhV J5vasEbWWYgCNX0MIO8c9WMMZaFCrnmotUQIXQ9uWMSMbJUKOeR1j+Z+d 5stbg2Hao2Z74agg2qjP0XnbU+zbUPpztulExDpXaR032UF10kEOz5VfR A==; X-CSE-ConnectionGUID: 7E/53FFcQp2eBsT1KlpA5A== X-CSE-MsgGUID: vRjnLlDdRDujf4hSmiy5SA== X-IronPort-AV: E=McAfee;i="6600,9927,11078"; a="22927491" X-IronPort-AV: E=Sophos;i="6.08,175,1712646000"; d="scan'208";a="22927491" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2024 08:10:26 -0700 X-CSE-ConnectionGUID: TTXcgHXATACs5aJ8v94Ldg== X-CSE-MsgGUID: D+QJpQ23RHqrRZCsdLl7Hg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,175,1712646000"; d="scan'208";a="37514006" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 May 2024 08:10:25 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 20 May 2024 08:10:24 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Mon, 20 May 2024 08:10:24 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 20 May 2024 08:10:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RdsWu1loMrOhe+Zg0+e/1VGWsOaCcAXuMk2Bqly2trMMyDai9Xpn04twPdm4dG4UA9FPeK01ibWxZ102WX7rSCcKQinh36sYGscaGFhCKZcEErCgGMRiA8ILCtPZfl13JNV2uDsY22OgUlhJ5sPWPOeCaHnG4QBUyimtZ51ugknZv8QaxqbWvKcPKmXysCgNmjRnp3Ifa1iM20bFjWYOGahh1P0Xukt85SW5HSRakhJkHoD6qlhGFUJcjEiFHy7KfVCeMgf+19W7LHTtQvmIFhTzbBQ0d2Vv57K7Kt7gXlRNu/51Xi/hFiMlrkTwXSdxTMsoiSmN6+qS2RuimZt5zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RlrLtWwr9S+nqs6ZkTnsvdt3mnuAuIb8W5HPbEJAs6k=; b=U8smOyDeq+unOou0DkAMZODbmrKruoC44BkrsNVrPGKNsSt94NLCh2G0njgnw1TsNuboTzZj4yrfr4PrrwpOI3lbhpGyvknWq84Gqwsmmq/UVHphgJldSibKVm2EErPbPmAaNGq3YTTPOAkbcz7lS+ffq3OlA/s0bQMuDAg8eFFu9rXMBjWEOmfOTjg8z5PjFrhcQF68kMz0tKPoNOACUOEi13kLcPXtl8lIiYOnSN1a6xO7xhGpzCxzu5WZQBHQ/g9HBiRZmtpg4mn6Ywegd0SQuy5TQBv3Y7fKoiJuCcLqyWwT5TgDvPu9xrkMmm+U58cRoAKJqWueH/MJoZ0sFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB8659.namprd11.prod.outlook.com (2603:10b6:610:1cf::5) by DM4PR11MB6288.namprd11.prod.outlook.com (2603:10b6:8:a5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.36; Mon, 20 May 2024 15:10:21 +0000 Received: from CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::7037:678a:eb45:ac6c]) by CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::7037:678a:eb45:ac6c%3]) with mapi id 15.20.7587.030; Mon, 20 May 2024 15:10:21 +0000 From: "Wu, Tong1" To: FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v8 12/15] avcodec/vaapi_encode: extract a free funtion to base layer Thread-Index: AQHapkLNfK7KnkZ6cEqarD9SDuvu+7GgP4aQ Date: Mon, 20 May 2024 15:10:21 +0000 Message-ID: References: <20240418085910.547-1-tong1.wu@intel.com> <20240418085910.547-12-tong1.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8659:EE_|DM4PR11MB6288:EE_ x-ms-office365-filtering-correlation-id: 4ba02ee5-41b7-4cbf-265e-08dc78def7c4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|366007|376005|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?wRF/RrI07Ce4ruGCQWhYo+hpHBsFc5waly4BX8CDDq0fovRJRvkcQCJW3Rpj?= =?us-ascii?Q?uY9/4woDvWDutwqrc6gXs08palEztynUpKhaYyb/q96N1IodHZo7PQCifEpS?= =?us-ascii?Q?79AhELvLyj7pNBISVUi+uOmWLGKsNfx1IU+IuKkzBevRUiDl7j962i8Lk+Nw?= =?us-ascii?Q?ZniIbgQXwshbeDDkKDbtC9Qzh3udb2XlqAGhHnITYyQRuhg91gbRe+yjfXTu?= =?us-ascii?Q?mRN4oLTpnNzqTHJlkjWE7OGQy7+Jekf2fufXRJWigien/9qOA20DKER/VS0A?= =?us-ascii?Q?yeXIiE7qrfUdM1n9cQddSLODVPM5tMR5k4jSJEv57qV9vHsi+AfER4KiFp98?= =?us-ascii?Q?jYsIEWbpdCc5eRBoALvXLbGrxFOjhBP4ZR+VV/NyZS3WY9q7HNCYoc8mwUZ5?= =?us-ascii?Q?03ugx8zawSkmTqIAYxFCAnfhGq3BW/9G7bXy4jr02LGBHebqHoHDoGKt1eEb?= =?us-ascii?Q?BKRodOlM16WPPCOnEAeIbmxfo5GvM81vczs6oRmlEnkGN+47X0Er9DIPKiBq?= =?us-ascii?Q?aFJz8HWLv2tZQZLCf+fO1THj1d/hEOFhnGzvZo+lbVn9cK5PRrbjFl98So2h?= =?us-ascii?Q?AInIc5xu5/QsUlG0TiM8UGnHVXvJl4Z/iFfErj2+KdeCs9sYrcvWXxkAUpdS?= =?us-ascii?Q?PeHb6TPVvDJiwU0dC4ZxpJTsKPTXHqVlDyhB2l/AF5dZG6MpQzq/5xC68XiI?= =?us-ascii?Q?6RS4wCBFdFGm19Dp17JqEDuUH3AWMmv05y77COczmh+vaT+lo309sMGST+WF?= =?us-ascii?Q?r3Of1tnV1d6QF/ElrF4i1malrm814g2QzC/hVWfvph8eRcdIgSlOJiBtCWPc?= =?us-ascii?Q?yPhBNGhxpZ0n1suIynmJ2mbqIg5W0FrMJSdGu58bU73W3Z/sG2g8Fk2AuclN?= =?us-ascii?Q?8xkU3FObuAaZcQUdK9sJRx6eXUjdsbjU9VP9Xowk3TPb/ylYguk55NNtqufm?= =?us-ascii?Q?9b+JYGgsGHrguBc8Re+Mf9H1EWFAtZsf4Yyq4Lll0iWEB2ty8eN4rfqjHmrb?= =?us-ascii?Q?cNpvhvmJsuNqHBaXrIlbTsCZeY3O0fkb3MCubWifdAfzuEKd7QLysRYfLIBL?= =?us-ascii?Q?/L2av07zj5JRknQtD72slfa4NDgSfDf9hgDugurnv3whegHDlSr+dOw9ITJi?= =?us-ascii?Q?IID3LW/FGVLnnS9aGQWZcgstnLZr/U++gGdvQURDj1X7y9u6qBBJ7Xh/KyUv?= =?us-ascii?Q?tAB4VuVzd/kTnfqBNSZngvTveyPs3OitbWTZ8xawEzm4Alpu1Jvs81HMuT4b?= =?us-ascii?Q?0Gk4LWp/cffkh///3TC4pLd65DtZ80INb3L2vSDTmmXXy5TtL/Yi24KixwbN?= =?us-ascii?Q?wabBeDGgHpThuPXfn0Srs1tWAj39B0Lo02qiV1fPH9+tEA=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB8659.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(376005)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cOCcIOvjMBn4871FE5pnl6xp80dFmvE+T1sMOqixMxMVLE0c5yJWt+p6dgiD?= =?us-ascii?Q?wQFHTl/043++QtvAySq/5JxAar8QfztSiCGcOH/I/a1agl8YCM186fSnCNZM?= =?us-ascii?Q?/Jjj4dgv6kYlzjyOL1zNKCyxAFOq8KEAd/iimx7aeg0dBhZjidcbmc+aktkY?= =?us-ascii?Q?kj6xqJwzltl/7JUitxvtUkzUbWFaJBRxBZyD+tknXCwDCfWelm2DcACzkZRF?= =?us-ascii?Q?0tOrEDrvYKJwXQy8juEawSluv7quODD7gzPDlRDGhJ4dNjjkLWQ/+DtaJPDO?= =?us-ascii?Q?fFPYg/Rt5ZxDbg1LlmC9OmLiB2ZXfwws8hntj/bF2xyXQSmQGdvQKC+2ksIE?= =?us-ascii?Q?d1LUiiS2JuJCHIdV/ZyX85THR3RYHVM5HnqV8IqRK0EvLdqv3YoUWSRsMBlo?= =?us-ascii?Q?p2FSJnAvKENMh6xVFDv4kjdxj/kEv4l/s4j1wH4IcPZCXexRvh7lNpCKes8d?= =?us-ascii?Q?pLTh65ktVZHLZ+1R4VgYgOkegzTYrw8jslKXxnH7MQIBT0cZ9BL02lma0jMi?= =?us-ascii?Q?Dh48sDJG1NsGyHS5GCUFRvRUTbAM+d3B5agAr4i+W02XTsXBXLrcOOlHa6Fv?= =?us-ascii?Q?XLv7kL5kjmhv7lO5l2h13/3UE9o2azBCoudbuJqbwq63Rj1X64eeyMGiRHp8?= =?us-ascii?Q?JtJUjj5kPMUkrVlxt9p979Q36K7QsZ1oaHK6gLoGy3RbKf6yCceddEsUponD?= =?us-ascii?Q?YtWqQHVeQoIIc5QiKZu2kNAWpH3YEwUlG8rPUr5qYmSe8Dooulycs4Nh8IaM?= =?us-ascii?Q?SL6+Ko6AW5Ph1LGRffoK/Nm6e0hjAcqas8LaJmA9VXpFEZ08lcBA+X+NNvNl?= =?us-ascii?Q?3X6rLfpZA7EzLrLztZoxSBD5b8Xxzcpu/iW24P/pzR58iATOd/6+XZ1gXKz6?= =?us-ascii?Q?/lIXEPaur1XVUIn89mJACRNJ8MSmohaqugDLLWVT/03OnaaxFwoE+Z4TbvRb?= =?us-ascii?Q?xKL9ZCrluPWPJLc89uEA+EMWigZKeM/rNa70IEjrDhztKM3xNfAfQihwe92T?= =?us-ascii?Q?gsbiEzZ/ei8zQqSNUBtNJtCu9YnCB7zAFiASUCTlzj8KppY8W5dvJWadUTB+?= =?us-ascii?Q?z+/x5fwp5rQz//TFVAXtYS7MZrHCb9ojFd3rIRGbVXsRiSTk+hGuXpM0TbS7?= =?us-ascii?Q?BwEg6xf7BDb1AVWZ9D/X3WcAoiGRqKZrZxr16vPRF4pGvJzvA6aZbAfW+jEd?= =?us-ascii?Q?k4IX/lgemJv/oamMkqQn1nt8Dte80IvoXmGgfSSyBiKQ/RkjUhBK4+o8JfwO?= =?us-ascii?Q?hjngpXT/mWWZY+2p9ZPX8DEIxMqDi0YtrnB4zt8flyZYwrQVMlPXlDtb18Ac?= =?us-ascii?Q?IAvkHFX1SnULjUogxElRqQ9ZSnJBMKMZ7nREzc9TJ5QxtJp99bfMaJLRgvG0?= =?us-ascii?Q?jPfJPMd6tFVQPHAaHY2omsyyFABuF0fTnBUyZu9fZrmyYru8favn6cNK6r5e?= =?us-ascii?Q?NZY5KLktZlONwVjzEaBKzs5raG2mYX16pzHGJrnIArmStQf//FpCl2s8I4rQ?= =?us-ascii?Q?afGBBoFUaSIuH+vNuopfv0tQZqyhkD1/EpSFe6lZc+P7hn4Vj/dIBubO5L33?= =?us-ascii?Q?IdPQQx+2SmAeemagm9E=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8659.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ba02ee5-41b7-4cbf-265e-08dc78def7c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2024 15:10:21.4247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 36LWRlOUK6OkGQKWAtVK0TU9/2ndhegc0XeA2H7f6LwyrOYlq48w6jjmvKSsBIg4M7Y51hh7X/Ssely4K8vw1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6288 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v8 12/15] avcodec/vaapi_encode: extract a free funtion to base layer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "sw@jkqxz.net" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >Subject: Re: [FFmpeg-devel] [PATCH v8 12/15] avcodec/vaapi_encode: extract a >free funtion to base layer > >On 18/04/2024 09:59, tong1.wu-at-intel.com@ffmpeg.org wrote: >> From: Tong Wu >> >> Signed-off-by: Tong Wu >> --- >> libavcodec/hw_base_encode.c | 11 +++++++++++ >> libavcodec/hw_base_encode.h | 2 ++ >> libavcodec/vaapi_encode.c | 6 +----- >> 3 files changed, 14 insertions(+), 5 deletions(-) > >"... free funtion to ..." > >While I do approve of fun, maybe this should be a function. > Hi Mark, I've sent patch v9 which addressed multiple concerns of yours. 1. AVClass definition is put in the first patch. 2. Used "base_foo = &foo->base_field" 3. Used vaapi_pic and pic instead of pic and base_pic in vaapi_encode_*.c to simplify code lines. 4. Squashed init and close into one patch. However, I did not change the way for .alloc and .free since I feel like the malloc(sizeof(VAAPIEncodePicture)) and ctx->codec are both part of vaapi context and should not be moved to base. As for the .free function I have this patch to extract a base layer free function which avoid the mix of two layer parameters. Feel free to comment on V9. Thanks. -Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".