From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C9F154B0E7 for ; Tue, 28 May 2024 15:53:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0543468D528; Tue, 28 May 2024 18:53:13 +0300 (EEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6FDA968D4E5 for ; Tue, 28 May 2024 18:53:06 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716911592; x=1748447592; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=0X2Ts4udJRZktSWwMbkjXMGK0Mi8m4kzaSBfogV5ujA=; b=OE5gY1tvu8PkVKHeJMAqCx1QoxQQopFNxTV0buC4xwYnSeFhC3KzKahY YeTUgvJszT8cxmzGjTxR+HqOfgQK1YsXx1NHeg82RvESm0ORNS7xAKf9E j/l5fAfn3tDYqz4iFm1d/2B1oI+mA1hruZ9pl+xGT+ScwsWzhbw/TmQHB 9hNbSQLSlQBorZonN/NHHvWhzMOWQs1frj8DiojlB7nV34rQxGv0St0Me tVaxQkqq4mJEocRjRZIOJEQnTF53TWKQN8f0esgnng/e+0FP+Wq0AsGXT uZmzSv24JvCyyqlS4BY4HmVxx7G1K3bZUFAtbpDTQqSj8N3MEgr7AIbmY g==; X-CSE-ConnectionGUID: oFSFy9gvQ9WWEt7xQrtZwQ== X-CSE-MsgGUID: 97ejw2PvTYKs7IlK8S3Bew== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="13140935" X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="13140935" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 08:53:05 -0700 X-CSE-ConnectionGUID: cPrHalrjQP+zuEqHiaXCyA== X-CSE-MsgGUID: /DwjHXsHRhOKdYUAwdH6Gg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,195,1712646000"; d="scan'208";a="35135498" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 May 2024 08:53:04 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 28 May 2024 08:53:04 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 28 May 2024 08:53:03 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 28 May 2024 08:53:03 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 28 May 2024 08:53:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mnf83Q7UBALSsmz7jSHjrDWEECX4Hpg2+kcWb1GHR39IzZdXLyZjVisuLnO2MCcHEVYm1XSU+4alPsWV9Nzzecy1dMlDHaut13kXvkxg6rBD3gmSTEKOXUMLKFpZsAzkZFtVQD/K5OMvKOLBPXcmhdc9xnbf5AUVpkRcXWaSblqu/VSJtz1gMGmffeCx/5aTbImzldVZetmPDcdztB6jEaAxNDJok9An1vns3WJzd8lHoNjABK9gHrTOZipN4KaKrL/nKvHo0P3oOEzMB6XYaPZZXdHHxksMzBVSDC6lC1wHTIAfuSGWGZANdo6UbB27/SjiSVl5qbYHnLb4A4JCTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0X2Ts4udJRZktSWwMbkjXMGK0Mi8m4kzaSBfogV5ujA=; b=UHFsvIfXHrH9WPDHTnhp7Btxu8EyYNVTm+yHlt7dO8mbTv+jzTEt98cSF9p4MXnyd3gLHn1lI30VCy7LyPzdaBczIAYysfe0i3vWJoGpulyApM3oVrPtru59jH2K54oRDhTxpkBqdN4/v1gZMEa2wDRCdP3qq199CVypNGbyQYslO5DJnfLFS1GfOJIPsMtt7XkD4yYXDIxjZiYj8UCj4I76yLrMvLCz4gTszn4RTXELhvSqAX4tpHWELQ9kI792eV5Vw13/RY2dtWwKkUzAxYnqPj4KZyOo57Izq1EdDPXBPdBKx6pqWvbSHa7dQfD3bOfJaedzIjsIg9WskRMdzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CH3PR11MB8659.namprd11.prod.outlook.com (2603:10b6:610:1cf::5) by SA1PR11MB8352.namprd11.prod.outlook.com (2603:10b6:806:377::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.38; Tue, 28 May 2024 15:53:00 +0000 Received: from CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::7037:678a:eb45:ac6c]) by CH3PR11MB8659.namprd11.prod.outlook.com ([fe80::7037:678a:eb45:ac6c%3]) with mapi id 15.20.7611.030; Tue, 28 May 2024 15:53:00 +0000 From: "Wu, Tong1" To: Lynne , FFmpeg development discussions and patches Thread-Topic: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract the init and close function to base layer Thread-Index: AQHarqSMmbb9FCknbE2DQBEPiWFV67GqOCBggAAOMgCAAonykA== Date: Tue, 28 May 2024 15:53:00 +0000 Message-ID: References: <20240525103022.1390-1-tong1.wu@intel.com> <20240525103022.1390-7-tong1.wu@intel.com> <5fdbfd06-b971-4bae-b192-34058775ee93@lynne.ee> In-Reply-To: <5fdbfd06-b971-4bae-b192-34058775ee93@lynne.ee> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR11MB8659:EE_|SA1PR11MB8352:EE_ x-ms-office365-filtering-correlation-id: 055bfc49-9fe0-431c-25e1-08dc7f2e4075 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?utf-8?B?RWhNcDhCd1FBVjR6Z2I5ak1pRW1VcmY2OGtWeDUvWUlsd09yVWl4d1NvQ2Q2?= =?utf-8?B?Rktucjh3QmZLTUxpREhwampITTBuTW04c2hHallNaVhMUnNJLy8rUlU0bGJF?= =?utf-8?B?Q3BibWEvQ2VBZnFybXFYaWZXYzBTK1BEdHhibXBTc2J2KzZORGk4eW9qY3l4?= =?utf-8?B?N3lWRlFTQ0dIaG5WelRYUzdBcXo4LzhjZ2VMMG92U09lUndMdWhMak4wdXdP?= =?utf-8?B?cGV5Lzh3TVJYQU9aZEdzSUoxOTZnVzRmMDBJYjJRYUpDU2pjMXo3OWI4czhS?= =?utf-8?B?QnkrQTFxenJrOGxLakY1OUhlUWsxeWNScERDdmd6SGxEMnhPTlNjS1hGSFJl?= =?utf-8?B?b1k4L2s4OWdMQXBmTkdDR2VDeGxpZWk1OGI0WlF5UmJwMVloTmVkUXJFYWV3?= =?utf-8?B?RExTZStSbStoTlZ6dFl2dkF5akV0ZEIxaitrY2NBZjZUOGs2YlA2SG5tUXpk?= =?utf-8?B?K2ZmWVZSSzJpS2tLMHVCdURkMmlGSWkvVzBpMnhYR0lhdEtUOXVscG92SVl1?= =?utf-8?B?R2NlR3NNWWpoRzRvRXg5R3NhQ1FBUmJCanpYQmhoNEQzekhvK2JkUTdHNmdR?= =?utf-8?B?ZXBPVVo5akJlaTZPQm9uTzk4SG1iTEd3eEc1aGQyUnJwUWlsdTBBa3BQV0cr?= =?utf-8?B?b3Bha2k2TGFPb3g1ZXl0VmZBNXZKK2lOKzJWVldsMEtWZG9sV25tcTYrUGtx?= =?utf-8?B?bXFjTlVzTjJxUVpIbm5pM05XNG84ZGoxYm56R0FpYWJmZkU2MnlVa0hCcU13?= =?utf-8?B?RzZKNVc4cVNub2s1UVZKRitBV3BkdERlZnNPM2s2cXFLQTlwbEVocjU1RHRn?= =?utf-8?B?YlpqR21RL2VHWDJUWUdvZFg2dDRHdnJ6UjRwUEJRczF1UG13NnpacnJSTk1U?= =?utf-8?B?TjJjaWFUUDRCNmwzTUNDdkgrN09yWEpTUE9HMlNKaWFvUWo4bTdNbitSVWNY?= =?utf-8?B?N3ZhNWJpMlZzV3I4TktrT2VhSENKM0owd1k0bXlBTTY3a2ZBSHlMQU92WElP?= =?utf-8?B?RktxRE4wQmZVUTJMQWdtY0huLzhKRFhUOTRySTdMUU92NkhndXJXT1ZmZG1V?= =?utf-8?B?OW9iNTYyeEtTTHZJUXVvRFkxejBydEI5aERkakQ0RzR6ZDBNMEdIbEVBUENQ?= =?utf-8?B?YmhPVWZWTlVrRkVTWnN5MGNyajBOQ0NIbnhaVXdXKzE4a2RBdzR3UEJmZGRB?= =?utf-8?B?RSsxa1lxNGM1WnFNdWN2M200N2lEMFI0ZkY2V2JWbDBvS0poUURCOGgzcEU0?= =?utf-8?B?eC9RSGl6cDlYSDQ2MGNzZmJpdS8weE9QS0oxaTgyUER6S0tqYXQ4Mm1OSkQr?= =?utf-8?B?ZndONFZWQmxqZzhUOXpGTTZKMSs1b3JOWERmZThMMklTRE5WaUxvZXVtUmlF?= =?utf-8?B?NUROYXJjWXUxY3lPOXhlUnRnV0tGa3B2SDAvUlVqbFAreW9KaW42ODVUOHVr?= =?utf-8?B?S1lRQVNDaENGL0trTVRvQld5RmVUM2tVUHRORFZ4RjNCV1MvMmZWWGJNdDRx?= =?utf-8?B?UDFRdmlrQVAwUUNxMnVWQ0xETGxweHpyd3E3b2xQOXdodHgvbkRuTU5MM0Qw?= =?utf-8?B?bERhZ3JPVGdVbWFxbnk3cG9EbDhrRXF0TUZOeit2eFRvQjM3QzBNbS9mZlFu?= =?utf-8?B?MVdCMlhRcUlrbi9WRTF6QjhIb3pyZVJDM2I0WTluY1orY0FtMDd6TElhcWRt?= =?utf-8?B?bkN5M3Z5RGIvUjBuL0szNzY5MGFXcXhiY21IVXZiUXBXZWpnQ3VpSHlDOUZL?= =?utf-8?B?Sk5NVU94dTZzak56a0NzNnFCRlpuU25kdW10M2Rlek1paHRNaEtndC9GM2Ix?= =?utf-8?B?OE94aFhiZ24rYlc5T29RUT09?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR11MB8659.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VUY1cUxBb1YvczZoTkJEL2xwSkdETUNHNklYc0NtNDRaR2FZOUU3dzhoUFdW?= =?utf-8?B?YmExd3FRT1REZEZzaDNTVyswMUxlYWVoa0RMd29UUzFueGJ1QmYvQlZIaEQ4?= =?utf-8?B?bDdSaXkyekMzL1NrQVlMOEViKytpY0RRSWFZVk5helVSTTRQMG5tTDhIdEZw?= =?utf-8?B?emo5YUMxTGNWbUtQdGRmb1pQL2s1WGNhdGh3WTh4TDNjU0xlZkJ3N0lkU1Yy?= =?utf-8?B?bnJXdWlqRVQ5eXFNZUlmMDdHdndRSVZUSFptVVdCSG5EYzdURmtHdDlMbnEw?= =?utf-8?B?L3hsRlVkNWZEalpnU01uYnVMWkgwR2hmdHR4dTFaQlFZOFgwSlRzWU9DSS9T?= =?utf-8?B?L0k3M3ByUVRJd0tXWmFYeTJNM0FJVEhMTE1wTFB5MWVZR1BHVXZOdGlBTzMx?= =?utf-8?B?LzZVbldNVUxjVGhWQ1p4YkVvNUlIMVR2RnRvZWlZTFVWcU95Y2hqOENMbjFy?= =?utf-8?B?eUhEc1RWakRCMTB6akJrTW1SV3JjZDQ4WFZRL2lsdjhvS3N4VWVSUE9xUy8r?= =?utf-8?B?YURRUDFIK0hmOWJOU2pvVm9jUmgyVCtOZGpvdzZuM242bjFVMHcxTW04NFU3?= =?utf-8?B?dW5FZVZCWE1tWFZBcU1JK2tnc3dlMG9LOVhwZTMrMDF6aTAveTZGQjM3VXBE?= =?utf-8?B?UDRhVWhJN2NlREZnQUJSUnVWcXF1TW5qY2xQdmhBWG9CZlVlalA3ZWhhRU5Q?= =?utf-8?B?aU9vajV1MWxJYlpSRkUyUE9BQjlTWk40dEJxSnIzVndKSDRZWFFiK3BldGxJ?= =?utf-8?B?eXRlQmt5TFBuVTA0c3JnQUZUa01pYWpHRHNURW9UdGREUkFpU0hhV0djZVJE?= =?utf-8?B?dCtJVGtXK1JPd3hiVy9HVys5Zk9icjMvVXZNaGpzWVdWNjFGZmpWMC9UaS91?= =?utf-8?B?VXFYRkx1K2NxUGpKOUY5V3AvME1DdlVFb284VG1Xb2wxZjFCSWdXNHpFVVhH?= =?utf-8?B?WWN4dmRTWjdUdVlHYS93SHJvOXBjYW52M1lDU3BCWmtwVDArZklyMEZISTBY?= =?utf-8?B?ZGVGS1k1S3RFN25vcFQ2Q28zRjZaMzNSbStad25DdnFKQm8vaW1VMG9Mb2NZ?= =?utf-8?B?Z1Q0QkZjd3lzT0I1TEV5d3hqNmJTSktCNFNyVmttV1Bhb01KMUQ5U1ZqT0JN?= =?utf-8?B?UFhLL21pTWxmL0pjUDhrb0lrcU9KUk5WOUlaNUc4cysxc0IzbTc2elNYSjln?= =?utf-8?B?WkVjMnQvL2Q2SWJTVnUrVDFOTTg3YzU5SmI5YXYzSzJ6bmlyZDUzbUgwU0tO?= =?utf-8?B?cHh5NmMrQlhuWlhrbVord3JMYUZwSndDTDBRdmhPdFg2YURnMWxJNjE5QmFZ?= =?utf-8?B?TnVUOUZmN2NWTk13UStQT0dLRFhnY3R1WThqNDdiQTRKS1RneHhYWWlodU9J?= =?utf-8?B?ZXNldWRTcmdnRmRXblJTRU9DcStTbmxraWdtSVM2VjhuUHBERXRvYzNTcDFo?= =?utf-8?B?aFRtVlVlY0JFb3JHT0Y4dlU4NGozQVNwNENqVVdPQWNWYlZqbUNCTzB2STZl?= =?utf-8?B?U0tkR2RNQUgzM0VXWHBRcXUzSktOdUZNbkRsREw5ZGhxTEg5YklWb1Y4d2pk?= =?utf-8?B?K2NLWTNqMEgyZUR0Ukwza3V2TTBQMnJYSTJqeDRLVld4NUkxNW9vN294TzE2?= =?utf-8?B?dUkzMWNMUStSMXJYeDl0dkJOZ24vMmdrQ0xzb2lDTVArTEVPYnR3cllIbnc0?= =?utf-8?B?cU9CU09VdWNMNHJ2MktPeXRmTVV5TUx6WE13K1puRzhkaElmYjlzaXJaajVj?= =?utf-8?B?L0QxN0U4QzM1MWRRdFJ0VWcya3ZuTllOVUIyWk10MW4xK2JtVm1aYkFzZlZs?= =?utf-8?B?OGdLcW5zdUlaLzhLUE9pRSswcTQvYWIwd0VsNDFnWEh4aG4wOHUveGhFeVpN?= =?utf-8?B?Qytld1FjSXU2dUdxOWFNOUExMFRYUGpxc09iSWZlUG45SFZnOURjczBHYm16?= =?utf-8?B?T1pLSTJqMUlpd0I0Nno5azRZbmNtM0V5enFkSGxkbWxiN3JOeVkvRkpZeXl2?= =?utf-8?B?L1dzc2llNFpOcDdOTi9UWmpFVUZSem9acXp0T2Jsd3BkQjhteFdPd3RQdDdO?= =?utf-8?B?cEdXay9YQW9ISiszVTR1L2xMVUxSRVFXMTBYQ3UyRUFzUExtOVo1cVJyOUh0?= =?utf-8?Q?GGZQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8659.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 055bfc49-9fe0-431c-25e1-08dc7f2e4075 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2024 15:53:00.6097 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: d47X7pKvRHSOTukMDg77lYN3+5teLu0Bvb/LDbIA3CbSIOxLVrrR64P27QYOBDSR39bTKrd5DbhqXeojJASonA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8352 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract the init and close function to base layer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: >From: Lynne >Sent: Monday, May 27, 2024 10:04 AM >To: Wu, Tong1 ; FFmpeg development discussions and >patches >Subject: Re: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract >the init and close function to base layer > >On 27/05/2024 02:35, Wu, Tong1 wrote: >>> From: ffmpeg-devel On Behalf Of >Lynne >>> via ffmpeg-devel >>> Sent: Saturday, May 25, 2024 10:07 PM >>> To: ffmpeg-devel@ffmpeg.org >>> Cc: Lynne >>> Subject: Re: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: >extract >>> the init and close function to base layer >>> >>> On 25/05/2024 12:30, tong1.wu-at-intel.com@ffmpeg.org wrote: >>>> From: Tong Wu >>>> >>>> Related parameters such as device context, frame context are also moved >>>> to base layer. >>>> >>>> Signed-off-by: Tong Wu >>>> --- >>>> libavcodec/hw_base_encode.c | 49 ++++++++++++++++++ >>>> libavcodec/hw_base_encode.h | 17 +++++++ >>>> libavcodec/vaapi_encode.c | 90 +++++++++++---------------------- >>>> libavcodec/vaapi_encode.h | 10 ---- >>>> libavcodec/vaapi_encode_av1.c | 2 +- >>>> libavcodec/vaapi_encode_h264.c | 2 +- >>>> libavcodec/vaapi_encode_h265.c | 2 +- >>>> libavcodec/vaapi_encode_mjpeg.c | 6 ++- >>>> 8 files changed, 102 insertions(+), 76 deletions(-) >>>> >>>> diff --git a/libavcodec/hw_base_encode.c b/libavcodec/hw_base_encode.c >>>> index 16afaa37be..c4789380b6 100644 >>>> --- a/libavcodec/hw_base_encode.c >>>> +++ b/libavcodec/hw_base_encode.c >>>> @@ -592,3 +592,52 @@ end: >>>> >>>> return 0; >>>> } >>>> + >>>> +int ff_hw_base_encode_init(AVCodecContext *avctx) >>>> +{ >>>> + FFHWBaseEncodeContext *ctx = avctx->priv_data; >>> >>> This is the issue I was talking about, this requires that >>> FFHWBaseEncodeContext is always the main context. >>> >>> Could you change it so everything takes FFHWBaseEncodeContext as an >>> argument, rather than AVCodecContext (apart from where the function >>> absolutely must read some data from it)? >> >> I'm trying to understand it more. >> >> In ff_hw_base_encode_init we also have the following code: >> >> if (!avctx->hw_frames_ctx) { >> av_log(avctx, AV_LOG_ERROR, "A hardware frames reference is " >> "required to associate the encoding device.\n"); >> return AVERROR(EINVAL); >> } >> >> In this scenario we still need avctx right? So maybe this is the "must read data >from it" situation and we keep AVCodecContext as the main context? > >Yup. My point is that FFHWBaseEncodeContext doesn't become the primary >context that must be used, but a separate component other users can use >standalone. > >> Plus I have this av_log concern which is there's indeed some function that >the only use of avctx is its av_log's context. Do you think I should instead use >FFHWBaseEncodeContext as the main context and pass it to av_log for this >situation while keeping AVCodecContext as the main context for other >functions which actually read from AVCodecContext. That might lead to >different av_log context in the same file. > >Just save a pointer to avctx on init in FFHWBaseEncodeContext. That's >what most of our code does. > >> Do you think the callbacks in FFHWEncodePictureOperation should be >changed too? Or only all the functions in hw_base_encode.c should be >concerned. Thank you. > >No, the callbacks should stay as-is. Users need to retrieve their own >context via avctx. That's also a reason why you should keep a pointer to >avctx on init. > I've updated v12 and made this change with a separate(15th) patch. Please see if that is what you wanted. Thank you. -Tong _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".